From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71ED0C001B0 for ; Wed, 5 Jul 2023 13:29:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1B848D0002; Wed, 5 Jul 2023 09:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCBB08D0001; Wed, 5 Jul 2023 09:29:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92E08D0002; Wed, 5 Jul 2023 09:29:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9C3ED8D0001 for ; Wed, 5 Jul 2023 09:29:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7C386140113 for ; Wed, 5 Jul 2023 13:29:00 +0000 (UTC) X-FDA: 80977638840.10.D2EE4D3 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf10.hostedemail.com (Postfix) with ESMTP id 974ECC0017 for ; Wed, 5 Jul 2023 13:28:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=IzKz48eZ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688563737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NpR6o6UngpTjfG4xhlvc/k43Ojwmfmb7RvTInWAKx/A=; b=LzlP3Uu4TI4Pbh4G3/xDaDpcIkSmLdQr5utd+P5b+uAj7z6m/+4oxVZf8nTRaTTITm500I uqMJycgBvCQ1/6luFqOttiYYj8Xp3o3xNYE0H0hK7hxU8MlD0rXFd+ipj6etvCP4RdFh0M Co4gsO8h4cM/UNYODs8XxNv8BcT0m0s= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=IzKz48eZ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688563737; a=rsa-sha256; cv=none; b=WvM7tl1vYBJ23Rk4QGkXGasWSSqSYTckLkMRcewAkVSBcCX6Vd32OoS6u7C/2r9qwTxHNN jFZMqVRhmveHAzrgxwRR8Ya1YEeaKFCjFRCQoIFJGQqlkaMSULkWMNrr+FmaEMuuP5ioL0 b94E6IwcrCDcHXGeiADUyeCyI3IbCC4= Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-38c35975545so5333766b6e.1 for ; Wed, 05 Jul 2023 06:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1688563736; x=1691155736; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NpR6o6UngpTjfG4xhlvc/k43Ojwmfmb7RvTInWAKx/A=; b=IzKz48eZVZRf0SSZ42e493A33i8LmM0OVazoCU1gSc2Nc1BiNPA1/iLTfvGrFuuqOn DCdWg6n0WIs4Aoh/bibBMWLGoJwVVQZlwqa9E2fqLHqf/2cFFfjXn9MciAdLtmrRdc+O Rm68J/ItixE4/Y4Npx9Q8A3aYHIvn1ex5DjZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688563736; x=1691155736; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NpR6o6UngpTjfG4xhlvc/k43Ojwmfmb7RvTInWAKx/A=; b=AfZfMTP3L2XMyudoOqVygf0RClY3bMNT9V6bQgYMJeJm8VBP/cu8lIQ0P1yIq3Nydz mBNP+KLp/vYF8yY/GDHTTj0qouzZrvj226KmoRt3ATOCJN0xLH4rNWIOBHP7EmjeGKDv yGjItKN6SgDDMMndwrkzPY59Kk0NiohJry0+p4h4hOVyGzD4DL0UP7qjo8iexE3xdcZ5 5pqbq3cSNRP/FaNVDdIFtwGG1BmUmNMfSTxlkD3URbXvdEsu+1aN6Ypr67d+AtPRYWBb 2wbZ2QG7ceO9qMzZScWrOTVJchbW6gPxVkzknpvewnho8WgGNKkiCC1ciab/eryc9Z4+ 5P4A== X-Gm-Message-State: ABy/qLYQFH1f65x6bJNHdQQyhohRUnucbvjHOh4+50uxrwcKolRUal4l 1TCByt9nQSE7Cr769ma1QOfkiA== X-Google-Smtp-Source: APBJJlEwskeS7PJ5c/IKumSrNExWt3Akj3CfwMxbuBrtNqK+mjNW0fExiV0qWkThqkp2+hfaeG17yA== X-Received: by 2002:aca:d07:0:b0:3a3:d7da:cb6f with SMTP id 7-20020aca0d07000000b003a3d7dacb6fmr643096oin.2.1688563736626; Wed, 05 Jul 2023 06:28:56 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id w29-20020a63161d000000b0052871962579sm17664589pgl.63.2023.07.05.06.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 06:28:56 -0700 (PDT) Date: Wed, 5 Jul 2023 22:28:52 +0900 From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCHv2 0/3] zsmalloc: small compaction improvements Message-ID: <20230705132852.GE283328@google.com> References: <20230624053120.643409-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230624053120.643409-1-senozhatsky@chromium.org> X-Rspam-User: X-Stat-Signature: cbo61pp6ku6qj9bdyxgzunyytuqyfpzo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 974ECC0017 X-HE-Tag: 1688563737-514026 X-HE-Meta: U2FsdGVkX19pRCNuGG559ZQC0qm8bXwxBqLJc8OXmWvYopa7HdwLsISxwiUxeLvtcgNAG+moLM8A5qJHw24C8GUT98NnwkDjiOiwjFGw4EgTarDIEygbWmiR6Gtv8GG1n/jsmLgc6Cvp6m7NT/mdMejduaUnEJyo6JM3o9mnWHqtolIGZd3cEkz6CfpLROXQanYScLyXGggluYx38jhr/HZis8+QXRGUYeRy63cEvVWTJ9p3EZ48+59d1QSP1Th44cwymM4m4Ih2m6inRH3MDCKBbZ5e/eFkrsOzcZESVqSVwrhqPnDxay0WBiyNwWRVVzpzsimXHv4XkG4kBhZ7AK8eDkmJp5EwqODAc436AOeSC2RuNJR1YurdjCSoWThep37cYWucMBOeqY4YZYKwBCHQNaiDTHPtvRrSSqW1Tb0cqBzXi4Lko3JRych7TVeNpgm0LLW2Wb53gwZB9fpHv6FxmBmNG3iWfxpuabNuA/T1dhQ2MPMbxEadgCeLght9hXrt33S6EQdXV7lyGRt1GUj6C73D21FDlj6JyouwgJpLr81mgGrLRXuQC0AUUITBXgLy+W1UOJknf+nM/Bbbrw9pTG5S7+ugu2EKurEAAF/vK9HjZfQFWROyCy4gIdgtO9d56Y2dOiiCpKE2iKHP82FVDJdcEujlxdqQTjfc7aA0F1uRrugdH2aZERGyYuBBUqQq6g52P+nrSjQZDG0lQJwzfgXPO568rMvmeeR0Zj8Vq7raZb7YRdqpqFCz7RhV6P5trDTEjVVj68YS344i14Y2MDXXUc7Qf5FBigb4k7BSZgTMS41M4oeludcvdK4oOy/zYCk0dTw2JFlPxzToP/c/Rdkzw6TwhAmyNX6nmZH7HAzcdTgPdlRgbBxwxKhnHrOWJt0eyu2JaWmN30qjw86iz1oYbX1Px25GKAse7ilenr5Yb7jVSAI8jM5wU+oVG3yAQHYkle5GyPfVhAu QpWlzpTg P1ZTE6UFcFNBcrjuz4PlaljfI0Q5aZj9BHQFln/oh5ptyM0XnQCy/UcbVU08Cm7QPTbsVk4Ja0N2S06SVV96+GuOYA45RIOOv2YNbXVVCJZZmAZ0zTltVgfBfK46Yiv6HzeSVE1W6fZ+ZAwhNoiy9LFvouk8OfV6P7BCVKXeL9Xib1DTjOMmyf8DZ85BlxQs1dOYeq/CCu66AI8ljMlKf5xkQ9o4W3CoWNdg6azPrjNIcXRZq8/ttA9ldrf3vo4eynrzB9RmEWZ0t3cXU7FJ+jJCrRu2hH7kza4cZHcDU2jpo3d2kWsLfg2LI8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001607, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/06/24 14:12), Sergey Senozhatsky wrote: > Hi, > A tiny series that can reduce the number of > find_alloced_obj() invocations (which perform a linear > scan of sub-page) during compaction. Inspired by Alexey > Romanov's findings. > > v2: > -- picked up a patch from Minchan > > Minchan Kim (1): > zsmalloc: remove zs_compact_control > > Sergey Senozhatsky (2): > zsmalloc: do not scan for allocated objects in empty zspage > zsmalloc: move migration destination zspage inuse check Just for the record, A synthetic zsmalloc fragmentation+compaction test (100% reproducible) num find_tagged_obj() calls num iterations in find_tagged_obj() base 545699 812899 patch #1 460701 691821 patch #2 422372 651372 // lower is better patch #1 is "zsmalloc: do not scan for allocated objects in empty zspage" patch #2 is "zsmalloc: move migration destination zspage inuse check"