From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281EEEB64DA for ; Wed, 5 Jul 2023 12:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 704FC8D0002; Wed, 5 Jul 2023 08:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B4658D0001; Wed, 5 Jul 2023 08:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52EC58D0002; Wed, 5 Jul 2023 08:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 41A3C8D0001 for ; Wed, 5 Jul 2023 08:21:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BCBAB054D for ; Wed, 5 Jul 2023 12:21:19 +0000 (UTC) X-FDA: 80977468278.16.9C4C608 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 530CDC0016 for ; Wed, 5 Jul 2023 12:21:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ivKX9HIx; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688559677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a6Nk9N28tpATSH0+5KW2Z9yQf6QWBdI+heV4d9bxsB0=; b=3AFkYKpS4qouSXaKHZ1WiFimSOdAaVP0ac/zq4iA8tXBQ0mrIE8QJfzkZa31OAEQ7j1tUm /uBtHCzZgpZLroWYT2+M3xWkQYZe/WuwfjZzlTEl5whjMobT3XLu5iMM+qK3fFAGwc3DVn ItuCV5YfmC9se/Ym5rvqymSHj7nNY7E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688559677; a=rsa-sha256; cv=none; b=BOqBN4ytt2AMuh1nDRYETOMHeduioPUWwofgSjPKiTqzh1j6gTU1HIbqZqDuDPaGAwEmAJ gNHRjIJWI6qFxSyXCwUgPMFx7gqv30Q+NoiBIfCal3hB5jLpXYm0znrODkcvynty9GLSZ7 aGDxxLvDlypp+2FXL5hh55Vcl8Xnjss= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ivKX9HIx; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a6Nk9N28tpATSH0+5KW2Z9yQf6QWBdI+heV4d9bxsB0=; b=ivKX9HIxU6riK0WSJJLdyvIgi2 NDlZ7qZXzS17fOW9w9bzF9Du8/Ufbc80Igg4RSTEICzPPV0nFt76M+5nXerfm06XUHbfY9IEMlRqQ K6tjcAW6984NHdAzcKNrrRGw2zJb6EO5DB/MuvOeWirPLarZtFiA1Pho3RjZ2aryLUso7Qpfh+EQU J+igUWGpKw8f2vrOojdndQAAoue7f4CzaODAmJp1aS1cZvy8+jOEGIXcytLalcj5/5dDmWHDVg8T+ NMuYbXYK/b5DkrNLG4KKQnygswV4ID4EvTp7HDwgv0PWKl0v8WnDPa2qjfRCwEaoMcJfi0iC0tcir YZqIVtqw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qH1VN-00A3sQ-HN; Wed, 05 Jul 2023 12:21:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2126630012F; Wed, 5 Jul 2023 14:21:09 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0A4BB2022DED3; Wed, 5 Jul 2023 14:21:09 +0200 (CEST) Date: Wed, 5 Jul 2023 14:21:09 +0200 From: Peter Zijlstra To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "Hansen, Dave" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "mingo@redhat.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" Subject: Re: [PATCH v12 20/22] x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP Message-ID: <20230705122109.GA4253@hirez.programming.kicks-ass.net> References: <20230628152900.GI2438817@hirez.programming.kicks-ass.net> <20230628203823.GR38236@hirez.programming.kicks-ass.net> <42e13ccf7f27a68c0dd64640eed378c38ef40967.camel@intel.com> <20230630100659.GF2533791@hirez.programming.kicks-ass.net> <20230630102141.GA2534364@hirez.programming.kicks-ass.net> <20230630120650.GB2534364@hirez.programming.kicks-ass.net> <20230705102137.GX4253@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 530CDC0016 X-Rspam-User: X-Stat-Signature: jc4szxxp4fra71xqjbp3srwa6n9nsdsz X-Rspamd-Server: rspam03 X-HE-Tag: 1688559676-800814 X-HE-Meta: U2FsdGVkX1/w+OeghiwW1PJwHyDbhqXYn5+Mq8vQ0zT4Si40QaapK3v2wkxI+dVa9UVbZmIJ8AbDUjo3l6CmkCCLt1O0MTOPgoKGoH8oANUXgpXlZLg9P/u1j+CgMBr2RZIj+lk7EboBRklKJNg7zfy7q6L2bG2228PqLeQAYOK9Z7oJxK7iTB857zOGBHSx9Hn7lG+gtXAMy7tG9jV/nN7Zmftu1/V3o+gi3YuQ4KqxeSgGIRF8baiGgZAG+d5O3BdkI+N1UqDGrMNzbzwI3bP2VBcn23Uirihl/4GVCN/cYa0RFxJCzpKodOW2rDUVcW6+1w5J4P6SEdnnk5C4E9Sa1gpgyn06kBxnEHhv4OcdndsgurhQ9WbVnANe6bW4O+KRW8PoLFH5q0v9NVZpvZM0YpGpji4QI28Kf0SNwbxfpeopupSMU5JZq5Oazv8dY3RtSSz3G98EuXkytjeFYl6Ubb5usR0NsfCd5a1ATI4AzBmEKxBJeR3utqaPZfpnf1jEb+qeMrV8DMbxBvykL95W7/LU1HxmG1CyUAoxkgzBDelZE3ytDhZt1PqGXSENu9GhFuv8Hwk29XinSZVQ66EcASdftk3U6mFWIKgveY8VWsWSRyHAf71oKpQCXEQ6FJQntvpvjPh1G/Eps0oeZ+YHvq7byA/E22GSIoIfddCjnMfsQPofovlF7HKAdymrQFl5+z5MaP+DSXwRl92UXCvZEe1y3kJHf8i+hWq7kUof1lq5UXOelW/4HJy/zUe6Mlys2+6v1u3q5wxqH5m8QAuuRYsvbidyMBZd+1rYTzgqUE6gEB00JrJQHAsb6AZHvWYowWc407Dtfc6BMO0o1tsMJ2D068cDk2pBcnfeuf9EPGR6JoVusdj+XfcdpyAaQyKN6hZPttUOoPGkBLUBrhlgrTZTLk6iq1YZ/g+FID3rIVN3WCdggsGa6OOPGoyl+hlxkjOk76bYQ1Gp6R8 365aHGKt DlfG91vmfDaqeoRVsQ0+MyosftQiBBdxEy/4e5QtLcfM0QEV2RdLQhPvA4IN++5KYG90wTly/nBFsJYLhmQQH5a8nmyzdC7HNbSNh+2dQP+cEqe/X5qaMHAG4uSE9/o8NkaPEo3cr1jK0Tp3DJ7PUxBX/5lO/7k75msyVNnTZ9ccDMBACCzibbs/Fiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000200, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 05, 2023 at 11:34:53AM +0000, Huang, Kai wrote: > Yeah I think from long-term's view, since SEAMCALLs to support live migration > pretty much uses all RCX/RDX/R8-R15 as input/output, it seems reasonable to > unify all of them, although I guess there might be some special handling to > VP.VMCALL and/or VP.ENTER, e.g., below: > > /* TDVMCALL leaf return code is in R10 */ > movq %r10, %rax Well, that's a problem fo whoever does tdcall(0, &args), no? But did I say it had a crap calling convention already?