From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47352EB64DD for ; Wed, 5 Jul 2023 05:13:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86A7B6B0071; Wed, 5 Jul 2023 01:13:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 819BD6B0072; Wed, 5 Jul 2023 01:13:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70B2B6B0074; Wed, 5 Jul 2023 01:13:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F3A26B0071 for ; Wed, 5 Jul 2023 01:13:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2BEAF1A01DB for ; Wed, 5 Jul 2023 05:13:20 +0000 (UTC) X-FDA: 80976389760.21.02BFE9B Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf04.hostedemail.com (Postfix) with ESMTP id 5622E4000D for ; Wed, 5 Jul 2023 05:13:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OBbJSZMC; spf=pass (imf04.hostedemail.com: domain of 37PukZAgKCKMVKDNHHOEJRRJOH.FRPOLQXa-PPNYDFN.RUJ@flex--shakeelb.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=37PukZAgKCKMVKDNHHOEJRRJOH.FRPOLQXa-PPNYDFN.RUJ@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688533998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gT6pZh3cT1w32dr+ueGGkCKTgUvlyCVMnThh2JSE8YU=; b=2wNBoRRg4sxduimE93OIBVSYxLdjfthv5iFI183yKXJ+IJT2AJ9k6dHKVZahiWht9F/8by mJSCta3BQgQ1YNGeDgKAZVNoG6Aw6SHU2p8OpzB06mI22fjUaoc2jwjNuYULUKini1ENmi citJScKqwOd58L9ZGf7DSuHEQvBx19c= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OBbJSZMC; spf=pass (imf04.hostedemail.com: domain of 37PukZAgKCKMVKDNHHOEJRRJOH.FRPOLQXa-PPNYDFN.RUJ@flex--shakeelb.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=37PukZAgKCKMVKDNHHOEJRRJOH.FRPOLQXa-PPNYDFN.RUJ@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688533998; a=rsa-sha256; cv=none; b=iCuLKlCMyNqPrXYoid2qZFZNHNq/R6EPUbbzkI5Eh6avTvV1CQtzzfjyyDR+T8ddgsexkt /gMrhLYoi9kK9QFoRKpaAzAA6xDHfl3+gJJHQKTRUYIBdI0DRlHLroiMYNznX+jZfZZWnL xMWMzsBq+CqQrZg5qNX0/+avdEgyzWg= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1b88decb2a9so4593425ad.0 for ; Tue, 04 Jul 2023 22:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688533997; x=1691125997; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gT6pZh3cT1w32dr+ueGGkCKTgUvlyCVMnThh2JSE8YU=; b=OBbJSZMCRmWJRGNr+2nlakOGy7b+hmh5AoDWzGUz+gsSJ9FrIHFTy3BU9bd98MUf0+ Ti0PiXbpFuRTsB//X521enhJvLj1kkntNylyKZJ8SStJ4c5BQw1ml0VjwLFZOVAyWG5X 6IRmEPYDnaUi3226wLArBHnGAqBxBj8bGv04vO+Snnt41ZIrjeYWmZrrTug8UPc4NUdn TIsOHVDJulcQOE324n1TGbDsPUJyq3aqUzqPFc/v4tSdy98TAxffVNFhKPgjVtHrP4uO N/nc//NZfZOxdcepr8jrierqdpiaUidl7gU3JYCfPgKh2Bm8bQK0jzV+156rZEkOdhUC 2TKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688533997; x=1691125997; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gT6pZh3cT1w32dr+ueGGkCKTgUvlyCVMnThh2JSE8YU=; b=R1yNi5uQ9drHw+y957zxvPekSRrW4fsBmKqHIvVkAsmVoEvArwrPY1kCA1iNFcsAbT NiIC1sxz+1Hj5hY9MZjg1OYuc8FmHoiFRTi4ksXR6tXF2XJxOskkb2y4aNLAj0Qfx4pM I1Nytvw9MODcw7f1N6MgZo6wFgz+NdkYHa0X9x21I4gF/kd6YSQ8kxTvdb4747g8g5xG rTS2LAFfz5HRxugLGWgT5bpTY3e4FG37PjQxLJdqd/hofD067IQ/BNY6ut4JW2ksKoA9 ulxDXdhqB2H65rIUlzw45CibxuPwWL6u4Q4UcrdpBbKIf1Fe50fb7lJiDEkU7m+okTjP Yjcg== X-Gm-Message-State: ABy/qLZ93BCk5Odd4Exi59KTLHu6aRg8UTf+SkwzTy+FdQA9OqXsuZ72 iO0iJ5kplGjLub04nr792486v3AkizHIJQ== X-Google-Smtp-Source: APBJJlFXqm7HYes4vLrR0lEdYT1MAfj/VubSpUxGuLDI74281zmhu5XwCkDM6sFHl15sMgKwIGCPbFlRIul9Gg== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a17:903:1303:b0:1b8:2de6:cd04 with SMTP id iy3-20020a170903130300b001b82de6cd04mr901167plb.0.1688533996951; Tue, 04 Jul 2023 22:13:16 -0700 (PDT) Date: Wed, 5 Jul 2023 05:13:14 +0000 In-Reply-To: <20230704115240.14672-1-mhocko@kernel.org> Mime-Version: 1.0 References: <20230704115240.14672-1-mhocko@kernel.org> Message-ID: <20230705051314.a2duuft53nqs67ut@google.com> Subject: Re: [PATCH] memcg: drop kmem.limit_in_bytes From: Shakeel Butt To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , linux-mm@kvack.org, Michal Hocko Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 5622E4000D X-Rspam-User: X-Stat-Signature: e5aqu3rokqm3oufywpk1ya8opswaq7nm X-Rspamd-Server: rspam01 X-HE-Tag: 1688533998-861552 X-HE-Meta: U2FsdGVkX18t96I39CXpBS75ualxQqVOgxl0lJXR8KIwZctQWpqTIJNOzH8sM/cB7/5Ng/VnmtnuhrDNXMo7NqJs8fFHUt27K8Ve7xqXh0Oi05jH3CUjdQslA0Jr+dUhnQfzM9BNEBo+8GL/LomkrkMSZbh7f19GpghSCzqe8mZ2UVreJ9Xp0PrvkrxFcVQEadSkT0nME6MS1yJSUsIXisXSjZ65geYdO3hmnMt0fxBbgcD7022zZpjygSInBS/FiyREBbokr5SV0cBtd5rq40gssiHx0w9Sw/joTyE+warZwfSzZRx04orMwfqyBzNnXZhsrl80rEN14zEhvh+HuKwmbgCX4dDCmaqyrrpsbzKNcFVB2hRpP4SHHT1eECKgTb72PD7U90p6w+lA7Ghq3TRODsF7c+rdKrB+pHCzZ1WjGT0Ck994uyDt727p4OTBsW756op3l5H4+LDuBN4QXdhA/Fznhl3NpTZ5cJxYSk5CCOBqLMfZ9iFP7MeJXG++3YIjEIWysqr6dEwzBuPy1sSvkZKbs73Ej+skr0g8YC2mcOFsiciiBN+EiAlPRzLmA40WAx1sgM2uMH6GscHIrUHVFNztI9g8jAtVgWi06r5Ube4LGYjbmSQF8dQWgZ6LIq//+E2aQoNqPdc4CcluQvc3qxhTJHJGnr9dtvLiY5ttUDERCsHJFejs/TwV1Cn28yaGD4O0z4BhBhn0J3TldWnntFTwC+Q9i0k9Su4Ji0wbYQlDGhpX5fl1zX5c2nkDKrIzWePe5UU6+ae1ahw+WW4RZv9LxzhXfXjfTmNOSwYnmIeADT0dgRuEjGLTdc9u4YdeStdKQrByc++wlFID7KNO+cHzVVdW6z3sZ9AQAMYQw2ubjwk00FVcBcfeELKBxpkFGLo0mqJeTWjOAqGGlLzIBbBFMFm/qwZTzkoxAPIcqpI3ncLsU9FfztBjUlMnJjQsvI7f64DFkUM2jX1 NuYnaM1B qQWdgYkyb0F94/lVHiYcuOh+FL/kcDU/ggIvfTDhGxIT41XUCUesuKshl5ILgyfthuJY2HXBW1/Hw2fdyKedzjggBVFc8MD6riAkn9F09KjQVWnY4vKopx7yHxflYzC2Z5+mFOovheCs7pBTNaxKHttmKQYL2jatcJU2OMZYox+hF0dmQxCXQaHtZkH4zCFeVRTlawYbN3hazJ+O2RAp67gt9S4a87Hdn9e/vBJl6ArdS7AA1s8QqTkSmFJHyItHggwRkhcSEKwYLGtXuGJLaU5dcMkF1aYQgyMrVVpIljmKfnO7kpDJ+zi7fKvxyGwBa+IXOY4kkyD+3r2c0KHDAnlOqbYmUBLBjFEl89NfL9LzCFkeNBiBztYO63j8wIRUjf//fuQIO9RdGwynz1GV2AM0ThicwqDAjmD9LfCLQBQ7qxPnDEJVL/i63d/BQCxIpq1umqJGEMMUiU9i2tlpjizvTBEOhR7fQ39DdFHDXH6L98ol9XqADUeN+Gp5vdK7oTlljQol1pMka7pPIXepgxUPEqSwYwd2loUM3b2Z5QNM5qfDIjKIibLUF3bXzLlhjjv2po1g7CRKOwp7IAzLsPhXynMHoH+cOXY8rCPT2JYr3NKs0n8LtHAfL+uPA97y4HQjg29J7xj28XZSLeOO7gCzdk3+YgPaVI4F2+0eAxJGo241ikwepviGuUsLW7AWggKvfZ498rUR8MvTduXkFQHEMWWNXbGm6dx2hY8P03KeVAKi5Bdd+fgJEmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 01:52:40PM +0200, Michal Hocko wrote: > From: Michal Hocko > > kmem.limit_in_bytes (v1 way to limit kernel memory usage) has been > deprecated since 58056f77502f ("memcg, kmem: further deprecate > kmem.limit_in_bytes") merged in 5.16. We haven't heard about any > serious users since then but it seems that the mere presence of the file > is causing more harm thatn good. We (SUSE) have had several bug reports > from customers where Docker based containers started to fail because a > write to kmem.limit_in_bytes has failed. > > This was unexpected because runc code only expects ENOENT (kmem > disabled) or EBUSY (tasks already running within cgroup). So a new error > code was unexpected and the whole container startup failed. This has > been later addressed by > https://github.com/opencontainers/runc/commit/52390d68040637dfc77f9fda6bbe70952423d380 > so current Docker runtimes do not suffer from the problem anymore. There > are still older version of Docker in use and likely hard to get rid of > completely. > > Address this by wiping out the file completely and effectively get back > to pre 4.5 era and CONFIG_MEMCG_KMEM=n configuration. > > I would recommend backporting to stable trees which have picked up > 58056f77502f ("memcg, kmem: further deprecate kmem.limit_in_bytes"). > > Cc: stable > Signed-off-by: Michal Hocko Acked-by: Shakeel Butt