From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8756AEB64D9 for ; Tue, 4 Jul 2023 16:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03A9D280097; Tue, 4 Jul 2023 12:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2BF5280096; Tue, 4 Jul 2023 12:28:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCD78280097; Tue, 4 Jul 2023 12:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CC6BD280076 for ; Tue, 4 Jul 2023 12:28:45 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 96CF08070B for ; Tue, 4 Jul 2023 16:28:45 +0000 (UTC) X-FDA: 80974463010.21.CC5E206 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id C47044000E for ; Tue, 4 Jul 2023 16:28:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0XQ4oeyj; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688488123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kJv2YUx3JEPTO/EzC9PMASgZhgRNeU/Z5BNfMnNqsAc=; b=2gHpxUkSjNN+ApAnNcdOtBoMw704p3Nt/qFrzPmAKWJ1WxWjjJjE+RTYpEh0cHpx/95wkI sbj741bnuiwLaytFMmu9+mKLlovNwMR9MtIomk726BBuWxEquPeJwYRE/05c4NJsroqlQv +DoqPXglbcA2taAFag7hc6m0L7z61Zg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0XQ4oeyj; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688488123; a=rsa-sha256; cv=none; b=NWiKf1Wi4/L61tW6qHr0u5bzIT4+8n11Y77UOinyYZvE5HZKmASci26uQ3Bu5MV/56ZDj+ xrKgPew49Ryq1oP5dXYsAdyPKjtH+bPktoMTMPG4H5SBJpWcPfxilqav2dmLmoNSy3loFT 0aCwBIIOnPkhfmVubKEuPYqtxFqStKo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB5CF612FF; Tue, 4 Jul 2023 16:28:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B52AC433C9; Tue, 4 Jul 2023 16:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688488122; bh=Gy8FgsQVK/jYScLhhq0egPzRmFR+KS5pw20GUgHA3bY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0XQ4oeyjCyautIiwSTe5EC/yMfZSt2h+C+Sbss8KdTUnR/ha0TRvc3hZybNOYhepx vlUOIBve68EImeRtRCQsKw8nZkpRVZ4e5L4p7t/A99AezxQBWgGawT36jTypLPp6R6 RJupaePm4n27hfh3rK+poyA7//My622wkShIs5JI= Date: Tue, 4 Jul 2023 09:28:41 -0700 From: Andrew Morton To: Liu Shixin Cc: Muchun Song , Matthew Wilcox , Mike Kravetz , Oscar Salvador , , Subject: Re: [PATCH] bootmem: remove the vmemmap pages from kmemleak in free_bootmem_page Message-Id: <20230704092841.2e71a21ee1149ec662c73744@linux-foundation.org> In-Reply-To: <20230704101942.2819426-1-liushixin2@huawei.com> References: <20230704101942.2819426-1-liushixin2@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C47044000E X-Stat-Signature: r9fbmpyybc79676fm8iitkuj71q7m5b9 X-Rspam-User: X-HE-Tag: 1688488123-255734 X-HE-Meta: U2FsdGVkX19Sw7bhPevByrEJXbTdsX1sLuE2frevtx2R/LRtb9/L85/PM9hkZlBYSq+/5IUgfB3jUIiXseYlmkzFfqOOTJ8gBoSMOU0MURjAhWkNE7ghdTIslQXhPD1iznUBtbcLGx+6r+ZOJyq/nNlEz/Xq4DoCDy2sXn71yqj8w+NEGb7bnnNUXYHgmxbhsAM0TnGjQBMH26APSQv5v3OzZAGyNHIgPM2VGaf1ZNwad+QC5E/4sSbIZycWnKZrfM9lhV627i///n5yrQEv/Ds+TYixWVtJkr26rsS1J99aHUIj84RsitKTtUvKTXUM/n1h+Jlylea845O2E1Mm/3C+GU4b05rqsK1qbipY5zbO+lwHtePcsHdnQXwcws9jfXpClejba1PgB2hqqAeLn4IjClezXyPCCLg7lHy7N1lg52KkbGrkFoZlv9CRRwKDdXwT2zv6COFr5nrAA1ekTBa2+8IQowUdoQnN8PNH5JHQgQoy9/VnHjBEwZrUx7bVSSSI17XkTDdbp8b65yp8gKCzZ+EVbFuTjuRXZPZ3cHd3QNrgl4QBbEuHVdyxBEUvCMM/5DMuovzjbKKX6ePLA9+F9Iy/zuizd8vWPIwWrbf58AbJ0b/If0v3KWt+cS30fqDRBGSFXMInMr8KTFhbP3vApDJJ7GlnecM5qiNNLaknrxqoxyR9lfPtt2AA1DGUdIwZOcDe7zpIcK+K5f/x3Zn5beHLgTXnXB3lz4wRWFu1Bl+khGmGPVX/Gj4HltomDLhaNO5tndvDlUtiL2YOPmZxMWU6iElkiwN/WgraA/SM6LIwzV213FEVK9U09niIfJJnTq/U0ZtKD8WUrIo1l90lQdeG+jUMgySpgS40GjfbFNrZvMMqSqDMEk7khYDKC57Sa7Or1/OxlcFR0ZjMyaNHd6Czk2aVoJVQG7LQxhnwkl4GmOWMcF/0bsfBF21fr1UnXL/H4ZyQ5EXJSM8 P5rHEkYR PufSOT7G5/RdWaqCVt7nsoPfgSLAedMvV6qAvEmtL8E8PmmSEsx6nt4p7Dvi2P8ICgpEZhUKWUAOvOpdsrzdpSXECHXy28NWXFISIW6eRQkfmXgrQzmnaiETqDeZ4CeYdGUCCU1Vzt7Qh7sYlQp1JcqQsOwXYQjEWm+XTyx/avufhxbNDgjHzm2+D2qJUmIAeVZfeoudxwp2cFgTDU3n284qiMiqZE3uZcXgnpHyA36uxuwNF3sxaU5IegSSZthGBC5TSHKxrtdoD03gMDDz3tEJG8UTAMJXrLcdGiCbp3WAmvRf3EsO2w1kiHl+AbxVV/mztL18WM/HwcCUmFW2QHWZrN+KzO4gvMifD2un8Vt2hgd847jl7zS/bTFA1dwbmQrz4MROMwype14k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Jul 2023 18:19:42 +0800 Liu Shixin wrote: > commit dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in > put_page_bootmem") fix an overlaps existing problem of kmemleak. But the > problem still existed when HAVE_BOOTMEM_INFO_NODE is disabled, because in > this case, free_bootmem_page() will call free_reserved_page() directly. So I take it that with CONFIG_HAVE_BOOTMEM_INFO_NODE=n, the issue described in dd0ff4d12dd2 still occurs? That kmemleak reports an error and stops working? So we want a cc:stable on this fix, yes? > Fix the problem by adding kmemleak_free_part() in free_bootmem_page() > when HAVE_BOOTMEM_INFO_NODE is disabled. > > Fixes: f41f2ed43ca5 ("mm: hugetlb: free the vmemmap pages associated with each HugeTLB page") > ...