From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF5BC001B1 for ; Mon, 3 Jul 2023 13:08:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A4AE900003; Mon, 3 Jul 2023 09:08:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 954CB8E00BA; Mon, 3 Jul 2023 09:08:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843A5900003; Mon, 3 Jul 2023 09:08:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 730DD8E00BA for ; Mon, 3 Jul 2023 09:08:45 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 038DA120892 for ; Mon, 3 Jul 2023 13:08:44 +0000 (UTC) X-FDA: 80970330210.27.7C45F7C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 172571C000E for ; Mon, 3 Jul 2023 13:08:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=xLr+Vuyd; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688389723; a=rsa-sha256; cv=none; b=OOhi+DPxaqNRmlQk/yLBR4Np2wXsRW3bUcz3elFMFHvAMzDMAMvBKTdA170WoXc0xY9j6+ fFZp88sLw5xgiTGQcnaG7bZ5UMqmdOqokf98BOiVd7D3W1JFQnmEGUhye6wnV9n3KMQYpW MYhbTVt+PHuLAGZZRDaRMRp9rpUDLAs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=xLr+Vuyd; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688389723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H34mLoiDBOdpjgL1ge4/tLLTf2MHb6p0nL37Pz9Aq9s=; b=duu6u9RkE5l+1QEltS6eh1Jpi9I+vcHo4KKnvRkiVXbogNx9cTSpFpCt5izC+C4J2Vo34Q pYuZxTlS2X35/nhNIRNUJPGdd2fYnR5ibXORoZIajITfVVTYGyYYrkhfr0iMw6u2eaGD5l NvVTy3oEnq39mqqFHpnpTQqjtJByGPY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1CDF60F25; Mon, 3 Jul 2023 13:08:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 795CDC433C8; Mon, 3 Jul 2023 13:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688389721; bh=ypbcj87dPUAw9tzLtO/umPTpb2y3vCv6n+L9rNnzz58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xLr+Vuydj3zwqtXJDbof6qt1egJsCwGG7z1JqapZix5T/n6ja+Kwo8KTGK/Y2hItD 6KKa493JijPBeliZnn61IYNmRt9cFvJej2Vrmki4L6PeJItT/MixQmRQzIeTPVpLDl fAvq9kslDMfoChfvyLMM2g2U7ug/P0An5+tF9UYc= Date: Mon, 3 Jul 2023 15:05:28 +0200 From: Greg KH To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, david@redhat.com, osalvador@suse.de, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, bhe@redhat.com, ebiederm@xmission.com, kexec@lists.infradead.org, hpa@zytor.com, rafael@kernel.org, vgoyal@redhat.com, dyoung@redhat.com, lf32.dev@gmail.com, akpm@linux-foundation.org, naveen.n.rao@linux.vnet.ibm.com, zohar@linux.ibm.com, bhelgaas@google.com, vbabka@suse.cz, tiwai@suse.de, seanjc@google.com, linux@weissschuh.net, vschneid@redhat.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible() Message-ID: <2023070342-human-spill-a62c@gregkh> References: <20230629192119.6613-1-eric.devolder@oracle.com> <20230629192119.6613-2-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629192119.6613-2-eric.devolder@oracle.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 172571C000E X-Stat-Signature: nexq8rctn515pz3xxg36ebued4x4ygpa X-Rspam-User: X-HE-Tag: 1688389722-333713 X-HE-Meta: U2FsdGVkX1/aqRrW/RoJakNLFIrElen2uvwEsdECqefu9nFnxjDav0LGx+QU0E4PpZagoovcngraU8K0IawD8m7RQw1wwLU4HiwYWNtO6zbxbaMAfimUn1POjSB5sJGc9csWFR0lnlI7LNkJiMsZcrz89PvWz10uRYdEm92EA1thFwZIw+twnYTum5P2eEVuL6L/zB30kUQg5xkOGmEijNdP/efSJcETHnCTGR+/rpgQDimqD4P1498hfKtLWi0LK3rofpOlNum7vPHJEXVkpfVtt7WMfv2869nZ+fVxb3qDl1a7M/o6Db9QXvIgYDReTLms6lpcSAEBViNnUVGr8JpShPjS8/zLI6Ix5pG+dFvAIcs9vSGk2H3ok4sZ2u5wvtzZYIVs+vBh4gsHTpTmWu+LOBju2MKg0ubJ/BGe0drE2gQNLWVAtR3Umms3Z2blKyrHyTkO3935/u8s4pHRD7NBdVngfLrhQCezb8JJXdTw4NW+B+qqzI+qp6NTAkGctK1WWx0FDIufzcXs7MExCGSBuE0PwadGk3x0MZIgjCHv/hlUsnSTLVhoyTT7p29W2QTTbdheeM8MNwMIAgc6GU6PDjOJX9WzM+9vBK89ygzAYcDGFrL1bplROj4Cyp6s8pAKstjr0GAEAKd7n9bmP1joPzYyUZU46box3cNsS1EF+Q2E4U+J0LrmZTnwqjnx0kSuFIAifSIe37/d5lK+eadlpPedPtsNLvkFgGzmEuR3AYLC4AD6fakx74VeQbF/SllTdflXnVEfBZxB3DXa4qLiv9YBF0nkKtLsbaRkpi/bfi6tFagfYF4N71rCybtITJ4qJAUdOE9nDRoLWwTIlvXJ/Utpw9QlQ8/cfLMC7Yuze5UJ15YgxJXhKHWT0cna/Ut4oZvKWi4WWsU3/gJ+5YIdexo8jzBZtfrXWn7LaAFp2X09KaHV+o75UjqnZc+dojvy225A8n4zvSemLom 1GnemnEr 6Yba4DYnTh0r+RtgqSypCsal/CynKrEnb/Qqjs9XcozIqUbGlAA8CfMDdVCC2bN+2FP7N1AnjxRbqStmZlOCjxwCBwSUgNo4BTLUJQYHnQxlWgIsJa9hk12BR7BERDS9h5BYIzkkpSxRCrQKxE6DRTxhWRwJkpZ1SSY0OfEECCppe+4t8hYlMAQrgWNSb6rjbFq9uiXcjJma5ZS7pMCwAeuG/XskuCBg2XIY2vJs0udhBDzvpyaiXg9ICakLFR3u8hLbUnOrZdvLbx9kGbfCP3hgKCAJnakIILcQPnSE7rp7b2PmAHGUnanGzM45r20d/Kjsvf3EPGwcociotAn5FkGfufU4/+DeFRQ8aJ4pIsUj41r8AV/qs31Pduxxu1R3Dr1oD12TPQajvP3QRps1NA4g55URKo5L7mjAkUbq5S1JP3lgRX6M7EFcaSkn0HaibTJL0RWvXY33yK7g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote: > - the function body of the callback functions are now wrapped with > IS_ENABLED(); as the callback function must exist now that the > attribute is always compiled-in (though not necessarily visible). Why do you need to do this last thing? Is it a code savings goal? Or something else? The file will not be present in the system if the option is not enabled, so it should be safe to not do this unless you feel it's necessary for some reason? Not doing this would make the diff easier to read :) thanks, greg k-h