From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A85EFEB64DC for ; Mon, 3 Jul 2023 13:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B66D280004; Mon, 3 Jul 2023 09:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 265F3280001; Mon, 3 Jul 2023 09:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13946280004; Mon, 3 Jul 2023 09:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F335F280001 for ; Mon, 3 Jul 2023 09:58:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C61461609B2 for ; Mon, 3 Jul 2023 13:58:14 +0000 (UTC) X-FDA: 80970454908.24.8A31376 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf11.hostedemail.com (Postfix) with ESMTP id D867140015 for ; Mon, 3 Jul 2023 13:58:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=W8MiGSK6; dmarc=none; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688392693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/XBj/KASDZEwaINZN6zR62oMWEpcbbmzAAJb5oHzCeI=; b=W8qFoaZKq/1UBidTbWt73eTEyXGNlDZM5/WPLaqHlP+JWFa9fHYPGhVgrwN01NbGWuT43r MfsyZsbMQI/KN4setYRULlYQHUZUZZVCv81L95NzPzj4R+K7yxwcwxafI4PC5b8cGkNE2V x4uWNDnE+inYDZS2l8h+h2v4tRbP3js= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=W8MiGSK6; dmarc=none; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688392693; a=rsa-sha256; cv=none; b=XqG+m3J+GRq61vB6oaAq4MLD8tHknPmJEoIwONtUDpmy1SLeyX6aCOxz3O6ownSJmWAbap 2U1435Ak1NW7p8p1mUpEJ6XQwu6szBTyxQrCP1JcO6Tt2WTC5tfyDeQyCFOCBTBMYoMHaP uczIgaHyjDVrcEKMMNDs4MnLfeE9JJw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/XBj/KASDZEwaINZN6zR62oMWEpcbbmzAAJb5oHzCeI=; b=W8MiGSK63K7sPBiin8aiix6wVO nHiTld2qumxTI7KLvLiwRcb6+D867gCT4fcfIrf2UUrOCFffjXpjVD2DolVTfso0nq3diFjiGDl7u I5R7gSTbdHSFUrmZXgVcKXmALtqvVzN9LEI4Lug2UX5PSrFU19UfvLyffICP0tjPS3Z263iCSCX8Q NG7pwby6B82QH/I9tyBuHDRRg52Dvqxu2PWPJE6HcnpfmsSfWKfnO9hjIskcCD2Vwy21zuqEGbyXI n52/HizMJdjIcYm/Lk/JIgxjXRuwiGvNZSsrmij1Tn9hr4h5xsz9/UA0pRH1DMprbqSBd5tjIh4q8 Wxemefbg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qGK3e-00A60O-03; Mon, 03 Jul 2023 13:57:38 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 4FC4E30012F; Mon, 3 Jul 2023 15:57:34 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 308802028FBD3; Mon, 3 Jul 2023 15:57:34 +0200 (CEST) Date: Mon, 3 Jul 2023 15:57:34 +0200 From: Peter Zijlstra To: Yair Podemsky Cc: mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Message-ID: <20230703135734.GK4253@hirez.programming.kicks-ass.net> References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620144618.125703-3-ypodemsk@redhat.com> X-Rspam-User: X-Stat-Signature: 3bkmfpijomhx6c9jofkymr47mo3nnqis X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D867140015 X-HE-Tag: 1688392690-658896 X-HE-Meta: U2FsdGVkX1+LsTeXUMTdNM3FHEqH6OdgkBwsrCjcHIXiZSKbV/SIjlxdlQN8DQy4SmzCRF+W5xf33giYuzJVBg6Vo34E6VIB3pQKlSWqe0p2B2aj+146fmJoeGblZsl+HQjwatPfLK5ukwntDwGHnd4BrBpiUnb1cTFCHhsJz2494cy3XR4zhvmgjps0CbKbCd1UWzNHtKDvuLjN7UoIBpfoo4AM9IGe7qCyfndPdow0UjOx2ipsq2now94FQcI31lX8+xmSVNvYh95R2jZySrvq6KhgwiLcHhIJXU6mMmBXo5QM0cTpzsAIWSK54+gzoGfETkdluUjCxGTF4F4urdfEqKN3BxFbJzXEjbKbA94SAZ4kLiE0pJomj/SDM0Gy+XKLufGB54tysnZSHaerNTs7ebe70Cszo1aCgcsEhxzQ75VyeQkcLhvwKPhDR6yjHejVl137ByZMLKMs2l2crGpH6KxTF5Tg/FYwuhtTw63JupAPuBn8Qt5z7vYCDqFcL0admBjIOja+xMJmOSyi9uO+oEGAOJfw3ltI7Qx2+EO2cHAFrLGdJyjfOT0VOjmDXsRqGN+h3pZfuOXIV42iNY3bTPg7602nXTuC0zEIL3VzL1LBhOicN3++0R2P2T/guSLwQSYA7VhgWxUW4wgpcOvytUguU9pfkkwcgbWrd6iUqcLpZDQmp5x3kHM+6RkanMjaImOlowDQPg9S6REHteTaQpi4rG6zEDYAErlwS8310dkeWfrO7jmjjK0+250ZUX8JzUz2uBEA6du3qqJszeUIMca6jqtaqjp0VN20i+iUBiM1e5yGhv8pFhYt28D0WrGcqf2CNxOMi7vP7pkLqxG3nX5+ImadkKwYJeiOf0BdJDYUFI7My+hHKECJr28D9Ag2pzL0l8fgPJS/wbUYpmC31BQQazZ4ZEK5evG3wLZwSKodMBGS5NVObfpRSpmDlZ3Ch6uLH/MUIBBCYjn miA0zsrh Tmu1kraCqCtlwUBG03raaPOTdNyMJYGilqjK+xnt561c9kXu41dp8JeQspTyTCgLShYj3KGk3DjXXWgvbReXjPbQStZsSPCysuXkHURlabwgFhiCXOo+zedmeNf7YQ3GHalXXhzZT02RxBtA8OXmMtaFc9z6fO+qfeOpIbK/lnCTwogcLEKXaHIAgaZNjalsdAkqMSszMI4Fl1i3xgvtiuwNhqsz5vgGetxAM9G1YWCIBXMrOPCRG8nz773Z/joI+kxmuBHT/D9DvJME+h/wbF7G36A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 05:46:18PM +0300, Yair Podemsky wrote: > @@ -191,7 +191,13 @@ static void tlb_remove_table_smp_sync(void *arg) > /* Simply deliver the interrupt */ > } > > -void tlb_remove_table_sync_one(void) > +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS > +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) > +#else > +#define REMOVE_TABLE_IPI_MASK cpu_online_mask > +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ > + > +void tlb_remove_table_sync_one(struct mm_struct *mm) > { > /* > * This isn't an RCU grace period and hence the page-tables cannot be > @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) > * It is however sufficient for software page-table walkers that rely on > * IRQ disabling. > */ > - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); > + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, > + NULL, true); Aside from what Dave said about the REMOVE_TABLE_IPI_MASK thing, this isn't right. on_each_cpu_mask() includes the current cpu, while smp_call_function() explicitly does not. Yes, they all end up in smp_call_function_many_cond(), but the on_each_cpu*() family will have SCF_RUN_LOCAL set, while the smp_call_function*() family will not.