From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11455C001B0 for ; Mon, 3 Jul 2023 20:17:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B7E8280037; Mon, 3 Jul 2023 16:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 865A6280030; Mon, 3 Jul 2023 16:17:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72ED1280037; Mon, 3 Jul 2023 16:17:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 65351280030 for ; Mon, 3 Jul 2023 16:17:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3D24C140131 for ; Mon, 3 Jul 2023 20:17:31 +0000 (UTC) X-FDA: 80971410702.16.93B0591 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id DBFC0140012 for ; Mon, 3 Jul 2023 20:17:28 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QyJfPH2L; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688415449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0g8Wzx5XvcYH1oRLAwfYgmHKhSSWQawMNSCEQK6wVYE=; b=b72aQvMp5BS1uEpKgNaxz2qhKOhEpHzbrmSfO4eIDy/LEICy5Y38egZBZc9BJ35E0Du7P2 YT/wgV8FAVueUiZBHJTXSSZ9VUZix0ZLGN4Nfh/n009SbdT4fBXzeu6JqIIQqthGnX4lcv QizflqoL6VF2GlgsVEy1seUYPWg5a2g= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QyJfPH2L; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688415449; a=rsa-sha256; cv=none; b=xqXb13p2xjo063x+lvbkNVxwoNOEjwaSaJFsdRXKp300k0R47YBDkl/IEs1MhLcvYfPp4K 7NnMZ1zSNq/aFXhkJFTAq6PGzw4K4Dem87yTa3tYRZIyXwOhmjeBtuHpVkWLzdTx0whuVB p537tgCl8pGvr7+YCzwEqTx+A+WGbc8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F6836102C; Mon, 3 Jul 2023 20:17:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8356DC433C7; Mon, 3 Jul 2023 20:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688415447; bh=XHU+arubqBaR5pmsCXvdTB+U52TRbs5evboQlgh5QNM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QyJfPH2Logy1xxnhXlrKcAaNQpk9tua6e0fnFVnzcHAVdviWFo/mGGToA+kX0YwOG RjmilJVLwp6/+L3OmUXe5Bo3bsQ73NUZLVu77SVgeD+KlaAuTKO25PQ4c3E/ubpD2D gFtBhPxCkmNpj0r+givPOB81woCUSTQWEQ+fDfPg= Date: Mon, 3 Jul 2023 13:17:26 -0700 From: Andrew Morton To: Eric DeVolder Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Baoquan He Subject: Re: [akpm-mm:mm-unstable 62/89] include/linux/kexec.h:41:2: error: #error KEXEC_SOURCE_MEMORY_LIMIT not defined Message-Id: <20230703131726.d505551a7ea964341ece91ba@linux-foundation.org> In-Reply-To: References: <202307031404.Mjmo2JK6-lkp@intel.com> <3e8eecd1-a277-2cfb-690e-5de2eb7b988e@oracle.com> <20230703093144.27aa0d991c380f54be34ae93@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DBFC0140012 X-Rspam-User: X-Stat-Signature: y1dtk5hugmf3x4aa757pxdbeqxcg5ae9 X-Rspamd-Server: rspam01 X-HE-Tag: 1688415448-868478 X-HE-Meta: U2FsdGVkX19wcSlc/vO+IJsHfH7bObafHOR5vL9WwXGuEJ3/dme0/7cADO/Mky9nvk0EUIpwjIvkm/4uPR0tNWvdBGk4zlIsFTYlPA67btRNcyTnC17p9kJVWTV/DfHOEQaODTKGmmAWI1lxri0GYKOWKWc582DuzZvPuJ0vgHt31fNb0B9suERcrbFXmC5ibuPBjIEKHFQC1OQECwaNVzZsPTRm2x+kIKpVWR+CumOMxyn7WZwj8Dxm0kv0r49gAJClWZOi7jlFeC1m8Xs43yUpSJXqKgPyYDHRAUwyfzhNlPBZlM/tZyKjr9fQS0cGJoBfbwIAYF2UJ47YoXwRBfyWgYzBDN5L7RYi0bI6RVkkV1uHsX2iyLasTAqZeSVWEltx5028w9CRqBxQW7aMtTl9ctI/PuCc5Gt9OB+oQ3cnYdYVUP/8hSn+y1iW3p5/UuzJjZiSnjmz9T6kdQXBw5WR8GUs/CRLL+eIDvapxgzlSGOZnHiau4b3X4p2Zteclbt8sDDOffwualG4w/CyVEi73KDOqXdSaMuo/O/5J62d0tiqqdF5w98cxhmOphEtPrJJwYCQ9ar+3hehSK74TZPsAiwGeM39w5ffhVB3OrjiQEO14qOjXUgrMPze135ZkOisIrfzyHOOMgtEEVYaRaY8SFo4tzXHu+IFzz0AgRurqJonF4qUlXSvNpDPyA7Nu2PGwmWLJWB1xb+ML9w2/PEiH5Jfhpqw86bikYu426eypDfa98mA91WvZS/WsZyII+HjvLX4k1MSqSAz5rWiTMMd5AufU9dL/zwdu35SHpVlIAh4o580S3TiypbxXvNv1ee+lTfliWkBOCjAINFi7/WCr7jhaOc/IAlfI8CPHkS4kj+4gvKJZVNzZWIgp+FulPc8fjMkHp3YuByR9LY8CShG6h9OYKShTqrAtoXJnUl0N+0QRvqwT0Ngc0Kig3mtbpAjAwSSq2jVaHxOKrO mVuuN+ra 0FvfmREbCVQRswxgX4cG7Zx7WWKWgpLut/0cAaUsx1A0NSuAp0n4vBnyqjkviZIlc0fpdD1by63vVrccki0xL8vDYoDy4133a+W4gviCYKy6P70WqXNNFgRFW67MujVKCADXNTC2JfESKEeSumEWgNQDmZroYWXJEbQcxGk8GiRTWIvQidJjZS/h672hDOTK1I/SHktBTdiFAZ9XNLMpRfI6MMxZgZT+T/7VoN9Wji8UlabSKaF9ipcEdC9uaEaimqhDokMgAtCI8ws3wfmAfkF6j8G4HKs7hZiYHJcKfRaFea5VK7uA4MlP95ZTJr8A5HuvTw5qmiRRYl+uvcj4yFTzrD9VwF0RoSvBt3RmAeFhHS2JRKu6fl71Pxe6g5Ntw4ryeEg3IdwxS3AU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 3 Jul 2023 13:34:21 -0500 Eric DeVolder wrote: > > > On 7/3/23 11:31, Andrew Morton wrote: > > On Mon, 3 Jul 2023 10:31:34 -0500 Eric DeVolder wrote: > > > >> Here are three possible courses of action: > >> - do nothing; preserve existing behavior as intended by the series (even though problems like this > >> can occur) > >> - fix it with CRASH_DUMP selecting KEXEC to eliminate the problem > > > > This one, please. > > > > Or make CRASH_DUMP depend on KEXEC. > > > >> - do not fix it but document the reason why this problem occurs in the commit message > > ok, great! > > I also have an unrelated fix for riscv, and this correction (for both arm and mips). Is the correct > action to post a new v4 version? Or is there a different method? If the changes are small then I feel that individual fix patches are kinder to people who have already reviewed the previous. But a new version is OK if that's more reliable.