linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, willy@infradead.org,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH 1/4] mm/memory: convert do_page_mkwrite() to use folios
Date: Sun,  2 Jul 2023 22:58:47 -0700	[thread overview]
Message-ID: <20230703055850.227169-1-sidhartha.kumar@oracle.com> (raw)

Saves one implicit call to compound_head();

Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
 mm/memory.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 21fab27272092..098fac2f5efc0 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2932,7 +2932,7 @@ static gfp_t __get_fault_gfp_mask(struct vm_area_struct *vma)
 static vm_fault_t do_page_mkwrite(struct vm_fault *vmf)
 {
 	vm_fault_t ret;
-	struct page *page = vmf->page;
+	struct folio *folio = page_folio(vmf->page);
 	unsigned int old_flags = vmf->flags;
 
 	vmf->flags = FAULT_FLAG_WRITE|FAULT_FLAG_MKWRITE;
@@ -2947,14 +2947,14 @@ static vm_fault_t do_page_mkwrite(struct vm_fault *vmf)
 	if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE)))
 		return ret;
 	if (unlikely(!(ret & VM_FAULT_LOCKED))) {
-		lock_page(page);
-		if (!page->mapping) {
-			unlock_page(page);
+		folio_lock(folio);
+		if (!folio_mapping(folio)) {
+			folio_unlock(folio);
 			return 0; /* retry */
 		}
 		ret |= VM_FAULT_LOCKED;
 	} else
-		VM_BUG_ON_PAGE(!PageLocked(page), page);
+		VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
 	return ret;
 }
 
-- 
2.41.0



             reply	other threads:[~2023-07-03  5:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03  5:58 Sidhartha Kumar [this message]
2023-07-03  5:58 ` [PATCH 2/4] mm/memory: convert wp_page_shared() " Sidhartha Kumar
2023-07-03  9:29   ` zhangpeng (AS)
2023-07-03 23:29   ` Matthew Wilcox
2023-07-03  5:58 ` [PATCH 3/4] mm/memory: convert do_shared_fault() to folios Sidhartha Kumar
2023-07-03  9:29   ` zhangpeng (AS)
2023-07-03 22:05   ` SeongJae Park
2023-07-04  2:25     ` Sidhartha Kumar
2023-07-03 23:31   ` Matthew Wilcox
2023-07-04  2:18     ` Sidhartha Kumar
2023-07-03  5:58 ` [PATCH 4/4] mm/memory: convert do_read_fault() to use folios Sidhartha Kumar
2023-07-03  9:29   ` zhangpeng (AS)
2023-07-03 23:32   ` Matthew Wilcox
2023-07-03  9:29 ` [PATCH 1/4] mm/memory: convert do_page_mkwrite() " zhangpeng (AS)
2023-07-03 23:25 ` Matthew Wilcox
2023-07-04 19:35 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703055850.227169-1-sidhartha.kumar@oracle.com \
    --to=sidhartha.kumar@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox