From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DC3EB64DC for ; Mon, 3 Jul 2023 10:17:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68AD08E00BD; Mon, 3 Jul 2023 06:17:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 639688E00BA; Mon, 3 Jul 2023 06:17:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501788E00BD; Mon, 3 Jul 2023 06:17:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3E0708E00BA for ; Mon, 3 Jul 2023 06:17:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 11ADF16039F for ; Mon, 3 Jul 2023 10:17:06 +0000 (UTC) X-FDA: 80969897652.11.8D382DF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 45C07A0017 for ; Mon, 3 Jul 2023 10:17:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N48t31dm; spf=pass (imf25.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688379424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MmA8XEU+ZrXII3PHQqU0zf3NbN1gNUmXLfw9UboxhU=; b=2SGNPQm+7bL9LTYpc8b2pb5P/rDA7q2qnK6dwpLZC/WoT2++N5Kd+8+d0ivVi2ailUSPNn 8Y8kV5FIfafnFdwuCCaDCuLvVbGKq9Awuetndw/O6k84qAmnlof9hTDvIf5DKdpbHebeJO jXd5ygHRuxi/EcxDPpW1tQTMJTnlniI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688379424; a=rsa-sha256; cv=none; b=0K7Gd0RPZ+w5NfVN1LpzWqudcgooQCF9MsMr20KAYYvzcJtO4db/X+a2hHBtSJXPTud1mS MuAX2Z821EPvEKiUnQXf0MDGdbO0h1YlZqHL+0ah4vQ2cuNUP23uJB1U+Vu/rjTMqXMF/D +7349P2H8fyCzdTN47p3+qT3DqT4nak= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N48t31dm; spf=pass (imf25.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4097860E8B; Mon, 3 Jul 2023 10:17:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27205C433C9; Mon, 3 Jul 2023 10:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688379422; bh=Ny5BGLb0fUO45nms2Ulce0zlZ8XNNtXNnuA6dwqjEBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N48t31dmHrvPkjWqY/Baq5NMlwFHpF/7g/ejXfLwkkPN42h5TOXItvma+bxHIp+jm Be0k1GcbbozhqawxgxQ9ckWmybPEkUlvoR9e3y1UyKVALxXzW/pPdkR9hHqr/iSdT4 KtIfKN2z/s/hK/pY0Q2lVADesdGmfW/yun/6rNax7EQfnaHXhp7uGAetlmtb6hRiFF 9pVWWJ+WHTLS+XS6sXe/ol5Nn/BuiOV3HkRU1rK+AcUuxMlj0YftQB0xU7RSHNZe3q YdkBiGSeWYiXLYG+WOf3YVelcAYE+XuLl6TwnNB5nt1TDV7sYP7EF9CUqrn7ooo++S butW0UvCnz+qA== Date: Mon, 3 Jul 2023 12:16:57 +0200 From: Christian Brauner To: Andrew Yang , linux-mm@kvack.org Cc: Alexander Viro , Matthias Brugger , AngeloGioacchino Del Regno , wsd_upstream@mediatek.com, casper.li@mediatek.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthew Wilcox Subject: Re: [PATCH] fs: drop_caches: draining pages before dropping caches Message-ID: <20230703-freifahrt-dachwohnung-49d858588e88@brauner> References: <20230630092203.16080-1-andrew.yang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230630092203.16080-1-andrew.yang@mediatek.com> X-Stat-Signature: 61dzf9g81fn4qq9o7ryjquwydcqucmkc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 45C07A0017 X-Rspam-User: X-HE-Tag: 1688379424-58560 X-HE-Meta: U2FsdGVkX1+xOTbVLVYrBqgfztQZK55C8s7hCpeM6m57xNfDii9SNSq+S7+JLndQrqlcKMzQBovUsoIOgXwh8bUxmrn2abvGvhFn8dcjZ1Em3jwtVd/yUaUuFjowBUOIeScV3SDyERGiJVe4kzCMfEO9ZSIUgsdxtL0EYO6RIyNaK+0sfHqYXpC4HPznWDp56D5v1aIXhs893cPJRUCsfyYSWpVamh/o1EKVhBQB3J+bNJR8cMnuNDL5fU4+5TVGbItLT/u+bBj0/8x02pIkawoMnuC7UTIo+vOiGwgl2nVWzeNRhCxLQkk1Pv4fL6jpyaVQIuWyDdx0vvTg6Fqyat2g4Os9LvhsSM7Kn865abdYiwjR8fDaIBcWGeWH8TznNzD9DJXq5IunLp+5EpP2WIxN+rjgUqv4A1bBcsbozkfGoSInAtmC6ky0TREf1ANd+W+Dm5hZcs4Hr7m/i8p10vCtQkpgTlAZIi1q06mHnntKmC8yIVpXb+k0y/aw9iG6KlnKmIIByjzL/sMGIE+iHi9tTBcxjt6xSQp4SgRr19RViYOGZd0rM+NZfCnH/aPL++RhkJOj168zMJkNF7KcOWjdQR9qLgkgwy8XKX+kUsC4tc3bB8igtXxLYQ0Ij+PI4OvOC9Fpt4WGaDRdc7NVpG3xdFlEML137xJmyqW34WztgTlgLnNz6lQAG9cxyH12+jwlaLlP4T+CbIPJBJm2fINf730iv23TBpY/2y5Nqt5kd/hJlHMQC+ck7tIHK+6OQN59ksQl6J7alazmW74/yj2HkhJo15W3dWwqdnS4IJrRfZj8XCutldlOyWtIStliDHoY6W3xj+jqMlQUUeMvmLSPlZF0T/9QLgUZlYeSe9Ye+XyzK6R7i9S0RfP2ZRsDqMAVy9sPk83aLVWPGOrwQmKUKQy6RMUbTIIxnHWg6xhGG9n4zm5qn2Nq1m++4gHxBaRt3SOMTeoQN8TI+ya AbZdjmfO eH2X3Ufiz+c+GPqa9mK181MtXGsmaloB/V6gKeXiUv1d0QXU+a66rWjaROkrLgxaoC7aopVpyf2DBncslMKCQopE9vO7cqM01aLWOOAGUIss+IxOdtltptC917NhvRJT8zwleyuADJcqcDITKtpDgcg+61Z8Pi89lB+NJpGY8rh0Bcpr+WAWh9s3b23x5gJF6hSA+idWWDg7nXIzOywDuuoGdefR09KnTz3DD5Tj3RVrC4agSSR48pVMY2LdGtFHgTOgyaHicbbpSUdtWHLZg3P9DVKIwb0pt3yOYohp9IR7kFNyRrYpO3VoHzU6p31m4S4OVySvLO5XNfQnLGirOmU+YqZP0AckK7SaHIf3/Z0sXQ/R/pYEMjuxEE5Syjs9MrCqXTwn8u8Qc4SYMJUSbJQKk72DICMUK1KQntjzxee5rIlein4OEngSPxJNoN3Jerm6iW+xL1BH7FE5FY9xnoLYr98G0Cckn78/d9BdKclRLjZqpUBrtZCHcTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Really more suitable for -mm to review. On Fri, Jun 30, 2023 at 05:22:02PM +0800, Andrew Yang wrote: > We expect a file page access after dropping caches should be a major > fault, but sometimes it's still a minor fault. That's because a file > page can't be dropped if it's in a per-cpu pagevec. Draining all pages > from per-cpu pagevec to lru list before trying to drop caches. > > Signed-off-by: Andrew Yang > --- > fs/drop_caches.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/drop_caches.c b/fs/drop_caches.c > index e619c31b6bd9..b9575957a7c2 100644 > --- a/fs/drop_caches.c > +++ b/fs/drop_caches.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include "internal.h" > > /* A global variable is a bit ugly, but it keeps the code simple */ > @@ -59,6 +60,7 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write, > static int stfu; > > if (sysctl_drop_caches & 1) { > + lru_add_drain_all(); > iterate_supers(drop_pagecache_sb, NULL); > count_vm_event(DROP_PAGECACHE); > } > -- > 2.18.0 >