From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C07CEB64DA for ; Fri, 30 Jun 2023 18:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89C168E0043; Fri, 30 Jun 2023 14:42:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84C888E000F; Fri, 30 Jun 2023 14:42:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714188E0043; Fri, 30 Jun 2023 14:42:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 620D28E000F for ; Fri, 30 Jun 2023 14:42:40 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D75240ED9 for ; Fri, 30 Jun 2023 18:42:40 +0000 (UTC) X-FDA: 80960285280.03.7EC49FD Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 2380140013 for ; Fri, 30 Jun 2023 18:42:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="qTdD+kQ/"; spf=pass (imf17.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688150558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s90sSJDGZ4o69CYENWCxmFlyZZs5Y1mAusgwMiJFmQc=; b=Ov1LGsg8RoBTwmHnqy9Emm6EwKJ0sjSOUDhGvfab/ohzMCNlFG2Yyeh1S5nPOPGrqJ62w/ 3IcOL6VGZGjMeKvgqBzEUrQeKnSe6g6EjwCvQJmGHPWhQ2CJbohotrAE3hGBwN7OxBnptg gnr/kI94k4BT/AXZbfTOPE0iJkQyn+o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="qTdD+kQ/"; spf=pass (imf17.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688150558; a=rsa-sha256; cv=none; b=FPGYABpmWmqsAJGGRNzNtdobD8fSp4kHEtjcN0hE3Qq730nk+u1cmW6CmeruSz0M+Kfo87 FmVw6yv9IitKM7HbkEzjOmTlffjO3gq9DNsmBPdU1+3nVLRNw3dxL7LQ+G8NcmF1moMR5k 9Ot7HcBBGS1v+vq5PaFFYP8PsrkPkcE= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-66872d4a141so1731312b3a.1 for ; Fri, 30 Jun 2023 11:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688150557; x=1690742557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s90sSJDGZ4o69CYENWCxmFlyZZs5Y1mAusgwMiJFmQc=; b=qTdD+kQ/dZz9jFS4u5KBrSV1OOJAOhIlDM0dffuAP0q3sUhu/kxp8taqzzUmdZpudY c22eskJXTrN4HL16oes8igxcavJCz/amPw78uiR4IBRXlUFSHO6sCHH13SbUrTlmIPsg MbFxEY4ya8HuDWT4NfdtdKdqi+77XSdGXWebLa9+pMmjF9olCc/kuS2bY0Ejj4jrK+s9 WC99WMEyGCsdIdaIoBGMD0/aVJ10bej66ILx9pklM69fAPeHlENKvBGOgThvqX2p7UOB bkCHri3FXlSAhTrsava4uloq6l8Y63TpLaQLLlB4QpNi4DhDALNbEUcGTDqNpRPb2x3x +knA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688150557; x=1690742557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s90sSJDGZ4o69CYENWCxmFlyZZs5Y1mAusgwMiJFmQc=; b=anzMU5PCd0Xc15kabmCwNZLjE9f6y1w2/gMHVrBBdQ2JSgrPkjBz5XmPJk+W70BQ/N yisykGi7ms1+ePDTFtxEnsIm6A9Kr5Iej/AnSWmzpCQQZJ9qo1rEyWrUNB/3Kyicfxms WIY3jj730jmIBpaHxsGf0DGgLvr9L93yE6el+QTRxFLrTVo+pY3HpJZ8M+7xcVpiFKFF HWhZIkeBG2GTNgcBnR8T6JqUxxqUqfaE+T3u3ieJ/G3G2iqn7Eup3jQIhvMUYlndNUS+ mqT62/Msi5w8j9yTeJfnfeFZ4W3QibvFCcf9EVlXNH6V9oPdSlHvco+EqVax4EUwC0Dk k0Hw== X-Gm-Message-State: ABy/qLbbuLVySFsxXqXrvF3WpRwLCnr98BmXG8+z+s3BFzUCNXF8IEky PxG0ewAo68ApsAOhPibd1QY= X-Google-Smtp-Source: APBJJlEGsVVJrMfSJnWrKK8x9XhlvZ/lVjRS2VwnK4Qau3PCGMmGslkxKbq9jz3H2x84e9lAp+eoow== X-Received: by 2002:a62:7b07:0:b0:682:57f0:7c00 with SMTP id w7-20020a627b07000000b0068257f07c00mr3143508pfc.3.1688150556680; Fri, 30 Jun 2023 11:42:36 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id j18-20020a62e912000000b00666add7f047sm10215681pfh.207.2023.06.30.11.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 11:42:35 -0700 (PDT) Date: Fri, 30 Jun 2023 11:42:29 -0700 From: Isaku Yamahata To: "Huang, Kai" Cc: "peterz@infradead.org" , "kvm@vger.kernel.org" , "Gao, Chao" , "Raj, Ashok" , "Shahar, Sagi" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "mingo@redhat.com" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "tglx@linutronix.de" , "Luck, Tony" , "kirill.shutemov@linux.intel.com" , "hpa@zytor.com" , "imammedo@redhat.com" , "linux-mm@kvack.org" , "bp@alien8.de" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "x86@kernel.org" , "Williams, Dan J" , isaku.yamahata@gmail.com Subject: Re: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230630184229.GG3436214@ls.amr.corp.intel.com> References: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> <20230627095012.ln47s62pqzdrnb7x@box.shutemov.name> <20230627121853.ek5zr7sfiezfkfyj@box.shutemov.name> <9361abfa9bf22c2a1a4b25e5495bcccc5b8dcd43.camel@intel.com> <7b61715ad35d7b9916f55df72378e02e62c5cc4e.camel@intel.com> <20230628133541.GF2438817@hirez.programming.kicks-ass.net> <03def8b40a7db14f31d2ad67fb1a201e8ae8bce0.camel@intel.com> <20230630092232.GB2533791@hirez.programming.kicks-ass.net> <716cdf73799a5322cbe34c7f23d582f8a3ecf301.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <716cdf73799a5322cbe34c7f23d582f8a3ecf301.camel@intel.com> X-Rspamd-Queue-Id: 2380140013 X-Rspam-User: X-Stat-Signature: jrstyo58jrss1dqimb1gdpzanp8kdeda X-Rspamd-Server: rspam01 X-HE-Tag: 1688150557-846985 X-HE-Meta: U2FsdGVkX192kWLB3PPYBoxethg+oR5f/6q2FNIW7hlgmNTlkFaHO94ztzN4OyaJOpYDOW1QgB03op4r44Igl28FiuXxKgM6HugZrFFxZT18nEq52SRi4drk8AcgmiTHJrPW+Nt25ChohtfQ/JeCs1S3s0NAgR5vugbod8wBKNG+sg2FbEqctuW6umQGC8uTeFv+5ErlfxqRwybn2kxbRQbgi7IiuR1sJ7Jold8tA2+JXG4zqBVROaJdSMXXrkfS6X6bPGcUHWCOqicZSWwGQEJ5Oej8AWysn1Tyf/e1ut6UPQwl8V5ONn92sANDw6QJrg2jKkP1V4zDLXbBnh9174b2SbGwB2hBFLA9ZSgznGvuUBs67yECIDpMsM78zEp+eL7cj1ejNZhfj94K7jCSDPHxW+06uNkdgWJddwo104cnoPmkqMuEYDZHRW0tYAU1vxHv9eh9XJ61Qu8z9FRfhrTWRHirMHiGx6XNFfQ0TPqQ8xObs3Uskg8298TZYohwlbUg3qb7dLeHYP6KE+Lv/3m4GVPyU8LV1McI9uLpBm85aHWegph8k+HoYtB2bRBrzJh+HBOg7TO4PILe8B6BVxNwGKiEs7C7KBp9a4lTJ7xdOwdnT0eBmjqXQaA3PYOrvkjSd5lDliQ9cUxWZ5cx61Sysxf34LdBPy13Y/6jzvOLPBFlwSUxo59t3pu4s5aw/tgD+R3HX0zatlf1rrkqgZ0WpUUVOU/5RfAsW4TRSZVti1OTvndYKpRF/yz6fKkooSvS1iLXE2HckVHlPSSlM4mqSRJ5eJogmaZTiGSPsqyuR3m7SzfXpjodmBHYdXCxR4LG1LoztT1NWPTL590WDi/sJ+ZHqAD6xjC7dNWnsXrXPO+ZsGcgfrtt90Cr3Prq2NCCTrvc2/352KvCnwRCINIPBbFPzmRgniWjuFIRkxuHb+zvACOuBHGGTXr+l6154We+3y2JCn9pY5srikT hLe7icvK UUleGfc/LaNYT443PYnpzeSGV1G3uni9ab/RHMcGm8fpDsNpCW/DiLXBD7mhqMmltkTN+bPQPlNanAYO54PalF3z8xSGkBSYl0PCCaluzjbKdU0F0pdSlsYgRechZMvlqOIV3XPS0wQByG48L0lnkEwO/Y2ZVt8QrzFbUXWxd0tJpOtRF20L2wemqq9dCkWz9dTQFIOZrDQoj6HBDUseH21JsHTplGxUbPoZz/Kjv1wI2w7ukMa2JFC6b6hKbzQ5WknQawHK/GLT2lgW9oT/4IehDSGktY0Ci4hlJ6kcdahzWoibpN1s2jhxH2JUvowRwDRzo1fJPgDRHh7vP+sxqNvSpeuHRxkwCv6K37GXHL9dPsxBO88VahBvxYL7sgHIE0Jja2Xs+TjIsF9xaGKiW8tUpjBDqkJkFDdmiafBX7C5aYqBbYINdpphnp55VUs0X1p0fYV6D+GZwlFh2rwBhUBwLTDNnFf5ugQR2ouwac7GDV8rQooEnb2STPPqnBgcvg7dzUgW6eCyDPdai1M8PplCNGguBS5NxLDXeaa+IAitKe2+cRQc2hjUpZNsq6/esqCFEF3mAECk8HrQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 10:09:08AM +0000, "Huang, Kai" wrote: > On Fri, 2023-06-30 at 11:22 +0200, Peter Zijlstra wrote: > > On Thu, Jun 29, 2023 at 12:15:13AM +0000, Huang, Kai wrote: > > > > > > Can be called locally or through an IPI function call. > > > > > > > > > > Thanks. As in another reply, if using spinlock is OK, then I think we can say > > > it will be called either locally or through an IPI function call. Otherwise, we > > > do via a new separate function tdx_global_init() and no lock is needed in that > > > function. The caller should call it properly. > > > > IPI must use raw_spinlock_t. I'm ok with using raw_spinlock_t if there's > > actual need for that, but the code as presented didn't -- in comments or > > otherwise -- make it clear why it was as it was. > > There's no hard requirement as I replied in another email. > > Presumably you prefer the option to have a dedicated tdx_global_init() so we can > avoid the raw_spinlock_t? TDX KVM calls tdx_cpu_enable() in IPI context as KVM hardware_setup() callback. tdx_cpu_enable() calls tdx_global_init(). -- Isaku Yamahata