From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B3DEB64D7 for ; Fri, 30 Jun 2023 13:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA7D38E0013; Fri, 30 Jun 2023 09:39:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B31A68E000F; Fri, 30 Jun 2023 09:39:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D16B8E0013; Fri, 30 Jun 2023 09:39:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 870A98E000F for ; Fri, 30 Jun 2023 09:39:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3A30D1203E4 for ; Fri, 30 Jun 2023 13:39:03 +0000 (UTC) X-FDA: 80959520166.18.68413D8 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.221.58]) by imf05.hostedemail.com (Postfix) with ESMTP id D795D100009 for ; Fri, 30 Jun 2023 13:38:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of falcon@tinylab.org designates 43.154.221.58 as permitted sender) smtp.mailfrom=falcon@tinylab.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688132340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LRPr9yfUOUjWg7UqeHvxtUxFjw8EasZQcd8vBHG33Cc=; b=daahknaqQqRkSZs/fx9Vrpr5Rj3R/zNQDko05CqxZetkoVCJ5ikRsdrLEHmR7nr6hfmMyK 6ykmhwAXwS7/BV4dP/wlscCoSUZZ6SIf2Cly8LUJW3OLXfImCMzHED4Ze5A/tHI3OK8X0Y yZwouJww6df+LDw1nOXthsWI7r1w81E= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of falcon@tinylab.org designates 43.154.221.58 as permitted sender) smtp.mailfrom=falcon@tinylab.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688132340; a=rsa-sha256; cv=none; b=DaAiZutHQZLBz6EltkNiz7dHcLKDuJkcXoRa9wzJod6AllP2unCfIPWCRI+MT5nyGoMqG3 6wYaId6MeVFFcSAt/44omqkYbtXcbmNb/SRecooJXNP+7mwIBJFZ6vlcYFLwIXEW0rR20/ LX/8g5VOD2BYqxf6hz8MOqdaulwaosI= X-QQ-mid: bizesmtp72t1688132308t5lpes6w Received: from linux-lab-host.localdomain ( [119.123.131.49]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 30 Jun 2023 21:38:27 +0800 (CST) X-QQ-SSF: 01200000000000D0W000000A0000000 X-QQ-FEAT: G+WLZ/1vSOE/QeI/ppaBpcBNTobcOzk/g+2a/fUhWadeWAN+Bf2pPc5KJQ0qu voSj4wbaCgh1sL5WZn80GZweZDDv0HyR/15Km1SmhfByZvoLY8ZUEIFopcm4HQoEA6UX4ZH t8q9lQ5IwoPbm+PPSMuTROK2wA7dH7g+p0MWNA9tXIAfcqqhXmQheuhxTN6yvNrJEXakTbJ L986E2QHyLUolLKqSvg3ID/S1QVbiu0NyS/unPrW1XC+2lWzzKtzBj7VB9+og4kdNRHJL9N 0r1UDRFNLOuXKr0uS1P4VPKZje/L5VnJ5ZrmSZ6VKBU0pQaENlncL4aoXOdcf5Itm4Og3Yz O9oTPAv7rIx2XYBpdhXS58MK7GPO3KO7MVrWKretIXL59pJhBYmGlgpTdc9kJl3aYmvUyXB X-QQ-GoodBg: 0 X-BIZMAIL-ID: 4867400409169338334 From: Zhangjin Wu To: linux@weissschuh.net Cc: akpm@linux-foundation.org, brauner@kernel.org, falcon@tinylab.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, w@lwt.eu Subject: Re: [PATCH] mm: make MEMFD_CREATE into a selectable config option Date: Fri, 30 Jun 2023 21:38:26 +0800 Message-Id: <20230630133826.245610-1-falcon@tinylab.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230630-config-memfd-v1-1-9acc3ae38b5a@weissschuh.net> References: <20230630-config-memfd-v1-1-9acc3ae38b5a@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D795D100009 X-Stat-Signature: cp13znotif58c1xrqbpr1utctbtki7to X-HE-Tag: 1688132338-343932 X-HE-Meta: U2FsdGVkX1+Hs7x2kcZP6yZiR/WUlJWxitOccnxNbHOjiCFfyIck8PHD9AuqHAHEkcbW7ABf1PJgmNQqPmqLjUn3Oa9a76E0/jN6D72GHkevubzQB1Bw5faUSyuv5ePsBfTC+g7akz7RYba1YhQi+HFUQs/Tkzy0uLUjmF6BX3pdqUELTlJ7ZAIl4PHahkdKRlLrn3EDLPqci0amI00R4MezcxQdQpHPfcCBRVMBRfvykzH2q77RFckKWbx8qrG6Y4i9DuxqkHjGoSuz0U6MPjxiSUXwtGHOdZnWudkLCpB7bnNstL35JIgf/DsI44ZtiR16OmBzfL9RvhyHGs/vbBondB8Ye6chqsQEMQIUU58o+ilASJyAwE67xMaliY6rzENaHVKRtpmcJxmuf4i7rDyFsnsVRyp8V0UxblCe4daijKh2CRquuxgj2OlKWLdbn2qlLjBY7eV8C/c1ps2A04cv509t06sBgW4OglYU0/6E08pWSdTF1S5h6y2O3rZGB9BdIELufN+iIseO6Tvt6sZY2WjRRdGBldU5ZUr4ZvgENokS3Zq+yDtWTSRNV4/O2esLXjUFsML5fUnpE1IApvb0eL4egEFQQKMIJFs7ns+HaqVq5Cmxwk6n960AxRC6e0+bUHwxkyj2sk4kzr66L3aZDv33lowFA1OQJTXCZD/f1UPEt0kRZDZJZTOxKqznusqviIu6AzZL08ZCAAvgh+bKHf1hHc0EM6qjo8tr6UKOgMVI3xlGSaoBa/RzHukIkQttBr79Et5XiVf7nPwYErKwnR+pTC9DoXzoTT5sFq/fI0ARU4QT6JWZNab9ZftbwLCrUKLc8xJQhh146Dof6Mpt0dL0pA8MKqCsNSvhNTx44Z1gUhTCaMu1lTH8KJ9Y5sOFgoQeXztcRDCH2EUOCc8PNWdKpYic6OO2zhGhs9HAMtneOVaVFRGEwx5/4Id/cXnvrb9jsLlMmkGLZHw Dt005Gq2 AP/mGASKK6ju5LSNRcFGG4WJLJl82aaUeb8gA0JAlbDbLLOMRYiy0MAYgkhTyoskz+LOSAlF8CCybHBTAeSxFz1P0kgnfBQnOvc05jobUWuZyJOQwUBaAc4v6T/t2c6fA0b4ZenzDYEFDze0k3BWc5mwDTRrw/TtVIVwW9bo726un000udystTKkQUYDBg7/EHaa+mm1NC21GuHY67L0YSdbtQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Thomas I have manually applied your patch on v6.4, enabled MEMFD_CREATE (and disabled TMPFS and HUGETLBFS) for 3 randomly selected virtual boards: - arm/vexpress-a9 - aarch64/virt - mipsel/malta For all of the above boards, the current vfprintf test (uses memfd_create) of tools/testing/selftests/nolibc/nolibc-test.c passes without any failure: Running test 'vfprintf' 0 emptymemfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=1 'init' "" = "" [OK] 1 simple "foo" = "foo" [OK] 2 string "foo" = "foo" [OK] 3 number "1234" = "1234" [OK] 4 negnumber "-1234" = "-1234" [OK] 5 unsigned "12345" = "12345" [OK] 6 char "c" = "c" [OK] 7 hex "f" = "f" [OK] 8 pointer "0x1" = "0x1" [OK] Errors during this test: 0 If this test result is ok for you, here is my: Tested-by: Zhangjin Wu Best regards, Zhangjin > > The memfd_create() syscall, enabled by CONFIG_MEMFD_CREATE, is useful on > its own even when not required by CONFIG_TMPFS or CONFIG_HUGETLBFS. > > Split it into its own proper bool option that can be enabled by users. > > Move that option into mm/ where the code itself also lies. > Also add "select" statements to CONFIG_TMPFS and CONFIG_HUGETLBFS so > they automatically enable CONFIG_MEMFD_CREATE as before. > > Signed-off-by: Thomas Weißschuh > --- > fs/Kconfig | 5 ++--- > mm/Kconfig | 3 +++ > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index 18d034ec7953..19975b104bc3 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -169,6 +169,7 @@ source "fs/sysfs/Kconfig" > config TMPFS > bool "Tmpfs virtual memory file system support (former shm fs)" > depends on SHMEM > + select MEMFD_CREATE > help > Tmpfs is a file system which keeps all files in virtual memory. > > @@ -240,6 +241,7 @@ config HUGETLBFS > bool "HugeTLB file system support" > depends on X86 || IA64 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN > depends on (SYSFS || SYSCTL) > + select MEMFD_CREATE > help > hugetlbfs is a filesystem backing for HugeTLB pages, based on > ramfs. For architectures that support it, say Y here and read > @@ -264,9 +266,6 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON > enable HVO by default. It can be disabled via hugetlb_free_vmemmap=off > (boot command line) or hugetlb_optimize_vmemmap (sysctl). > > -config MEMFD_CREATE > - def_bool TMPFS || HUGETLBFS > - > config ARCH_HAS_GIGANTIC_PAGE > bool > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09130434e30d..22acffd9009d 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1144,6 +1144,9 @@ config KMAP_LOCAL_NON_LINEAR_PTE_ARRAY > config IO_MAPPING > bool > > +config MEMFD_CREATE > + bool "Enable memfd_create() system call" if EXPERT > + > config SECRETMEM > default y > bool "Enable memfd_secret() system call" if EXPERT > > --- > base-commit: e55e5df193d247a38a5e1ac65a5316a0adcc22fa > change-id: 20230629-config-memfd-be6af03b7dca > > Best regards, > -- > Thomas Weißschuh >