From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E202EB64D7 for ; Fri, 30 Jun 2023 10:21:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CE6A8E000A; Fri, 30 Jun 2023 06:21:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97E0D8D0001; Fri, 30 Jun 2023 06:21:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8456B8E000A; Fri, 30 Jun 2023 06:21:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6F5D08D0001 for ; Fri, 30 Jun 2023 06:21:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3E0851C830D for ; Fri, 30 Jun 2023 10:21:57 +0000 (UTC) X-FDA: 80959023474.19.8D7839F Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf26.hostedemail.com (Postfix) with ESMTP id 6486F14000A for ; Fri, 30 Jun 2023 10:21:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=mr5w8p5k; dmarc=none; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688120515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZTty5miVE3pLFaCbNCICtFycZZgvwRIvYM0pV9affk=; b=MhAqm972lN2ZMhBqXrWBfV+JqMm7owPdccxvguLUMGnPM9wD21iGkb2lhxNhtbxXS7uWZ/ o53zY8aWsVjE+bt/klTmFZvrEpPpTjIrClyfaXaWdpzjs4bN2+AMz9SItaVudrVkoEA2N8 DXACJaACv5eTJnaWd6aKqIRKZRvtWjQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=mr5w8p5k; dmarc=none; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688120515; a=rsa-sha256; cv=none; b=o+NV2Sw/Fru7luMvFAGBW6ShGvO4FdoiuTqblyggrzkYCUDru5oEcDOnruOBXXh8/Be0ag lHRjZe9S5dsMEU/nUBBfO/ZpHdvFouYkKK/ahJWmQtEe0kdlhLjkvu/Jes3FlS74H/RMQk Fb8R8iuz4fKzBuId+L6Q5NbyswbEbFs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HZTty5miVE3pLFaCbNCICtFycZZgvwRIvYM0pV9affk=; b=mr5w8p5kFvbz0qkVhJwLHaS4gB GnYulcZDw17ZUPFMeM6y7Op7khTnbhx8ozRYLZsQH54W5wygIBv6uMjs+VJYNwo56SZJ7bpgWHBDX slnIxzMdV43ozSNjwC3T+nHdnJNYRSlnKLVmbAolWhBWTjFn28pNMiSyo035DDo7AZIRB5YNO6UtD gr8MIP22HNB1+dhFTNbyKqxx/EWlnFGG7F4QM+GOqkgdu9LXuAxtSzrv1E/kZ1Iyc9IxGGpUzA5A8 SOz3pGsdN7uzW+eET3vi06wjGGRVyRg8eeG4ks+b8aBqeNODpGys8xfRXC6UspjjKWSYlz5fa9mr2 rXr6Z0zQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qFBG3-007x7D-1G; Fri, 30 Jun 2023 10:21:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 06C69300023; Fri, 30 Jun 2023 12:21:42 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DEF7924819474; Fri, 30 Jun 2023 12:21:41 +0200 (CEST) Date: Fri, 30 Jun 2023 12:21:41 +0200 From: Peter Zijlstra To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" Subject: Re: [PATCH v12 20/22] x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP Message-ID: <20230630102141.GA2534364@hirez.programming.kicks-ass.net> References: <20230628152900.GI2438817@hirez.programming.kicks-ass.net> <20230628203823.GR38236@hirez.programming.kicks-ass.net> <42e13ccf7f27a68c0dd64640eed378c38ef40967.camel@intel.com> <20230630100659.GF2533791@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630100659.GF2533791@hirez.programming.kicks-ass.net> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6486F14000A X-Stat-Signature: sxe7cnezbrhyrkb35hg5qrynwyic4s6i X-HE-Tag: 1688120515-769844 X-HE-Meta: U2FsdGVkX1+LQ5ggEFRjhG11roCiKlCLoc3MlPObzxMv+AOOW5gh8MZWrHOY/uVh7Qp94QV9lHhtp3fpjj08uVFrGIHxMS84XhfxdzFwc+JpNJYJ8dX7tagALrLuez6eAIpnjCNZ1sUdpdm4kFXQsgSEuynpLqhGkAZpwL5yl2gDTcTbtYspt45p0KKzNcaZgvzybBmBUDCN/gFxu2Wh689FReiC5esTieZgB+yApZVXWYGIOcJyAr3XqlFAvVgK1l6d3K/NJCgnRGo+wLunP1Y18MXvmsv+zryb41T+iRreQN00FspRaHoLasSJ5djFka9F8aNNmjqh4aDHhpLcTMzhrwKvYh4p38ojt1cphYhdqQXr1p52OFA6xMl9QrTHhsGw8rvM18fUGEIPnG75sOmZYmIqtYoHqMA/4NQ7Rsl9SGdMrzWmWTm+8B7rMye1fygglHNZlEjKtM8Kzqt2GxRXHQYsCxcFnJlH2C91yUe2Ek22iheroZv+jxLuX1ahC5WIsFIKlSX9eCJRkNRBlwKG7NgEYylDzzS+QfhKToad8ye1xhqQ/GAcoG1+HaDQ2yuqKvRKPeBGNr/wkpTJcMm9jMhQj4j4tEpWc6OrKDLvmSSgaEJaO8iyGUapPVtNUWh/eEfxcy/dZ6B1NIGWOOyd94Spjj4F/ic6dJYBzj3Rf87HukoQE/2XNqHrzr76ugO/P2wqPpqXIXXP5VmUidCDfLhQix0W3Q6V/G2zD06u/Zloz6g0Vk7J+ueUBhIx1Hrjqzue5am6CynZIH5aoS4HrwFDRxrVWzeRzHxmKHXPUCZs/O5SQFO+7ye1bjiZAIVRQen0X1BMw/qED0Q73g1zG/4W/Je76BUMoqYHaDr7PXX2P5CGB7ekeva5nzj/wtyKt8AAlv2t07YUNLn6o+Zr4AnXbSWPrAHoYF/pEWOzyj6LhehOJB4xjwegc2jzzJ8zilIaZmcswPhNuvz 7YmTAwZO J5hXDm/uJMjAPElZxiBVfkQpeqXPMXk/w5sxF1hYkS1FOJCmMqxSp68o/Y0JgTXH61LJ9RQp5r7ffzk7b3BaFbS+WrnSitmxEPPQxzM0mf3V4HrnkIdpEwTe9EGDVLXpFC4QtOGpo629KQay/XX+c9bGFXRq7mBelYxTr6DzvExd8/J1nn2NXMg4v5WSV2c5ev0kklrki/SK/HjY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001969, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 12:07:00PM +0200, Peter Zijlstra wrote: > On Thu, Jun 29, 2023 at 10:33:38AM +0000, Huang, Kai wrote: > > Looking at the later versions of TDX spec (with TD live migration, etc), it > > seems they are already using R12-R13 as SEAMCALL output: > > > > https://cdrdv2.intel.com/v1/dl/getContent/733579 > > Urgh.. I think I read an older versio because I got bleeding eyes from > all this colour coded crap. > > All this red is unreadable :-( Have they been told about the glories of > TeX and diff ? > > > E.g., 6.3.15. NEW: TDH.IMPORT.MEM Leaf > > > > It uses R12 and R13 as input. > > 12 and 14. They skipped 13 for some mysterious raisin. Things like TDH.SERVTD.BIND do use R13. > But also, 10,11 are frequently used as input with this new stuff, which > already suggests the setup from your patches is not tenable. TDG.SERVTD.RD *why* can't they pass that TD_UUID as a pointer? Using *4* registers like that is quite insane. TDG.VP.ENTER :-(((( that has b,15,si,di as additional output. That means there's not a single register left unused. Can we still get this changed, please?!?