From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389AEEB64D7 for ; Fri, 30 Jun 2023 09:26:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2CE58D000A; Fri, 30 Jun 2023 05:26:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDCA38D0001; Fri, 30 Jun 2023 05:26:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7DAF8D000A; Fri, 30 Jun 2023 05:26:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 98D618D0001 for ; Fri, 30 Jun 2023 05:26:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 34C06160E78 for ; Fri, 30 Jun 2023 09:26:30 +0000 (UTC) X-FDA: 80958883740.22.76780D5 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf27.hostedemail.com (Postfix) with ESMTP id 63FF040005 for ; Fri, 30 Jun 2023 09:26:28 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=oafGXmMG; dmarc=none; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688117188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A7ZndEt01QEZmkLMkpapRia2Tu8Y/tv4dlx01OgRstM=; b=NgGtCv1eky79morg6uUkigcl0INQFU69I4vH9ud+r3cv2J4pbf+T2QMS97OeY0dwG1CfYB 0No8O8sNrrpgGGEqzE0/rcEPOe5Q5FZjAXKohV4nxWSVff/GUHofcJDAN46jK4bNaWnH0G HslE6Mqlsbake6j2NJ72KluwzGuVass= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=oafGXmMG; dmarc=none; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688117188; a=rsa-sha256; cv=none; b=Wm5rw6DbB30r1JE91d7UCRR8IrcJzu+IYzxpMWJmUmEcikaal70s/AZAdE6m4eHmYmEdaJ ZYt1I0P9U5Nd+AJEbmLb4+A/Oy5z2dJ2MtJ35qJjXhi9RLDVn8qWQxau0Z8RbGnbE6QSWY l0l7FpL1cCT0cPW07ouU83aqRCptqiE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A7ZndEt01QEZmkLMkpapRia2Tu8Y/tv4dlx01OgRstM=; b=oafGXmMGFJt3bsEOzR38QGYprG LNFkJjjxFfrmiWLryi6zOAcgKaY1wXL2D7SMBGMsbfy5PSOHUZiWFQH1noAJfkpWU8K79s3cflx01 K0oOO9cjX5PFKMcbM5lowEZQyEOeGJ85XHGlrJiPH46Pj+sgxj/ON9oEMsW8YQmvgBz2w3MJm4fJD P87HMXE5fYGq5t36C1Bg45k6ZuOL3hbq+VCzqo9ef32LN0LuZcRVEmxZz1szSkcnvgMUQFgARiyZP /sWCJxggP8hn9ce8+Xa8y5hTM7l/L8Og1YgC++eWuMPD4scs/iOo5fTEXThcRMUXoEjagHDifcaW2 tf4fyGhA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qFAOO-007wMo-16; Fri, 30 Jun 2023 09:26:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id EA3A3300118; Fri, 30 Jun 2023 11:26:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D9AAD245D3645; Fri, 30 Jun 2023 11:26:15 +0200 (CEST) Date: Fri, 30 Jun 2023 11:26:15 +0200 From: Peter Zijlstra To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" Subject: Re: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230630092615.GD2533791@hirez.programming.kicks-ass.net> References: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> <20230628131717.GE2438817@hirez.programming.kicks-ass.net> <0c9639db604a0670eeae5343d456e43d06b35d39.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c9639db604a0670eeae5343d456e43d06b35d39.camel@intel.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 63FF040005 X-Stat-Signature: k6xxbwxhjcp9bgoturpf5kkxmxn9kztk X-Rspam-User: X-HE-Tag: 1688117188-168976 X-HE-Meta: U2FsdGVkX1/NeR8RPyVYJodyT4jmYmWS/IZgXu6UjaTMoUPfkSfoPEMr+4rp8jPQRJgSC2uWa4bBFE88TnGzH98C+D0scd3h3S1fKgixtwhQAJGHH0evEQTrHmkegxI7pnr1vw6uDhD+qVtU/AlP1Lc8SFqtarXYXUJEnxW5J9zbriPNydHwRzEcltlZsPWuEFPIcKhKtH4RaT4okithhUg0fwmEIE7z8xnCfDEv8pOMJ71RKujGUCVbj+MUNB1SldIT5YN0c/dn+9BaOTiWZ2SDMtUtAOXAkXixiDci5DE05uEoFkEppF+SLE4UqrbePRBzeOc0G1HgcNfPggJVCjNQ++vfeD0e1tmzYonNiMj/ApxDwhOIxDPgfaI88TI8t0nj+bqu2RJ1MHt//RYcu9bAyYqjf5qAeTMvw10KsUgRI4VbRIKx62/4k4ZEYDpgcQfJUk8JntJ+m+TJnkvZnHxmYzamambXYLfvc0EXnc0FFAJAZnmUck0TK6xKP89SjfBrUnyWTMqoTNLRzOdE3wysewoBnVdxr34HpARQJhCoH64Wl7VEc3RTzXQsWcCGS74AltVVQ+xh/hT8UqsLF6Wyk1TIsfuQjKoUcZapkzngJFSEC03UzBKMrJIyoLiut0PWu5dCwxRE+bCIbzQ3SwyUWxfAWU7MMSTrzXziAKUAYnepGCEDw6k3Kc1hMEjkUTIPgrIvlBX6jV6nTWdd9BJ5kqivf2pdn0UQ1wHTFp0ScEz66kVgAKAv/jt9GLEkVF/uZVU9zThTKZhuqjB2YdpBGypWUdHCw6G6NaXNkUsGWf6XsTvAsjitgzwSwZr7i101NgMJw7wARhQEPzdGSeqta9w4N3lyT0okGo386RyVWWWAkLaSmiBAyevVTfR/aMN2qu9WfLrLUWePPjQO1N1OCMmtSAjOUVT5ZXQZm/WxFdUwb/lf31rahLFgIZPkEp/WkWt7R1yaC1xAH4h zW6teij+ hP9rEXR+1ORRZ/kR98azX4AUCjJPWq4YQiWGzNckq92nqLBNX3FYQC0O5O52Z1BXqbXrofROOwU39Gd5aUnW77XwNMbJx/8g6Ti7dlsQOL/42q0GKU27ROq2qrthtFG3SAwhx/qNdhQGv5fVkSpC4KU9i7pYsPbi9ynaBl7IdyljkfFihUWiwjAk9aQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 12:10:00AM +0000, Huang, Kai wrote: > On Wed, 2023-06-28 at 15:17 +0200, Peter Zijlstra wrote: > > On Tue, Jun 27, 2023 at 02:12:37AM +1200, Kai Huang wrote: > > > +EXPORT_SYMBOL_GPL(tdx_cpu_enable); > > > > I can't find a single caller of this.. why is this exported? > > It's for KVM TDX patch to use, which isn't in this series. > > I'll remove the export. KVM TDX series can export it. Fair enough; where will the KVM TDX series call this? Earlier there was talk about doing it at kvm module load time -- but I objected (and still do object) to that. What's the current plan?