From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73470C001B0 for ; Fri, 30 Jun 2023 09:23:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 159C38D0008; Fri, 30 Jun 2023 05:23:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E1E58D0001; Fri, 30 Jun 2023 05:23:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9DC88D0008; Fri, 30 Jun 2023 05:22:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D6D5F8D0001 for ; Fri, 30 Jun 2023 05:22:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC644A0E75 for ; Fri, 30 Jun 2023 09:22:59 +0000 (UTC) X-FDA: 80958874878.18.85EFCE6 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf30.hostedemail.com (Postfix) with ESMTP id 5605E8001E for ; Fri, 30 Jun 2023 09:22:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=XmROkBf3; dmarc=none; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688116978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iTX8DaTvNk5W0MCthv55SgD+0pWkPm2TRQnZZ/JQ/qY=; b=oanoxzN56Muqa/Zpa7jxTqj7nlDRoqb1cMHPbvojPMhCl7NrOt6EojdGL+rv8xLFYbJpm6 pqhG9Q+gYtaFW85F+RcrVV9IfWPsn2pOPp1M5lQsH/8YvFd0rTKpFL5Yf25eKNgNaRlF0K d5cuX5z1PwEx8/euDj+5qvUL/MHOwCM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=XmROkBf3; dmarc=none; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688116978; a=rsa-sha256; cv=none; b=kYw1F8FAuicEoVI5Z/svbn+bvoy/66u/LAI9D36ofKK+GiKeJg02jXmNf3hp5uKUQeL/ne YP01N4qS6Hm1NT0cpva5M5hNSZAag0CLdPeohGEwZg/kXToI/hpuhOMeFur7iY1lZAWG0r N9/VJHza4ukvq1WQhneB3xezIEto5EU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iTX8DaTvNk5W0MCthv55SgD+0pWkPm2TRQnZZ/JQ/qY=; b=XmROkBf3JCdjF81mNoAr+LIl+f Vw8rNxXyhVFIA0bcfCCqDkKp3Al+MOXDa0mh1xa9kPkY5ab+csf2UZDMVn5QeNXvnolMSu7KXZamX liALNMxlMn2C5LbM5kDAFUWhYIBVmAef4LIoP1kjEkKtDU2knGS7fXjBFuUqkKkncUp4hZzHaJSz9 jhw4r3B8HYmhS3zz7YVk0EBMRfidp7WyeP9dAzb36mYOOsr0Lxbf6/FsQgwJai7oPDdjonVeM7Hv7 YYyJhy0l1q7TWDUSN2nX/2Xt/NOP8giii0QyfQDX6v4keJsJdG9b6/BcmIYd2X+JGtxww/4uDsPOi sxo96+iQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qFAKn-007wJ4-0D; Fri, 30 Jun 2023 09:22:33 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 51BE7300118; Fri, 30 Jun 2023 11:22:32 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 31692245D3645; Fri, 30 Jun 2023 11:22:32 +0200 (CEST) Date: Fri, 30 Jun 2023 11:22:32 +0200 From: Peter Zijlstra To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "x86@kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "mingo@redhat.com" , "pbonzini@redhat.com" , "Christopherson,, Sean" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "tglx@linutronix.de" , "Luck, Tony" , "kirill.shutemov@linux.intel.com" , "hpa@zytor.com" , "imammedo@redhat.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "linux-mm@kvack.org" , "bp@alien8.de" , "Brown, Len" , "Shahar, Sagi" , "Huang, Ying" , "Williams, Dan J" , "Gao, Chao" Subject: Re: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230630092232.GB2533791@hirez.programming.kicks-ass.net> References: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> <20230627095012.ln47s62pqzdrnb7x@box.shutemov.name> <20230627121853.ek5zr7sfiezfkfyj@box.shutemov.name> <9361abfa9bf22c2a1a4b25e5495bcccc5b8dcd43.camel@intel.com> <7b61715ad35d7b9916f55df72378e02e62c5cc4e.camel@intel.com> <20230628133541.GF2438817@hirez.programming.kicks-ass.net> <03def8b40a7db14f31d2ad67fb1a201e8ae8bce0.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03def8b40a7db14f31d2ad67fb1a201e8ae8bce0.camel@intel.com> X-Rspamd-Queue-Id: 5605E8001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sd9b5km3zdzdwj9z8ck19zfhadxrikm9 X-HE-Tag: 1688116977-194009 X-HE-Meta: U2FsdGVkX18OjNgZDFN1f7B7lVskeEvpxzcIT/csGnrB9eu9BsD8+Uo8veyRBiVg/rsz+XUxLbSc+iQkEg9KDT+4OpY4y8q/wfZUlhd4Udw165PUFqubCwwIxA1Sz6MQs6YvrETTgo8PxPfE5oDosH+qvF7MM9tfkjsNiM+oD20MlhYA9EoFgdWX5MPBHNnGkxQpkwAD4yaddQL+63e6R99ce0D3RTl5V7kDgos+0tEN7h0aZln7hQNLxOPJGIsZdYK+9vlgmhVD3PCnQVeCpu2y4xwVf55jOFUB2rj82r33AUPZTyZnIn8l/pjkQkZhEmHG4yiThkyyCj4EWe564qGNLDAFegY3FhGIAjzxcU86I4UPKPJUMv8vkO/Eb6pqV4wfIq+/YIKk1eKDsfj/juHMMq6WblTV/zkgIUYrt6qmSEOyKoKX/hxKkT7+2Dk5XZsScJWb5gsDx1Nc2Y0lZooYJh9iYbva1g5xXpja1+WoijERzEgry+A8ObogiIlgMeC6doKqPjjk7ah1h2pFLsHbSJd+avW7DGhjX5adwG1yzwvny09yndhZM+lHbe2XoiSnLJBrWKLRk/51RFTqx7uhbQQkdOHlx99zQNsB7tnudsh3kQkuio060yxpgat6/HBJIGoGvpnciAwCOw7w35VBQXtkAfOKm3LdBmfbRUNMP6vg4uQriaFQLYW3eVAskPtx11mLwN5n2TJ+tuSFlLg1z1RWUWRvirkY6Vc5B8AyTlXZoPX35tiUg4ofru/woYuHjq0QUDlhahkKfvV7OG8MgF1aUqJtuWskN1tTDnPFQLvhEnM38K+KqSWbzem4GFhQHDYD1/g7/3ofBob+LQDwe3q79qFpFQxLQqI+g39aiCWnqftc6n0HOblgztzEaSS/XJZ+CPX7+YpU9yJKePdSjcyQt+c7oWkfnQQ0O2ONMHnLNrAWvKfVm+ut/RQ8yHkG9CGKgx4sWQQJW+A fMw2xBrC xqAwQ54yc9iIrrSGIEU3tYIM2qtK/aSNTKV3PARsBSxv1BxQDLWPYmN7TGxIMIfwfWkR0/QkORbOrvgQsxkwW5pTQ2JNcuoXYS6uA2pbvtPKCjUgYj7oOEdmbtERHluoLMSOe2X6aEjcYIZU/TixEx6sgLAmbAOAccWaX4g59bqBQnxPzSH+bb6oS/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 12:15:13AM +0000, Huang, Kai wrote: > > Can be called locally or through an IPI function call. > > > > Thanks. As in another reply, if using spinlock is OK, then I think we can say > it will be called either locally or through an IPI function call. Otherwise, we > do via a new separate function tdx_global_init() and no lock is needed in that > function. The caller should call it properly. IPI must use raw_spinlock_t. I'm ok with using raw_spinlock_t if there's actual need for that, but the code as presented didn't -- in comments or otherwise -- make it clear why it was as it was. TDX not specifying time constraints on the various TD/SEAM-CALLs is ofcourse sad, but alas.