From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90131EB64DA for ; Fri, 30 Jun 2023 09:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE3448D0005; Fri, 30 Jun 2023 05:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6C388D0001; Fri, 30 Jun 2023 05:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE56E8D0005; Fri, 30 Jun 2023 05:03:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AC6E58D0001 for ; Fri, 30 Jun 2023 05:03:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5AFFA1C918E for ; Fri, 30 Jun 2023 09:03:25 +0000 (UTC) X-FDA: 80958825570.15.5CFC08E Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf16.hostedemail.com (Postfix) with ESMTP id 5EE43180025 for ; Fri, 30 Jun 2023 09:03:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JXOvXHWL; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688115803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hfHAhGMZ1g/eAO3v+vspufkwWt8k07jEyp1O/WsYS/Y=; b=meqqa5IUnzuNt3N3F+0afHQTvcH1kVki9WrWkmwiEeNlczH33egymyKzuc7x//rpRwqtMW Gmn8GRnFtNtyzkCXTutl00/e6IphUvANYDV6XTq+JSoB3akJ/fQY5YGGQ1zvz4yblq15WT FJmVudBHPuKKtXi6fVwv3x5/JWe5ki0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JXOvXHWL; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688115803; a=rsa-sha256; cv=none; b=Yliag3umWHcQAbjUC4Yw4BAW1GOO8trCTIIlfyL0Ce6S3i7vCgsK3E7jJtcBWtFvSip4sc fj5uhwnqoHorDtX97H2E1qGqBCVCgspqTnb7cwyWMaRXZqSSuBvxy4EDZw9OqRNDyogkhJ AQat3ngwwnBnidJzlfBQ6ccYPxDk9Yc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688115802; x=1719651802; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=G4tgA5Quxms81FQitPgPzP60ScKph30Y7igWUr2N9eg=; b=JXOvXHWLZJeXMTlxy9RPYabsGcZDDYZJdjfS/TYAvy1IIDI2jfJ7w0dw VZ3oDoRlVbr9iIga4IHbO6H7WDNTwTDBKumnA8ko6ivmAXx8zpXVmM56N bO6a5z9ZjHC1ONzE/BEjuMzwh9pCy1Pk6clTv1Bt7WGub1IccFg5dcOm6 wyDZJSpGRLD+7XR0u++C42O4igm2ytzSkGY0I8NGvMDYnF9TZJVz1Xwij 7M87XnRbUB2yeXeaNjFJFE5lnHd++Qlmt0XY+a76u5ajoTTrUuvEnL53E UHPwFuORTOouu71BC1kK296ST1Sfh6nQ6AOci6XonmqMwHlvl0RPk1HlB g==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="342690206" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="342690206" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 02:03:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="694958090" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="694958090" Received: from valeriik-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.49.47]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 02:03:12 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id DC7D3109754; Fri, 30 Jun 2023 12:03:09 +0300 (+03) Date: Fri, 30 Jun 2023 12:03:09 +0300 From: kirill.shutemov@linux.intel.com To: Peter Zijlstra Cc: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, tony.luck@intel.com, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 20/22] x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP Message-ID: <20230630090309.6mnsvfhcptekmzfu@box.shutemov.name> References: <20230628152900.GI2438817@hirez.programming.kicks-ass.net> <20230628203823.GR38236@hirez.programming.kicks-ass.net> <20230628211132.GS38236@hirez.programming.kicks-ass.net> <20230628211641.GT38236@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230628211641.GT38236@hirez.programming.kicks-ass.net> X-Rspamd-Queue-Id: 5EE43180025 X-Rspam-User: X-Stat-Signature: 5zr79h8fixgrwmb9h4gcida9q66ux436 X-Rspamd-Server: rspam01 X-HE-Tag: 1688115802-443306 X-HE-Meta: U2FsdGVkX198TfomXgydmlJwH+qBQzz8jLQcVR3ogLBCVkkF3wXT/ZwTAyWYXOKxQn+RnqnSnD1q6j/6f1/B0Tt2MTbRnEeh919neI04xwRUMoUIBFWOEKOzhTDVCjanUlIgWMCciyQy/+VbbiSMoofvJBY4cRujmTahv/Tn6neTKl09xDbGKUIiSN21vTGC2S78HZczGV3XnCHCnDKzAFBfsd01+/iIZWnV8R/UsUulpq+Kt0M2fpARgRb6bYuJwx1JpJO2wB4mkpg3rafqLLnBh6LdgSerTQGDm93mFD/VxqSqqEEj0LiQuo4zgfaXWUQm/FFdM1rlqSrH0rA/TtxcSBqSju9ZBoykRGzfr1pA195WNwFM8e0O+lDMvLAo9fTGWBHpwaviQVNHy9WMIJwZwB/tDdJxj3G+wQvzjdJcD/ECx2fWcQrKJwRU9CUOa/dlwaZrDiTl4u/Yo+C62H0HuFQt5h0Y01WCWJm0Xz0Lh10W8wNK5zrQ7FwfYYaqUm8UC6YrPAU638nz+yqfpAtT4+/O2gPV2jz2PIBQmY7Kj1teEWMNwnJBzR7M/akDqG9spWEI8cn89PSnOuPWPd40t6s5NEyHrMKU8kjIK7pzvsHiVpb4A37hRhcPZ49ACaboUOWNKDvY9PHpjAcC/vthRqabbgvgF1UYYQdbRGcWQXKpZeDeslits/X6e/bT+RkS5VNTTHxGuvyI4rzo6MKyBqw6yY/ttJ2c4og8Dy+l1s41/IZ1u8r4PTjbo/ULQCWG0QXQBZVU44x0geGnWQ7yvWJL7FaDXLkwItflNV2SXwgRbWpybhg8yPlBEwkZWc19liUILKCm1PXZrrZERemsfIHA5WHO8Gb7oBa9ObOBpzxAxZn6N0Pr2fHVaYCtWuDwAOPT3O+GqnkJdtWrapHUwKZV/Qi70+4jgSoW5ddXpqAjn7FeGdJTdwTmMNUIi2NvzKNF0aU2jtSZljK uYKsS5YP uP67g4dOj7s0bd+GW94KD66KcdD/6fcGqlCw2uBgJuBi7Tx6a8vX8tNVQb28y/x2Pydt8v19+jty59GrDcS19eoQ7YYTCgRZhNjURqDu3tbGbo40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 11:16:41PM +0200, Peter Zijlstra wrote: > On Wed, Jun 28, 2023 at 11:11:32PM +0200, Peter Zijlstra wrote: > > --- a/arch/x86/virt/vmx/tdx/tdxcall.S > > +++ b/arch/x86/virt/vmx/tdx/tdxcall.S > > @@ -17,37 +17,44 @@ > > * TDX module and hypercalls to the VMM. > > * SEAMCALL - used by TDX hosts to make requests to the > > * TDX module. > > + * > > + *------------------------------------------------------------------------- > > + * TDCALL/SEAMCALL ABI: > > + *------------------------------------------------------------------------- > > + * Input Registers: > > + * > > + * RAX - TDCALL Leaf number. > > + * RCX,RDX,R8-R9 - TDCALL Leaf specific input registers. > > + * > > + * Output Registers: > > + * > > + * RAX - TDCALL instruction error code. > > + * RCX,RDX,R8-R11 - TDCALL Leaf specific output registers. > > + * > > + *------------------------------------------------------------------------- > > + * > > + * __tdx_module_call() function ABI: > > + * > > + * @fn (RDI) - TDCALL Leaf ID, moved to RAX > > + * @regs (RSI) - struct tdx_regs pointer > > + * > > + * Return status of TDCALL via RAX. > > */ > > +.macro TDX_MODULE_CALL host:req ret:req > > + FRAME_BEGIN > > > > + mov %rdi, %rax > > + mov $TDX_SEAMCALL_VMFAILINVALID, %rdi > > > > + mov TDX_MODULE_rcx(%rsi), %rcx > > + mov TDX_MODULE_rdx(%rsi), %rdx > > + mov TDX_MODULE_r8(%rsi), %r8 > > + mov TDX_MODULE_r9(%rsi), %r9 > > +// mov TDX_MODULE_r10(%rsi), %r10 > > +// mov TDX_MODULE_r11(%rsi), %r11 > > > > +.if \host > > +1: seamcall > > /* > > * SEAMCALL instruction is essentially a VMExit from VMX root > > * mode to SEAM VMX root mode. VMfailInvalid (CF=1) indicates > ... > > * This value will never be used as actual SEAMCALL error code as > > * it is from the Reserved status code class. > > */ > > + cmovc %rdi, %rax > > 2: > > +.else > > tdcall > > +.endif > > > > +.if \ret > > + movq %rcx, TDX_MODULE_rcx(%rsi) > > + movq %rdx, TDX_MODULE_rdx(%rsi) > > + movq %r8, TDX_MODULE_r8(%rsi) > > + movq %r9, TDX_MODULE_r9(%rsi) > > + movq %r10, TDX_MODULE_r10(%rsi) > > + movq %r11, TDX_MODULE_r11(%rsi) > > +.endif > > + > > + FRAME_END > > + RET > > + > > +.if \host > > +3: > > + mov $TDX_SW_ERROR, %rdi > > + or %rdi, %rax > > + jmp 2b > > > > + _ASM_EXTABLE_FAULT(1b, 3b) > > +.endif > > .endm > > Isn't that much simpler? I'm okay either way. Obviously, arch/x86/coco/tdx/tdcall.S has to be patched to use the new TDX_MODULE_CALL macro. -- Kiryl Shutsemau / Kirill A. Shutemov