From: Viresh Kumar <viresh.kumar@linaro.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Zhipeng Wang <zhipeng.wang_1@nxp.com>,
kernel test robot <lkp@intel.com>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [EXT] Re: [linux-next:master 5324/12162] drivers/cpufreq/cpufreq-dt-platdev.c:18:34: warning: unused variable 'allowlist'
Date: Fri, 30 Jun 2023 11:36:19 +0530 [thread overview]
Message-ID: <20230630060619.zsfw4aynce7wt7cv@vireshk-i7> (raw)
In-Reply-To: <20230628153923.GA254367@dev-arch.thelio-3990X>
On 28-06-23, 08:39, Nathan Chancellor wrote:
> On Wed, Jun 28, 2023 at 01:33:40AM +0000, Zhipeng Wang wrote:
> > Hi,
> >
> > I'm sorry for responding so late. I have also tried to reproduce this issue many times and I have not reproduced it.
>
> I can reproduce this with the configuration that the robot provided,
> even with GCC.
>
> $ curl -LSso .config https://download.01.org/0day-ci/archive/20230625/202306250025.savpMM8L-lkp@intel.com/config
>
> $ make -skj"$(nproc)" ARCH=i386 CROSS_COMPILE=x86_64-linux- W=1 olddefconfig drivers/cpufreq/cpufreq-dt-platdev.o
> drivers/cpufreq/cpufreq-dt-platdev.c:105:34: warning: 'blocklist' defined but not used [-Wunused-const-variable=]
> 102 | static const struct of_device_id blocklist[] __initconst = {
> | ^~~~~~~~~
> drivers/cpufreq/cpufreq-dt-platdev.c:18:34: warning: 'allowlist' defined but not used [-Wunused-const-variable=]
> 17 | static const struct of_device_id allowlist[] __initconst = {
> | ^~~~~~~~~
>
> The W=1 is the key here, this warning is not enabled in a normal build. This
> configuration does not have CONFIG_OF=y, so of_match_node() is just defined as
> NULL, meaning these variables are indeed unused.
Ahh. Sent a patch to fix it now. Thanks.
> However, I am kind of confused as to how the robot landed on 3b062a08698 as the
> problematic commit, as I can reproduce these warnings without it.
Right.
--
viresh
prev parent reply other threads:[~2023-06-30 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 16:28 kernel test robot
2023-06-26 6:53 ` Viresh Kumar
2023-06-28 1:33 ` [EXT] " Zhipeng Wang
2023-06-28 15:39 ` Nathan Chancellor
2023-06-30 6:06 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630060619.zsfw4aynce7wt7cv@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=zhipeng.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox