From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C14EB64DA for ; Fri, 30 Jun 2023 21:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE5528E0055; Fri, 30 Jun 2023 17:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E953F8E000F; Fri, 30 Jun 2023 17:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0FA58E0055; Fri, 30 Jun 2023 17:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C07808E000F for ; Fri, 30 Jun 2023 17:57:37 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9AA071C80FE for ; Fri, 30 Jun 2023 21:57:37 +0000 (UTC) X-FDA: 80960776554.20.9B209BD Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2063.outbound.protection.outlook.com [40.107.93.63]) by imf15.hostedemail.com (Postfix) with ESMTP id 86BADA000B for ; Fri, 30 Jun 2023 21:57:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=aorNiie7; spf=pass (imf15.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.63 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688162254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+iP/yKKjl5mdIjpVbAtOLYWO3fTzTwcqvi2QUrxpywA=; b=ylNDpwSqGL6Ml737KD/wAq4blvFVYJMRKjbje/odUpzYVpghhaG37BT2gPbkAmgR+T26w8 XG0LdjxFSYBWmGBljMSgzMMOuK0KqkJu7G0BeNdTutW0csqgCShh2mx5fYBiYIEizQoCm+ lBfLLSD5f03ORrxaG1NoP1jLA9KWAkM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1688162254; a=rsa-sha256; cv=pass; b=YS5rN0kutXTkqvPe97cnFd1WNzOp7ECyOzbmA/USvwOOW0KRDobhK1ovQkoTL9LTgB4pnc QuvkICUv1m8YTZ5jdBN7/9jh/ag37Zj0uO0ELvgjR9djNBoaizqwqdhlxfm+b8hw41WDTe 3lXnPLm/QsVnKoZFF0nihHi4QVknv5s= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=aorNiie7; spf=pass (imf15.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.63 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfYjU94Cnp06BXBw5UiRvIRCry8BPZEoYJOfUqeLOmPcov+IzIIzh6FfdcywTlQojkBFfPrNTPKhz6MhmdMHOAE5IdOQussuo5qf1xPyo1zr2R63Sr0QDq+65564dYVyu6rMWwTQmIKgFwo2mHq6dvU1x8SkbhIao/BsZFYHamzpC0M2jBwTYc9YZdalYsrfSs/MnnWxbp3gX1+Fxsso4GdkMImp7rhYwDp0YLa0q+D069m9HbRltQkQAmca7OpbKE7FVdQeuwcBtPiPR9piOQ+mzk0KvYb+9/lVw9Bg2Q1absC2sgz26R9Ojs8qINdQbwjEmSChDzIz9lGoxkCldg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+iP/yKKjl5mdIjpVbAtOLYWO3fTzTwcqvi2QUrxpywA=; b=NL5WNRrNrPN/ZgOw2kvgxt2ScqjJE9T70CIt44UpTkUISi+AJNM3Pw2rY8Xb3/Pyu6DuVeu6nRX0hzjv7/Z0I3NasLMPL8afi+hdQgwsygv05CHdkD0GDgKJJOU8Uwjw332jP7QmJKkBAeKzlm1ZNwRO2YJ6ifzk+10K7/i3HHrHQ+N6b44J0Y8ukLc7UtLawazzm0MpU6HLSuVTXC0S6dfXpgRdnhjQm3cm0SwVNq7aMzR3v7gWfscumoW5x89utGdtVoGfIHuSKSuqXCDWdWclNg2O/GG1XGHoT3y2XQDGman01wkm1/u3bVh/MIOTtzZCI5DuFQ3xxByPVh/suQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+iP/yKKjl5mdIjpVbAtOLYWO3fTzTwcqvi2QUrxpywA=; b=aorNiie7NFRWzpxynbEUyhNvR8XyDo9C/1bNYcN8A02dXHJcoSJ29Dnnditld1YyKDTRCVQxB8p8xfO/iX8+oDv8uqTWZQXWn4v4YQldY1/uZtkzNVUyPBRX8WFB11Qsesli7xIzw/Ja0Rs06mpEivYK/y/bz0w+DjdixyT5jQU= Received: from SJ0PR13CA0084.namprd13.prod.outlook.com (2603:10b6:a03:2c4::29) by BL1PR12MB5062.namprd12.prod.outlook.com (2603:10b6:208:313::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 21:57:31 +0000 Received: from DM6NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:2c4:cafe::7b) by SJ0PR13CA0084.outlook.office365.com (2603:10b6:a03:2c4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.10 via Frontend Transport; Fri, 30 Jun 2023 21:57:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT078.mail.protection.outlook.com (10.13.173.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6521.43 via Frontend Transport; Fri, 30 Jun 2023 21:57:29 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 30 Jun 2023 16:57:29 -0500 Date: Thu, 29 Jun 2023 16:02:04 -0500 From: Michael Roth To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , "Kirill A . Shutemov" Subject: Re: [PATCH RFC v9 05/51] x86/coco: move CONFIG_HAS_CC_PLATFORM check down into coco/Makefile Message-ID: <20230629210204.tknoh7p3hw45jcp4@amd.com> References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-6-michael.roth@amd.com> <20230620120920.GAZJGW8B6XHrsoLGCJ@fat_crate.local> <20230620204315.xr7wtcrowc7oprka@amd.com> <20230621085400.GDZJK6qMeOU2monJDv@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230621085400.GDZJK6qMeOU2monJDv@fat_crate.local> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT078:EE_|BL1PR12MB5062:EE_ X-MS-Office365-Filtering-Correlation-Id: f0427086-2cf8-440e-9a14-08db79b4fff1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2sMGfiNIQZezfcZ+PMzMdNlgxoADlvJl2Lni3o1m/an0dVjtH/TvzKf9pgnnM8aK6EchpUcimIfT2GE4BKWCWXtWXwFyo2sffHuQE3pb+0HkGQZTo3mzfAvqbymOFNjolh/RVms2Dpqy2IDA48n4Ex6zXSE/7SaC9s/Nkm2k4eWrl7Ix5Wg9MDX2oAZzTu0TrUqA4KtdOqXIMF3qC4akTccxbif13LtRYO5hFgBCv00wqukWGUa236DlYiMFPF11/uncY1906z+1xSsbyj1PzjlIm1PRqeBzUIQ1FPUwsx6TP1UTBPV3TGlbfmr0WCTImzbAC67/Pe1FUqNyP//zlHOev+Y8RPuGJn7fDwJ5vuQZJXXX8EfiyeMlZmPIK86zodgAcVm0lWAIGAN76Q3CB9F4yhRvDPKgdCaT5FyyW93XPuRKevfGgNw4iP3eT6NyVa38aczMQd1gHKKCMDudRz6ZEU69vjQqoJY/sf+bHWfI7sXUxyq2BUBvOQuslkSMbaJRApASVvuDgF1QHx2UukzzYoRj4ZKKZfnS1VkiZl7YPO+o++dx74NCx6zqFPWOWLG2OETx7fWRgSKOI/+MiVJTb8fDf0xviQVU1IGOafN2/TiVStiB31XL3kNTCC6C/ikEqbwkpubXChwN/VPK3g8gPoxISeKUtYlOos6DDITkZaE4c3z+sMtjTX/TzA4PEb/o1ZmUR5Yjo2G54u4eHcsVSWRm7HNRWkdCZK3P//9LuCr9/ir5EK3WJvgS1wy7Sb0jUPW+VCQtmd2gzqQqdTI4/oi/oFoOADdLiMDDpqs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199021)(40470700004)(46966006)(36840700001)(336012)(426003)(47076005)(40460700003)(2616005)(2906002)(81166007)(356005)(82740400003)(36860700001)(40480700001)(36756003)(8936002)(8676002)(82310400005)(5660300002)(86362001)(54906003)(966005)(41300700001)(6916009)(4326008)(70206006)(70586007)(6666004)(316002)(478600001)(16526019)(186003)(44832011)(1076003)(7406005)(7416002)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 21:57:29.7373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0427086-2cf8-440e-9a14-08db79b4fff1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5062 X-Rspamd-Queue-Id: 86BADA000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jr84ccyhz5576szsb6m9gc1rqh9smuq8 X-HE-Tag: 1688162254-221721 X-HE-Meta: U2FsdGVkX19LnlH3womQJ5M6w/Wtry4XsaZbsctXTaBNKkYbO8I3VfbqD2OwwNZsDCrNFRsKwnO9UNdetIObFq+K7KkmQp0bvHZboC5VSGqD3YOFBQqcdQ81eB4FtocSw8gRmqfCWpbOnLd0cPJ4BC1N25XxQP+6HakT1ixS6m6I3Z9nQxFjmwOwZ7drl3rnBUXQVaUKJfdsfuAQDE5u2AOTtl9iAGP68kxBai4P7guXrX5b1jOTsO09WbQxlKp5e9+yGO41mqFRHNVMFOz7+MyKPuM8abAJsIIz2Hv691WzjB+2e3Fwfwpw4Sb2R0lfIWUUsdVnUUp9EUQXqDx2L15ntiHyftLzY/9a6CcyX9w5Ra3wYsLyMdtK9Z6lldDBohKKA07Q04r1Mm2U7BKoCsaimOpkqWLwyzZ1mEMHRBJUGtJ/JuJT+twNAQEt03JYckszhY0a/bT+8aOqGXyDmTf/ROITC89buttXZHOND6HKdJUpBU6SQGxp3856RkN4HePZXnZWu3/WB8cuxq+ID9q+RiwAwrx4UhMFTRKGrBLgHIXKdvQgYb9KkNbtYZH0UQDXtXf6Jx0Z3+EeejUOKOgUFhPfW+7masLMR3Gt6dFQ8af0UKgRmvZP6mjJyJL3gpDRCIRj63PbKyU5YEramMLtm6I+nDTULG7oavrqMsj8VDir6gpTySUawWTEKnA411dpDW47lzXDppvdthfyvIuBTpOBjSL0v+5NlszZZ08/dhz6Um5qN8VKO4tsCYfo4LWkoxAoRFyCN3lMmoL8uv3vQ6w9tunk6lIojYIPdtt0CRdSacKbW4IXVFcbhNSp4W8fqN/+xf3pL194uEp5svcEosmZoSOTf4rufr6KzRLgTAVZNEGeoXd3h9VoXrF7D4piMOh34+WdEIAOalfrH2GG7KVUbGVqRjb0tBvvRFYT4dc2eBfpa/uecFAQsB5cY8XopG6AH3+8lCO3XnT bsNp9rPy Sm+zOV2ky9XqCNEJTYxVcYeRulAQ0tqpoBlwCVfmWXStP3afldnS0AS/qzgKgdfe7jBOMI+D+/58jPvPq+0wG8PN7h4SCIqqSR2CN+AJ6GxR2N2OoiIPCs/oFCdVniRPBuV5MGGODwfFR6Fzrbw6Z6Oc314M941viUBKdDFd0d5Axzk9gNDmllAkU49hJU+yaO6QQX4Xp7/2zTfwAqRN03K44a4DZv78ZfKGcZFrGgVGruaSv/IJUQVXyqR8VLkdyCIknSMgeGCfZfRKXHiKwA26p7kMo05sCAV8jrl4DezP8ThS57SXqVSSGoKMsaOBzzOgpKqYJcg55aCP2wU+XpfaRrysI0uYcTlgRHyTWVQ58+lxEVyvkU7U0Nh2WlLEvgO9C6hk3KSa/Nl920nuw+HAHteItj2gUH13RvShzDcXyAeOi4nRnINQr6apIzXfY9w7A2ZzgQXu6FEQsDF3iJt2lyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 21, 2023 at 10:54:00AM +0200, Borislav Petkov wrote: > On Tue, Jun 20, 2023 at 03:43:15PM -0500, Michael Roth wrote: > > Basically, arch/x86/coco/Makefile is never processed if arch/x86/Kbuild > > indicates that CONFIG_HAS_CC_PLATFORM is not set. So if we want to have > > stuff in arch/x86/coco/Makefile that build for !CONFIG_HAS_CC_PLATFORM, > > like SNP host support, which does not rely on CONFIG_HAS_CC_PLATFORM > > being set, that check needs to be moved down into arch/x86/coco/Makefile. > > Ok, so if you put SNP host support into arch/x86/virt/svm/sev.c, that > should work too and won't have any relation to CONFIG_HAS_CC_PLATFORM, > right? Right, that works out just as well, and ends up being a bit more straightforward. I have it implemented here: https://github.com/mdroth/linux/commits/snp-host-latest-v9b https://github.com/mdroth/linux/commit/a889a2dd64b62d9c3bf74cf02e7d8d71c7061667 and dropped the patch that reworks arch/x86/coco/Makefile. Thanks, Mike > > The CC_PLATFORM thing is a way to check for confidential computing guest > features by abstracting the capabilities so that you don't have to check > *each* and *every* conf guest type in the conditionals and thus go nuts. > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette