From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FA3C001B1 for ; Thu, 29 Jun 2023 10:15:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 118ED8D0002; Thu, 29 Jun 2023 06:15:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C90B8D0001; Thu, 29 Jun 2023 06:15:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED35F8D0002; Thu, 29 Jun 2023 06:15:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DD55B8D0001 for ; Thu, 29 Jun 2023 06:15:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B3DB140DF4 for ; Thu, 29 Jun 2023 10:15:34 +0000 (UTC) X-FDA: 80955378588.15.B2A2B5C Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf10.hostedemail.com (Postfix) with ESMTP id AEE25C0017 for ; Thu, 29 Jun 2023 10:15:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dcWZ5NDM; spf=none (imf10.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688033732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nDGbHYON3QMZZHI/rVaGi3YknFJKhjrwpLA6wDBndcI=; b=kcsGAm9cAp4xFP29HDf52iOQCX0zGUzrORf8EuK1Q+sm802tOwKFBKKOFRClBw3PkJn/jg iLm6nj4PadOdFteQbQ173jISU7OKgEOqErHsIosvruzjT3tQnEwW7PdZWuoGBrZnGJqBhA u4lWN8RSnQwV84u+l+pitfI0Y7TPlx8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688033732; a=rsa-sha256; cv=none; b=G594pAclyteZHFQbPbptESeCIN90lGtZXptwHry+w2eyOwCQoY7WGzQotsyIkWCqNlSk9v gz4PP8lmoafWx6UUEN/cHxR400Wq3d5j4k+QMj5S3MpH/fNPHREmFZMrRZdI+rHr19spYd MoB4YEjmmbJChu+3MTU4GZTltRbDAJE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dcWZ5NDM; spf=none (imf10.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688033731; x=1719569731; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=X08EZN+DaChxrUMPDyxcVgkqN2it75n3TMT5gy+uEis=; b=dcWZ5NDM7Rua9v1XLrCHp6NWFT4ZGXvDaj58f/KSeI3uHLry1hLCKFHc 1SeCm8+WiWypOEDqzikZq+Jk6y97Hf2kSiEnkSWEN0GfpQBosCRRT7eip TqgfrJWExQZVsMdw5jRmICIF73ARz+ca4ALdwshcxMIgmjVo6yqBBWExh MpKW0sUCQrRVFWI12XUfTsBUhNqtXYzFg6K7iPnsMhZN9EJb6kxJCqAcq czhWz4Hcp3rXwCbfrldZu3nr/yBI+gTJy9q5twh5/PRYRgdzvfDDvPcly ukV7ONdhcZcKgxVHiy2FFPYHsrVnVhfiaCb7rtac/EqZAbdb2NgLKqKLf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="448452076" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="448452076" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 03:15:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="694569273" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="694569273" Received: from aahouzi-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.47.115]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 03:15:22 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 29F1F1095C8; Thu, 29 Jun 2023 13:15:19 +0300 (+03) Date: Thu, 29 Jun 2023 13:15:19 +0300 From: kirill.shutemov@linux.intel.com To: Peter Zijlstra Cc: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, tony.luck@intel.com, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230629101519.xhuia6d4gtiosesh@box.shutemov.name> References: <20230628125813.GA2438817@hirez.programming.kicks-ass.net> <20230628135436.GC2439977@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230628135436.GC2439977@hirez.programming.kicks-ass.net> X-Rspamd-Queue-Id: AEE25C0017 X-Rspam-User: X-Stat-Signature: pthf19janu73q8i4jseubcbk3b15jukw X-Rspamd-Server: rspam03 X-HE-Tag: 1688033731-889182 X-HE-Meta: U2FsdGVkX19rPb86BRZZFY+pmVktJ+Fwp+91i9Eq31XqQ19r4t4aiC31lrWKJ1ZpykRylclW0FS2NbmM074zzwZhNryds0DsMCxbFAJNGyHyjtATedJjlsGYNG0TCD6S5UOQvvtICXXx6VUQp5OBbzGSjTr7Wg0pwD9g5nw+YE1APbzF5SlFpGygbksF8YRZy36cgYNv8GcVMFJ3YewQPmBCjC65V0lznGvDYPswCNbV69a3aTlI3DIOeYVlW3/chLoWqxe8T7km3RNyhfYkgivz5u7x6U2hda49N5kNKOaA4+wbBRYUF/b0K5hPv7DY+swJL5w+4/EtWBtHv+M4AYju/KbcsgHgyvi0UvuPt+pvHqJFBnflZtOldN8aa+6+HWsNKyGsuYdUFzFf8suSkDlkdv/uTmK1AWA/iPCdpvV9YOXOcc2glINU7MvjhyCKJ5E03knLX5Tjt0yXcDHCsX3yu9oVKYVMakOwe4wMtbx1lkuakEZBm+9ISRGKlwRCmza73RpafgH5vun4bsbenP5LIVqfgEVuTcGO3Wadq0fZaG32nZWmBc+CTTAyaIsc+AB7BHJKRWDATLlgOT1+zEzILAMWsVmV7Ji4AY/BJMRKKQ5WfCcNWU451XPzEbQ39BLaefikGKR9bwuCxlHk8O8Y+cAvHOLtyZg6mEgaFTxwDUOnc8J9v1w4dKISapiaysWNCzJTS3oU2seHMjGJoZuJRo418LKjyEUrz7SmwsP+aPmC4RclbnokCgmBh73YaIJV+C1SXC3ZianiFVpQCQNFNPO+hOXu8a06VnRaJe9WJ9azPOwHawDjkAqjtwwQkLizAYCS6zORGUliIwuOkJ0t88zfuG3Gb9mIZRPLloaaDSUkVdkYkTJPzbDsrF+bzxDOodL1fe/UtUFW1J3UC9Pwzblesv1D/T1gzF1FHJatd0atGDUtDRLbgYE+UeHbTivRdfNxczSSWM0uqtT JNlbTeak 2WzYlThCSg0t9moqwDJsVksOjEgPYx9d1MZQCJsIq8mfR6+wiZxKrAY5vEJ/H6GcM/rdkJvUbhwbWbOgH8zfq+0ZK4ZbU1X0VWqMXh8vgbt7g7jQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000642, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 03:54:36PM +0200, Peter Zijlstra wrote: > On Wed, Jun 28, 2023 at 02:58:13PM +0200, Peter Zijlstra wrote: > > > Can someone explain to me why __tdx_hypercall() is sane (per the above) > > but then we grew __tdx_module_call() as an absolute abomination and are > > apparently using that for seam too? > > That is, why do we have two different TDCALL wrappers? Makes no sense. __tdx_module_call() is the wrapper for TDCALL. __tdx_hypercall() is the wrapper for TDG.VP.VMCALL leaf function of TDCALL. The function is used often and it uses wider range or registers comparing to the rest of the TDCALL functions. -- Kiryl Shutsemau / Kirill A. Shutemov