From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C978EB64D7 for ; Wed, 28 Jun 2023 14:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB3078D0003; Wed, 28 Jun 2023 10:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B63728D0001; Wed, 28 Jun 2023 10:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A53E78D0003; Wed, 28 Jun 2023 10:18:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 95EBB8D0001 for ; Wed, 28 Jun 2023 10:18:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4D9F71C8809 for ; Wed, 28 Jun 2023 14:18:06 +0000 (UTC) X-FDA: 80952360972.17.7B1EA81 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 1A009140021 for ; Wed, 28 Jun 2023 14:18:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X+y2nRAA; dmarc=none; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687961884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WHS7onuXT/a8g00MBKmGlEUlFARjR8xadQuu4dkQLVQ=; b=uDN4uiKDxk222doEy0FeCJmy0cnz7XZ7g5OzIO5bTP6p90OdjF/7XzFO8O/+mSw2Mve2WC EeZ4l1uf85MYN91G5PpWt5zWV28gFRrdxfrsDp3CMKS1kr5AVdPdzJQ9k9OD3DEvPbx2yg bO2H0YlEexkA4d/jXP1hGy463KWQOUs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X+y2nRAA; dmarc=none; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687961884; a=rsa-sha256; cv=none; b=LVsXY9LlAjbGGmX2n1jFRdmzqqwzUxJIoqYi5M31kZclx77/PC7EpIqEjO6rSTspaEJhoe QWptnVo+UCArKT8nBPlaa7GBMKCtnKtZyUbQN2ltAYsM1m2MIXoJQ0xyS5M9rQL+wqHI/o aGNMorD+wzJobPopVaB0StAbc2ee0UI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WHS7onuXT/a8g00MBKmGlEUlFARjR8xadQuu4dkQLVQ=; b=X+y2nRAABO9CYH/S/cO67Aav2A Z9L+Ubju0tpzunzzVqTASlwVFl2aTpcezURvoi6K1zqxzXlORCVbKPcOFBEhv9L4ZYLJro7xkYivF 6d34SozdoP5rfGxg8mE+JUHIxdTX5sqn7kph4kKa5HxocTJhzGBlmPk9eSiCQOYYBDDUC4+w1V9dR IVPfMa4YNObNIqCMYmkY02S2cxQZD5bLT4clORhk0hXbtyUCwNWiCWcbIg5nYhOAlmiwaCr5jRHmT d+w5aRRSGxubahjTpvm6XSZM1ycZjIS4QHYBMQ749hKyUD3MdYa/3ntH5ZAyQjRhaaPFrYAwXAgHi s/XXZv7w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qEVzU-003qti-RT; Wed, 28 Jun 2023 14:17:52 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id F1923300095; Wed, 28 Jun 2023 16:17:51 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D8FF52458D611; Wed, 28 Jun 2023 16:17:51 +0200 (CEST) Date: Wed, 28 Jun 2023 16:17:51 +0200 From: Peter Zijlstra To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, tony.luck@intel.com, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 09/22] x86/virt/tdx: Use all system memory when initializing TDX module as TDX memory Message-ID: <20230628141751.GH2438817@hirez.programming.kicks-ass.net> References: <999b47f30fbe2535c37a5e8d602c6c27ac6212dd.1687784645.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <999b47f30fbe2535c37a5e8d602c6c27ac6212dd.1687784645.git.kai.huang@intel.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1A009140021 X-Stat-Signature: zduekpbse7mrtp3ide7qtj13uqri8y5i X-HE-Tag: 1687961883-467593 X-HE-Meta: U2FsdGVkX19SbRvSTd0j1Gmy6LwyLQL4B9yJFTpyfo2ATunCASzWxYOwALmJHKe7c6xRIc3ZQxdU2PeD6rWOJsHcxYgFWW7SDScLaMgLqduOOGG2HvdoPn7mRYK6oW4kb+GPYkaS6YkJU6VZONBz3qfBHtioips5Phanm6XZI4rBtQ9wMT4XIwNTvEbnbHjLUC87nWNO3PazScDV8TrtTeLnj45hEPHs4WJjhz5op+F/I+ybGdlNKLXW5mCUQQs2lTf7gRz49hfGu5y1p2x1GMzBCqRsT1kZriaLP+EAdMTBV/6yDjpyUGyopHJ6u69ITmQNTr4l6gzg/I+BSsXRnRsjpZcok6FhhNiNAK2gO5yhYBFxBGhYsIcNQURIzlu5RTohfnIoxkLAoIp9KuFP98giuQJruqwt3eF0IviyXKABbKiGRwIT1jP7XT4bYHPYjfeImLqcYpymGn9jz+6baS11GIgFrWLwxUGzw+8LvJB0j5/lmZJ27y0Q6aiHhNN2xsicXJBetK7CTEnj+x6pxsBstYCzfKmb898ixNQzm667ccq17CmL0svFHu5EvKUk/qxs8eWi/6yTb0gMDBATpsgRByBli1yhN293OCLvt/tkKDcqG9ExIud2EAmro1G32SG94s2+5ucBIF3w/bOST3ErwhO0K1c6J0rIER3cwz48duL8iRw3R24KfGI/oEJsFq6Js5du3/iq7zpqJaaqWHhDADfmp7ovfJdDxyHcNPb/lcrV9mCf7F1U9trhfyq4ldWWfDv3tIpuigbTZJb2rsb6TBBtPtWxAa+wYuor53qD5gwphIceNMKUQqthrQyXksayX/O7N1kT/dUmy9OnN3OV31NfOKZS0oAWeOv7S4wMXK41rxqXqd55DeSwj6e1D7vjVxessS0EWbX/XGVf621Pf9iUDJhKlrcOHXFdhb5xRXxkjmIZe3wpxDU/x/QYBxZuCEj/ncad/hsWOY/ n5HJSyJl V7RURNZimySJBE03L4FX3Cb1XdJmt1LsymEzGnxO6O1oayCiKcY6KHaAUrc+Y6X4YPXtRtaLB39lZup0SaF1+WKxwl65O5JU+Z0iZtNH2K0Ieouhuo+Vo5A4OKQIt8qjbQCrGfUSNDVrS0Vw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 02:12:39AM +1200, Kai Huang wrote: > +static int tdx_memory_notifier(struct notifier_block *nb, unsigned long action, > + void *v) > +{ > + struct memory_notify *mn = v; > + > + if (action != MEM_GOING_ONLINE) > + return NOTIFY_OK; So offlining TDX memory is ok? > + > + /* > + * Empty list means TDX isn't enabled. Allow any memory > + * to go online. > + */ > + if (list_empty(&tdx_memlist)) > + return NOTIFY_OK; > + > + /* > + * The TDX memory configuration is static and can not be > + * changed. Reject onlining any memory which is outside of > + * the static configuration whether it supports TDX or not. > + */ > + return is_tdx_memory(mn->start_pfn, mn->start_pfn + mn->nr_pages) ? > + NOTIFY_OK : NOTIFY_BAD; if (is_tdx_memory(...)) return NOTIFY_OK; return NOTIFY_BAD; > +}