From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E569EB64DA for ; Wed, 28 Jun 2023 13:54:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 924E28D0002; Wed, 28 Jun 2023 09:54:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D4D68D0001; Wed, 28 Jun 2023 09:54:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79C1E8D0002; Wed, 28 Jun 2023 09:54:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 664AE8D0001 for ; Wed, 28 Jun 2023 09:54:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3247B160AE3 for ; Wed, 28 Jun 2023 13:54:51 +0000 (UTC) X-FDA: 80952302382.03.9449678 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 2004E1C0009 for ; Wed, 28 Jun 2023 13:54:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=W7LN9a17; dmarc=none; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687960489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5EcaSelTELk66D9yc9EYTzF87nomzYvNvPRV8mwi9rc=; b=ad4jA8wNN/mTEVCoJmUaa8nZDyRatQCgrqoZW8vWF4TRO77ANRjZZOX7i3HAhItU8TnXLv mnbTlYw9hg7HsFueFn1Ugegy5k8/rEDb9jFolRzPJSbRPwtG1O7wMuWW/6jJSQ9Z6y9yf6 yJ3/tIqYiQdX8OnacRfbQkKRv22olno= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=W7LN9a17; dmarc=none; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687960489; a=rsa-sha256; cv=none; b=IRPfMT/+Y8/gcCLadIaXXE+N8WUxqzbTq3W5ZHIEEIoegGnbYeJw1MGlnQadVb7u4qPTn4 HqXqfwn50/urow2H4/pAy0iKkjYU+j94NshDbgUD3YkCaJys2zM4Y89dwkSuhLCrvkkEJd leHiMjbw6Pq3A+B3qacwzs2NnOTY9as= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5EcaSelTELk66D9yc9EYTzF87nomzYvNvPRV8mwi9rc=; b=W7LN9a17V1DnA+F/c3rpfgeTL+ s9C6KEt2zXeQToktpw0ehyIxpP8abSG8JjAcd9hEC4JaLD6uOF28ErTho1dbkT4FRasYilW+/pm9O GaSsh2got/8M5YCpEVHSaY8H+lWAe3N63tWBp/2z5fY+mKdxDssIuFK9qmNpu5ecE8L8odGjryrT2 WFMy4Jdp3EFl1ebmWQlv+E01ibKRG2NMOpr2uJVr3ZFgoClliTEpNwjhVxW7ODFQiIbaDbxY22PqA J7KGeNLv4kkiMfDRCqctgMKvjGcSccUdAk74NE+Z8nefaHQ2rvGphUe/z+LAwqyo4NVN1faZP7an5 N4GwLRXQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qEVcz-003psp-FM; Wed, 28 Jun 2023 13:54:37 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5214B30005E; Wed, 28 Jun 2023 15:54:36 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 316902424518F; Wed, 28 Jun 2023 15:54:36 +0200 (CEST) Date: Wed, 28 Jun 2023 15:54:36 +0200 From: Peter Zijlstra To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, tony.luck@intel.com, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230628135436.GC2439977@hirez.programming.kicks-ass.net> References: <20230628125813.GA2438817@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230628125813.GA2438817@hirez.programming.kicks-ass.net> X-Rspamd-Queue-Id: 2004E1C0009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dond1yx5z5jkt8u6dt3md43634er6dcx X-HE-Tag: 1687960488-332670 X-HE-Meta: U2FsdGVkX19w+yqpmzOfaK3A6fvhyhmBLs0Ky1g08uDQHxSpTB/cZSmRkMcRmoK55pAYTGqrsYaHvJo9OlHEv0JEg1nwLwIAQX2ER3PtyBk/eAYrBLgpufPXdSas+7/rfWnR/XFfqvRsuzLfk+gLP49VOSN06g8Tzn7EOsY3Px2OX5QFiRigLBe3gII5wkeJK3zE+sStu/GpPUTIPwpEHfH7QA4pgd6GYkt6wWVnNrJs/3cNbCRZLfkkV6FRrZ/ih+nUfh3rmMdSwQ2AsTyJLM2qiL3UOR816Hugxs4OHY6KsY+6pyhYfcGMOOBLCgMagMg+YRn7jXp5l1Ylhrt6kUV4iXIZms4NtpAnUUf9SOBo1yf23AB5nkSOOGEj4/8YcLxeT4GyJXUjgnjnp4GOyXlomOIZVlM64vF4Jhbi4+90ytEqA1KOiB0a+tuZd8P15Ozin42KVvh9Ejpbf16ebQA/QIzbYv5Me5ZDheeAiz4xTXb/4oPVL7t7McnvwCA+MeBK+zi9f5uKGjOW15ZzG3jwswjaMdtk/eCk0Utm8u+5MMicCw3tOZ+5GYcQW9zqFYBnfUDb0CUQsaDusi2WhmQ7YSSMmTbIGZTblU7u2+gs9ajxnk6v9LFFj7FaEd06l/kvX+JnxvNSVPxeDALPps3OfeYcl8+4KNS8ZwhWzPFAxX9uSH3jyJEPyhxxgzoAN0MyzqvH4tOOjxwra+sZyXghVa1K1qzmgZwZz4g72ZXIfGGqj4k+ghH8gxs4Ls7QJrRnjdcTaQw4F949rL5xC2NvfO6xOfzQQqWug0PJ/pfTWJwuUIwWc2KYMt43km6fmzvXLCyv0PeSQuDUkcEya3yuHLmdbu8CKfenxUPzRlPlcf/CKoz8pPizZGj48eXKUBoW9yMsmdtVOWVEjQGX0zt1/ZHyi8lcmnEXxcBC9y4+yx++e0TzOZ3yiBc/8LpE6A9IKN8s9Mvg8oCtKqk 2P3uNmEZ zxpFP3ipuWVK3sO/v5VtCTRLN14dxWnxhWvejttZCbdgmvsE74+5pqquTIZH8K2eOiYzUpzJUP+PwU5Y1eXWa4aPBgomPk6aLi8DAtgXkWb+nVfu5J57PTt+fJYRvPLiaWLgIsluK23lsIm4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006676, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 02:58:13PM +0200, Peter Zijlstra wrote: > Can someone explain to me why __tdx_hypercall() is sane (per the above) > but then we grew __tdx_module_call() as an absolute abomination and are > apparently using that for seam too? That is, why do we have two different TDCALL wrappers? Makes no sense.