From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72798EB64DA for ; Wed, 28 Jun 2023 11:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A649B8D0002; Wed, 28 Jun 2023 07:50:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A156D8D0001; Wed, 28 Jun 2023 07:50:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC5E8D0002; Wed, 28 Jun 2023 07:50:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7AF888D0001 for ; Wed, 28 Jun 2023 07:50:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4FA8E80DA5 for ; Wed, 28 Jun 2023 11:50:39 +0000 (UTC) X-FDA: 80951989398.04.6DC4288 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf30.hostedemail.com (Postfix) with ESMTP id 42FD380011 for ; Wed, 28 Jun 2023 11:50:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Kr5Xg+HX; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf30.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687953036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3QWhwcggje0Zh8q3JLmV76lObnHkgDJPsqjopfYmIGU=; b=L4G6Y9h2gVmCnftEsf9fy0LgOOSWoo1JMG0E0CIac+zrrxB7if5JXIzlNGjAMziy9SziCi 06QeR3IJvZjRDhplK/u2HatHH+1QfilD6DZlFfZTONo0XbhxiS3d2MDOZRqWrEeWxBgwVW Phv/8tKnT5afn4Wm0reiEm+Ztv6wxqs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Kr5Xg+HX; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf30.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687953036; a=rsa-sha256; cv=none; b=gJPvF953E5ggEtUERAaM4kevVC5yXfclQZRcc2iJDZsdkV7itR6inkE4b9u4jODXPT5e44 eCxd3xeRBVWI1re7iu0aYTp5to3z1jiP7oGQYeLNfiYEl8uvyjU2EFzMWccpR6FAydmuVD Vjwng0RIaqzCuT9JAAasWZTlOgoU+A4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687953036; x=1719489036; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0y2L7BWu5pxHd+qe15FseOMCJGFMdnLrhdBLfYvItgU=; b=Kr5Xg+HXJoUosNccuSjM9C6iFBIkqucyTYTdsQxB6/ptBWxysa/1uNTu YwykwwXxf60fO5bIEwUnQ/LPa9AsV4gm9XV7z7Mu39O7YxB1gfEz662C0 246f98YfLtg58iWKACua09xK1ikgM7+SWXND/qsFJ8t8PqOztr0b/9cuL v7by4FaNzpKSr7b2IUe65x2QYXLLz8DbS9qfwGFMOcqgb5NcxdE4/58sq NAklC8a22g4gwi0ibPr/bCCL7hooR8A0y9STAmRJ2rlZ+K5S2s+bfKVl8 aneAvEuhSM7kQQNGYd+ocW5EOXW2uxV3btEVGxfalofLfFVgpd8/GHDQx g==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="427828656" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="427828656" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 04:50:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="782254879" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="782254879" Received: from rajritu-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.47.187]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 04:50:25 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 7D4761095C8; Wed, 28 Jun 2023 14:50:22 +0300 (+03) Date: Wed, 28 Jun 2023 14:50:22 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "Gao, Chao" , "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "Chatre, Reinette" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230628115022.2plia6tonmxxaj5x@box.shutemov.name> References: <7c4b54cbbb887a3b7e468819a2cf11f7434674cc.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c4b54cbbb887a3b7e468819a2cf11f7434674cc.camel@intel.com> X-Rspamd-Queue-Id: 42FD380011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9yuf3udzb4wtcar7m1wbp1wpdcg48hjd X-HE-Tag: 1687953035-312272 X-HE-Meta: U2FsdGVkX196e0EOfSWOUzLQ823KFSLiG3E8tytsStII1dRnwjBL+4UQYXscn8fYLRcaVCMoXIANzhyviM0NYAuKaNVO+rlyJ4Ndfcu8aKtGvI0TleOZjZqIVZRj0GepCAWJywy+a8GDSS/e1MJhnOFANHFKD/p2jmCtbYNPaxJbQu1T9ApOIvvGx6KOz0zDKsNXiOf1bQDaD2y/Zv+bJ3tgBL9tQFdLZc5lMiEi2ushQgGbtq8JkCi6yWuWETuS73lVcLOL0ki76M7l7u2bXH85QU4vMO65mjnaJZHedT9gas4c3iQ7joNNS6AH2Gsn+Xc5WLQEKf3nVY0r4DfkCabw5kh1B3bsUOb8Ylj/vGCHIekRLVF9qRsQzrm4nNiQZ7oiPCxfWmpZzIl28syXeGRiTlfy2VrKJ8w8DezcIcQgoGjiRWckxplsDUuDcsi8vKjg8YvhfKUKBkeB1vfdrugYmeOIqf+jZLxNaFEj4Q42e1XZs0oXUDtQxORP1uteDwflZ+tyoFRbhN0ZNbGQgLEozz/fWoza/bycS8ZgXv+gbNDwq7eEfJaPQ2pQHSvRALMRXyJZHRSKby/BW4V8kvgvd95jZDZlK5olPrr2hb4dqZdEF4ra3xSrTlK5aLr81jbECeksjjvIh6kGpiZKcHOsZ2aSHCPwkGfazhSKxUiixBnhLFxGPBxCMXaQoRfGLj3zajKH9p32H01pxjpBGbMfCvnGIgvNTDNcWw7Kxs8tshNplqsszH07Lcombu0BlZ6tY9zEkMZMKy6pU4BF3DKe5ZAC5IyOS0SiQgQ2LtdJc/euB2izdXaRACi8RQdh2b1nCAFLEp9I4RJsIUZoEHtRf95Y3dqvRZWJKpCDIe0TVRa6RDbGutHf4N6JZzEajUV8FeQ1I2eMgzURTbQgFvVZYy7U/iuBKMx0+g0U5vAyn24oeFdIxDZqrw/TJ/J1VStfcpTiZWxtDNbkujQ dO7gKzi3 kmbFBw0TpjpzR3YMgIaHX8hy/91jEeKwcuqlfAeVefXzQf6oY+iaOg0zYYn8D/IL+DthZ2yYprkM4UMfQ0TBwNyOrSQXQC4WiBjgQfIht6uCGJLWwo7kx3pdu2xwJaRD2YlqB+HhutuJS6S5m7KWRtQSjJT8KsncyyFLB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 03:34:05AM +0000, Huang, Kai wrote: > On Wed, 2023-06-28 at 11:09 +0800, Chao Gao wrote: > > > +/* > > > + * Wrapper of __seamcall() to convert SEAMCALL leaf function error code > > > + * to kernel error code. @seamcall_ret and @out contain the SEAMCALL > > > + * leaf function return code and the additional output respectively if > > > + * not NULL. > > > + */ > > > +static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 > > > r9, > > > + u64 *seamcall_ret, > > > + struct tdx_module_output *out) > > > +{ > > > + u64 sret; > > > + int cpu; > > > + > > > + /* Need a stable CPU id for printing error message */ > > > + cpu = get_cpu(); > > > + sret = __seamcall(fn, rcx, rdx, r8, r9, out); > > > + put_cpu(); > > > + > > > + /* Save SEAMCALL return code if the caller wants it */ > > > + if (seamcall_ret) > > > + *seamcall_ret = sret; > > > > Hi Kai, > > > > All callers in this series pass NULL for seamcall_ret. I am no sure if > > you keep it intentionally. > > In this series all the callers doesn't need seamcall_ret. I'm fine keeping it if it is needed by KVM TDX enabling. Otherwise, just drop it. > > > + > > > + switch (sret) { > > > + case 0: > > > + /* SEAMCALL was successful */ > > > > Nit: if you add > > > > #define TDX_SUCCESS 0 > > > > and do > > > > case TDX_SUCCESS: > > return 0; > > > > then the code becomes self-explanatory. i.e., you can drop the comment. > > If using this, I ended up with below: > > --- a/arch/x86/include/asm/tdx.h > +++ b/arch/x86/include/asm/tdx.h > @@ -23,6 +23,8 @@ > #define TDX_SEAMCALL_GP (TDX_SW_ERROR | X86_TRAP_GP) > #define TDX_SEAMCALL_UD (TDX_SW_ERROR | X86_TRAP_UD) > > +#define TDX_SUCCESS 0 > + > > Hi Kirill/Dave/David, > > Are you happy with this? Sure, looks good. -- Kiryl Shutsemau / Kirill A. Shutemov