From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06479EB64DC for ; Wed, 28 Jun 2023 00:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6578D8D0002; Tue, 27 Jun 2023 20:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 608E98D0001; Tue, 27 Jun 2023 20:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CEE78D0002; Tue, 27 Jun 2023 20:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 41DE98D0001 for ; Tue, 27 Jun 2023 20:31:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0328E1A0A03 for ; Wed, 28 Jun 2023 00:31:34 +0000 (UTC) X-FDA: 80950278150.11.DBE6D2A Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf07.hostedemail.com (Postfix) with ESMTP id 1F41640007 for ; Wed, 28 Jun 2023 00:31:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=XzW9jw0Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687912293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XM8hQAD7sAgZi8pW6aajDq5y68kjdX8oGtV+xaawf/U=; b=HPS5oVSlB3lhPIaNvXSGSniSIGg5QNQ8NwuxJlEEPvHvU9FpWbBsvkz+FrM5ge3HMFiLEn 2sca9j5fftQrKmhFjk91Apt8QxL4mVeH4a5mmPMoCRCzlH07jyrcfLMzO8WGNqMYnensyj zvK3YFv0bh+ZXVxczc70um/N2hhsma8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=XzW9jw0Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687912293; a=rsa-sha256; cv=none; b=M+bEl63iqOlO/s6ReeA3Tv05oKoT0+twIfwDQoKk8f2iC8saSDkr0SfPvBQY8CyBZj/yaP CWypXSlPxyeIx1EaD4O4gdEHLfbb+qA06amtZRAms1+VaX602+dBcLgRdmKyJWpKN/+J8L 2GbkH7Ieg6TyfL51zdDA4pTHUBkaC2g= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-666ecf9a0ceso3036510b3a.2 for ; Tue, 27 Jun 2023 17:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687912292; x=1690504292; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XM8hQAD7sAgZi8pW6aajDq5y68kjdX8oGtV+xaawf/U=; b=XzW9jw0ZxclnHhqqY5hoQeITwmGF+eQf2Z31WtwKKbhh60/XHAeMMSf6wOVrjm2uxY cdOCnTaywYcknu1Ii3oLpVo0Eu3SfnU9ED5/z/6HmXyhEE/HI1fAipNkBI8aDNFqm0th rg1g93Qk5IHpUsGOTCceFrFsy/5dgspzAiu5CbAU72t/aaMXA/JWdRmFQxhuE1AK+c4E mxdlKkIouwhfDVAIvE9fiCFRMT393DAjb70PjVc195xSFbF+4QPoi0n0SBzIHKOKhJAf aB9AjyOXFViP+NlXmfCCtxxhfCLPLuQRJNbWVjNj4dyY9RHuk3u1Rru51gRsFJqNbPvg /3SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687912292; x=1690504292; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XM8hQAD7sAgZi8pW6aajDq5y68kjdX8oGtV+xaawf/U=; b=btOoyGyo8sXuLkDDLczMuGmd3a22W4sRSwhqPbv/J1Z5+ufKcpKJRI5b6cHAFjL3Gt k8R1aAQqAGp4IuiEY6Iwz9sRZZat1rKl2cEu4F8sakJvHc3QeS5D61O/1IgK7o+Lmb41 QiYY4Ts1MRJFo0Rl7KEtCWMdIlV74SGRzkbeMTcV+yNsPY04rbhVvs4Zme++fLSCYC4s 0recHIB6RxQSBKIuxW49uMOR9vnUogM1anKp0a0eH4bWITx5xoUZvXPrYxDWS2NnlFZY Y4NBVaiHlliqpMNLIkcU6rYtsW3JMS0uNOkMCbScYM7OxxX28ULtZYvElV16vg3tCM9R 73IQ== X-Gm-Message-State: AC+VfDzf47iJUs7lz3DOlhtt76WZ7K7sBwmfDsB+U1CS7Q+T29haYpGa pHUveas5KiHFN8npfkkeHSk= X-Google-Smtp-Source: ACHHUZ57emkUxF4X0LBpxahJKoGiTEUqZKon2TnYW9by/gNFqU28R426K+gVZbAIth3A1FUOf2u0GQ== X-Received: by 2002:a05:6a00:1309:b0:663:5624:6fde with SMTP id j9-20020a056a00130900b0066356246fdemr29717928pfu.22.1687912291885; Tue, 27 Jun 2023 17:31:31 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id x48-20020a056a000bf000b0064d32771fa8sm1354780pfu.134.2023.06.27.17.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 17:31:31 -0700 (PDT) Date: Tue, 27 Jun 2023 17:31:30 -0700 From: Isaku Yamahata To: "Huang, Kai" Cc: "kirill.shutemov@linux.intel.com" , "kvm@vger.kernel.org" , "Williams, Dan J" , "Raj, Ashok" , "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "Hansen, Dave" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "mingo@redhat.com" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "hpa@zytor.com" , "peterz@infradead.org" , "imammedo@redhat.com" , "Shahar, Sagi" , "bp@alien8.de" , "Brown, Len" , "Gao, Chao" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "x86@kernel.org" , isaku.yamahata@gmail.com Subject: Re: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230628003130.GB3629671@ls.amr.corp.intel.com> References: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> <20230627095012.ln47s62pqzdrnb7x@box.shutemov.name> <20230627121853.ek5zr7sfiezfkfyj@box.shutemov.name> <9361abfa9bf22c2a1a4b25e5495bcccc5b8dcd43.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9361abfa9bf22c2a1a4b25e5495bcccc5b8dcd43.camel@intel.com> X-Rspamd-Queue-Id: 1F41640007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wpquayajhnmetmoocex31z55i6wryiwx X-HE-Tag: 1687912292-494104 X-HE-Meta: U2FsdGVkX1/sQBFSKOBMZ5vXuwFdOMAPQlBVHNlSGMu+mNUlU2B3bYJYkOf5//1ulu35vABZqxB2TGOjG0uIw21sYTydyhEjxz0aaDV8uoG/0cUUCSMlaXdqSfnvAELNAfh/keblSQQZMB+ZRKEJ03QRRYp8gqheDGKhYI4DLNVuLcWNZFhDBM9Q/AdKxm46yf6l1qjrHP/y19x09+DHMgEB+LDsYUnFjFgzl2DaljuWQj/tXee40KasKuaDKJqA+gT7csp7aAZl+9fx4Mdwpycl98SRdrZuTed9PBkf26qXH7FxiYLWZaBK3L+Iu07r0McBkx3o4iJCZSjlA69laTFe8PpCU9YWh+uW8kw3mPSiy9xVY8AFREiJRcowboyv4WFYEfL6w1PEeLNkvn1thMc1tpR8VNvPtmOCeH7K3akA8DYnnkQ2V6AztPJwzzHogtl78CIa14bI0HYwl+p86FxI0M+YuIWbBfpJgeoYibUGRC1bM4UTJvbU/BwwGHqFRQaQ5KZM1CEx7jfw0pDRu9Mw7SyyJZCpLSml59/VlaJbxX9swJwR+KVJ9AzdLH8vLk7r/xToW2Bl9/TtBsJ3pWswZWPU3+rsU90POv+KPlicvtwzOImymHzIsxiV4n/zU5Pi12qS0/lS5NbE40987ox5eRBxUjqwSTiAm4J3DXeT8UAVuYd0VXTkUwppKD7ObJVhJp+6VXAwsbwtvnVN6Pkx+6QYYlo2ujjH10Bo08LGCeYlAkeMYCYKPkvJjtUYuUtXl6FvYaUj4LTFavf1lr2Fi+iePPOZ2ZstuKqx04EOTXQNDYX6FFWLfHDQ17mfTXJ2c/qLQS7V2fmDywc9qqXof84Ps4vWtHt2AzO08jOMEl5CN4VJyW0GBtzHKTCJ7R5DAY9Av3QDxWhgupjtLNZEgP9BcHRMsH8y1LK47BkEtdlJERYn+UjKXRH2gdzIFoNj7nxJL+u8dmfF1AQ 6Kvrw+My NbOtmPVKr+JeNKuyLO0woQB+ly881siaR+4EiPRXVUVLNhcZFcbtOD4pNrmS2GuUnucoMKPyktEq7SZ9xl6cwpZKI91FqPHLVt34vI5IedS/tTo7cmccZOwnusLB8d6aDdEGrzGuukxnUmVTPTEEcoAyJhrYiPC7HWOrMYr9Lw2qBAD3oUpQHyLE4J4PdaB+p7q/yxErQTyGHW0Fv6BPFkwJd+Ej1mttoKESrhNXU99VNYPLKEFTmqdfRsSOLGhDcaHF3TgbfQ8AGb3R8epI40raZKEgUBBpNX3YnhRnmFsX8zpJz6xjkUNkFYP6nplU09xZ2UgaHb99JRXOG3Pp1woNJjgKySxqCQ+yYhjSRaTdqMUQRLKZISihdZHR/QSI4qxlz7IYgnHOoCnSZWIsj25vqbwxubJ6EaIe10Keuwxa6LTONevC9JvmDSRyLwIDm2lpG85aDaRuc8zQPH/jqnoR/mZ08HSaM0S85iYTCmnZUUa0vlL0569t0ZqImMpefaOt3ytf9mbLwiHJg2UEGmYdd0l4FqDetPBztPPaORQXbU9aRKuiRfIcj9cYQ6CvyTUYuJv32j52UNpTFjaSKCnAkDuMCPEUL+cyi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 10:37:58PM +0000, "Huang, Kai" wrote: > > > > > > +/* > > > + * Do the module global initialization if not done yet. > > > + * It's always called with interrupts and preemption disabled. > > > + */ > > > > If interrupts are always disabled why do you need _irqsave()? > > > > I'll remove the _irqsave(). > > AFAICT Isaku preferred this for additional security, but this is not necessary. It's because the lockdep complains. Anyway, it's save to remove _irqsave as discussed with you. -- Isaku Yamahata