From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5CDBEB64DC for ; Wed, 28 Jun 2023 00:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A1068D0002; Tue, 27 Jun 2023 20:19:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 151A28D0001; Tue, 27 Jun 2023 20:19:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F34128D0002; Tue, 27 Jun 2023 20:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E38D98D0001 for ; Tue, 27 Jun 2023 20:19:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B5944C0A74 for ; Wed, 28 Jun 2023 00:19:11 +0000 (UTC) X-FDA: 80950246902.05.4D9E43C Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf13.hostedemail.com (Postfix) with ESMTP id D5B522000B for ; Wed, 28 Jun 2023 00:19:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lXZCyJeD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687911549; a=rsa-sha256; cv=none; b=g2ZGjxV8beNZLLoL80lbcfaz9q83tzc8zsHssjdAkRvfMFmmwwVHwrtbE9Lmwvuub2s2KP p4oxGkmFLCNxvpGTCFO6fjl46S/w8lxCeLRosoXIazBymEIri+Rbuj7kYRiHUbxEcNJB0z yidmfiv9q6mO31HeKsQQqnRDGOSFz1Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lXZCyJeD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687911549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LRW+WfLeR5s36t4pmpW2ZzxI34nEruKTcCkQKc8zt1Q=; b=3BztZXV8brChjTfr5VbxQ7qzn9YA+zdaRNMhQoewOhtVOMEPbJxN/GqT4FTKPAlwriAJLT Z3yj2fuzduHxSsviNgp1V0ecuruAcN4VpSO9wCLQ6stFQs1VAmye7KUvpblEsm6NDeRYk1 t9iegwMokpkN4eeydf/ksBXwxqS5v4I= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2632336f75fso812481a91.3 for ; Tue, 27 Jun 2023 17:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687911549; x=1690503549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LRW+WfLeR5s36t4pmpW2ZzxI34nEruKTcCkQKc8zt1Q=; b=lXZCyJeD4x/gEW6A/gLJ9H8o8uBtBEpQLgGWLAuapamP8apREigOJbO980T40piv3j WCpnhd4zm3WHUySGDTZmZQbs4XwQWoG3Ze6TXItSpBeAZ4nOMp9mMoj2r61WE9xiEhCY Yzp2DggX6Uk1j8W7foRtc7JTrQFxh7/EVv1sLjpAJJtEJz9Rm1ccVAqKvzXaaARLDrOW mXFLwWLKQ2EkuGYeyb5N0lmHoMxg6ZguIFT7m/PLtvfuKqbxOEhVYWEGul9CAGrqswyB whrDRsXYJUz8Yka8EPN9pSotmXOZpWThpPGlrrBbIy46M2JJ0L/9cgX5RWWe7+uchlb8 GfrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687911549; x=1690503549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LRW+WfLeR5s36t4pmpW2ZzxI34nEruKTcCkQKc8zt1Q=; b=k2yTMVO+H57LbulElnxwRyCManVBn0/zXrUVknlqHjIpU8nsiNqfNX24K/wqpXBylf mFdFB2vYTikS1MR7nxJKNLfUM7tO7BShMzuMcPHaOILYHR79u0/+cEF7Tlk/MqJKQk7C CogZ31BxqxsFEu1Bf8ihvqUQMqT+ryx44O+z532Uh1yicvfnd2PG9Cjb+umShYuJV0Am KRjoCIfHmsB018sGetg6s1nhg6tQaWuAZFeno1Cq2VDbQdo6+6tfL0UVhyweOZmVCzVM pCIYWgM3gJR8ln/drAMfbLPGOtA9GhNilt9hLP+iWHEDC6zOEL0KlPfuSHrbyi4dCbfs AXSg== X-Gm-Message-State: AC+VfDxGSyK2SKgue7HOplTPaf4pioNN35HFETPS4HkYVgrHkf9QAd7M zbL+XcjaaPHTq7j/rgKTBd8= X-Google-Smtp-Source: ACHHUZ543SbHsjKdnX0Px9SlC2128aPramo/lQSbMVvPHEubWaQs0pY8hUL1Js96oetOeWXp3foqAQ== X-Received: by 2002:a17:90a:346:b0:262:ad7b:235b with SMTP id 6-20020a17090a034600b00262ad7b235bmr12898198pjf.34.1687911548511; Tue, 27 Jun 2023 17:19:08 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id lx13-20020a17090b4b0d00b00262def4ad92sm5062690pjb.41.2023.06.27.17.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 17:19:07 -0700 (PDT) Date: Tue, 27 Jun 2023 17:19:06 -0700 From: Isaku Yamahata To: "Huang, Kai" Cc: "kirill.shutemov@linux.intel.com" , "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "Yamahata, Isaku" , "Chatre, Reinette" , "nik.borisov@suse.com" , "hpa@zytor.com" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "x86@kernel.org" , "Williams, Dan J" , isaku.yamahata@gmail.com Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230628001906.GA3629671@ls.amr.corp.intel.com> References: <20230627094856.6udzuhzhygc4nzit@box.shutemov.name> <102e45dd81589625ed064a742508597e0d118375.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <102e45dd81589625ed064a742508597e0d118375.camel@intel.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D5B522000B X-Stat-Signature: ugjx8y6xpana7gq4sgforjzcxee134hq X-HE-Tag: 1687911549-593532 X-HE-Meta: U2FsdGVkX1+wWKi7obJbFunU17ckhJGvX5QjogpjLuQPVir0wniSpdwzkcubk2MGckgUuEiMqNxOQSULj52BrUuc0lLBO/mRY7NYFIB6tpUoV8tGU72PP1QOCk1Pe9vJTm6nP6AsykZdoXQfOpLYdjN3DwhSOQ7pdzVD2FlrCmRUEfhlHQoEQXpnW6gExbT8QrjNKmRWUHTsOBKgzej3DgMrjneC4vFFaRks3p6FD09bbDSZegx38IXe5nTZQdZpjHSjvoBnW0m8w4uZ/DY77i1mMd7Q0K12k95u3QohceBK4xbLGTFqrEIFmI8gBdMIaEzxHCil+G7A/9GMIS6VdgM396ymzjk3BusM69HUMG7k77/FXqIPuZvew1P3R2+aSQjKAGMrsBRwoh2KKq6CrBs1l2paHNwKA+esCRtcbPAllYQJ+KGO4O7p7SEl0M2DCNTCWrQI3gjn7MxlwYCwtZGJ9b4ezOFkzUS8g8+Jo6e2yvOkhzzznUBxUZ/y4aNnKhZopu1mFfcdU0EUWSZ7p15E9CSuWAv3Lv19kJ1Psr/PYdAzjnVNX4mxhkUUp3STzi+9EfNPN89YpCoanlCLiFkqruBk7fEDZURmwE/tmTNDyfGuFjLy0D+sUvYiPiPK/VOKVhJ3D+UVugjMXdu9bcjQBs4vinKngW/fcGynwgzxM1KxYvMe8ZsPqDBhZfCSBqESn0FjiQtwq4Wjild7Df29joiDHmwNOblmwuZtSHOdEUqz2TZzs9MEwqcXzzE6UdtUgxMk1sXdt4yCySEqOeSUkyZ80Hb4j75Opn3BFDxqFuNIfmCkWH1gDnYvk+zBzAy/iPB6Z7rfaRnGLD43h/+5ZVDuntSOnaz6YuE7WSU0xz4luY1TulRAY0PovZsUZXEw4v/Lz5YygkIWuTOphvuMjvDn43WiEwbsJlHSsc9nn7QtzryzXl/1PaSaNSitbYTfSpWTvxnBtw9R6LD lAeeu0zK gcr73f70K13QlsOv3fWUaJGezFjwIPVqQW0PirenlKC9f0A4WYiwlvqqCwnIzGFc2Pbooe/Xgo+C4+utiXqKscOA/XIaMId/HGxNAHGcERzNT3oTFn7mVX5nGgsbUZPv8fYn/n9wVq2Hn/n2AjZUzAahGpSXl7RUemCqPm4uDBdFM65Uga7ULUDNDXAE8fbKKBvAjOKgRgudMaSTBJ/fZOdYQqZ/Ofjh9/OwT6qGsheJR5f2pPnZpjpAc04F8sU6DfPsf9zA6XhwdnNh8t1WH3aP1aC6iQ8Ti531xtiJYO9otim89wyVS2U1lHCOGFncZ9KhMV5+Qu93lQieyVjjz/4XfBi6m+0oDdGNV2UrYBTcfZWn9GW+Ta7kl3HJMwNm5agXZint10qI+DNRysgoA/rxrqp50ynSMcQECiG4i2sE/Z0/RvAeQp2myOoq7dVyEHotzPbBKTgVG977FcKyScTIoUmxvgZEYCW1O3qg75DBtqncZ+fvBj9fOxLo8rICKYffmNzXZk3QIvun2h/24/eeYYxWc39wE5KxcIgp+Z8IIoTgX34RUxXpZRgSJBkrb7PYZKj5twjQ0FYcDoE2KCcxOYrE4SJJZUhkIOiF+gstJuWjQazwTbW+0i6mAlrvtQV3g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 10:28:20AM +0000, "Huang, Kai" wrote: > On Tue, 2023-06-27 at 12:48 +0300, kirill.shutemov@linux.intel.com wrote: > > On Tue, Jun 27, 2023 at 02:12:35AM +1200, Kai Huang wrote: > > > +/* > > > + * Wrapper of __seamcall() to convert SEAMCALL leaf function error code > > > + * to kernel error code. @seamcall_ret and @out contain the SEAMCALL > > > + * leaf function return code and the additional output respectively if > > > + * not NULL. > > > + */ > > > +static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9, > > > + u64 *seamcall_ret, > > > + struct tdx_module_output *out) > > > +{ > > > + u64 sret; > > > + int cpu; > > > + > > > + /* Need a stable CPU id for printing error message */ > > > + cpu = get_cpu(); > > > + sret = __seamcall(fn, rcx, rdx, r8, r9, out); > > > + put_cpu(); > > > + > > > + /* Save SEAMCALL return code if the caller wants it */ > > > + if (seamcall_ret) > > > + *seamcall_ret = sret; > > > + > > > + switch (sret) { > > > + case 0: > > > + /* SEAMCALL was successful */ > > > + return 0; > > > + case TDX_SEAMCALL_VMFAILINVALID: > > > + pr_err_once("module is not loaded.\n"); > > > + return -ENODEV; > > > + default: > > > + pr_err_once("SEAMCALL failed: CPU %d: leaf %llu, error 0x%llx.\n", > > > + cpu, fn, sret); > > > + if (out) > > > + pr_err_once("additional output: rcx 0x%llx, rdx 0x%llx, r8 0x%llx, r9 0x%llx, r10 0x%llx, r11 0x%llx.\n", > > > + out->rcx, out->rdx, out->r8, > > > + out->r9, out->r10, out->r11); > > > > This look excessively noisy. > > > > Don't we have SEAMCALL leafs that can fail in normal situation? Like > > TDX_OPERAND_BUSY error code that indicate that operation likely will > > succeed on retry. > > For TDX module initialization TDX_OPERAND_BUSY cannot happen. KVM may have > legal cases that BUSY can happen, e.g., KVM's TDP MMU supports handling faults > concurrently on different cpus, but that is still under discussion. Also KVM > tends to use __seamcall() directly: > > https://lore.kernel.org/lkml/3c2c142e14a04a833b47f77faecaa91899b472cd.1678643052.git.isaku.yamahata@intel.com/ > > I guess KVM doesn't want to print message in all cases as you said, but for > module initialization is fine. Those error messages are useful in case > something goes wrong, and printing them in seamcall() helps to reduce the code > to print in all callers. That's right. KVM wants to do its own error handling and error messaging. Its requirement is different from TDX module initialization. I didn't see much benefit to unify the function. -- Isaku Yamahata