From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC1EFEB64DC for ; Tue, 27 Jun 2023 14:46:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44F9C8D0003; Tue, 27 Jun 2023 10:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 400828D0001; Tue, 27 Jun 2023 10:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C7D28D0003; Tue, 27 Jun 2023 10:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1F8778D0001 for ; Tue, 27 Jun 2023 10:46:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DF665C0A2C for ; Tue, 27 Jun 2023 14:46:43 +0000 (UTC) X-FDA: 80948804286.05.1D82289 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf24.hostedemail.com (Postfix) with ESMTP id C880B18000A for ; Tue, 27 Jun 2023 14:46:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="ZELrA/9I"; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687877202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sx2I2uTHzyFWwymbKmW6SHOFKTNzQ5cGIsjHspz4koA=; b=BGbmlAQ/iJdlQe6tuNDzgzgojyE5R8y5B7n30WLtP6Bsu0/rNThUuhAFeFyvYh1MKaEGik cgYgYeSRtxwTpko+Tqh2G8Golu4CWy6kiBhdAk01h+Mv+zm3E0fh+UeYH4CIVoAX+25/nZ CYi7Gr9CCv5o+AS6Y7KQfAIdvhf93u0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687877202; a=rsa-sha256; cv=none; b=ufKGq2AT8dhvCXuX928zHNlD7ZLxee4T5tPKhcJROSXbnAV04Aesq8p5MtB2OEpv13RmiJ 2IIc40QhSNEIyX7G7sXBDSBYqeyFjCffBLu6hMhM7p+dnfKluR/UMkfuTV68HgSeQ42BcG W8w9ZOTWSp1wCCUjpmNbVlKmRPQlHTI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="ZELrA/9I"; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-3f866383b25so44773981cf.2 for ; Tue, 27 Jun 2023 07:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1687877201; x=1690469201; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sx2I2uTHzyFWwymbKmW6SHOFKTNzQ5cGIsjHspz4koA=; b=ZELrA/9I+gnOIdSusx5IIl2N9aNIvxXXeGGmk8e5HI3PYQ1IIgx7xZdjnuYlAy8mkp 0G7ZnnXRnnSOI6ZfevieJaoYOJRHBhS3BrrtoiJHqpN0qrcisK87zGQBjlog80atBDv6 rFBWHKIL+GOM4N0g/u1w7IUav2KTcFK8LsMzmgtaNt/HkfWbQSntk9q8DxTZGBWPsihv wDqDMc1RlpW7jkI8xGZlik+VEQ2O5hnfXlAGd8LUAQ845g57pvSQHSM3twpkzP+lMGhr /xWFBsXi3BysfsllnhectRxRvkdd989PH298AyLoNeX5Fr+rY5I7RMBVMrzzMlqDaO92 Hg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687877201; x=1690469201; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sx2I2uTHzyFWwymbKmW6SHOFKTNzQ5cGIsjHspz4koA=; b=lfWqFUU4HuBK9gwwjdXACIYLChH4+GgXOmG37tDY3a86scTK0WTaAAf6GzyrksQNCB E0MCEE/YLeY+AhP+9Ds9bPgBG1WhFMOsCXt7RvfxcJOvzGWUqNQj171reqpvwYsMgNSm 0YRzhpsMeVuIMlHhdYK6aJ8CEzc7Lx8kXWtJzKRhLMUo0teIjhTvK69H68/IPL1sdd83 rDlxabldgfLkHZdtZi0gp3hNBnbf03f+ZmlsabAGfKSpcmQJnlVfSVPUrNefcxui1d2s NZvY/aAcCG26SOclplbj1KoBIhled2d9uAbB/W7kV480USMWVzltdl1U1T1XELsdGEPr pfeQ== X-Gm-Message-State: AC+VfDwCf4dIhDKgCaZ3z06wEfccLXgV77x0xE5emUN1mQaeWmITNVvb VTrXIiP+H7VXJQ5uhu+FKr+b2w== X-Google-Smtp-Source: ACHHUZ6hWYDxmlOuzkAWCv6V6pOmoUF7l8ZC7BNyWQw8rQRVSNz8/Su8DeUifEIa/1aCckgdpPiyng== X-Received: by 2002:ac8:5f0a:0:b0:3f6:ac1b:47b3 with SMTP id x10-20020ac85f0a000000b003f6ac1b47b3mr36857835qta.34.1687877200763; Tue, 27 Jun 2023 07:46:40 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:3a96]) by smtp.gmail.com with ESMTPSA id bt3-20020ac86903000000b003f9a79fe046sm2465029qtb.38.2023.06.27.07.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 07:46:40 -0700 (PDT) Date: Tue, 27 Jun 2023 10:46:39 -0400 From: Johannes Weiner To: Charan Teja Kalla Cc: akpm@linux-foundation.org, surenb@google.com, minchan@kernel.org, quic_pkondeti@quicinc.com, quic_smanapra@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm: madvise: fix uneven accounting of psi Message-ID: <20230627144639.GA52561@cmpxchg.org> References: <1687861992-8722-1-git-send-email-quic_charante@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1687861992-8722-1-git-send-email-quic_charante@quicinc.com> X-Rspamd-Queue-Id: C880B18000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jt1f5rt5k15s41x8fzs4tj53skgsjs9n X-HE-Tag: 1687877201-556243 X-HE-Meta: U2FsdGVkX1+mWdG1zTYfAdL/5sC4wyrx7IySdLtXoOzFeNW9CkowT/roJ+yRF9/WhddmFaelX7VxS9EKB5GAPFyMj0TSXY+8ITWfyUFzuI6guLx8hWXLVf1WCBURpXqWfBIBYNAhqIYTp25yL0o1uytJXgi0pXzAda6+J/588yo0iO5/ZDlXzihH6vWO3HdH8eCAifhMCd2lsvTHSCDe0OdL/DHqpOBmcpuhs/grcDg6igiqF6oFJZ9Xf+wegOD1O3FV7/HUYddyQBCmo+JLtp8T/vL0Qv91ZaZKTISiXHSmRKAwK05U5uUcVLclIw54ZAlwQ1GdrENsne0NHRee3oFNf0enahsQ30n1y2cw8bzgP8S8W8C5mFEX2AruQY3zaZkO7MnJv3v2Y2A6XzjF00uWX06tXINoUkTEMEhcFDzAOmMgEUJ8HYdj7oXa/+8kgTXy+LDKzdpEt9Hw0b7HxUrbsaL3gkuiXB0aGidbQxEzlV3gYSx+J/NnRnaHCudCHe9ozVtv+R1sCVudLIL7vRqDiLYO7tblbvtKSvGa4gcWBFl8EGbFbdx8T/uMezSsQiq7vpIctN1hgec/UnJ+ZiuI9SJ5kOnSqMEhdbgpruVxmCdRciR8m8ZDVbqeukALQ9QvF0mnAyz1Mq8/9OG5BsYiEuVeP0GDQTTAdeB/HWs4qZXgRV8uYk7qaDmlCE9RbdnP4vLOwCeRGv+QrclgdoZIRUfv01jUEB5+SgbWd+osUy6VOOCXHyI+e2yAsE4hJCWf+XK93b8GwQ5XahwyBAZ5k98sXa1KRfS3Zc8qrPT2XQma2lPd34pu+qkJ9GtKWmM/nDe+pVz09tBLoyM85kbD3OcEEmLWRboNKyEbKa4rQtC9l0AUxFXS8VHdqNK0wldZj3Ln+XrvHaUlyySYYhDWDAK15sqi5dHS8z+hdEivAAZNm7r+hjDM3BOUIkLs+Hb3CDNxc0F1BsST6a/ uqlORzVj j8Wja4LA4T0g7iQeCDEjyVfpVsxRyo5dCM9CTnBo8OPe6TQd6M8NubQFZ4cdlvg8Rpky7LevtMCsIE+FUkgJukIT302XEEbT4guhalMd0yhcUQUMPVhPm7CHGFHK3G9Wet+5XDzBo11qB5wt97gr3J+Y/lZ/EDq+uxm4aIyt4+9/3Qq+VLIRu5y/JB1YmHxlw7S65IoJyGBJavnN0XFYfZ+tzkJXpW4GOB9/WzkZrgMY0tuLEhrdaHpAPcZQBz516Yy/KolCcNhOfdXZ2JvOatzwX6lapLuSwATfLh+3m8en70e9ChX4rtgOGzxYHWGZ+a9/o0uaXG1UuJwZ94I5mZPE2CqRM50/PiPO3W7t98XPiB1ptAQcSKJ/DEKfA5wmSFBTQc5NxfTk40tIRLPiQpBEM5coL9wZLjuhA3McRLqV4DO5+1ZHte3OCRHt+KeEmMh3tO16n/k6CjQo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Charan, thanks for fixing this. One comment: On Tue, Jun 27, 2023 at 04:03:12PM +0530, Charan Teja Kalla wrote: > @@ -413,6 +413,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > > folio_clear_referenced(folio); > folio_test_clear_young(folio); > + folio_set_workingset(folio); Unless I'm missing something, this also includes inactive pages, which is undesirable. Shouldn't this be: if (folio_test_active(folio)) folio_set_workingset(folio); > @@ -512,6 +513,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > */ > folio_clear_referenced(folio); > folio_test_clear_young(folio); > + folio_set_workingset(folio); Here as well.