From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76405EB64D9 for ; Tue, 27 Jun 2023 14:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E66308D0002; Tue, 27 Jun 2023 10:34:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E16058D0001; Tue, 27 Jun 2023 10:34:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0CC8D0002; Tue, 27 Jun 2023 10:34:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BECF58D0001 for ; Tue, 27 Jun 2023 10:34:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 372FBC0A19 for ; Tue, 27 Jun 2023 14:34:22 +0000 (UTC) X-FDA: 80948773164.21.44E861F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id ED84D8000A for ; Tue, 27 Jun 2023 14:34:19 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MKYywGfE; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687876460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j7SJwWgTVBMWMKWcbUlEdBZoWmfMwbbd62astjobFKE=; b=KRNv8BZEucP0AwGg1t/i+bF0emrKIQpUw7QRMtQzYwQHybFCvKrVLqXBbmfvnwWyhm4HRV Jtou8jrqSQUesF62vIyTAmkw7HpNoZa6651RYqzX9WKfAbBdPcZOPGEhyFjnpCnh1rmvN8 LhbG+QZ3Jj8bgYgLpphrhZA7sH02FMg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MKYywGfE; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687876460; a=rsa-sha256; cv=none; b=IiEPPiXKlFCRSAztAuO4sdFUpYQ6HLzWl2a0dVHRg6+FyAtZqBXcbCaWMJwYcwvFliI1d1 KtJMlhYb36imWEi4SxCDM0MgdBW3oNG4ckLcl9wbKBGa0OD4CiHvhb9wfPBshr/FtWKDku VFDoxcVIlf/VoD4mOAnUnWhSWtItOys= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C599F611B5; Tue, 27 Jun 2023 14:34:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 666C8C433C0; Tue, 27 Jun 2023 14:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687876458; bh=qBKYhMeBJz+rIl9E1m/ziiZUzXijsRdV8U0bSFmCAAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MKYywGfEVa9DRexeIPqNaUjeRBPlf7lgFIsnaoikLG3J3hE/igIoECy0oaBWuLrWY X+RibNBZXeQ4tyUBIxUert9sOmkm3HP5vbhHSchXEjF+mS6fRtQ7NwZXCtMkP/78w2 iMIi0zd0RgA5K4PfgsTi+gqoKIGo0Eb9ubFZXEPsQsjEcPDpc54jM8W/rRyJ7My+RN nsO0nFPh8qEckskzVUFKInD+W2rQqmBTYYmzA2TjJOa4TTV0pjbjvFkFmpoAqqh4iZ x4B3arvGowo9a+wykswC+zXnMvvnk+tjrI9JUJJld10JjZjUH2oj8AhH9GLRK2L9XM n/2bZTKFNd6yw== Date: Tue, 27 Jun 2023 17:33:18 +0300 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node() Message-ID: <20230627143318.GN52412@kernel.org> References: <20230625050850.GJ52412@kernel.org> <20230624024622.2959376-1-yajun.deng@linux.dev> <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: ED84D8000A X-Rspam-User: X-Stat-Signature: ixsg7848ufomzpb6rr9xxw7yy73udqir X-Rspamd-Server: rspam01 X-HE-Tag: 1687876459-528003 X-HE-Meta: U2FsdGVkX1/Y7uHfxP8OmYp4Ugo548seMeQNQj8Fm0sduq8jU1BDJSo+RESbNUIc+DB85A4cq0Px/CPILNlhuONq958HhusFfzz25aBIoOLTTLFDS6diNHZdnRofKMz/T1X7EM0KIo3jH1qnIllc6TFFedK2Kb6m/+3aRHg63o9pJ7JKKLev/3CJBM+uCBzvpHnjxydztFUtnXkCnGcrmDJ4Ml4YYpPQ5B9BdhLgQ34B/4x/cP3e8gOI7YMdJx7691rgPdoL85GdpkFITh1v/am03YiGPzwRzMadCcVXW8iwvIVTMDM63SMnVVaOsgIYNT1aQNUOdkTe5guHdb2hUD/3I5yo8IZRKelq6Yrw8DsIscBTqfi6bGyDndYCtFK+glAipJiG9FSUw+jCk1qYEfRakdtDOXg/NBdnCQ0zeFjqCI9RidMBcbynRIjLxri6GoLgOAS1fFP8uRmRT6YLhJtinTA9aOrHydcgZx4sybtDv4GcShyhb0R8WjpT0zyoxqNvNu26H8eAXO1U8jZxnMGxkM4sZK80UZZmbRX3TY4qb1VX6iD98ugjU9gew6cGjT7p3LMeICAM35u3/qrkmdcGfZI5XsnY5rdpKNiXdsKonYb6qhHIACYNq0Z8QIVvzmOBPQGi3ZZZwQr6bOsKKFazdeYLL5AaL2tdxvH68xreCa11R4zKN9YZOCwA7K04i01O3CkL7tc8J+GU5Ya/5Ttoplax1PCz0KjrGvzBNTl6bhsplbEYjsmeYWNAbihBOtDAZEdjy/T9O2ZjcvcfV3AHSuPjumsL/B4HKdx09nfqfQkGIi1RbeSJlrI1iQtjCbqsHxv/IB7TBM3uFNUd09Hhn4jJQYjOOPa7QZBa2LwBy09+ui+OQytg2F3vXddzg5izxqzEv9pVUndkmTExbrPOmQIkzVjn7k01zEGv4b1MZeEz+2pxs8izSvvV/EVF1LQGVQCHTT4+WoR8ztk H4j4IW7k v8ORxguFcSZVFrc5blHBNB41TitQ3SuSAXqcg1z7DqZmKifzoIS84c130dBtX+Owj5F8BLqX17cqukOXv3FKc2MFm76ZhjC5KT6whT/iL/31V+EVeo7uxemsn4OAwGDptmbRUKgVuy33B7sf4xX6XrrTMjD75t4VOS5cHfHPDrLZF+1PTzjKU9lt4DI/Fn5Ax4qiFoGjjt0teFfQU7Q62clCWzNHhFEKRiqq1FniUKNCJGfaFLjyHoU6gqzvO/srlb0Zj7e0S32z+KMGR01JuGnrCtrB/tgM09vVBhdS89pkQWOVwgoqEUz54MuamTxDXE5YgSWm0kjU7GXGP25khVQSbQDi22aD7uB8+My5AlAe0lkC7lnIgJLrLvU5aDst/1ciQ8vyQ6fYOg/o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 12:13:16AM +0000, Yajun Deng wrote: > June 26, 2023 2:21 PM, "Mike Rapoport" wrote: > > > On Sun, Jun 25, 2023 at 07:39:10AM +0000, Yajun Deng wrote: > > > >> June 25, 2023 1:08 PM, "Mike Rapoport" wrote: > >> > >> On Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote: > >> > >> It only returns address now in memblock_find_in_range_node(), we can add a > >> parameter pointing to integer for node id of the range, which can be used > >> to pass the node id to the new reserve region. > >> > >> Introduce memblock_reserve_node() so that the node id can be passed to > >> the reserve region in memblock_alloc_range_nid(). > >> > >> Signed-off-by: Yajun Deng > >> > >> What problem does this patch solve? > >> > >> If we set nid and flags in memblock_alloc_range_nid(), we may not need > >> memblock_set_node() in memmap_init_reserved_pages(). > > > > When memblock_reserve() is called before NUMA setup, the node ids are still > > unset in memblock.memory, so very early reservations will be missed and we > > still have to update node ids in memblock.reserved later. > > Even so, we still need to pass the 'flags' to the new reserve region. > choose_memblock_flags() may return MEMBLOCK_MIRROR in memblock_alloc_range_nid(), > memblock_reserve() couldn't pass this flag in this case. flags are only relevant to memblock.memory, we don't care about the flags in memblock.reserved. > >> I tested this patch and delete memblock_set_node() in memmap_init_reserved_pages(). > >> It works fine. I did not delete memblock_set_node() in this patch just in case. > > > > -- > > Sincerely yours, > > Mike. -- Sincerely yours, Mike.