From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC5C4C0015E for ; Tue, 27 Jun 2023 19:22:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 790B38D0002; Tue, 27 Jun 2023 15:22:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 741E08D0001; Tue, 27 Jun 2023 15:22:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62FF08D0002; Tue, 27 Jun 2023 15:22:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 534458D0001 for ; Tue, 27 Jun 2023 15:22:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1539D16029C for ; Tue, 27 Jun 2023 19:22:07 +0000 (UTC) X-FDA: 80949498294.03.AE7E7AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 38FF64002A for ; Tue, 27 Jun 2023 19:22:03 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OdmvUc2k; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687893724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2PFUe3PC1nqG6Bla8blg91P1IRyZEClVhV2gtLfjiE=; b=pEhenl96/7yKGuy7y1QjfV0Oni8wNDlB13iK6eQdITZ6t9uprum+zVaWEd3AnSt9R/D2s5 WFWIZJr43viwfjwQG74fAu4g6dsvnTYoTpa83EjP5iEcGZZ3KXwf902ZcbdC0vcX5xFmOk bW3X2SzlCkn6TGeJNOeksEkXXFi/mWQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OdmvUc2k; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687893724; a=rsa-sha256; cv=none; b=FLVQWlVc6lQJN8B5CrGdLloa7YSRx5N4TFe4V3ChvIBUldCLzpzKReaY/ST4LGSEuO+tfy yHq/mFu+BMMwEiS16qiDWzaJ7MfOEHeoi/ajRjMQQF6no1a1E9iN0IPtuyeWv7FaDDKlf0 8CDblhmHUp+3SyRLSCt8GxAhmgQVVJA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 087B0611FB; Tue, 27 Jun 2023 19:22:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01F90C433C8; Tue, 27 Jun 2023 19:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1687893722; bh=V2PFUe3PC1nqG6Bla8blg91P1IRyZEClVhV2gtLfjiE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OdmvUc2kCOYkyZaOhjl8Yb6iNV+MHvldLV1TN4pN3SBVb5w6KpruNwn/YEaFUHukt YRnmjtqICXTjbftfqMtK+6ZfMHsWsIZct3rqdz7t/soSd+k5/mAKfwyNoRnaiH9eWo yMli74qo38xIXUmp9xpNrRX749yW4Mo3vj2Nehcw= Date: Tue, 27 Jun 2023 12:22:01 -0700 From: Andrew Morton To: Nanyong Sun Cc: , , , Subject: Re: [PATCH] mm/ksm: delete the redundant ksm_merging_pages interafce in proc Message-Id: <20230627122201.6e25819493823dfc7cca4741@linux-foundation.org> In-Reply-To: <20230627133542.2446285-1-sunnanyong@huawei.com> References: <20230627133542.2446285-1-sunnanyong@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 38FF64002A X-Stat-Signature: n4z5ejmu5pgz7brrno9pnpq6y94u8f96 X-HE-Tag: 1687893723-561735 X-HE-Meta: U2FsdGVkX1+DTBpxgBzL/YpzM/o9+JlrDMr5noZedSST0mlD0lVCCoK942IExGPTU6dcZUDinn9ZE2M/zPZxcXFbOfA5DMr3rRW8gBEfTUWwbQs2fJcj9/ippuIhJ7FprZaHg6gCusPx7PXZz+y/CrKjSWNMm+Brwdok2SUbnRk2g4Ms4Pi9KjJRi0/f1vKV3Im2Kbf8euK/B/tTUneMeFf8T0QUu4CesyA90ME1Q4Zcd5oA86j0KfN/JHaGqM/sVyT9VITt3vTaeYSCuQrspHqTaIKHpT5493MKgP8N8QDkiIA/QOfPIUIMuk0aFDCOpQdOpMTg2aGG6GCG9KBiiVxKsnbS9bbLvExyDugZSb85x3oOqzqkbgJFUY6SMD15fNQXCtHZtISrmyYs+LI12zMpNQIDiQYOVfhh3p5x2YWNVofwC8TEoOysCyUkt3U/tzVT+HJSYqlnT+pbI3mBMgCJL9d+nM6AHlCv9UiREnKs3Ce3TrT5dolicb13WDWiTgoZcRerNTd9BrGXsQJeQrFq4Fw2dbqM0mFXqlRTnhLbWpnr+6jxeRUFNdqJV67JqxwToLzS84xQmYIDjWERoA66rMfGQ/cKQkMgoXaKS3olMeUePpvGPw/UiJ6ZAnXQ2XBVenOJdhq+LDtB2mwQby2sK075BeO3oMK3a8XvZOssUiEhJRr//f5NLo8n+eU58Q5In15gX9HEoz8B6PU3nQgWXwhj82/Dnqbw1gIAduyUkCPQ5GbQ8vhDGthPtvFeLvin0D58tz5vXiTeYhKRl29rRX8bM4IGe+E2KNVGAEV8P238Ixsiho1LsYhUj2sSk1YnbkJNPuPIzF4Igs/eXc53eroDiSJ7yYrox/LHen2yFOmKJdAQUyntIjbQEofY6k9AGpM+EkZhGjBH1/L9CDjtTGIZu40fpbTxeRhhwUVcZT61Q4rlzTYnjEOINgd4Xxk8Qa7jef7Df6Klsnw DeoKyCgu 0RP5gzgj/nKdWB4z5G5BGXljAgetwIoeh+0zkXl1RoFYADPSu/GBuFMsWzxLd6ne3lYUXFGnG6IgSdWjyEy2lan7o7WQwfWd6WgtMYFQPpheJONsasPYuGfFvI/PuiiUzBiY1FD5j3t/r9JEgQxs1a9kUOKIBtsX4G8UZTSzO9jhptQiUPvuXboAfB6iJ7yDjiHCIVo8PyPN52I8vEcmM5rVYDw3b6d5BbqPdO7aNfcNg83Dtym9G2DHwRpNJ7gQvAWz+R9fIKzJExJ3t4zVE8uJFFzyeNgkC57AuZwp9CSAHtGp7GwKp8p9irzkpO0yTmKeVkR/afYiJM/WpIEYnn+A+ezii2woI7m/g9KpBjXt3w1JNqok53xag0rI6qArDt3fQBEB02L54Vfs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 27 Jun 2023 21:35:42 +0800 Nanyong Sun wrote: > Since the ksm_merging_pages information already included in > /proc//ksm_stat, we can delete /proc//ksm_merging_pages to > make the directory more clean, and can save a little bit resources. Well, this is a non backward compatible change - any userspace which depends on ksm_merging_pages will break. Yes, we could remove this but it will be a lengthy process involving emitting a "please use ksm_stat instead" message for a few years before removal.