From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00F93C001B0 for ; Tue, 27 Jun 2023 11:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928FF8D0002; Tue, 27 Jun 2023 07:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D8AB8D0001; Tue, 27 Jun 2023 07:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C6E18D0002; Tue, 27 Jun 2023 07:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C0218D0001 for ; Tue, 27 Jun 2023 07:36:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 36041A092F for ; Tue, 27 Jun 2023 11:36:35 +0000 (UTC) X-FDA: 80948325150.17.71EAB95 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf12.hostedemail.com (Postfix) with ESMTP id 4E70C4000B for ; Tue, 27 Jun 2023 11:36:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MQwTGFGD; spf=none (imf12.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687865793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fxMdUhPKZYQMfTCQoz5OS6RNm2prVytzVBt41LLNMxw=; b=IRratGDN6cRayu/3U+V+Tf9GBZKMxXviXMLhE+2WIAyD6x4B+sFeprWhlh8JMNR8FxDBU3 pcOtFmb4OdvXF5epcG61l/FgY08CzCY8Q8J5jTjmIbWmeAox9I9POkE2Xq39KZFOXoAG6m zjhaViyOoJdQJjj0f7Cjj4LhArPVLuo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MQwTGFGD; spf=none (imf12.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687865793; a=rsa-sha256; cv=none; b=QeJySxGvIP4eG1XHPi1AwCqs6JA1zPqH3x69RpanD5fzDf9YpGEgMsCMDtGLOJmc/vJ35O Y+A8ZcuvAeMERg19NLg/Sn47ouQb2TkEJCLF++At6tzzQANZHUHT5wXtgUItZmtjPi7VBW ffKQL6foQlG38OokEwD5NHHXvylkD2k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687865792; x=1719401792; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=b60RLvgCgE69eplE2j+D0M1hJ0JYNceI2V64TdDSM24=; b=MQwTGFGDwwiIAoiYomWzJOpomMv/FxAZQ1hSD9aCI5KYc9KPwxjRWz9c eHPDAKTxEHElLtzidgW+6NSUFf1veiE2xKlofUNkmerdQ+95GNAzdhPPj k/XXiA7NixIUpJh0pwBozrd6O4KqtOoNvAR0SELA69vby1jBzsoOXBLUh UptBujSUZ7BY2ZGEQwahYUeAbE7hwMOLfAHvlTp4c5m/e1ePhO4beewrx z2h2etbXPugy/IEA+yXTSpfjs+x1Q81ENEblGSyxTUPp/BOs/S+R7g84i ntmKKlp2nURX/5L764cjMPwQ3IAi0+1ogUK7Bjxa9ZwmqmSvSj4L2C+qh w==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="361586296" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="361586296" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 04:36:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="806445038" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="806445038" Received: from rbhaumik-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.217.121]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 04:36:23 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id D57B0103738; Tue, 27 Jun 2023 14:36:20 +0300 (+03) Date: Tue, 27 Jun 2023 14:36:20 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "Yamahata, Isaku" , "Chatre, Reinette" , "nik.borisov@suse.com" , "hpa@zytor.com" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "x86@kernel.org" , "Williams, Dan J" Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230627113620.pnxqp7cel66zuldi@box.shutemov.name> References: <20230627094856.6udzuhzhygc4nzit@box.shutemov.name> <102e45dd81589625ed064a742508597e0d118375.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <102e45dd81589625ed064a742508597e0d118375.camel@intel.com> X-Rspamd-Queue-Id: 4E70C4000B X-Rspam-User: X-Stat-Signature: 6q1m5z7qd4q6wu7xsikaxwgdqzc48881 X-Rspamd-Server: rspam01 X-HE-Tag: 1687865792-941376 X-HE-Meta: U2FsdGVkX1+/+s4LPk0V9ACyPC6SLwfI6fNiAi4nx89I/xhvRu6bTFZVvsoi+q51UxRXhDvReWjESGLtZ4BwXqhiH9AZtX8gPAD90oMAqhWCKE7qUUCUw/33Wj8ZaQulNpDLZZvqr8y40lHvh7UHXQaLn7FStOTZSeVR3LLVLBp5oXazbojKbL102hHxDEGzb5dvBxv1UQWzYlt0FnxV573jx6W0Bu3eTZ59nmxRRewAT18dN3Hu7ctF0X3DlTJ2Z5kZtIXfb9Q5eCp3U7wBAEjdnYPhwWEH1lmXpah/4CqT8Rkv5qXpSVkLL1BMabU8BQ36xvPelTpXcSaoKFLhc0Azg70YxplfEpRYLcH2+R6glaj0Hbi2H5/B6mdIvHGMY/wwqF95Bj0Wkpf+WVMO5OAPAhOl30bCDRq943pbL7jUnhD1RaJZxwZof6zmHlrGHZShtdxLw2Gnhk7kFFJ16fs8s22BNJMaQrrp+9UReNWhNNyHLys3JePTCkg6Fi/7wNpUr7TBWUapGy+zNqk6S2P5GswJemtTB1nC15XnVTB8SVT48mQxUXAXg+9wU9anNNHT9MWQ0iv964xYErJa50UeQMfuEPGlw7oakIogsxVxn8PRs71gW4WDdQOo703eQSbY/jXAv0qVkegph5T3Dk2Z2DrjUfbTUWq5TQgdeRi0MPkTUsXjuFSaC/c6TQNPUNXx8otUeUAtpPAacJ2AxH5llogD94RkkR687EPaFxd376dEEgW8Iy7o7VJmnl09LksJdaU8qHHZhXA5V3FFQu8LNhBNV9AsIHlUJZ0evtPq34J4prxJOSfhmA5MEeBxuNLRCuQPtKCdVTmA5svXdCu7CyUgu+GfR7zQetUvUhBPwrnJcFhnncoY6nBoiXhYDMn6oXw6b9o2YU4i+Bka0voMAvcfVnHb12mZPOqlAY57wwfHy+vUCgktKUDZTq84WrnjFXSAWHGXEwR5SjT 1KDXS7JI F70OpEaaZlbMhZ8sUn7Mj5w9WCxpzmGZRBZCCODzMiVu+jtDkPpE9nELkvUr2pKVpWUgBCK4YrDcF4RoeAVci11OQlzliaFWt7FKLVLGfeRTj3NMFtgMfzxcRk7xkSROG7XKqMOT8DipxcLpO2E/hRoN747pPVjhqA65x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000060, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 10:28:20AM +0000, Huang, Kai wrote: > > Or is that wrapper only used for never-fail SEAMCALLs? If so, please > > document it. > > > > How about adding below? > > Use __seamcall() directly in cases that printing error message isn't > desired, e.g., when SEAMCALL can legally fail with BUSY and the caller > wants to retry. > Looks good to me. -- Kiryl Shutsemau / Kirill A. Shutemov