From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D71EEB64D9 for ; Tue, 27 Jun 2023 09:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3863C8D0002; Tue, 27 Jun 2023 05:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 336358D0001; Tue, 27 Jun 2023 05:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FEB08D0002; Tue, 27 Jun 2023 05:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D72B8D0001 for ; Tue, 27 Jun 2023 05:50:26 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 78C95140957 for ; Tue, 27 Jun 2023 09:50:25 +0000 (UTC) X-FDA: 80948057610.03.A2BDA2A Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf17.hostedemail.com (Postfix) with ESMTP id 41A6E4000A for ; Tue, 27 Jun 2023 09:50:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bztpDKMP; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687859423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ocDJOW5xdwADvMeq2r4ZJSSgExZvq1Aa9Wwtz8My8B4=; b=IwSBkDsz2NZ6tezkfLx3+pgQKylgkOAJLx9g092PXMwZP99+qZyLXEGQyRlLmK4N7eSr5f f7UK3op46SqA8J9sN5hUvvKGOZrm0Q1MXbpiM3vkyHaX0/rFtZmCL9OjRdAUAKnom+Xl3j MFUBa05lkbDFmdDX0khcdzc7fzWM7NI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bztpDKMP; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687859423; a=rsa-sha256; cv=none; b=Ycxx0Qf0UMPQTEHNA1gNXt4AhIA+QrRKV/eIJ5YciHHI6k+UK1Cn0p8pjyyan1tONVWsCL sXoPzwwCck8OQn1J2Tlua6H6PiotRjwQudjVWgIGUjJAQ0L98rWIi7OSSQe27iSOog5msM Bqoc4fSFj8Wr5dyP/OxNN3/2QJubFSA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687859423; x=1719395423; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=S34hN26QAZtQUW6DKc6TE+7IhWnV1UGr4OqGCCuhdv4=; b=bztpDKMPeEd5TM6MdmVjENZSVFRoKV3HhAcBCIDHLh3D0Gy9fRs4Z+i7 7PZVkrqhmPXZ6l32yEG70z/0fxWDRXxCOq23gJ4zdLAHL0iEGwXaVUQhI /Zrw6kO41rnIxzZWP3NZuJ5S354xMqP+RXqMlt/mXyUYiKIp5wb+jqYo6 ozuamyjw9AERe1KpIa3J4oTLh8Hf/KxyfLiRKwckAQO91uAmXoqWu8v+L RmFB90TJ/S22PfMRE4xKHvaY5E7p7NkiETewQPnLkKlbsnTSTb+3uSXnA 7U6/AoR6kr9AlYeLSKRfVdKgCIcLbzbfBn/R+k4rTMW7xavy147dD0rxn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="447911890" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="447911890" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 02:50:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="806403097" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="806403097" Received: from rbhaumik-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.217.121]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 02:50:14 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 24381103732; Tue, 27 Jun 2023 12:50:12 +0300 (+03) Date: Tue, 27 Jun 2023 12:50:12 +0300 From: kirill.shutemov@linux.intel.com To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230627095012.ln47s62pqzdrnb7x@box.shutemov.name> References: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 41A6E4000A X-Stat-Signature: 47jpp44egop4kygfq4jiq3no8k36gfur X-HE-Tag: 1687859422-523217 X-HE-Meta: U2FsdGVkX19VD6S7EWW17ljrsHmtQnMuQ5uWIAT7Kj7jg4pYq1svAm2n9mZu0azkMVg5LOBjQFeYZAjeo2AQ2r9MrVw6JRxWOVTOhro6F0Vjzjr/xRIY9jm4n4aIOvxU4rfVsBqPE/1EeYluvA9SrzhvhD4wIt8Q9HX8OEomHaJuuRBDC9gwenT0wuZGQHkDqzbfwBjU160yWOnYwO/S1sLjPfN41URbUOtDEY4hj3zLaUFbOpgQgVQn0lVAaoRjyQnBzWVfIzn9yYIEzkPF51jdmKcnpyPooAoJRSpRsgeFreNQPcJZmgi9P7Y8JKlrW6HK++AnsdarBPiAYxVEOHpTuCa+FlJsIad4/C6bBIYv8OSCl18yn+mrQvzWOkV7l9PoP0M0Nb627jnhNRYGDnsNtpk3wcXxkhoiVvELCWSK7Xl+H9JmhENIhhxC6LrBsBB2R/ffHO8jkeBAX2OEPnCSM7V4h8VMG6BeXJqpg0R89xiqGWJg+T4+b5PD+JBV9i6sD82IR7wx5IFvJ5OkpBVD1r39l1gEF2iN9H2yYwTvjcf4MtSEM38p0TdB9NPan2gc6+G9OvuAXf7DBP3bKiJtENxX9B4Lc8BkDimPCYnL/jwknkubX/bKJiaPt/V7WS3nNGitSnjMKbwPCp9J32pDMxgHsGZIKE/0b9WLqcy9mfJKZmKhBEJXomzRJkimiE0m1O1HEr2BNuLkFDEl2RXPBeTAK/GJ8tdOkuYRASlyQKm/d7F6nTe757IBhPcS30xLiK+wdWigfFfH6VpW7nuwYVSoPFSIX/Ibk9KSUCfqcjmfVb7+m6PN/Wl9mGqa2qn8Z2gPs3ZCaXBu+HxcJ4DeJmmVDm3vI7z4xFhWGeIAqTFe7S82oIuyAcpbdUpAK+Map2dN0gusiharHHHfKwW4bZBhg9XKhRHs52hOjfrm6J9tf5o7hYhEXEBUK+LDTGW24/PcHT2WibM+HyT HC7M7N6Z 3pvlDwgU3DrP0YR5anpRMhbmnUnHhrVqXkjMOQcjVh5fK8iCTTK9dc2Gnc0R8pJRiR44SN0dmc/6FkQSrLpCa6wOp5kJvNrBOr50B5KIeA9d/XzQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 02:12:37AM +1200, Kai Huang wrote: > + /* > + * The TDX module global initialization only needs to be done > + * once on any cpu. > + */ > + raw_spin_lock_irqsave(&tdx_global_init_lock, flags); I don't understand how the comment justifies using raw spin lock. -- Kiryl Shutsemau / Kirill A. Shutemov