From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8851EB64DC for ; Tue, 27 Jun 2023 09:49:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422DC8D0003; Tue, 27 Jun 2023 05:49:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D3DB8D0001; Tue, 27 Jun 2023 05:49:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BFE8D0003; Tue, 27 Jun 2023 05:49:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 19F568D0001 for ; Tue, 27 Jun 2023 05:49:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E34C11208A5 for ; Tue, 27 Jun 2023 09:49:13 +0000 (UTC) X-FDA: 80948054586.12.C64E876 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 3952EC0015 for ; Tue, 27 Jun 2023 09:49:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cHHIs1k2; spf=none (imf22.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687859351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WnC3NK8TL2m+g/yhyFAMWAopoDpUDdOFtpoQiieeXjc=; b=BcAXRiyrw+Q5S9eevrr5W0VIoa5yb2j4rEBCaOYxcdiXQ9kO7vUinO8aYTNdF1fyvVyd5p V/aIhjqR1UubYa1n0uCZt6erO4XoiMB+PCrhD5Kgwx60qrA/br+WhxdeMIg/148q7WXrgK UbGaBM/k/ppre9FWE4IG6JSNNVhtX/I= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cHHIs1k2; spf=none (imf22.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687859351; a=rsa-sha256; cv=none; b=lzh/LR/SSzw1+3lV7IWa2GVkZo05iOl3OHlmO/vsEZRA86wtRGKjL9JoSDmoTEynx1xBus WKKuD+crSBX7uuqPNpja7Cbx5fz+Hqj8kOlD0Evd++daf+AFSJwfPGSEaEW3YUTNOV7UyK zg1FNkre/QFv8SlwuEHyp+iD6ADaiRo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687859351; x=1719395351; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+Cd7Gb/cSfWMtYaqI4IIQwz8koCmdUbWenXmNDuGS04=; b=cHHIs1k2euYiTS6kOt8rKlU8TUL1ckHoo2alRh7RPjwSfXIjL3S9IHfm nplgfj/S52bLaHMBam/cmVhAEuUBocpRBrUr0GsB3S574thfnQcUj0Vs9 UtuJI6g0/tFda5Bxtbp2HqViKNHACl5n8HHJV2bJP/kkM67thFBAtLK3D RBksjtD9wmZhybyx6no5SS66isQMOaNG5tCfK81cJreeOJ8HfqAPTZRgW xI3WQyjm+a96e+rNH7Oh3UHqCdH3XjGmPdDPbMydD/uyuGQWEOCZUsvCX XJ+3HQuov30gJKe/DmzX1HDcz+Jg6OcAO+DZIDD4um32eKybq+2SUZlV1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="447911630" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="447911630" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 02:49:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="719719700" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="719719700" Received: from rbhaumik-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.217.121]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 02:48:59 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id D342F103732; Tue, 27 Jun 2023 12:48:56 +0300 (+03) Date: Tue, 27 Jun 2023 12:48:56 +0300 From: kirill.shutemov@linux.intel.com To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230627094856.6udzuhzhygc4nzit@box.shutemov.name> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3952EC0015 X-Rspam-User: X-Stat-Signature: gys9mh7yajak3sw6s86gikxzktfg5doj X-Rspamd-Server: rspam01 X-HE-Tag: 1687859350-635224 X-HE-Meta: U2FsdGVkX1+WTLC3GITeDTGXpOev/fDI3WXmWVbbxE4BRFy3HMCLFwyX3qYSlrkEYF75EvDmnLVdUDz4xEwJnY+fgI+XkZ6E9baw50FcSrFFsI0wj+BPIGyoIOVlkiMAG+oia8hROa5Ilhv0EgT0iIWnan9B0RLV9RdKa8zINo4RByVo723ggFJpILh26i5pFwaooX5StEMMO5vXN8lj4gzlZLFwm9gxDYS57U3e7RdCPkcxtao3MxR3H+t1D1YaOvydEE7Rx1TXf5YRRjAytab1aQMh8FYazJmD3JFkPmL2ZYlsF4jIiEsvQ5NX24lzs0RoZg6b9yoTpwJ4tLBOgw/O5GoUUHM8TnugN+ziIyCB6QkoZNsst/MJWXNeaicrEsUUOnq1Wkp6zw47MWLK+eUBJqx98dgIdbG9UziOX6/YoQ+a3jpgEqX22rxXE5LNSxQKwelW4Od7oOnSigmuKyacf9mzf9900odwA5erklrCMMPZVUOw4QYC7OEoXsknYx/okkwlCINn0AWhG2dzA/ttlE+LebmbgDBE/58fX8/TtcBBwjqHCqUK37xNbvE3jLVK0blplHXRsvLK99y9QY2uYGZXg6Lmyk/ZgrBWfIwyuVTkbAw3G+XWE/Mc/gLgW4i2C3Ck+6xMs54CE4uhhg4niHy8htOmdOfgXwqbP9rhF3gZCi/JvChCdFt/5MRZvoh3hQvj51FbMUk4dRD+mkPjmIkZ7kwRAlSCRfOtDaGtrEWIhm7Bfj08OVu9tjTnap+Gkdq6xOE/0CgH16BhAatUrFRo+b1IxCTKZKWx6O59KHAhsjaf2KA1TfVSWV3a0H9JUs1JbXW4bi6iwz5NG4meHpZCIUQK617I6WB5BuGN8oSec2/lEZuc0nztrxL5v47eBnhcpqIolNrvuU6OLkZEo1/C5TjAUX17U41pwRWVnt8oTf50PIuD3puxoAyMRDtRXhS9OxVKGoX9jaY wYzsTuBh 6vhijuwkf+4D6fKPRRoj89uZDdr4HLGTfzy6EvEeGzcJEzQ5X7zfYbTG6PcMnOuPrIKnnJLQVr9/Pq+BC0lPhUvY2rXf4U6kckjJ+K+PMsNj/8Ek= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 02:12:35AM +1200, Kai Huang wrote: > +/* > + * Wrapper of __seamcall() to convert SEAMCALL leaf function error code > + * to kernel error code. @seamcall_ret and @out contain the SEAMCALL > + * leaf function return code and the additional output respectively if > + * not NULL. > + */ > +static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9, > + u64 *seamcall_ret, > + struct tdx_module_output *out) > +{ > + u64 sret; > + int cpu; > + > + /* Need a stable CPU id for printing error message */ > + cpu = get_cpu(); > + sret = __seamcall(fn, rcx, rdx, r8, r9, out); > + put_cpu(); > + > + /* Save SEAMCALL return code if the caller wants it */ > + if (seamcall_ret) > + *seamcall_ret = sret; > + > + switch (sret) { > + case 0: > + /* SEAMCALL was successful */ > + return 0; > + case TDX_SEAMCALL_VMFAILINVALID: > + pr_err_once("module is not loaded.\n"); > + return -ENODEV; > + default: > + pr_err_once("SEAMCALL failed: CPU %d: leaf %llu, error 0x%llx.\n", > + cpu, fn, sret); > + if (out) > + pr_err_once("additional output: rcx 0x%llx, rdx 0x%llx, r8 0x%llx, r9 0x%llx, r10 0x%llx, r11 0x%llx.\n", > + out->rcx, out->rdx, out->r8, > + out->r9, out->r10, out->r11); This look excessively noisy. Don't we have SEAMCALL leafs that can fail in normal situation? Like TDX_OPERAND_BUSY error code that indicate that operation likely will succeed on retry. Or is that wrapper only used for never-fail SEAMCALLs? If so, please document it. -- Kiryl Shutsemau / Kirill A. Shutemov