From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE507EB64D7 for ; Mon, 26 Jun 2023 21:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1F218D0002; Mon, 26 Jun 2023 17:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECF3F8D0001; Mon, 26 Jun 2023 17:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBD988D0002; Mon, 26 Jun 2023 17:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC69B8D0001 for ; Mon, 26 Jun 2023 17:38:45 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9E2B2120861 for ; Mon, 26 Jun 2023 21:38:45 +0000 (UTC) X-FDA: 80946213810.21.2C5D8FE Received: from port70.net (port70.net [81.7.13.123]) by imf28.hostedemail.com (Postfix) with ESMTP id 964CBC001C for ; Mon, 26 Jun 2023 21:38:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of nsz@port70.net designates 81.7.13.123 as permitted sender) smtp.mailfrom=nsz@port70.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687815524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vd4fbVU+bE4Bae5nF7RsWxeVw9nw5j3BhVoW+lZoxfw=; b=epvztJBkjzVLClHsfMgUCu1k58BBvP0gS+Vauns0mcUOw3Ms014UjHfWklzYsye/aceoS5 OM2ZRMzWDB3rvUHbcR2Kd+5gpxjDdKNAtjmuRLL04qEHz7lzkrUY7PR4qrf0kurLQ8DuvX wvKutK3nNj6CdOTODX7Nfs9MLmixwrI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of nsz@port70.net designates 81.7.13.123 as permitted sender) smtp.mailfrom=nsz@port70.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687815524; a=rsa-sha256; cv=none; b=42oAdh5a0+Dbh/Gjdg2z5mRxUc5+oSSEzGrFPf3sCgw1IriVV82A9tePPWLv16p+0Nv2I7 OWGeUqsAvU3fk6e4DZ8n3qOG1Xr/i58bVyofq55OiS/nq4jNmabzPCQq7PLa73qD4otina YxXoCa1mzXCSZi0yR+7zxzUAjpiQdxk= Received: by port70.net (Postfix, from userid 1002) id A4A2AABEC0C7; Mon, 26 Jun 2023 23:38:40 +0200 (CEST) Date: Mon, 26 Jun 2023 23:38:40 +0200 From: Szabolcs Nagy To: Stafford Horne Cc: LKML , Linux OpenRISC , Jonas Bonn , Stefan Kristiansson , Eric Biederman , Kees Cook , "Jason A. Donenfeld" , Dominik Brodowski , linux-mm@kvack.org Subject: Re: [PATCH 3/4] openrisc: Support floating point user api Message-ID: <20230626213840.GA1236108@port70.net> References: <20230418165813.1900991-1-shorne@gmail.com> <20230418165813.1900991-4-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230418165813.1900991-4-shorne@gmail.com> X-Rspam-User: X-Stat-Signature: i66j4e5f6j36rqofyiko5gyj4g4n3hwn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 964CBC001C X-HE-Tag: 1687815523-38064 X-HE-Meta: U2FsdGVkX18ZhkBxIioSMzSCKCvAwbKr/tlUZ4/BCFOXeiI2pMzIAcD3LhlrAZbK4n5SWYrZBlhUVcYFWaM6HF9/7IB86E2H/topwue1tTX1vkD9/ft4Wixkn135vxOzbqKkBS99h5r6yD45WIlD7aOu0aS7dfPBxEY97BuEN58h0w4MSuN8CfUtkvaMjwne0VTnvmY2HREn9yYpK1o7lMt0xvdkzS7N6EwfJaeuVBOR7mPXaB9og3a0k/T5o9M5C9+qGvIJQL+RvF+qU97xaJ+C6Z+qfDK2DUFpDPCM+v+IBjMuk8X25t8fj3jBATqZb2D7HdtKCx+qurCD0nxeDlOREwfQJp6IU2McHybVsIcFYpa1BsdP3++G0Q61lISu70+EPYaRIZXEk5O190hbPihxsz8FFXCnsL8ShIeJld3svcN0N9GtG/P3fpFEdMfeTT4aPmSm5pwEwRFBFAZB+vWnAHy+q1zxrgeM08TIFHyrv4Py8AyeTTZW16kW6fIydg00dG/qv+nDXm3pzFItQ3A16PrLaP+cswDQ5ZBu4zhARXy7gas7hsuCw+pTIKiC0PrJyOTEYD+Bvdy4oQ1veGHOwpD4fykrgi7y7liq2qIWGaIoD0uowaRyQwW25cLosKOydUrHVqkwoeUYzgkMNloXaWHDXRCCLIhGoyBGMrLpZn75ee2TYGWmiaw/aIVn075TTUh7yT9MUz7Y/3O5BcFUI38GmShknVK3diiPsjasBBRdoEO5SgAQwOZVKq2OyTZ4QIJ5sSD+WwRMEenu1x/fcfICmDVsNYkAcPG/qQYFJjzkvHCg3mOC42HCF/1vTmSg7OSIgFBw17YhC09BYTkeZExAk64O8IWXoClAcBym3brGZk2FwWs3JB1UzRQNzJRNkh5j6nUc/Tkj2E3t27dJNxL0yFfT4Fyl6cNQUYFuHy4QEBke9jP4/95/E1QVwQDMxJD2ikS5BGwThZD LtWmS7wL +JeqcOBoejGy+C8vKdiWTQjJT+ixeTcRB2joEQI5YE4r9pLhd+xUshNQ9nnfDpZM7RWbe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Stafford Horne [2023-04-18 17:58:12 +0100]: > Add support for handling floating point exceptions and forwarding the > SIGFPE signal to processes. Also, add fpu state to sigcontext. > > Signed-off-by: Stafford Horne > --- ... > --- a/arch/openrisc/include/uapi/asm/sigcontext.h > +++ b/arch/openrisc/include/uapi/asm/sigcontext.h > @@ -28,6 +28,7 @@ > > struct sigcontext { > struct user_regs_struct regs; /* needs to be first */ > + struct __or1k_fpu_state fpu; > unsigned long oldmask; > }; this seems to break userspace abi. glibc and musl have or1k abi without this field. either this is a new abi where binaries opt-in with some marking and then the base sigcontext should be unmodified, or the fp state needs to be added to the signal frame in a way that does not break existing abi (e.g. end of the struct ?) and also advertise the new thing via a hwcap, otherwise userspace cannot make use of it. unless i'm missing something.