From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85BAEB64DC for ; Mon, 26 Jun 2023 00:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF7AA8D0002; Sun, 25 Jun 2023 20:52:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA8C08D0001; Sun, 25 Jun 2023 20:52:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B97918D0002; Sun, 25 Jun 2023 20:52:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AB0CD8D0001 for ; Sun, 25 Jun 2023 20:52:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 780411402A3 for ; Mon, 26 Jun 2023 00:52:33 +0000 (UTC) X-FDA: 80943073386.12.6FEF825 Received: from out-21.mta0.migadu.com (out-21.mta0.migadu.com [91.218.175.21]) by imf25.hostedemail.com (Postfix) with ESMTP id 7C1DFA001C for ; Mon, 26 Jun 2023 00:52:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tfsfO6Mi; spf=pass (imf25.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.21 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687740751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qoYCAJIdfBs09Y+PhvXcvipTrQRMfcPWXBW4aaEX1D4=; b=dxIJnNHOLeUx2HzfbWsCa/sUD6EGpjJj2oKLRnTDhfr9G7LAoMrKo+2z2qQVz3VALaBCgK 2q75sYWpQNSPJOaOPkestt2oz1y+MaWPBwgIndS8L8BlRN0XtnF/1wLVMBOhhReCOmba/0 apqjqdcDMuVKr5GnzvlY/kma+yyS7b4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tfsfO6Mi; spf=pass (imf25.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.21 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687740751; a=rsa-sha256; cv=none; b=kY3n9NKW/JW0jW0VOZw8soUAW83oLlYdXTmrxg6IAAKvE0dxzWTujXPj3WxhGiBpEC/o6X 4ddqNrWhnYuGRjn643QOKJLRHPZj0L/6HxjvJrq7hjqfayyNjiiBzEwBUyQ9cFBKX8yxoU yzBbOa4oRGoJDJ47eFczYmpd0Mwtk0Q= Date: Mon, 26 Jun 2023 09:52:21 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687740749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qoYCAJIdfBs09Y+PhvXcvipTrQRMfcPWXBW4aaEX1D4=; b=tfsfO6MiSP9RvTHVaGudEvTI07o3baUhBqbh56J/KDWzBNu8X55HX4j6b6R2AKA75oSBP1 +Q8+F4nXxkhGnX2O3vUKT6LetaF3iHmrMV1MgbjjjBlPkIvYq+fRS324yHW97j5W79iVDr 3YrbLWuFJvT+GZV8vkAig0AtLEXGL/8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page() Message-ID: <20230626005221.GA353339@ik1-406-35019.vs.sakura.ne.jp> References: <20230625113430.2310385-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230625113430.2310385-1-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 7C1DFA001C X-Rspam-User: X-Stat-Signature: a3giqoxre3s7iooq6zxq7wapmb33iidp X-Rspamd-Server: rspam01 X-HE-Tag: 1687740751-280891 X-HE-Meta: U2FsdGVkX18PxEnkxYUd1ZW29yvwOEiebffYrUkZPaQyaWFr251sBtn65FNeA8pPYBDisrXgGta3D4rA0hp+uoLL99CS5j/1pJluZF8eY1fPAXeZOWr8ysLCJ0ppabuNpI2FgHhXI506xnkkrciA7jQfpB0TRVR3B67bb9Q/wBHWnZgy23vft+ciGD8vprP6ImIKQo6EG0iwDYb0OFTpoyE6foM4uUmOoWPuQxNutrHNoftFA7tzPHAaN4J234Qua04Vl13KrIjfJx+MEhsCcMBxRYa5/PvRLAcVkT7ABugo6E8vjN9zo7co+ojpIE70nDVmS3AJuUn6ZQiJyNlGv6AejTuLDQRhL056oq34t6QHKQZFRhre7+Ul1vg02uzTqOmrCubxET6h1BpncHgq36DVi6TLyCkY3WMt7AmmNgM0X6SIerZSKw2Qb/COxybVdJaYQlGDkKo0F8BKralvvVLtuawSwxUZUgmtRTuW2Htjdt1HdDgRjdrB3XQOQZCuGt5v6AOn+g8nceXpqQbSI1M0mqMeultvScpco0UsooJo9M51O3u/AGSle6IznANb7DlUKmmaUnp24TaoAGXFHtkEoOcPQMsChQHL/IUIIOHhSikI8/aPm16tvHVza5Hu6jX4BIMD6AuLJGQ6eF5MZWbDfPoGsoVDCTq4au6Zn7hSyJrzWHlN9aZyV4fiB8Ls83k6qdlxWEXT8trmy+nBcHpjpUrd+w/zLrA3yIM9bTrT9EBqElEztYihaJLpqw52LmcAyceLBAXee3OsA0WQ3DvZu2HmLOD5D40J2Q+pvhPMNzDJ0mK97csRLtNkX+4nixLHANyq8VjaaNBGZb+fckH0rVsPvKxg7pQcXxhSweCQMn7wGh/nYvDIVUgX90K2iOe9jhjTIwGQ8SeeOMNYa4AeJ7M2diMgvXTZuCIhi/c2xDAqVdDcHJ9jmg0lRxm/afVm2MG1q8cRPNeJ555 Q+LC4JBr bmmoJzsE+P2HAHDePCnv0zT/1IYgjCean5ANKTjTyZXuirN/BgOvjVhJY8bibiucsmxegKPGdnApeay26X9kLH3Za4AY4eHq4EMfCUj3QbqOrx6r79p1L4BEC9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote: > Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches > are not shrunk now. This check can be added back when a lightweight range > based shrinker is available. > > Signed-off-by: Miaohe Lin This looks to me a good cleanup because the result of "if (PageLRU(p) || is_free_buddy_page(p))" check is not used, so the check itself is unneeded. > --- > mm/memory-failure.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 5b663eca1f29..92f951df3e87 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -373,11 +373,10 @@ void shake_page(struct page *p) > if (PageHuge(p)) > return; > > - if (!PageSlab(p)) { > - lru_add_drain_all(); > - if (PageLRU(p) || is_free_buddy_page(p)) > - return; > - } > + if (PageSlab(p)) > + return; > + > + lru_add_drain_all(); > > /* > * TODO: Could shrink slab caches here if a lightweight range-based I think that this TODO comment can be put together with "if (PageSlab)" block. Thanks, Naoya Horiguchi