From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: [PATCH 2/2] zsmalloc: move migration destination zspage inuse check
Date: Fri, 23 Jun 2023 13:40:02 +0900 [thread overview]
Message-ID: <20230623044016.366793-3-senozhatsky@chromium.org> (raw)
In-Reply-To: <20230623044016.366793-1-senozhatsky@chromium.org>
Destination zspage fullness check need to be done after
zs_object_copy() because that's where source and destination
zspages fullness change. Checking destination zspage fullness
before zs_object_copy() may cause migration to loop through
source zspage sub-pages scanning for allocate objects just to
find out at the end that the destination zspage is full.
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
mm/zsmalloc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 5d60eaedc3b7..4a84f7877669 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1620,10 +1620,6 @@ static void migrate_zspage(struct zs_pool *pool, struct size_class *class,
continue;
}
- /* Stop if there is no more space */
- if (zspage_full(class, get_zspage(d_page)))
- break;
-
used_obj = handle_to_obj(handle);
free_obj = obj_malloc(pool, get_zspage(d_page), handle);
zs_object_copy(class, free_obj, used_obj);
@@ -1631,6 +1627,10 @@ static void migrate_zspage(struct zs_pool *pool, struct size_class *class,
record_obj(handle, free_obj);
obj_free(class->size, used_obj);
+ /* Stop if there is no more space */
+ if (zspage_full(class, get_zspage(d_page)))
+ break;
+
/* Stop if there are no more objects to migrate */
if (zspage_empty(get_zspage(s_page)))
break;
--
2.41.0.162.gfafddb0af9-goog
next prev parent reply other threads:[~2023-06-23 4:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 4:40 [PATCH 0/2] zsmalloc: small compaction improvements Sergey Senozhatsky
2023-06-23 4:40 ` [PATCH 1/2] zsmalloc: do not scan for allocated objects in empty zspage Sergey Senozhatsky
2023-06-23 10:49 ` Alexey Romanov
2023-06-24 2:29 ` Sergey Senozhatsky
2023-06-26 10:54 ` Alexey Romanov
2023-06-23 4:40 ` Sergey Senozhatsky [this message]
2023-06-23 17:03 ` [PATCH 0/2] zsmalloc: small compaction improvements Minchan Kim
2023-06-24 5:00 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623044016.366793-3-senozhatsky@chromium.org \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox