From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46185EB64D8 for ; Thu, 22 Jun 2023 08:48:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D65188D0005; Thu, 22 Jun 2023 04:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D13E28D0001; Thu, 22 Jun 2023 04:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C02CD8D0005; Thu, 22 Jun 2023 04:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B25B48D0001 for ; Thu, 22 Jun 2023 04:48:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 85BFE14099F for ; Thu, 22 Jun 2023 08:48:41 +0000 (UTC) X-FDA: 80929758042.30.BEB8017 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf04.hostedemail.com (Postfix) with ESMTP id 5E0A540015 for ; Thu, 22 Jun 2023 08:48:38 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=brWKti51; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687423719; a=rsa-sha256; cv=none; b=4poGcqZwLXsQ0Dp1VZi3mBeTm46+i/nO6fFAPV99cfA2JhD7Colv6zUnYe9i5+rYLUN+/Z IM/BhF/5XfH+QRk2HpMHTLMYaCckHWVXmZOvUKGZyjKFZFHHFaGb08hoXA3SpB/8TjX6iP g2gQbPwbAFcUkyDW9ncmkj5bgXMt0N8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=brWKti51; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687423719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=mrA89yM+bAMKJMAOe42Qqu3f+tWDi9Fz0BaeXbN5joM=; b=ieK+SdOAwRyzjtmv4mxgRXHJ5HIHa6JKCV8/gNGXpCgZeCLuT+2fi8MM7EpphuibhTqxrG /kOOPBFtJl4PtQsFAgxdux+KRrBzqMdsmxLy/FkIWO4y2lFRpPcGxUpK8YSQD4Gpodf3L1 S0IH1Yo6uyDpE1wFV4UoTAbZXP6+kmo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687423718; x=1718959718; h=date:from:to:cc:subject:message-id:mime-version; bh=bmWy+xKkAXb+rnaBiHU4mcOtkFvUlGLwrnQePFdY2+s=; b=brWKti51GK0TeVPI2L422w3ZlwihX+72NqYRJzTls0Yb3oUWSza9UMjt YyFVDnQUQVz82rsUrbF/clzrxW4xg0IykOdMlbuy1pQL+tT+k3NSc74q7 L/FnfMoBuUJxyiImqR9anl58baO32mpKCyVsFq2oaQcKw9MlVukTV7P3G LrdCuHm4rlQ2NJo3UZ4C3SlyKPJEg5TGrfnRLDii0OlgmrfND2pPL9Fkq 52rJBlQXFbp9PRfQz7B1VfqKo76uVS6W9oseNWle4oeYfrpjS0UdJ8mh/ yMSIoUuRB8Wlx8BEvJBDuAh2tKCmKQErxG5rNJiRH5gHjnrLwo0dGp4jS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="390108911" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="390108911" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 01:48:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="838950468" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="838950468" Received: from lkp-server01.sh.intel.com (HELO 783282924a45) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 22 Jun 2023 01:48:34 -0700 Received: from kbuild by 783282924a45 with local (Exim 4.96) (envelope-from ) id 1qCFzV-0007SN-2y; Thu, 22 Jun 2023 08:48:33 +0000 Date: Thu, 22 Jun 2023 16:48:03 +0800 From: kernel test robot To: Mike Christie Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Martin K. Petersen" , Christoph Hellwig , Hannes Reinecke Subject: [linux-next:master 211/11867] drivers/target/target_core_iblock.c:892:30-35: WARNING: conversion to bool not needed here Message-ID: <202306221655.Kwtqi1gI-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5E0A540015 X-Stat-Signature: nbqd1s9atx1nz9s1yqgq599y6i6sudis X-HE-Tag: 1687423718-139950 X-HE-Meta: U2FsdGVkX1/xRuJOd/Nc8Ae+WxgI2UCPZm/NQUkKXEiQ4IOngFNvG4L+RQrv4rgmYUh32JyF6cMm9esOY+TQUIxrd3v9Zbianxyw92Cy6s4B8DJAd/14vaBXMOSMVhpDh3ykXraaRDOToZw9tI1CVwd9LV+d6ZiQn9SLeRQhMEtsREF3wlWm7j1nLSG6DusxyFJyTMe0djSwlI8O/3KPR2+cyo+wagWi7yoK9mAHh50h+rN2I0z9lmTJ0zk8WUR5J4WX+1sEU58qYZOhZn0+coWjQvrul0H+khOskKgAd304M4cpB1a0RDj3HU52GuP8Bn457KdAhkO3vLaqweeiEW2lxfi86hIcOMeQZBc6qmCvzM/ASZ6f8sYUcoWPA8TqUJsMLcFNzl/Yl9GRMW+yPzCGViTjVGLPALdasEqYyAQtIJc1/ph8ny9Jyw/eN1hwW1DXbVfXTwwWQ6DJa8A5vWxL1nLVm+xkk1/nrc899C5aFooWzMl9YQ8qsBmTgyoxI3HlXNllUkRw6ug7YUiSgx87xg+2lQojBZQn/Bi6Sv0AIyT5giAQUlswj9ROPBobglGCx0eGsSgjyDuEJ700Tu+ZqQb1VnIXvR9dZM/uaM0/kc6VBfWms3h7OwqZnrhRMj/TNfls3N0XvAWHiPMU9iJh5Uy2mK60pN7IPAwam3wGSbjWnApkNV2zkTE2xKG4TKExgbfSIxw25n8ELbgSIgPMgLB1oDeysd3cesU9LMLD6H00LChDCYo7JgA1T9cu4TVKSU5YSbuNAl5LxiYq47X6gq5AEEiv/WtICGpVAwOQy80I+0UkzXDwO05YLlZ8UnRvUV+fJ5Iz6yFElU1yANiFo4tDzAtWX7Bk+B9+1o7wU8jl9svtO/CndOCgk/1WnVqLO6wsengIWrw6DbiLN4bkRRs5/0P2oGhl4JVhArrKnOI6DlRzaCcwnvinm/Zq0FWQkLRiKGtJICJndWt GAdMao5K 1m+cs79Ssr3klwvVGoq39xEB2PGRaU6KEOyHdHyzERYZfEFCoVpvC+tyDV4ueMLOu4oTz4Zy0rkPoYikDkkoGMi078rO7dAvoMjMmBA4hoIPGmL3o+fMQ4Uj1lN9vDz0qTsirNHUqFcjKeFMIvI5fMEbJnFKg/2DV6YZt7KHI5oL167AI79QC3zEtRcS07o+P3e5boGmOrcLb0TqczctAftC74P9igKWVpN6i2PrNaSKEZljmrdTSAEBWi/S0rX7J8jK2LstaVB5TTccudKfdSqkleqJPvy0NTvo+6TOpag3qj7fnF5a+m47M9Inzfuf1PFRM3YriSUR7vgsL7dyOi5RubbcR1q3whu8J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 15e71592dbae49a674429c618a10401d7f992ac3 commit: 394f811848827ad23d2b43e94e5d72a24cfbc39f [211/11867] scsi: target: Add block PR support to iblock config: sparc-randconfig-c003-20230620 (https://download.01.org/0day-ci/archive/20230622/202306221655.Kwtqi1gI-lkp@intel.com/config) compiler: sparc-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230622/202306221655.Kwtqi1gI-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306221655.Kwtqi1gI-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> drivers/target/target_core_iblock.c:892:30-35: WARNING: conversion to bool not needed here vim +892 drivers/target/target_core_iblock.c 837 838 static sense_reason_t iblock_execute_pr_out(struct se_cmd *cmd, u8 sa, u64 key, 839 u64 sa_key, u8 type, bool aptpl) 840 { 841 struct se_device *dev = cmd->se_dev; 842 struct iblock_dev *ib_dev = IBLOCK_DEV(dev); 843 struct block_device *bdev = ib_dev->ibd_bd; 844 const struct pr_ops *ops = bdev->bd_disk->fops->pr_ops; 845 int ret; 846 847 if (!ops) { 848 pr_err("Block device does not support pr_ops but iblock device has been configured for PR passthrough.\n"); 849 return TCM_UNSUPPORTED_SCSI_OPCODE; 850 } 851 852 switch (sa) { 853 case PRO_REGISTER: 854 case PRO_REGISTER_AND_IGNORE_EXISTING_KEY: 855 if (!ops->pr_register) { 856 pr_err("block device does not support pr_register.\n"); 857 return TCM_UNSUPPORTED_SCSI_OPCODE; 858 } 859 860 /* The block layer pr ops always enables aptpl */ 861 if (!aptpl) 862 pr_info("APTPL not set by initiator, but will be used.\n"); 863 864 ret = ops->pr_register(bdev, key, sa_key, 865 sa == PRO_REGISTER ? 0 : PR_FL_IGNORE_KEY); 866 break; 867 case PRO_RESERVE: 868 if (!ops->pr_reserve) { 869 pr_err("block_device does not support pr_reserve.\n"); 870 return TCM_UNSUPPORTED_SCSI_OPCODE; 871 } 872 873 ret = ops->pr_reserve(bdev, key, scsi_pr_type_to_block(type), 0); 874 break; 875 case PRO_CLEAR: 876 if (!ops->pr_clear) { 877 pr_err("block_device does not support pr_clear.\n"); 878 return TCM_UNSUPPORTED_SCSI_OPCODE; 879 } 880 881 ret = ops->pr_clear(bdev, key); 882 break; 883 case PRO_PREEMPT: 884 case PRO_PREEMPT_AND_ABORT: 885 if (!ops->pr_clear) { 886 pr_err("block_device does not support pr_preempt.\n"); 887 return TCM_UNSUPPORTED_SCSI_OPCODE; 888 } 889 890 ret = ops->pr_preempt(bdev, key, sa_key, 891 scsi_pr_type_to_block(type), > 892 sa == PRO_PREEMPT ? false : true); 893 break; 894 case PRO_RELEASE: 895 if (!ops->pr_clear) { 896 pr_err("block_device does not support pr_pclear.\n"); 897 return TCM_UNSUPPORTED_SCSI_OPCODE; 898 } 899 900 ret = ops->pr_release(bdev, key, scsi_pr_type_to_block(type)); 901 break; 902 default: 903 pr_err("Unknown PERSISTENT_RESERVE_OUT SA: 0x%02x\n", sa); 904 return TCM_UNSUPPORTED_SCSI_OPCODE; 905 } 906 907 if (!ret) 908 return TCM_NO_SENSE; 909 else if (ret == PR_STS_RESERVATION_CONFLICT) 910 return TCM_RESERVATION_CONFLICT; 911 else 912 return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; 913 } 914 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki