From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF57EB64D8 for ; Thu, 22 Jun 2023 14:42:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A22D28D0009; Thu, 22 Jun 2023 10:42:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AAF68D0001; Thu, 22 Jun 2023 10:42:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84D1A8D0009; Thu, 22 Jun 2023 10:42:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 759F18D0001 for ; Thu, 22 Jun 2023 10:42:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2E9CB1C8421 for ; Thu, 22 Jun 2023 14:42:45 +0000 (UTC) X-FDA: 80930650290.20.BC8E5D1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 0E52DC0017 for ; Thu, 22 Jun 2023 14:42:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687444963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEufNZScMSs5MVwG9Ps+h77UK8rEp6c++7KnxZ9ZyzQ=; b=yxcQAteu0gHZ3///SjtAQ+slE9F7Qik0Y8kNITO4NTozQ8lisVRahJ8/hyvCpJLerk/Jzu /vsDdctavuMRo/iHl8LeofAHBe93C+ddioUGIFpmrqu16EKL1Dp6h18xuGpwDslOqnpLwF d0fEjanE90bKS4ldHhKrD89Tizd5/yo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687444963; a=rsa-sha256; cv=none; b=neWx8HBeG5u01/OVEOUiD1QYDE6sAz7S66RC2IpNfFvm8aN5iMNTpUYR5lb9NBqZ3eUPK9 GrGNOszITK8Lv6RxeWaogtm/tuhch6iSchuyv9/UPneF2WtalUW5ivocimSmB3CVZF9rsH mGJN76lkC7yn4M2LFPzyeEuB0clANh8= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDA091042; Thu, 22 Jun 2023 07:43:25 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6998E3F663; Thu, 22 Jun 2023 07:42:39 -0700 (PDT) From: Ryan Roberts To: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , Matthew Wilcox , Yu Zhao , Mark Rutland Cc: Ryan Roberts , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v1 05/14] arm64/mm: ptep_test_and_clear_young(): New layer to manage contig bit Date: Thu, 22 Jun 2023 15:42:00 +0100 Message-Id: <20230622144210.2623299-6-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230622144210.2623299-1-ryan.roberts@arm.com> References: <20230622144210.2623299-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0E52DC0017 X-Rspam-User: X-Stat-Signature: f14pa46r6ziq6ipkb8m49i4nkkp5bowm X-Rspamd-Server: rspam01 X-HE-Tag: 1687444962-387283 X-HE-Meta: U2FsdGVkX18UY5rG3iEPjb7V5th3DkewUSkZqQVF+yaeRvnQ7BGu2iCb6+SzZOiExc+Lw6YmCw/HeZkiZfTwrDkhAapjt9qo2EEEo1wlLI0xY/lMN8CwbBwWmQo3B+XNS8tkqAIO3494VTsdMDeolMinxCXETDoQ998juVsJnTXcayMEjgJH678FHs7gbjNCT7yBQN3H3O8Xg7TCmSIs/89/7G+8ljPlB+jc+EGDYNMi/RF4ptpw5Np7PghoyHV/uKB8Z+Bh0ceTe7YRSNsHCqHdIZcRDVFuRHPavMINRPaPI7M/1UyvwpWZTxgdep4GRtAJIQ8fcDuQomXlKm0kS8E1e9ChPqVYPRVnQqLnD31QwRos2blGY/y17aXSLs6XdHJ18WWK5TblabCbCya4v+59HdSjUpq1wjH6hirz1V1RfACHIXPGWQ4SKBMLk/ALBiNPX85jqkyknqS3PztNdPqzDmK0Dqsixm16OwL6hmBI+7io8F8JjdOkEGPQJ5k9UtHINW7yTXreLSkFgSWB497gz+snoIPujm6jPF1Bg/ZZdwQgHmMZJ4/5fdpw+08mktpUubu//ZgyV5n6ztOq2wjUsCbORycxLFMxMKABRmSR7xJNQIdlj7Isz8btdTbMeUeagKiVs8GRtlzWCfuIro830Y1nZ/WuUN2DqwZKBIIWCrjEeAcBOL05+qGzg2mVr3kqQg1gKpVOE25IFR+YggzW84pD9IRoygGDCmpjGaaOAdQtJJrLaX445OSmjCI5mq/PGOw/YlFtSAnIb/dnQu17wRiZEVUyi5RfKi1VNbQI3OX+b7bwUxJ3MjoGqFaDgoUDbnFMdXmN2KsA5ErBGk65XNgB12kHvvdhpCVLePS9aZpxohPctXIeNaw59T5xE+mzbDCwRU8m3MAjbH+KaiwPUJwsRoSNzFKdyzM0Kr2+Pm2RkY3YqtvtxHwOUSlwUTtgFKmIkHEtlwlJ4Sf bwS3fktd glt3kcYW+anbZq/hmbD9EBdYY/Q6lgVw5Qay3jE4x4dxv1VFiPN174KWeVHfRlS/IzX9iQQR/gMcvlSs0MNVDz+uklQTvKPX11Bk2y3BqKhg7mv32HM5QZ+P9FS0srSf+uQErq2oEzLExgCYRspWRiTKUvwBH/1QdHSmVb8z7sWKcDDSuAbuloaA3qVZl7dUCPxMMcqD4a6HWgj2fHsILB/AvVpWTrpWj2bcfNpR4YQWWUN4DA6WxFKmAaKwKhznvVbE5lkT4kBUFVpapPotFcW9uDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Create a new layer for the in-table PTE manipulation APIs. For now, The existing API is prefixed with double underscore to become the arch-private API and the public API is just a simple wrapper that calls the private API. The public API implementation will subsequently be used to transparently manipulate the contiguous bit where appropriate. But since there are already some contig-aware users (e.g. hugetlb, kernel mapper), we must first ensure those users use the private API directly so that the future contig-bit manipulations in the public API do not interfere with those existing uses. No behavioural changes intended. Signed-off-by: Ryan Roberts --- arch/arm64/include/asm/pgtable.h | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 2a525e72537d..1f4efa17cc39 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -887,8 +887,9 @@ static inline bool pud_user_accessible_page(pud_t pud) /* * Atomic pte/pmd modifications. */ -#define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG -static inline int __ptep_test_and_clear_young(pte_t *ptep) +static inline int __ptep_test_and_clear_young(struct vm_area_struct *vma, + unsigned long address, + pte_t *ptep) { pte_t old_pte, pte; @@ -903,18 +904,11 @@ static inline int __ptep_test_and_clear_young(pte_t *ptep) return pte_young(pte); } -static inline int ptep_test_and_clear_young(struct vm_area_struct *vma, - unsigned long address, - pte_t *ptep) -{ - return __ptep_test_and_clear_young(ptep); -} - #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH static inline int ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long address, pte_t *ptep) { - int young = ptep_test_and_clear_young(vma, address, ptep); + int young = __ptep_test_and_clear_young(vma, address, ptep); if (young) { /* @@ -937,7 +931,7 @@ static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma, unsigned long address, pmd_t *pmdp) { - return ptep_test_and_clear_young(vma, address, (pte_t *)pmdp); + return __ptep_test_and_clear_young(vma, address, (pte_t *)pmdp); } #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ @@ -1152,6 +1146,13 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, return __ptep_get_and_clear(mm, addr, ptep); } +#define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG +static inline int ptep_test_and_clear_young(struct vm_area_struct *vma, + unsigned long addr, pte_t *ptep) +{ + return __ptep_test_and_clear_young(vma, addr, ptep); +} + #endif /* !__ASSEMBLY__ */ #endif /* __ASM_PGTABLE_H */ -- 2.25.1