From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8947EB64DD for ; Thu, 22 Jun 2023 20:07:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22BCE8D0002; Thu, 22 Jun 2023 16:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DC1E8D0001; Thu, 22 Jun 2023 16:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4F38D0002; Thu, 22 Jun 2023 16:07:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECC398D0001 for ; Thu, 22 Jun 2023 16:07:11 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 997F51A04A6 for ; Thu, 22 Jun 2023 20:07:11 +0000 (UTC) X-FDA: 80931467862.21.C4EE48F Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf14.hostedemail.com (Postfix) with ESMTP id AEA0210000C for ; Thu, 22 Jun 2023 20:07:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bsirya4z; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687464428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rRceC2Em04Mn9wWhJvKcNrbkdrle685Lc8A6OEbK70c=; b=ritjl9NJxe76cs8o0fDUr1ZDEaS9xqj6iBMf0K+GS9Jg62jdhEkNtMQwUNcwXCiBSUk4ie I+/jgD4EQQpe71PKwFgCSITYbMMiqsoGZ0oz3/LTy0Luucx8Hp2Bge7mvloJIfaqmWJB9i 9Pn2qOryxSV67iDjBmxVL/C/p45po44= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bsirya4z; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687464428; a=rsa-sha256; cv=none; b=3ghUwekC6Tdxnf72Hs7OSWNf85hT9EJzUdwBtUX8EED3O4j/aU6Yh77VqEaL138tx7v0c2 MV7/S1DfutCERpeTl5i3bdRny2FtHZoMbg80aCTFFlYpK9bd7ZymbT1K1d36AF3l8Xts/E 6jClRQIsM6V2I0bHW0qGtlllTlubJFQ= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-25e92536fb6so3845134a91.1 for ; Thu, 22 Jun 2023 13:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687464427; x=1690056427; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rRceC2Em04Mn9wWhJvKcNrbkdrle685Lc8A6OEbK70c=; b=bsirya4zb/3ljIjxpSptQZleePVH2CV1o92QhMq5NxKbXezIIWsrETVcJPExRmrWI0 VHMWYzwCE0iMHi45bkHW3s864nrpv+huGC+J3hhyUhbEK63ZXZrIy9cGbq0A3JZ6CMdm JKUEQOL5VVmno+2HdwPSKy9rHYMCuMBSTbeCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687464427; x=1690056427; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rRceC2Em04Mn9wWhJvKcNrbkdrle685Lc8A6OEbK70c=; b=RhwXn35ZDX4PSezYHzVJanP5/B5yUDVDRLtFlmNQOwG7h6oARUlDXSg2DVF67bk3We UzW+YqznRYQS0sFPCUrmkw909abGNtFzLpiGZ3h79BRZRtzEKBTtMuGje7pm0d8nhQzk L6925vin3cYZ9j8nZs4O9R18ErioBqvdhBUO2ovx72kvEhUW4VfY0nHYGowR71fp3rD7 7xxnb6TDYFOeIEs+35ZGLbREiUCjWtOUkfVNHvrQwmSJuy7qBeI/oY658mZsW38iPbui IAbNn3Xt8KNYkOtx7kmmlmoeqJIV6HBw9aaeJaklO0r4eWE5Jc1g0dTSA52rE0yyFJ19 UZ0g== X-Gm-Message-State: AC+VfDygHGF26nqREKc+0qImPjYmps4tux9nwz2ToJm/FY8+4nEJxeTn N6CGehYrzSYVQD6Y14HE4cZOV7SB+A+qT+p09yg= X-Google-Smtp-Source: ACHHUZ6SuJ4+KH06vVHTEyfMKFigI3xO/NPcNvbNy7RgwL5n4tcxFj7GSoXHgSW2Xxso/W7fTzjZ7w== X-Received: by 2002:a17:903:190:b0:1b1:9968:53be with SMTP id z16-20020a170903019000b001b1996853bemr14191367plg.64.1687464426840; Thu, 22 Jun 2023 13:07:06 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id iy9-20020a170903130900b001aaed524541sm5735306plb.227.2023.06.22.13.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 13:07:05 -0700 (PDT) Date: Thu, 22 Jun 2023 13:07:04 -0700 From: Kees Cook To: Baruch Siach Cc: Eric Biederman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] elf: correct note name comment Message-ID: <202306221305.5F23BC4@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AEA0210000C X-Stat-Signature: brpcsi33b9mhao9y3gba4sm338668s3n X-Rspam-User: X-HE-Tag: 1687464428-233691 X-HE-Meta: U2FsdGVkX1+ekoCquzanVmGyQx+ePhrEj3gb60RuDBaPgX4FzIgkEKqm8jxd+TKEva+etPI2XCw3Qi+dEOoodU5p2UR4CI57S/KzBRUcn30I97AQ3BuvWbP+51T/QFvEOIVCd8uKJi4ghHm3Kfvgt+6cRD1uaFHu1ZeOZ1sK3B6a7Sf0qV4haPne8tC7vWjCUJ1iWMh5V0sWfTkMfr8oBjgBhSUaQEef9e31hXK3lKf8s/XC0n7WOw/NoULHHIypsLn6SQUG5vUfb5puwRsy/K/iByHwy5ne69jufuchc90leA8vFa3FfARsJCdu3SdVbyJq49xgli0dIheSavjxPZhRqZGytsTueqmRdKzKLwdaJueJFVNmf9VMDfmp3O1CP4KME2qo7pybI+5LFjt3vfc4WgtB7XToxZADCfGuUqH6V01TsbEA3EhFEedoEcMBI7qQmbb7y8LScGIBEE1/xPnXUmjnjRQzxzBAH7YK1r/5QVy67ZhtLFVeksl4RLh6GwPHScMYqLFoSIVEBet+w70Qs52CY4cv4aA5123K3vdW2xZnMNhAL/et0hR1Gpq/Pu7m+vtfdsGXH+ZTjAhxAgnA5LUd26YGXZoJdAqZrSm9597HOhR0KQPkgXlC1lloCgTiblJx9uRcX+XOVzIShG9VcFIZgAla/g0qul5cCAwuRkYTYv+A0KJ+Zhfsbd6t6y7XiJDDLsbWIHVIxu8qDn+xkXZq8+5LnXKWVnkJjPAzXsYLvd01/6rH1hoTIxUKQYm1fFuxmiuAgQWV5VwA8FpixeqvS08znLWYMpsy5G0FwRFkv4LeMB4CM931dFZ5gFDXh6FTg7ZBNCwAeyWzK1KPPjaj5/Q9deSBBuoGZ5Io0GmkDV01LQ8geItVicwqJjYJqs7hmFZHZ/9H40aZX9e5WfImyI9WEiaWIps0s9PsDLwMaZd4uCIO4NuY9mSBUFQ1UYoKe8taqea0gw9 l50bt1sK 8bQSTg0a6zw7s/q2W6mmM7ySQQJtGpbUVQZNLaso5kpS6PEHH2uRQhYja09/otGtN7qKEVC8ndlZ4IsVFyKFShrpaduEBpkYfM0ULpb0F9e48nhwvTu/p7za0I84FvYu/Ko/sb9+XMpCLM72WPaV2u4E/SocZ2/UTYSaQtdv4pP7/enOFoIlb0J71dTGEl0u1Xjko8zCxixfHfH+tMYltzR123Z+mH/1YahVxxKBIWTju1Cj2ARFekEHSSFuZbHkS7/cBl7Qi8HxRKKTiwAmb1Phl5xLe9PNO992qwYEP1Y8gY/UrndDJZk6ozfhtmJ6aoYiXFR3JF3pKwSzEU2svSudkWoDezWtuIIz4UUyMcDsmBfkKCyXdfj7sJk+SyP11J19ifsN9f1uET3MZFumWv9hvdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 22, 2023 at 09:02:43AM +0300, Baruch Siach wrote: > Only the NT_PRFPREG note is named "LINUX". Correct the comment > accordingly. > > Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support") > Signed-off-by: Baruch Siach > --- > > Resending in hope kvack.org mail server would be willing to accept my > submission this time. > > Adding LKML as a safety net. > --- > include/uapi/linux/elf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h > index ac3da855fb19..a8a0cced62c6 100644 > --- include/uapi/linux/elf.h > +++ include/uapi/linux/elf.h > @@ -372,7 +372,7 @@ typedef struct elf64_shdr { > * Notes used in ET_CORE. Architectures export some of the arch register sets > * using the corresponding note types via the PTRACE_GETREGSET and > * PTRACE_SETREGSET requests. > - * The note name for all these is "LINUX". > + * The note name for most types is "CORE". NT_PRFPREG note is named "LINUX". > */ > #define NT_PRSTATUS 1 > #define NT_PRFPREG 2 Is this accurate? I see this logic in fs/binfmt_elf.c: bool is_fpreg = note_type == NT_PRFPREG; ... fill_note(&t->notes[note_iter], is_fpreg ? "CORE" : "LINUX", note_type, ret, data); i.e. only FPREG is named "CORE", otherwise "LINUX". Shouldn't this patch have CORE and LINUX swapped? -- Kees Cook