From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5716C0015E for ; Thu, 22 Jun 2023 08:55:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C4CC8D0005; Thu, 22 Jun 2023 04:55:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3753B8D0001; Thu, 22 Jun 2023 04:55:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23DCF8D0005; Thu, 22 Jun 2023 04:55:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 151E98D0001 for ; Thu, 22 Jun 2023 04:55:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E636A12010E for ; Thu, 22 Jun 2023 08:55:01 +0000 (UTC) X-FDA: 80929774002.05.7C17C61 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf21.hostedemail.com (Postfix) with ESMTP id 1DE211C0010 for ; Thu, 22 Jun 2023 08:54:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=E+tFDKMS; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687424100; a=rsa-sha256; cv=none; b=XDBOfINTtbtW2cCHkNvdi71abPlBUZb0qW1rEdECqyoNVvBZW9bfI3ycVkbnR/bYrrVqOo 5aM79Bbxj5cbCA4RF4qzVLaHO1MSqcvAyYu2KlM9sFu4yJXWI/wsVen3bGuZpUpeh74vtV 04Jt3YcepQ6vflTu8b7NGQDCPnyF1+8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=E+tFDKMS; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687424100; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8pXD3DmjPUfWk2+jjA+m+4zKKy0fC+8AwUsZhq2lRmk=; b=k+G6dsxc6ZE3GFRDp1YCWvqMdnbf92QaRgx9kO2OZWlnNRe/OyNPwgXTxStXd9wgBTw4Ap swS4tz0MkpU68vimHg1IErzh4LlNo2EBrqusy4/V4uhuNhXxE9izy6frMnfjLHzNclXOEo 2pDwHxMagx6ZbIuMqKf3RsQsu9RIYiE= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1b5585e84b4so6827195ad.0 for ; Thu, 22 Jun 2023 01:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687424099; x=1690016099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8pXD3DmjPUfWk2+jjA+m+4zKKy0fC+8AwUsZhq2lRmk=; b=E+tFDKMSki037PBhfmhvWVloKXWuzU3Ri56xXQW9hCkunzqr3/MhlEZSqiNZ+tNI9q wXEuj2hNk0ysqFsBunC7adB4hsOSpWoOkzyNHyQickBfIH13Ob7zUzdQVkoowJm+gwHf GqLtSyQYvEY7J6FdTyYJ1xVnKRHg63OezBYT/3UycGb6EQo3xYiC+CTrGWJfn3US3UhJ dbGuvQxkFI38s4idyaP5iHfWFNKc7ZWCaOV72DK+NmzkQO6lFrqKljjPnoN3sVHURF0C M8AH8Js6rxjyGoBC/sNAUYyKjN9tqWo3Nk1SQH9TmJx7zV/vF6Qb8YX+sV5g8XxbHf9I nLxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687424099; x=1690016099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8pXD3DmjPUfWk2+jjA+m+4zKKy0fC+8AwUsZhq2lRmk=; b=Ds2AcdULCpy4cWBsQSSrttbfMnDQpdKPFYF1pLJ78ehfzAe3BQSxtFGojg5yVN/Ifk ymLn1XOyMDs/J8bSFAvP1zT7KLV9NHZ/9ONEKwmrY6lBOb+whehczr0MqzzibcPMS2js Vm1qmne2aEV/GtaMEddAhGuOx/G5mxdBDDAbxa37eXOvgxVtrqe4iElyRHVCOriluAkk mpSWflZfCaViePidrqjau4Tt/MZAIUWJe54JUcRLVReb67vX+JHe4RLd423EpRUUttpA qwzGken73W0tPyLJz325GzbdU1b/nyYVM8fqKC9YJxFMKfQb2xcxckhb5LUTizloDyBk kpfw== X-Gm-Message-State: AC+VfDzZtyNHFiJS9YHRjMagosN9Ikh9eXjkQdZWkWdnvkfZEEKyCiVX 5rWS3lB33qqBcyAB3Ctf9gGyFA== X-Google-Smtp-Source: ACHHUZ6uW4WhSYRgUY2aQCit4ogoH8R/r57rghu14Eyu6d6WG0AvLb+rcmWHNr1Voea08aO5tIYo3Q== X-Received: by 2002:a17:902:ecc6:b0:1ae:1364:6086 with SMTP id a6-20020a170902ecc600b001ae13646086mr21600250plh.2.1687424099018; Thu, 22 Jun 2023 01:54:59 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id h2-20020a170902f7c200b001b549fce345sm4806971plw.230.2023.06.22.01.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:54:58 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH 07/29] dm zoned: dynamically allocate the dm-zoned-meta shrinker Date: Thu, 22 Jun 2023 16:53:13 +0800 Message-Id: <20230622085335.77010-8-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230622085335.77010-1-zhengqi.arch@bytedance.com> References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1DE211C0010 X-Stat-Signature: 585nxf63xtwb8f4y5sa5643gykzryb9d X-Rspam-User: X-HE-Tag: 1687424099-785984 X-HE-Meta: U2FsdGVkX1+IXODUVS4R9xB5u1XsuBBykxzT4ufuo5woolnEO082Fc0ABtTPwrbc/1VLgDTCJsEeRtGcOH47QAPA/zBj/AsjE74Dc2LBWwJvO9nubSJRLXV7kYNNkUphg3L5W4p5Sou1cb9htftu+C8KLZelBATdwGhczwYAXAeu9Teq4oxBIRVXLf8jzhzOh2q1zh9u3G+ayHigy3to1q+rTlv+uuWyjd1KEgPG/Q6feTUlYlpK16cy1TmgcWV+EMo3JEMb68R9dkeX36SZT00EVzQXIt5AgREiNvIkkaDRz2DE7q81bGBGIK44Xiz9iAOqc2toVmb+TWn996FzgWbYLDBMqqJ1NarEKUZDdE4YQdb8WmSv8AoLZ3VeNKhgMUNGwMn8Am4Bc7+xjJ/gALHPlFVU+monXA1A6E3l7xocK10M7YMBJDUvsP551IvUiYfzoXg2hJ+LPmgf//M3mazhzb1yimlxsz49KNrUv7fp8nHLOHOfMUbgohLTDZu6qcTaN2GDee9/2HvlD+U0VzRIOLqtnpng6+OHNXa2jD9zMavpIewFl7KHC2P7NmW48wiaI27HED7b7/wFrP/g8Xga00PQH4ULtm4GhOoK1RGBIL8sZuznX/yF+QkrYafqqhnh8VGvaOpmsPwLvB7IW/LUa03erGqpjdUo7I5hoTqamsePXC8zS5+P1drlAF6oJA3iMIC9Qn9/noE6UfgiPk7l0eXCaeZWP7qOrLPNNNFOhpA2bNbWb8IfHKKSvshxEbCqo7OAIRAe10i1dLGefEv5PvBc2h8GM8koHyS3sTJ4+PXN7gXfR4RrwPNb1oVgeoEjtrRSoyd0JMyc+RrrtDHrVmL1DLVliGqlkCrvujicG5lHbAGihTIHxUByujGXM8M4vgDSo6EERAWblQSF6vbWF2wid9+CMuzcQagjLYYtDLbXfg0ffeC4rKzDXDW+FA+5cSekrsaLWEmF3Ki YlulD2dC jtofaMVD5TfuOXpJQHiZfdRtNAT6deQT6TIsC64sr0geY98xXoZA4q4PtGl7sRUkU9vA/+XI23tojP679FYGRBSvQaFYF9o5IKpwtE76HTRr16Gsb0OIdAZwxq0zKvKbVgijIkuQVEKIHLNVHu/NZQGZi3BOwqiHeR65Sk3VIgr8Cbfwz7aUD2Nah7+5p6wvTykVL8eLKye9TyGncefs98jj8eHbw1VQt4pP0XfcrOq1tk666InAGpUfUsgaGwGO+wvBa7zMO97EM8jl529wewyeI4gv6y8bGYrSsXqrG4YH0O1GBJKk+F3ERXBN2xEYqQGMkIwpMq7Q+kA8CBoMzJ+pPcThlU1kjMaClfxSPjCQEmgvviP32sk81BYrn4e6Wg9pnw9NK6Kl6AJij25982eu+bWmgbGpS+ZUG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In preparation for implementing lockless slab shrink, we need to dynamically allocate the dm-zoned-meta shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct dmz_metadata. Signed-off-by: Qi Zheng --- drivers/md/dm-zoned-metadata.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 9d3cca8e3dc9..41b10ffb968a 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b/drivers/md/dm-zoned-metadata.c @@ -187,7 +187,7 @@ struct dmz_metadata { struct rb_root mblk_rbtree; struct list_head mblk_lru_list; struct list_head mblk_dirty_list; - struct shrinker mblk_shrinker; + struct shrinker *mblk_shrinker; /* Zone allocation management */ struct mutex map_lock; @@ -615,7 +615,7 @@ static unsigned long dmz_shrink_mblock_cache(struct dmz_metadata *zmd, static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; return atomic_read(&zmd->nr_mblks); } @@ -626,7 +626,7 @@ static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; unsigned long count; spin_lock(&zmd->mblk_lock); @@ -2936,17 +2936,22 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; zmd->max_nr_mblks = zmd->min_nr_mblks + 512; - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; + + zmd->mblk_shrinker = shrinker_alloc_and_init(dmz_mblock_shrinker_count, + dmz_mblock_shrinker_scan, + 0, DEFAULT_SEEKS, 0, zmd); + if (!zmd->mblk_shrinker) { + dmz_zmd_err(zmd, "allocate metadata cache shrinker failed"); + goto err; + } /* Metadata cache shrinker */ - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", + ret = register_shrinker(zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", MAJOR(dev->bdev->bd_dev), MINOR(dev->bdev->bd_dev)); if (ret) { dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); - goto err; + goto err_shrinker; } dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); @@ -2982,6 +2987,8 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, *metadata = zmd; return 0; +err_shrinker: + shrinker_free(zmd->mblk_shrinker); err: dmz_cleanup_metadata(zmd); kfree(zmd); @@ -2995,7 +3002,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ void dmz_dtr_metadata(struct dmz_metadata *zmd) { - unregister_shrinker(&zmd->mblk_shrinker); + unregister_and_free_shrinker(zmd->mblk_shrinker); dmz_cleanup_metadata(zmd); kfree(zmd); } -- 2.30.2