From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10025EB64DA for ; Thu, 22 Jun 2023 08:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2DC58D0006; Thu, 22 Jun 2023 04:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDC68D0001; Thu, 22 Jun 2023 04:54:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CE3B8D0006; Thu, 22 Jun 2023 04:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CEB98D0001 for ; Thu, 22 Jun 2023 04:54:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5156340B1D for ; Thu, 22 Jun 2023 08:54:46 +0000 (UTC) X-FDA: 80929773372.16.5611B00 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 5F209A0010 for ; Thu, 22 Jun 2023 08:54:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=bLkRMM1j; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687424084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TQaNNe8oXaUFeFpLguh+yca1iGAODo9pDL1sZw6pJSE=; b=PZ10biIzn40MRR/7ze4EyxlOXlfDyvrt+bahb0p6wl/FxWuStzDy2LObvvJmzFy+0IGpTv CDB+QPipr3ZPUIcskYowgbb50sreC+gt8cTmHDqRVjfa1kUsPWvIGao+HLod4PO2Y60BCF hno78iZXcDxTUBW+2qkwc5qMT8rZXr4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=bLkRMM1j; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687424084; a=rsa-sha256; cv=none; b=dtNDKYZTiu8Vjqtfd4ZWzsxVLxWvgArEfiUqVjXAMf/89qGudgbY6PfcsWOYDedABxN1fq iCUFeuVQTnHj15s4hnnmaAI3kSQA012Ie4LuqS+EOBWEa0XVI5ziyjFXyUekN9cJTEDKCG q54XTa3IXuSPX+FJgfUGDv+Ikr1ZisA= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b515ec39feso12619155ad.0 for ; Thu, 22 Jun 2023 01:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687424083; x=1690016083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TQaNNe8oXaUFeFpLguh+yca1iGAODo9pDL1sZw6pJSE=; b=bLkRMM1jSdqXsEty9KLAFC9vFSq6Mb8s85EPujNxx1fG7cL+WhObUy7eJvjIIVVT27 Kiy5rsYxFdvQkjX/Hn7QfCF/H515sUldxTAV8THo6pKuerK5LdnjnrVU9ezaWAUUfrz8 rV0yX1ewF3SUu27Tytlc8UIGxdmoc2rf5KwQXmt4TN0xZENUrrBpDEpOBdYckFOGmW+/ CnWb/ghzLgegjrSPuJYmDsQVFRVYxO2XxU7X4C2jxwq5osf5N5i/+CYLyq1fNxhJsVCX q//piIl1OJNIHjgKTj8Fx/a4slkfZ5A+zdUvxvyRJBR/16JSIqSsZUTa9z9xdPFzC7nq BhVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687424083; x=1690016083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TQaNNe8oXaUFeFpLguh+yca1iGAODo9pDL1sZw6pJSE=; b=YGjYEE7PIODV/JEsFqA5PCUkBFydfyHE3L3j/qPm2GAX4nHmryZ2wFZOX7LkDRA+hg xztULvHhdWvpkjqydErjbHaNlB6XZ8D63nDhMwPBIHtRCqJmHts/f6fv2yR1yivROi2g SxmniDDlg1v/VQt8MeBD9y4S/M9Qmsm/XHXq/hydBPVNbiBOiLET5E8VgxNAp3FP6bOY cjYehsLNzJDyynFDGa27vRjNATGK5SWOpo4sszp5pfxXAhtHA7QVU+gDOHSHmvfVKAeA r5UROrOWyytqBEbJA5BDD6fcvPpp4XJkBFJEWb7cMZkV3LdqhwdKmjFeUpW141aL8rvZ c8aA== X-Gm-Message-State: AC+VfDw5aXukhy+WDkQagIdtzsq7cF7M+2o4VDjZRphnfD3Ew/l6N83e yNWeZ3cDC2VkCL3HZRomPdM1rA== X-Google-Smtp-Source: ACHHUZ6gH/Pv0NlMjwBsqv6k+8Uik3ghEf6lWW7kovYDQCKB++KLEA1PTcfQABA8HOR66RClg4yAXA== X-Received: by 2002:a17:903:32c4:b0:1b0:3cda:6351 with SMTP id i4-20020a17090332c400b001b03cda6351mr21555341plr.0.1687424083229; Thu, 22 Jun 2023 01:54:43 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id h2-20020a170902f7c200b001b549fce345sm4806971plw.230.2023.06.22.01.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:54:42 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH 05/29] drm/panfrost: dynamically allocate the drm-panfrost shrinker Date: Thu, 22 Jun 2023 16:53:11 +0800 Message-Id: <20230622085335.77010-6-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230622085335.77010-1-zhengqi.arch@bytedance.com> References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5F209A0010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mhym1wndk6ctkxu75qg5mr6ipsnjas3g X-HE-Tag: 1687424084-356487 X-HE-Meta: U2FsdGVkX19cMqr1E1zJVc76M5HdM4YXaqqrJZkptXyBV5kIu9y7Mfga7zK5buYnGvtqx/un8iad+PAw6WkN54YvfTjiiLTb3JSGb7Ig5Qbu3rhWnGHq8Dhce6HwJOyCzZwMvZQ6BjTgC2YLXn3ObGscyFFM2h1LLk+0ZtbGEj1qTq0BtvNcMqZlv0gm2rRIZd2/Wd10+1RGTWY5O0rZTwTciEn29HOIuqgk5gJysWwAFrptad116tQYhvV8EAto1wmouQblSdxrwZ2VM79ye7498RYwRW0lw/RZd/zc2ohlpo9T5ZK/jcRwBALQQYs6pxl5WMCbLBJ7mQBZhDkDfkdgR00lbgijX5mE5/7vM3qD5TjZPWnPdE+4VEPeNQGj32oehVXzYR13Of/UQEhU/Puk6PSpA7InujYAX+IP/F/HAzPrWSt5xe7CAzXN5/D1V6SmPW4Hxyg3rmOShQ5YDo8TVFjyh0B32kww2K6/FxxoPkF7ltguAVlpbNEUZMFm+IsLQE0T5ruduDSJaBERVlVNfdelUtSC0/HjzcLFKHBon9Q/36fEZNBrpG9gfA4Re2FkB2mO7caqGGms3sbbQV0ALfOFt5nAMwh4cUNe8o1vV6wO6zeEYI+7f1GzXBkWwDon9JohjvWF6ZwVbXk7sd+ZiOLEMqA3jGl55es9P040gumNTxr4MmHJRsvdHdvRrUsMoPx/70syaeAwsxEe8rdsBm34bfFSC7wFnE4PsOZrizwIU09Mrifwm2YWRWVpAmUctrNP2SowPjleoQ78zT6oo2ykucy2sPnRYz3t0jG+UdvI347f4siDOhtPrf/RycDOaeNoEwDn0R/Hqz3ub8Fb79fS2lXyaPiPdvnboFi83EhrlfrTdN1qVSReK0xlc99qjxKW0IfEKEb025/gana5C7UMTSauRXtuywTIZcvLxK0hW9A/T8LPq6PM2exVEUEikSN5FwbK3qUu4LN rONcEaLj Nqwm2X8v0O0bK5pIDcAW6ptm4Du/KgM1QgDXfJJOdOwB1s0wJe/rjAqfguVqHO7gxd8TXcZRi19A2FiMlo5bqdIec8BUU/yc122jrou0wwztoW/b2mb0eSIWWOpUizfhsEgsAVOJW/SBvkl+i9dSDwo64B8Upi5y+SHFj0oiaEKJ9XQDLejdvl4+M1t7YNJvlRD1ktH9A5gENZoTct6Gb7FNvc66trWoZAXKAnd8CnPdYFRfvZthstgomQ850bs3veCVu3mrucogO21YZI9Knn+YpjbhbRvc0+V+rfF/K1vFROu9tPdtf5HIIFsuKqrmIgAjnndYTfPAbkCgaJYyWVcVgkFfOnYe0yc4clk3OuFAT9MdyeZh3IRE7RMcMsOkxmQVOI5hfPcKzcc5hlFFS302ApcpGoi2DfTkc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In preparation for implementing lockless slab shrink, we need to dynamically allocate the drm-panfrost shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct panfrost_device. Signed-off-by: Qi Zheng --- drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- .../gpu/drm/panfrost/panfrost_gem_shrinker.c | 24 ++++++++++--------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h index b0126b9fbadc..e667e5689353 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -118,7 +118,7 @@ struct panfrost_device { struct mutex shrinker_lock; struct list_head shrinker_list; - struct shrinker shrinker; + struct shrinker *shrinker; struct panfrost_devfreq pfdevfreq; }; diff --git a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c index bf0170782f25..2a5513eb9e1f 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c @@ -18,8 +18,7 @@ static unsigned long panfrost_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) { - struct panfrost_device *pfdev = - container_of(shrinker, struct panfrost_device, shrinker); + struct panfrost_device *pfdev = shrinker->private_data; struct drm_gem_shmem_object *shmem; unsigned long count = 0; @@ -65,8 +64,7 @@ static bool panfrost_gem_purge(struct drm_gem_object *obj) static unsigned long panfrost_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) { - struct panfrost_device *pfdev = - container_of(shrinker, struct panfrost_device, shrinker); + struct panfrost_device *pfdev = shrinker->private_data; struct drm_gem_shmem_object *shmem, *tmp; unsigned long freed = 0; @@ -100,10 +98,15 @@ panfrost_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) void panfrost_gem_shrinker_init(struct drm_device *dev) { struct panfrost_device *pfdev = dev->dev_private; - pfdev->shrinker.count_objects = panfrost_gem_shrinker_count; - pfdev->shrinker.scan_objects = panfrost_gem_shrinker_scan; - pfdev->shrinker.seeks = DEFAULT_SEEKS; - WARN_ON(register_shrinker(&pfdev->shrinker, "drm-panfrost")); + + pfdev->shrinker = shrinker_alloc_and_init(panfrost_gem_shrinker_count, + panfrost_gem_shrinker_scan, 0, + DEFAULT_SEEKS, 0, pfdev); + if (pfdev->shrinker && + register_shrinker(pfdev->shrinker, "drm-panfrost")) { + shrinker_free(pfdev->shrinker); + WARN_ON(1); + } } /** @@ -116,7 +119,6 @@ void panfrost_gem_shrinker_cleanup(struct drm_device *dev) { struct panfrost_device *pfdev = dev->dev_private; - if (pfdev->shrinker.nr_deferred) { - unregister_shrinker(&pfdev->shrinker); - } + if (pfdev->shrinker->nr_deferred) + unregister_and_free_shrinker(pfdev->shrinker); } -- 2.30.2