From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B6FEB64D7 for ; Wed, 21 Jun 2023 10:48:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F9BB8D0003; Wed, 21 Jun 2023 06:48:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2827E8D0001; Wed, 21 Jun 2023 06:48:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D5508D0003; Wed, 21 Jun 2023 06:48:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC1418D0002 for ; Wed, 21 Jun 2023 06:48:09 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BA48240933 for ; Wed, 21 Jun 2023 10:48:09 +0000 (UTC) X-FDA: 80926430298.16.9D4AA00 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 40D9880006; Wed, 21 Jun 2023 10:48:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=T3axtBl0; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687344487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MATC2/i5eIW1+ytWcQuhN9zSPu6yjSnwQO2Fike5i4g=; b=knq9BW1ZEkhFGOpNv82Y7C6y6OAVrp3HR7hxvxka1p6hhIJNXyxr4qvDbRWsRmcAqFgcPc 710Repz3ZCfkoT0dhwUPVoYyk3fek+FoS6nSB03a4PDo9A7OVgEaNV25AqUFFyYxBr8rcW Oesn5EhbR+ioYPzEBncB1SIcRck6Ok4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=T3axtBl0; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687344487; a=rsa-sha256; cv=none; b=NnxblW9j1KL1ElaJ3ipjV/sQ+AguUEEUwxalvA56z5oynN5MUb/jSM1+JbxrPYmDoLuWGM LKGbJCQSLqqCbP+mZFmgghj9gn+3SV/kCqee36TOZJnOaTfKlGTkTQIFtjBgFQSQXajwrm e2FbvW2n2W3kCkQrWyC2i5wGq2vP3FU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DADB161501; Wed, 21 Jun 2023 10:48:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D79BC433C8; Wed, 21 Jun 2023 10:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687344485; bh=vQW8SpknqhfYsLd//ycoQUF1XEoKmVOh7WQXK7qiNdI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T3axtBl09Uj+gGhVy84WdPlv59/aPeu632cEchdYe8a/k5iJl0+IXsbF+vopEWDYq NwenFITRTKDLMCVF8CzPXY6p9Hti1Q2TT7eK4GXO8pT0fRmZYBTPxe1ckDw7AxLZe2 wT9Wmou6gxTC0sVGsza4KPz7hQ7x6JjyXWzC0NK4= Date: Wed, 21 Jun 2023 12:47:58 +0200 From: Greg Kroah-Hartman To: Joel Granados Cc: mcgrof@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Theodore Ts'o , "Jason A. Donenfeld" , Jiri Slaby , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init Message-ID: <2023062150-outbound-quiet-2609@gregkh> References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621091000.424843-9-j.granados@samsung.com> X-Rspamd-Queue-Id: 40D9880006 X-Rspam-User: X-Stat-Signature: f9n7rnbczebe61na9fb54sg9bugid558 X-Rspamd-Server: rspam01 X-HE-Tag: 1687344487-306391 X-HE-Meta: U2FsdGVkX1+aNM2vroSAkCndeCIU6R8U2AYGaojKDigGja9GBPLCDvuEOnNTrZA5JIb7pIlLDXb1BKfJOLzqq9TdJpC15By1u1dpOk1rMQ1YcMFnw6XvqYYArXaUUm+b4l/rQZCtZZXMU67EPjPVyBAR/0xSJSqfcmEPM/PZh1KX52pM3AgDNe+LhddrzDR5I+B+7K8hdWeZiyihBqWf44+IgEshnNb2IIfET9z9/DcUgdUYrV34x+qbnmInnBFmBfq91NYexCJQXwLSNmTRNCEvrEsOVRUvoZ5uRumsiSD7nRhv4qyyELpq6cNQBeg8GU+rMAcaDHRi2alusk524yBrFcHt/qqdXpQo99xC7e8LFWbftO8Vf4xtqQSJ+Ms/rRsUc8U9Ol+Q6KtqkxPy+LKQ6QbjBnwkSbD6MwIqntIWgcPpzL3+ay4kj/viIM5IuiKlMt7VV0n6CK5tFwAmC3apBAuMt8EPPj3QDL+1bRqKe42CXQBwz/T8YrhQGZgGf9IrymQoUdnAPmxdmMmwL38PUtxc79Vq5peR/UBXQyKZPDvww5R8aVXs1HHCjyx2JXaShLb6KLJrfGvtCIdYCxVvwJZmeKONBhIsiGQEENatRyfbLmWC1QF1agQsqD1ApfmDyqlkkX1krQaF2oFtvqoAVZ784gq3+H3f5UULQBM+riDcNKuz5KoaaJ1rNzIgQXgXlbw5PcLcGPKm1OMOu74wGLMWJ2k+d3wwiMyvt/KYXKcRotnlAs1oCKh4LO3gXqaGOW7ONj06Vzw2rtQqmbB7KCg7QP6jAtKaU3OaXq8VocTXUxUfpWpxOc4fjo+yIp9GS7HvGdxlOQZk6ue3ejkmE1U5xuacW5F5lYTx/i8olaijwpZvgnS2Wgd2M9k7PKEzqRLMPq0NUgL03Jqh2zsU6BcbJtxaVxVeuXJtctcDpbiNv6EhsE1EWgovw1DmambHa5i6/tC7LNyHzxc Jq8Akmoh mp8prhX0V8jBlzYithQ9XNkIumrx4jahidWGBctqEVFtpQUO3MUg/+4w+bsw6KDoqunpAP65ohzk6mdQxVYdOYOP6fYWedF0rtSUGF7jooyVswnAYT7YZfuk8w65KEdh1uml5RlNYWENi2zMAWIfkVmcyix6KYQrfMCd6vIdUFWHzD5yuBo1Yl0cO3E9HoIZlCsmObxliqSXXXtxybFonpnsXGtY9L+8zY0dKGzHD9bLFiOq7USe9b6fgvKH7qJ1OdANqd5qaApXn7U7I6U22geVtXZpuduhlc+NFctpVlCxAbSawJCyK8K0mfRjNtepceu6Blmx4IzDoKOJEebeD7oyUVYlMdPxilC5okeqBdOFPJ/fprLXbWgBAwKASRNPZD/nex4mh1dMyPMD1hnViAtuRC4+Nafa6nr9wTWakg8Ixo2E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados wrote: > static int __init random_sysctls_init(void) > { > - register_sysctl_init("kernel/random", random_table); > + register_sysctl_init("kernel/random", random_table, > + ARRAY_SIZE(random_table)); As mentioned before, why not just do: #define register_sysctl_init(string, table) \ __register_sysctl_init(string, table, ARRAY_SIZE(table); or something like that? That way no callers need to change AND you prevent the size from ever being incorrect? thanks, greg k-h