From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04D6EB64D8 for ; Wed, 21 Jun 2023 19:08:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 434238D0005; Wed, 21 Jun 2023 15:08:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E4378D0002; Wed, 21 Jun 2023 15:08:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D2DD8D0005; Wed, 21 Jun 2023 15:08:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1EFF48D0002 for ; Wed, 21 Jun 2023 15:08:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D7A7E4094A for ; Wed, 21 Jun 2023 19:08:40 +0000 (UTC) X-FDA: 80927691600.23.590EB3D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 19EB0A001E for ; Wed, 21 Jun 2023 19:08:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AuwYWVtk; spf=pass (imf15.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687374519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gzlx5RnCHflcDtOqwZ3Rr+I4hibxQJq2BXlC9aaq5Wc=; b=RGl+M6LaI/xx6EJUHIpruDpfenCq9tUqL5rt8OeEoU21fuT/jGGRO57L+vnOjcofkFu3o4 OjHbqcfGLp03RUnYU1hzE+r2A7yjvLxbdf6okevYNsdclhBCNxw5P9+Lq1D0IrjRKBTVgl HpvA/yEmyyyT/cyXTAs4brwt3vvkwlY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687374519; a=rsa-sha256; cv=none; b=cJpoSez7jASYCPxuAQcNBZD1xvK8Hg6XzOyax4U82aF3i4NvQQfsEYi25arzPziUog4lHm q4ahsd9aqma39wfR7RTKSg2OIaTrbCF/lWSXvMB53Dxso0exvNtQvKTy0Yle7X7zJR6XhW NbCGHRwdO5CD3POY4iSd65/TmUSP9SY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AuwYWVtk; spf=pass (imf15.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1626F61697; Wed, 21 Jun 2023 19:08:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57E49C433C8; Wed, 21 Jun 2023 19:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687374517; bh=zdNbjZQDxHEv0urZ4/sBxzDu1D2R6w0MnTDSSEDgokU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AuwYWVtkQWT/4N9IbulYyZJj1z8dRiE8vsd9f5nH8bqW8aDlumt+7nDYbdhNVZ6XG Wia3nOiLE/TORccj3S8yb+LtvZURvwPVL7dbEPqWGKip47WeCfMEavvHKeuEfmRhPD vKguyAKJ3M9Jmmxs0IgZSbx26egIcE3l0AGl5bcgxad/+PR4/cSnbp8f8p+4BSRbmY SPOmAIDTOSclOrFhFvx/n9PjjTUc6wmjyMtxETMdHef0fSdbPMD6kohZNyPp0iIvGu xY608xVu5ykM5vel/iFfYGYhoC2dWfb7atZfNBczI2KMiL7759gWtnlXUIcsBBwkr1 3GdEVAnwcnGIQ== Date: Wed, 21 Jun 2023 19:08:34 +0000 From: Nathan Chancellor To: Baoquan He Cc: kernel test robot , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, hch@lst.de, christophe.leroy@csgroup.eu, rppt@kernel.org, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, deller@gmx.de, glaubitz@physik.fu-berlin.de, Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v7 02/19] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: <20230621190834.GA842758@dev-arch.thelio-3990X> References: <20230620131356.25440-3-bhe@redhat.com> <202306211030.DioMEPhl-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 19EB0A001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ak3z9kzwseczzoy4es58jotrj5o9a33e X-HE-Tag: 1687374518-785797 X-HE-Meta: U2FsdGVkX19s7OmZLHFIOxfmB4fUc64kHykab1+sN8o7sQEf0+GCdnM97355gUcwSjmxbntXDAWjQNkIOF0H/A5WlJefUyALkrCRx9y640hLzNPg38lNWbbAFl0TQn3aze/ZneJdDuUmezAHmqjD2C77ufG3XZWmZOY3HPro2GhucloQbMsOa/yQ/fhKWuPg1ZA920SjQlyA1hB7izWvVl6o+RpPcnUzdqfcGp/pyqx8608z9HzcZSmz+kDlpM+O/4lI5XFN2YUPmVNuZbPPl9QI8xygy1WUCZ7cIp02wXI+f1dTzqWSdcVUU2KteBFwRXm9bKSFhIohWaqnpisZFW8RXvbP4dV4Rxq8KYgIUiIJp4Q6GsAKmXrgOJqCmPPcYHl58cBIwogEG7SWg1Tugw7scndk25a73iLWJD2Etuw6A7U4kkLDjVtaBn0k4h1HfuwJhnHt7IkdhDkgh1XrOKvYEI7tslZ7l57joi1jqhXVnE/Iy0Oxoe8YunZmN2MJ8mjBUwKpfgB5zswA0eS4Cyv/HrS5ay5UOLb7j+riPTmG9e9fk24ZuWju+juIF8HFq3mMrFWhKMMJW2UF0khQE1wLlP11xvkGJuoMMxtTRJpKSntBKCAvNR5EtNg9r11p85Epg4ixMLCQ8ypc/IGwnE8Zf1ef7eXifxYKkFwif70+4oUYQZeb3raUHeE1XoGsiD/aJ+ySNiroZMQ9c4Gn+HOSnsAJDY9ADMXEl81Dj3Wy0PpEz0NV6TDqeyXjUEkEKpynR/i3HBUijfw/NK+vLYk1kpOHrbbSkH7tU0KjFS0vbQRsawK/JmvtsMvMahR6Xby/oU+G5QQU9OYg3kjzFQ6G7UCUSPiiFfyL93RawnILhGcnNtURhDJg6oI6bAuWaR5n9kYSt+PXsU6UcGHk1XPK3yOiHkbwkYJ/kZyPeN1yILuNI/spEmfIyQOB5N35KzWKFnIycKo0fZsc5ew szp7Ywl+ V1DD1cVQ55Pec/OCb6mTHdyTMjiivamK9vM6Va5hTBWhDl/VQk+dBB+8iW4nstb0AX3eKc+H3erxQhbWt7Wwj//WY7NKtJ3a47Z1myTVnX3YteQhX2WwKn01x03ieDi5pQylpuD7ySpuPa0Z4uwU5wZKwmdQiUdAZIi1DphD3m5KfHa1wPS5FD4a92zkRaay3EOZQw2cCFe1HGce1MPS3754Gd9v1QRM58bWk0MS9Xa8bZaiXHurfonnCIDqPO5j6g/SFCET0i4++XCGUb+1+jU5vveRZnodC1O0vLqi9qEz5PrLqeJK0sIj/VzV0IDi2KWTi9y2Xp2BpJWS4cSStx63QkN/st1LkaEvR+xRa2X2pUa1Ky4yVRi7Efo3JxuTU5jQwsbOoMz96NNF+Ezl8XBy5sEBcFPfklE0v4mJN2R+yZKH4cdDDXKaXZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 21, 2023 at 04:50:53PM +0800, Baoquan He wrote: > Hi, > > On 06/21/23 at 10:15am, kernel test robot wrote: > > Hi Baoquan, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on akpm-mm/mm-everything] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/asm-generic-iomap-h-remove-ARCH_HAS_IOREMAP_xx-macros/20230620-212135 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > patch link: https://lore.kernel.org/r/20230620131356.25440-3-bhe%40redhat.com > > patch subject: [PATCH v7 02/19] hexagon: mm: Convert to GENERIC_IOREMAP > > config: hexagon-randconfig-r041-20230620 (https://download.01.org/0day-ci/archive/20230621/202306211030.DioMEPhl-lkp@intel.com/config) > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > > reproduce: (https://download.01.org/0day-ci/archive/20230621/202306211030.DioMEPhl-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202306211030.DioMEPhl-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > >> arch/hexagon/kernel/hexagon_ksyms.o: error: local symbol ioremap was exported > > I followed steps in your reproduce link, didn't reproduce the error as > above line reported. I can still see those PCI_IOMAP warning, however > they will disappear when rebuilding. The clone3 warning can always ben > seen. I didn't see the symbol ioremap error. Could you double check if > anything missed in steps? > > [root@dell-pem620-01 linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash > Compiler will be installed in /root/0day > make --keep-going LLVM=1 CROSS_COMPILE=hexagon-linux- LLVM_IAS=1 --jobs=48 W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash > make[1]: Entering directory '/root/linux/build_dir' > GEN Makefile > ld.lld: /lib64/libtinfo.so.6: no version information available (required by ld.lld) Hmmm, seems like a dynamic linking issue, likely because either libtinfo is not available or the version on your system is older or newer than the one that the compiler was built with. Intel folks, you can opt out of this particular library dependency with '-DLLVM_ENABLE_TERMINFO=OFF' to cmake, which will make it easier for others to use it; the compiler can still output color on most terminals even without libtinfo. > tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/run_tags_test.sh: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files > tools/testing/selftests/kvm/.gitignore: warning: ignored by one of the .gitignore files > tools/testing/selftests/kvm/Makefile: warning: ignored by one of the .gitignore files > tools/testing/selftests/kvm/config: warning: ignored by one of the .gitignore files > tools/testing/selftests/kvm/settings: warning: ignored by one of the .gitignore files > CALL ../scripts/checksyscalls.sh > clang: /lib64/libtinfo.so.6: no version information available (required by clang) > :1519:2: warning: syscall clone3 not implemented [-W#warnings] > 1519 | #warning syscall clone3 not implemented > | ^ > 1 warning generated. > make[1]: Leaving directory '/root/linux/build_dir' > [root@dell-pem620-01 linux]# > > I am able to reproduce this with the kernel.org LLVM builds that I do, which should not have that library dependency: https://mirrors.edge.kernel.org/pub/tools/llvm/ $ curl -LSso .config https://download.01.org/0day-ci/archive/20230621/202306211030.DioMEPhl-lkp@intel.com/config $ make -skj"$(nproc)" ARCH=hexagon LLVM=$(realpath llvm-16.0.6-x86_64/bin)/ olddefconfig all ... make[5]: *** No rule to make target 'arch/hexagon/mm/ioremap.o', needed by 'arch/hexagon/mm/built-in.a'. ... arch/hexagon/kernel/hexagon_ksyms.o: error: local symbol ioremap was exported ... The first issue is resolved with: diff --git a/arch/hexagon/mm/Makefile b/arch/hexagon/mm/Makefile index 49911a906fd0..ba4b04d962d6 100644 --- a/arch/hexagon/mm/Makefile +++ b/arch/hexagon/mm/Makefile @@ -3,5 +3,5 @@ # Makefile for Hexagon memory management subsystem # -obj-y := init.o ioremap.o uaccess.o vm_fault.o cache.o +obj-y := init.o uaccess.o vm_fault.o cache.o obj-y += copy_to_user.o copy_from_user.o vm_tlb.o For the second issue, it seems that ioremap is exported in arch/hexagon/kernel/hexagon_ksyms.c but ioremap() is a static inline function with CONFIG_GENERIC_IOREMAP. I think we can just remove the ioremap and iounmap exports now, as ioremap() calls ioremap_prot(), which is exported, and iounmap() is exported in mm/ioremap.c. diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c index ec56ce2d92a2..36a80e31d187 100644 --- a/arch/hexagon/kernel/hexagon_ksyms.c +++ b/arch/hexagon/kernel/hexagon_ksyms.c @@ -14,12 +14,10 @@ EXPORT_SYMBOL(__clear_user_hexagon); EXPORT_SYMBOL(raw_copy_from_user); EXPORT_SYMBOL(raw_copy_to_user); -EXPORT_SYMBOL(iounmap); EXPORT_SYMBOL(__vmgetie); EXPORT_SYMBOL(__vmsetie); EXPORT_SYMBOL(__vmyield); EXPORT_SYMBOL(empty_zero_page); -EXPORT_SYMBOL(ioremap); EXPORT_SYMBOL(memcpy); EXPORT_SYMBOL(memset); With those two diffs, the randconfig the robot provides builds and links without any errors. Cheers, Nathan