From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E836EB64DC for ; Wed, 21 Jun 2023 22:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7661B8D0005; Wed, 21 Jun 2023 18:52:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 715A18D0002; Wed, 21 Jun 2023 18:52:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DE108D0005; Wed, 21 Jun 2023 18:52:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4CD5A8D0002 for ; Wed, 21 Jun 2023 18:52:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 19C30C0A26 for ; Wed, 21 Jun 2023 22:52:08 +0000 (UTC) X-FDA: 80928254736.18.81B6DAA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 5423840006 for ; Wed, 21 Jun 2023 22:52:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dP4OACt1; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687387926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nh6DT4YWwYajMxk+CmcQq6I79stxhyCLVXhBm5V5v9s=; b=33XGwkeYlCvMvxH5oBDlgqx04gJGsl/HkDnNXIL1a+ScKCVRASdWMxd/Iiv1lpL+6PjYmq 6OCdvWjByf5h5MieppM4MQsMuMijlc1SKdJUiGarYKS3WzKIS1CGQOX7LS6Arxq+Qxj78C VnB8aVctaqan74YPgi6J+tMPOHBpQh4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dP4OACt1; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687387926; a=rsa-sha256; cv=none; b=clQhINlwwuEZZmIuk3lN2/pTVZ9zchVKn64dIB/BTZKP0f1aIoX82vZ4Fw0cVtv8L32poI Wtlf5c4G7A+Siu8iZFZym78K9AEM6RUko2ASj8R2UT4oQA0HTmlHDgovtQa6N0jCWNnLLI OD3wSln4qeWROKFSuR2sWbxDUT0Gdqc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FD20616F2; Wed, 21 Jun 2023 22:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57237C433C8; Wed, 21 Jun 2023 22:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1687387924; bh=QomhkGLLN8W2r9HjMDHaZujXKKaC8553z5+wqMaD2HY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dP4OACt1y8GyQBFosTzrkVpOpXUr+pMHBbNogmBbDeFFjXgKnnzJ60+1mlM6CZzHm x2+siVaEzqnEoL6vU1STdW8JXtVK8chEbIAyDY6KM5Zyn6m13mkls6+Y6ppYJ0XfCO 3qBjdH31QeNCnC4BK69/H5yS1Hw/aHslc38fCjzE= Date: Wed, 21 Jun 2023 15:52:03 -0700 From: Andrew Morton To: Mike Kravetz Cc: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Ackerley Tng , Muchun Song , Vishal Annapurve , Erdem Aktas , Greg Kroah-Hartman Subject: Re: [PATCH 2/2] hugetlb: revert use of page_cache_next_miss() Message-Id: <20230621155203.40c9e05d1a80f522f7e9e826@linux-foundation.org> In-Reply-To: <20230621224657.GB4155@monkey> References: <20230621212403.174710-1-mike.kravetz@oracle.com> <20230621212403.174710-2-mike.kravetz@oracle.com> <8a1fc1b1-db68-83f2-3718-e795430e5837@oracle.com> <20230621153957.725e3a4e1f38dc7dd76cc1aa@linux-foundation.org> <20230621224657.GB4155@monkey> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5423840006 X-Stat-Signature: oezkfkjsiokzjkczrr3qmpsopx4zh4sk X-Rspam-User: X-HE-Tag: 1687387926-213890 X-HE-Meta: U2FsdGVkX1927xrrwXlBp/vrr2dHs30eXWDDPEdvPYIF02mDGHWZ2GH3WBWqiP/xeM038yEVhn9ninRohh5xmv2SzZuG/NZpjbc39Ky8yjVdnX58GqStjxoDoUf4YTDx/65MLYytkev90QMWoZKLSyWML85H9Bxpq7hxnt0ofxTjlTTeIQveBr1ZgmlYH1WCf10CMqutALUZZ7g2ABKojikBnruRLDNTBZCVsO41gzqQ3mD6I0Xr9rKWAIAhPgHSIXGuDHLPDddQChpVPsjv408WIefSsITJ11KsEpx4kyw9fREFMWp9cy7CgV6olytX49pnoxb5lOi3czuaUCiG9SAKo9iFePYytA3Z123eeciMXT90x5tELRNRU3ndzZ+6LTU1VmYE+r86YhGL8BCxT3ObUwBFzCkSLIW7tZWXKz7wMK4kLoQOlGW2Zri0pq7AeoxuO/nTMzDSPTuJ/pB1XatZAXS1nzMqBDCaqUEIqaw81IQmYfeM9/r/p6FvVEx8RMOa8hD8KLAWdxNrp3PdK3JaPxlGniAZz4lgJ61FirOvRWQi01zPRWt6EBPrLYoVZwuShSPw0+tWn7ZKi0I5p7GTAxtTXW+1n4Si4AYpzaWl00FLxmJrzm2JNLDgg8HrOeyO/ndY2cwH70A8Sphiog5g2106SMA9GN1xhRWD9BBqZTxqNTg4OSdoNOz77ZjlMAfabkxyp8ZEo69xSeN6l3hwokofPDpMmFJ9HV23ZI84uPU0gYM036Vu8z28y+iVptyE9B/9GQ/+2ieviNvxto1JoUf7cN6H4InwwUhG3U0VNhsbVyibQUU2C5iyBoQUxh86mKNnaup7CVPqMFUeOP2/1UQXRitw6sSWdw82kUuocjxHcUOSJX7yZOw9ulThpUquh4NkAuQMxgLmZHpn+Qyl/KsVh7UQcUuV+IDZxrB98NQNIcgtwZqjE0z6tShORwYHyrt1bFzK/Ut/NU/ pW/AVIso CfrG/NlRbuMJdLkiUBgb+OEK4W3el86WnTJVjHIyzerJGa717LAgitrdLDbxxqyZae4OOg1nuVxgt5HqQpmHtYWNsYRSyV2dgagwiss0zSm0mJLD+JUZXiU4gZlFoeThDrHwEJgyNBZNMAGjrRThFHM6IkeOgCGuIAx35a6DIExWNaWa3HEP2a/TYX6O/FeZHCX7PpcFi5Ck9QxqMHoh8V97WW+ogAKv5TDwoDmcBrq+YhYegNhnSL2i93uHv/2O/TmuJ6aUOq+R8DYbAc8tHe6MtVWERjhZrgKq2DCrUMuuHWW1ScMpDgGwbkPlTt9Sx53HuEN7lAMAi/ea3IwpQiBRxiLJ63BvPO0BoJtIjHRn2iT8eRlDMui6iofNmsYlJLx/ojlAQMisK0ObKpPAgjXRVeEVR7Drnkh9nTqqlTmYfV5f5Uths5iDp1GBAmCBXMzB53wA74FOMVWllMSqHLeebNyRmNMm0OMy4FUUDzgc3v28JFUg97lW+EiB9i5tsJHyq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Jun 2023 15:46:57 -0700 Mike Kravetz wrote: > On 06/21/23 15:39, Andrew Morton wrote: > > On Wed, 21 Jun 2023 15:19:58 -0700 Sidhartha Kumar wrote: > > > > > > IMPORTANT NOTE FOR STABLE BACKPORTS: > > > > This patch will apply cleanly to v6.3. However, due to the change of > > > > filemap_get_folio() return values, it will not function correctly. This > > > > patch must be modified for stable backports. > > > > > > This patch I sent previously can be used for the 6.3 backport: > > > > > > https://lore.kernel.org/lkml/b5bd2b39-7e1e-148f-7462-9565773f6d41@oracle.com/T/#me37b56ca89368dc8dda2a33d39f681337788d13c > > > > Are we suggesting that this be backported? If so, I'll add the cc:stable. > > > > Because -stable maintainers have been asked not to backport MM patches to > > which we didn't add the cc:stable. > > Yes, we need to get a fix into 6.3 as well. > > The 'issue' with a backport is noted in the IMPORTANT NOTE above. > > My concern is that adding cc:stable will have it automatically picked up > and this would make things worse than they are in 6.3. > > My 'plan' was to not add the cc:stable, but manually create a patch for > 6.3 once this goes upstream. Honestly, I am not sure what is the best > way to deal with this. I could also try to catch the email about the > automatic backport and say 'no, use this new patch instead'. OK, how about I leave it without cc:stable, so you can send the 6.3 version at a time of your choosing?