From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9EE5EB64D7 for ; Wed, 21 Jun 2023 15:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4F7A8D0003; Wed, 21 Jun 2023 11:30:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFDF18D0002; Wed, 21 Jun 2023 11:30:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C506A8D0003; Wed, 21 Jun 2023 11:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B840B8D0002 for ; Wed, 21 Jun 2023 11:30:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 19630B01B9 for ; Wed, 21 Jun 2023 15:30:21 +0000 (UTC) X-FDA: 80927141442.13.59E2668 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf20.hostedemail.com (Postfix) with ESMTP id 838891C0037; Wed, 21 Jun 2023 15:30:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=pGdGnasd; spf=pass (imf20.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=j.granados@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687361416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4dY3siBIy5sZCkWLAJsADYQ9gjCB2XGjCqHI/EnrzWw=; b=QCXZ7lmNnUnrVYl0PurmIADx1EH9/Kba4520dByQCQ+OlOE12MdHWnTRvLv/D4sTEImvzR 8MTVwTE06QJ9ogsW44JBX22GIyfpPhmntAg3RKaM6JkzRY6Mf3OIGhTjZKldNmeH8/DYC6 H1ssCvLaZI5+dR1a4iIO1XgvwekdK38= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687361416; a=rsa-sha256; cv=none; b=CMMpgojTKumgsaz8g40RqHUho79ZQlDMWqFB/CV8N0v139hl/CovFhKafLc9qDJIeuRKn1 pdBUB9yP4Kpb7tz1+rmDQUb9Mt+aKR7rLNQJtL9TDqGCd4R6RRAWYiK9rbG7GHx/E+1cVG pz0hqAnqPk7E9aE2axP5mxOUoXC2kKI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=pGdGnasd; spf=pass (imf20.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=j.granados@samsung.com; dmarc=pass (policy=none) header.from=samsung.com Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230621153011euoutp01192645862d3e0a543891af4b47de94a9~qtkOS32Qw0899308993euoutp01Q; Wed, 21 Jun 2023 15:30:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230621153011euoutp01192645862d3e0a543891af4b47de94a9~qtkOS32Qw0899308993euoutp01Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687361411; bh=4dY3siBIy5sZCkWLAJsADYQ9gjCB2XGjCqHI/EnrzWw=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=pGdGnasdyQVz6DZY4mANhkND5Xrt681cqBfJfy97xUPZInu3VuYDlHeCfy1G2/D4c 18D/HuBWkadD4OUgQpv80ELCjEHDj40bQ2D16FPNPCKO+6rUNXV2/eSnsXtYqBWKtu F5+bvWY/pNIsls2QPTAqoHMPbQjcqWCwFBMbgLgY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230621153011eucas1p2787595ff5b934c65ea1727b5d5deb74f~qtkN_c_kP1922119221eucas1p26; Wed, 21 Jun 2023 15:30:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 3D.E0.11320.38713946; Wed, 21 Jun 2023 16:30:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230621153010eucas1p25fabdc546fa653beb103f6f68f4da531~qtkNVQ-cl3128231282eucas1p2P; Wed, 21 Jun 2023 15:30:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230621153010eusmtrp230e48834a7a1b40e208c6136e69457d4~qtkNTp7dV2052520525eusmtrp2q; Wed, 21 Jun 2023 15:30:10 +0000 (GMT) X-AuditID: cbfec7f4-97dff70000022c38-1a-6493178345d8 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 53.6C.10549.28713946; Wed, 21 Jun 2023 16:30:10 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230621153010eusmtip231fdedfd7d7cff792547031f714e18c9~qtkM_OVY70222902229eusmtip2f; Wed, 21 Jun 2023 15:30:10 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 16:30:09 +0100 Date: Wed, 21 Jun 2023 17:30:08 +0200 From: Joel Granados To: Petr Mladek CC: , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , , , , , , , , , , Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init Message-ID: <20230621153008.lpxi5gh6fzvammg5@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="6xqmlcamfjbvcfp2" Content-Disposition: inline In-Reply-To: X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA2WTfVBUVRjG59x79t4Fg67gyBEtbTEnP0CxtNfS1NS6QTOVzTTlVEayifGh syt+N8GyJpIoLAi1LAGufC6CIOywLK66Mi6oJKAIiksIqCCIinytjLuxXpyc6b/f+7zvM+d5 /jhi2kMt9hZvidgulUUEhUkYV6y/YPvbN8YrKXhRkX4SaIoLGagv0iEYGUujwdjdimHQ1spC nL0MQ2FZNAVPTtoZeFJtYaD3/ACCxs4mBlJ7ojFoei6z4LDeo0CbNUxD98kDCDRXlBj6FWMY 7iSU0+DQK1mI0RYzYLacYSGlxAvSUmMoUNkSELQ3eYPmxmLoT58BtpwCFoqKtRQoKvIo0F/L QFCdrKbBeuQohsu/h4Px0hAF5bcUDNwzxVNwcCQbQ3KKAkHV6VoMVys1DLQVOkTw6FAHA9XF dRguXajBoDsRJYLs5gYKCg/mi6Al4Q6CpP67CLS5c+DxmS+h8WwmBTmG2xgaos8i0CU/Y2F0 bEwErapUDJb4sxQ4OodEYIptp6BxtBeDseQYs+ozfmT/Ycz/0/cM84V/FSI+LaoB82X5Nyj+ VrYB8Ykx/SxvUFtZXmm6yfKZpZH8deM3vLL6gYg/lTeP11b1UHxcSyPNlxYcZD5/a4Pr8mBp 2JYdUtnCD35wDfkj/wTeluK1K6HyCB2FTnnGIRcx4d4hw9XZVBxyFXtweYgM1wxNDIOIPDyX hpxXHtwTRMx9s184OowVIuEoF5GG9mJGGMaPRhuPT2zKEYlPP0Y7LZh7kxhHzayTGW4BudJ3 67k+hZOQ+xlW2mmguZGppOJuPeNceHJryOmYLpGT3bh3SZaijxZ4Mqn9sws7meZ2kQF7+XhY 8ThPJ7l2sVN2GX+rpFKITTgf0mzSMgL/Qi6W3XzejXBNr5CneoNIWKwllsF6SmBPct9Sxgo8 gzgMGROGJETO2B+xwqBDJCd6aMLxPlFe65pwrCZ5ChVyJiKcO2l5MFkI6k5U+lRakN1I7G8e wvUcomvrwwnIR/1SNfVL1dT/VRPkBSTTOMD8T55PcrJ6aYFXkKKihzgTsQXISxopD98slS+O kO70kweFyyMjNvtt2hpeisa/7CW7ZbAC5d5/7GdGlBiZ0exxc8dJXT3yxhFbI6SSKW6vlaqC PdyCg3bvkcq2bpRFhknlZjRdjCVebvNX1G7y4DYHbZeGSqXbpLIXW0rs4h1F4fSlXr4Fr7fN 7PfX6QPUc+a+nWH6KnBfyEC/adaOutCpIZ3f7haNBVTVHFXP4vlDuz62KrlQ6/pQv7jFa1KW jvgeNyQF7rFMCZt7o1w1Oa9+UlWRgmQ1rz4n8xl0aGxblgwb4390hLZkiRN9JL2Syour8k/L O/xrP1pf96zTMe3nda7GAxrbyuZHo1PdVesUryb9tGF/yeH2p/uGTlWgnckfWi/+avb/Yqj4 Dcfeo/mrl9UNuOQs977Z1Clb1N65t7XEBSxrv5uvWKDnvs5N0GbcDbl2vSDAPrPGEPhpbLRn om8Jyly5UNm2cUn8na7b09K//8T9fPdV0Xvd+aZyW2zwsh6dSILlIUH+82iZPOhfCl1C+y0F AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA2WTe0xTdxTH97v39t7iQtYBkzse2VanY6jFUtCDU6N7xGume2TJEuec66Rp QdpiC0y3mWHLNmAykYfEUnnYgVDKowgIFCthnR1BozBEEBAFBQqI4zWo5bFCs8xk/31+n9/v e87JLzls3KOK8mFHyGJECpkwikuuIloWrfc2qrzTwzepWl8BbbmBhFtlJQhmHdk4mIa7CZi2 d1OQvFhFgKHqJAZTFYskTFmsJIz+NomgbeA2CVm2kwRobdcpWOodwkCX/zcOwxU/IdDeTCBg XOUg4FFqNQ5LNQkUqHXlJDRZr1Jw1ugN2VlqDNLsqQju3/YBbVcwjJ/3A3uhnoKych0Gqtoi DGracxFYMjQ49J7OJOD6z1IwtcxgUN2jImHInIJB0mwBARlnVQgarjQT8Ge9loR7hiUW/HWq nwRL+Q0CWq79QUBJaTwLCu60YmBIKmZBZ+ojBOnjgwh0F9fBxNVPoK0xD4PCugcEtJ5sRFCS sUDBnMPBgu60LAKsKY0YLA3MsMCceB+DtrlRAkzGC+TOD5nZH34hmL6xBYIx5BgQkx3fSjBV xV0Y01NQh5gz6nGKqdP0UkyC+S7F5FXGMh2m/UyC5TGLuVQUyOgabBiT3NmGM5X6JPKjgM94 2xTy2BjRqxK5MmY79wAfgnn8MOAFh4Tx+IItB7cGh3KDdmwLF0VFxIkUQTu+5EmS5t+NzvA+ Vtg4yIpHRs9k5MamOSF0v6mWtcwenAJE35jEXd6PNk7fZrnYk57vSCaT0SrnmwlEF40+IVyH akQXdGtWEgRnLW2aa6KWmeRsoG+O9ax4Lw6XHsntxZcDOGdmNT0yNrBy4cl5h76ifrjSwp2z hc5XjeGuMe4huuTXIJd/kW4+95BYZpwTR+vSh5zMdrIvfXGRvazdnH2N9dnINeka+o5ZR7r4 BD21MIhSkafmmUqaZypp/qvk0oF056IN+59eTxfmj+Iu3k6XlT0h8hClR16iWKVULFXyeUqh VBkrE/MOy6WVyLkyNdfsl2pRzsgErwlhbNSEXncm+ytKbiEfQiaXibhe7v6VaeEe7uHC49+I FPJDitgokbIJhTp/8Qzu89JhuXP/ZDGH+Js3hfJDNodtCg3bLOB6u++JThR6cMTCGNERkSha pPg3h7HdfOKxTw3CAIGgzCywRAX1hXzb7dij3vD9gb6a+bZ15q4GA5K+HZ5+4Csqx99XrA54 v/NHv+OSo1841AnfRTx/hKWTHT20K1cv0UbqfZWRdGLNwMQay1DipMGnwbZ7+Nh71zwVjfyt 2w6uvSD4/aH1soxurvDeL+brnu7sWL9oTfp4Mjfw6V11qST65deqgyrdix/bT2y5+kFA3Grb 6aQXBPveMGJ7DX6jLRulQ/2UNbCzWTtVHZVV8yAg1/F1d++ty4n72m35o9dT9p5nlUbOnxte NS3fcTMgz1db1NX+ZktL3Nx0psTex8Hf+vy5TP9du8Pt+eJq40zniLhKb8bq6msrFtpnuYRS IuQH4gql8B/pJ17rxwQAAA== X-CMS-MailID: 20230621153010eucas1p25fabdc546fa653beb103f6f68f4da531 X-Msg-Generator: CA X-RootMTR: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> X-Rspamd-Queue-Id: 838891C0037 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ck9jpu5ogjczkez7pba8usacx9q3bj1u X-HE-Tag: 1687361414-393215 X-HE-Meta: U2FsdGVkX18OAX/FegzQCYPuoGByMFAKc1wbAYu9T1bpvedVVkOrx3FYxMSBOORs9e5iV+zR5u7m92sGKHi9G528VsLjOFR/v3J8p7KIKbB4h2kzBQLQqqHtC4g84GzTsK2RUUerIIXZ9QdCB09DvIlUshWQvm3ZUIprm7JHJpPhBL5v2cighKgrZh52Ccm98Yhs3RXQnv1fpNlmPDqkywO7anjk6i0hIsPhijwDAFqvJqfls25/Th7VCpISh+YR5b2FM7nPKaFkKWH/8JfAvDnVxCCLYocV6yw2LemsLnQHqV6rdtZyKTJsEe6wRQD3R6ApRUoYiqWAVYj8UkMfTgJvVo6ckBwPOsHS4cwahW7lAf6JMecPVfixnSDqoDO1WyblCqdVuy2Kbr7UjOiU9Ew+Hg9e6K7Jfnz+dK4SsCGF97y9VM27bJreVM6k3ulkgVK1lmtslDOJ++bvKaBHIWQBz5y2J9PDe3yijFidvkXfLzf9OwnlVrD/Qr5JXghPWcqPKN5iQtFERuenOKcBCwJ66BUd1Vm+ub5SmOjohE25jlzUCOxFeq0PMj8g1iP3YxnyOC5NjsGfRZef22AmIV77+mr/CxEVfOryKe1+BMIG0w4S3dpaKO5NYK7suFWg5w5/Tv5viAT62ZGiHJeic2e/QVTnRnTnZHHBZEiOF0Sn/6Aq5yGbNtmB0uyyW5RH+5ovZ7Tb5yYpB50HKnvTptkUNYUBiHaj47z6tQusKySU6qZ5T8zoXsf0AxX/GouSM6OBTjFl3xrpowxGQP/vhm4cB3Tl4Q4qQptPAzppxSMKOXZRxO34EVCA8ItVaKcsC7eOhQ/1Fh3WpBKRle0ijR1Rli1VnJaoQSToJidV5f8BD1mrbMFclICP+ZvpjE5lOsoyT5FBKVB74wMpXjQHQc2js4eocLnZuDF28Rdlomk2LmPXmLdWvmll0k7SW9oNNEetibO2hWzIGxelpTO axnAx3tw QLg4cffJyswuh1PkyN8LBOxbqTKC6ajgOB8pAHJ5FICiTnSaA7UTI3VUNarYQPgYPJfBDonGRTWbRXFz+uJuSm6VzSDT7ps3nDoeZqaN7nT20IdfanVxvHlMwZDShhib7YoMpixAEtQHPy13WkuYfRibv/cRO62tQwN95bfsLGztBbrybR6r4P2xQM1ouGQoyjoRvenytqsVuxia8UdBs7ub3tfyhLAZmPtYKZg2jlKiqw08= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --6xqmlcamfjbvcfp2 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 21, 2023 at 01:36:46PM +0200, Petr Mladek wrote: > On Wed 2023-06-21 11:09:57, Joel Granados wrote: > > In order to remove the end element from the ctl_table struct arrays, we > > explicitly define the size when registering the targes. We add a size > > argument to the register_sysctl_init call and pass an ARRAY_SIZE for all > > the callers. >=20 > This does not explain the motivatin why the end element is removed. I also see that the cover letter also lacks this. Let me clarify in my V2. >=20 > I agree with Jiri that saving 9k is a questionable gain. According to > the cover letter it saved 0,00%. It is because it saved 9k with allyes > config which produces huge kernel. IMHO, the 9k might be interesting > only for a tiny kernel. But I guess that it would safe much less > bytes there. I put the 9K as a upper bound kind of value. To get an idea of exactly how much we are talking about. A lower bound with tiny config and sysctl enabled is a good idea to give a range. >=20 > And the code with the added ARRAY_SIZE() parameter looks worse than befor= e. This might not even be an issue in V2. After analysing Greg's feedback, these might just go away. >=20 > > diff --git a/kernel/printk/sysctl.c b/kernel/printk/sysctl.c > > index c228343eeb97..28f37b86414e 100644 > > --- a/kernel/printk/sysctl.c > > +++ b/kernel/printk/sysctl.c > > @@ -81,5 +81,6 @@ static struct ctl_table printk_sysctls[] =3D { > > =20 > > void __init printk_sysctl_init(void) > > { > > - register_sysctl_init("kernel", printk_sysctls); > > + register_sysctl_init("kernel", printk_sysctls, > > + ARRAY_SIZE(printk_sysctls)); > > } >=20 > Is register_sysctl_init() still ready to handle the last empty element, nope, after all the patch set, this functionality would be gone. > please? I am not in Cc on the related patches. Not sure what happened there. Should I just add you for the next batch? >=20 > Best Regards, > Petr Thx for the feedback Best --=20 Joel Granados --6xqmlcamfjbvcfp2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmSTF34ACgkQupfNUreW QU8CgQv/WDyYibe7/IonBVPexXNQGTVuyKh61uOYtHRK+2k13K3RLUk48Z0C+Q5+ vfTq/uCCkVwy/eYrMqn1RFGRzZ2NY6UkXXd7X6g8UVGLIiTCl2TEA235HjpPCxuh /RcNXUoYsrzVCc6s4XtIScbySNGho9BtuXw1vInVQy08FiO21l2apZYCWtOqRzdA GFUepViYRcMqGClksHNZKDND+JZWRjB1sqPr5UfLVo89RxrSGbDqZFP2DCU3ehNx vbSg+kcYu3PBOZQuhA9Eu4h1ErwKlk6PQJhJ04lpMwJU3eSR8+t6A/9iKE305ufv lulowZS/J4q8c+8IDMZR/g9Ire50DzZ0MzEENUn43oqh7EVc+C5XgG28Gxyb7P+l aXq/uiZNg8e1cD54e+l01DjFU8aEVz1KN3YE4NF2VW/EDUyiOJU3a+mkBSPSIt7C MSeQHeJvDOffcGjCWsyGwiiplObWKHl4WApjE/sA0UtkNFCc0178hmKbFf9ayZvv J2+uWQKH =taMy -----END PGP SIGNATURE----- --6xqmlcamfjbvcfp2--