From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B3DAEB64DD for ; Wed, 21 Jun 2023 22:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E00918D0003; Wed, 21 Jun 2023 18:19:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB0708D0002; Wed, 21 Jun 2023 18:19:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9E9E8D0003; Wed, 21 Jun 2023 18:19:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BE9ED8D0002 for ; Wed, 21 Jun 2023 18:19:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9C62E40836 for ; Wed, 21 Jun 2023 22:19:00 +0000 (UTC) X-FDA: 80928171240.22.46EED66 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id D750D120009 for ; Wed, 21 Jun 2023 22:18:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RMKtd2l6; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687385938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I14pqDwFw5VwTFsGGZLB2RDOayPERVDbIW6EHq7hiO8=; b=NLneSv4jv/V/2QDPwMBptXNY+2N1/YZKq60vsUArqbrwVqfxK+At+dWTiw24YItL4496Q9 wDfdOEjfdxjAy72m1z/zcOBWHbi636U5YOivtevNlFKzCL4vQVgp7jnRsuWpPm57aJTJLP S9t3XkpgCDhQK0Br7prVdXTti1KjNSw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687385938; a=rsa-sha256; cv=none; b=SXvDdyFIpIeUitxublmJbwj7qGyNc0JwAMBOc3qKNDXevad0youoIMugHDaYAZY1FqA3SB ZpbakoO739CsMSrXUDGFjXive/UccloenvdnARQAjT/O1Ngc2gF28SF/gAsi/kWgntnoLG bFXS2cqD3xO2+kx5SJCKyp7CVF9TWOo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RMKtd2l6; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4C14616A4; Wed, 21 Jun 2023 22:18:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB6BCC433C0; Wed, 21 Jun 2023 22:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1687385936; bh=53tS1I0N40ES60UY2MzzEHFLVoHFZs8JVif+NrqbUR4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RMKtd2l6NAdgqOYzztGrpCrzM2TgcEejVsCZKMtu7S+UUaDf0xD00x5P7/fQIPRcr IEkdp94KfVRKWZ04wJA+PeX8ep6JuG18BBTQtAdikv9egwtXY0SDeLG4bUldRDy/KP KKmOuU4gVXe+trU5l9opJQcemyg7JcOL0Qy1sfiw= Date: Wed, 21 Jun 2023 15:18:55 -0700 From: Andrew Morton To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Ackerley Tng , Sidhartha Kumar , Muchun Song , Vishal Annapurve , Erdem Aktas , Greg Kroah-Hartman , kernel test robot Subject: Re: [PATCH 1/2] Revert "page cache: fix page_cache_next/prev_miss off by one" Message-Id: <20230621151855.318449527a851cc0bb62fb34@linux-foundation.org> In-Reply-To: <20230621212403.174710-1-mike.kravetz@oracle.com> References: <20230621212403.174710-1-mike.kravetz@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 7ng5gsum7er3pttj5yg5kd5msf3w18kg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D750D120009 X-Rspam-User: X-HE-Tag: 1687385937-524856 X-HE-Meta: U2FsdGVkX18pRQ/qtqQx75Gpw6V31ff67P/UJ1Ex2hr1fflPi4fk0PcS/y2jyZXpt3lntiwDw3eInzqK+Vluf42myabNrEiVJRb4cEG3UpPYdmdWzxjvhFTaJquQMimPH6b+1gtwIRO3glg2NgWFJuILipCdeczh8TGbdug5N4Z5/9RSP4taf/vBoctbXDamL+CZPxUURzyJzdnIekwt9bUsRh0V7lTs5jZCnzCa/nKcVcEv9btAQxRmnUU7ae34Q3xhrxaMH9J6N0Yh1KjSacVaco46VnfF4q579Df23MLQnGgCEJS0O4UlZiS2GoSkj6kmjlJSVMxtetdw9Ys3Z0dZ+wPt0wP2ju9YrAx65Xt9CHa1biOb6mwGlys/YA2KjOFS8egJ6Ch3uzCLgVIjULaynSnmssSMoYGk2WqAgoPKJH+otbOQF8lW4udnAohVkd9XWkdp4lwS41wvERHPoCmNUEfm9qSJgpdi8zWXu4rFRXrj7lzRAVkDTDTAlB/l9luNuumIv6/D+4HOfw0BaWNswTCE1M1ADeZsg1h+4q8Htt9JcMajcAksZi+IF9Jwfuif9z6Ljg4v3jHAKdooKRCMPlmFYjYtSe364tchNt1JmPgvwo0grgPny5nhly68dYWaDCF+59jnR0i3hL+nRKmvtlBeKfnggdMudt14ugoQcuohTxEk0AjK1J9SYcr3DqkipRHi5v4Sa7G+v1WsKHTQSRrd4yaAfm3jTF3E8ogskjfsETAmMoM1oYV1pWcgXYD+yL1KI85AZkMECI6Nn6ex8fxmFR/h1BAWCiQHUB4IaiE9sbATbivbSZ/bd9rxA6AgTLQXimKjMn+mQAKJL57jjF0zwNuG1kLdTOfh7XGLG8PBiZTHEv6m41b5FAkB/jIvzugJfs2tmO26GNYwApewTZuKhoIRdfrCxdgCvCQjYTSwzPQAZv+3LBjq+IRo4aqICHRvFCJpgKGlz8q D3+V+UOZ m8J0UsJxNzrSg6TRfAj+jfSWIx3Ro/jko/2r9CdwCg+otvOHkekNNFLecsJVz4RieNd9yhF64rJbuvmfDB/EX7AGG1sKqpOlsffflvq02gbKAug4AkstTEqCLg8kGsD+K44w1wQ2axAB5TOsKYgUqvva4+G6V3iPGsX/FRewV3LzR0lZNzXg+WvaY8a0kZwqEuKon4SUWJayUvVHm91/IOyAWTlsHPQnSnsAwognde1NnlP/3+yVOu4fKqIv+FYdaOMCZei72WSvvMi5skgwwJDfEKtdk3RIKvetgglobWTshroPuhZ9RlZBYJ3AJjVChwUw7KwW7DYYgppK1eK+0DQ1pZgTrlvXbSYQq/L2bT2PA7ck/fQfxd+AnXaU/SpKDlMXrBZK/xLQcQSd/B+gsw3TObg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Jun 2023 14:24:02 -0700 Mike Kravetz wrote: > This reverts commit 9425c591e06a9ab27a145ba655fb50532cf0bcc9 > > The reverted commit fixed up routines primarily used by readahead code > such that they could also be used by hugetlb. Unfortunately, this > caused a performance regression as pointed out by the Closes: tag. > > The hugetlb code which uses page_cache_next_miss will be addressed in > a subsequent patch. Often these throughput changes are caused by rather random alignment/layout changes and the code change itself was innocent. Do we have an explanation for this regression, or was it a surprise?