From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F786EB64D7 for ; Wed, 21 Jun 2023 13:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91B018D0007; Wed, 21 Jun 2023 09:59:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CACC8D0003; Wed, 21 Jun 2023 09:59:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76CE68D0007; Wed, 21 Jun 2023 09:59:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6777B8D0003 for ; Wed, 21 Jun 2023 09:59:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 37D0BA08DC for ; Wed, 21 Jun 2023 13:59:50 +0000 (UTC) X-FDA: 80926913340.26.F1B9F43 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by imf12.hostedemail.com (Postfix) with ESMTP id 4B1C640005 for ; Wed, 21 Jun 2023 13:59:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=REuh7nlI; dmarc=pass (policy=quarantine) header.from=sberdevices.ru; spf=pass (imf12.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687355987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zWFbewBe5gfGgxwvybbxWY3tmBMH88HB0q4OqowM55g=; b=GSS9m+X508oJDMX2ww05rZsMN4ObAWc3apFiByooXOaPpH0wRtkf/wFz3z71zAh7cSxgU6 e3XSQK8QY4pH861/me4esg6XvcFeJIM9pxWcKsHkyE2Xu2uVMZAlyFimL5UpG8XGvPwp/z dqNUjogkoKuXhQUnjWrzqzxW0o4yYi8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=REuh7nlI; dmarc=pass (policy=quarantine) header.from=sberdevices.ru; spf=pass (imf12.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687355987; a=rsa-sha256; cv=none; b=8oTQkDa252G14QhrN/A9z4Pi1Vl4mrRePvdV8HAYqJP7hD4HkdTYTpPXI9iVimBRY45QL2 wyRyCn7RZG5pYORi3fx6FAa4OUZ0HueWXrtb2SDQpNdZ3UBi/IpNXmPjG69uSISrH423QZ gcqUBsQvn+PgZ5D4LRY9i3t2xVFbuGE= Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id DDDB65FD89; Wed, 21 Jun 2023 16:59:44 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1687355984; bh=zWFbewBe5gfGgxwvybbxWY3tmBMH88HB0q4OqowM55g=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=REuh7nlI6eKQgPgchgREMfasK9VVxf4ZLeudY6Tp9LHidWn1d+qtZljMcxlveqXD1 dmPZp4MR/YKBuNtXtGpk06GCX0YfvrpUomIO5T4/z0nrCYKQLH8kmfy6snssQIbT1r crSzOAJ7yFB4VY2j7Cuc+sadc9rrNDGxWpD611oD84NyhfonYPunHf2IWR8QPGimLy 3oj9PFa5fkkeXRRHbZSPOCR7OZRq91ijgfzESIcNP/pe3qwmFuMN8I+easwEMbJDLl iWqmyVcICjmwu173iFRTPG+wwwl+awe4o65tvW/2j1zkdCv6aNoGMqd30WnWWkkj86 tQNyYZrI85Uxg== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 21 Jun 2023 16:59:44 +0300 (MSK) From: Alexey Romanov To: Sergey Senozhatsky CC: Minchan Kim , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel Subject: Re: [PATCH v1 1/2] zsmalloc: add allocated objects counter for subpage Thread-Topic: [PATCH v1 1/2] zsmalloc: add allocated objects counter for subpage Thread-Index: AQHZortECyHNmKOx4kiy6hdprH0m0a+TTmOAgAALNICAAbQNAIAABsUAgAAD2wCAAAE2AA== Date: Wed, 21 Jun 2023 13:59:43 +0000 Message-ID: <20230621135938.outx6qezuholc3hy@cab-wsm-0029881> References: <20230619143506.45253-1-avromanov@sberdevices.ru> <20230619143506.45253-2-avromanov@sberdevices.ru> <20230620103629.GA42985@google.com> <20230620111635.gztldehfzvuzkdnj@cab-wsm-0029881> <20230621131716.GC2934656@google.com> <20230621134130.tm2oucg5eskelwzr@cab-wsm-0029881> <20230621135518.GD2934656@google.com> In-Reply-To: <20230621135518.GD2934656@google.com> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.18.93] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/06/21 11:37:00 #21545586 X-KSMG-AntiVirus-Status: Clean, skipped X-Rspamd-Queue-Id: 4B1C640005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9cifs5qybimutmrdy1qsj3xebe1gyh6k X-HE-Tag: 1687355987-975312 X-HE-Meta: U2FsdGVkX197VpVSMlBdkjAqkJu02kNiULxgyJcWFBMRvlm7YK95rA/GXSex+sAAfdtL5JxZC28cFhHRh62BVEum1jLaj9b4aphd4KpDJr7HrvO0MZlZSi21OsIkNCjMBLTEvdYnPLeheeZDUF6Ak+i3fwxpz6uDQQ/pB8RUuCK7BbDF13eJ/cU3tZBt9X4mRkOZiwybbluNcnYwIlzuVc7IKT//fnv5aSRhTBDyYFJUcSWdTfVn5vJM2F2zmrs/n15EnUvNPrBPr7F8rBnsy3Dm+bNUVFGrBsvtu8V6inrX3kWzv9+xqrUVXHCvKUEdJ8NkgcOo+fRmtaeVd9Q+1/J4OVWGQz4AzJut/pSdHcWfPgPNNGcTenI0iMQDcfvF+tdbt9+DrlJk+8YtDNo8+6sGwuBdNSsGNrAP+Pw5zOQDKgl9S2HoAOoWkHN3aSSoB7OvCC0KtA3i4o3IF6idtg/iqSbFT4CQiXJoD6SRJpSmUdZjLELH1Vz7GLPXYL3jCBcD8wqvToTtXRgzdPBs6DDo6lG5xp1r6R8n+97ZxIW/B6K0S6qxFN4GpLH+ivgdzxYx9z9jUQk+T1ma2qsjRiLKbJ+TmCK4tpDZB5x1BArW+HUb7Q0Le4tA2+QeceBMql+N66yrGYxnzhqdOA0RxNqk5rCSlGNcvjDKX2Gwh9pUM/92JLlncVFpMzPYMVJpO1ucLTNtcITisViiFGjouq3Zu+KpV+1e3k7isuozP3WcHTdfs0NV8QiCpSFpUC8HDwiz3my8oNmQKgP0zkJlfvfDxhGejwyB/PJwrvGiiZLU8LPmgUnbsbKkVd8idXjwsLNkujbXB0nWenLqei2o4d9PL41hBTEPbEOLOojjMD5uLAoZIpQtEMqfWS8lht1yMkPy1ywfelJv/p2vbAnvuvLabyzfmGIV5L5LNnackmdn1lZPaYedd7jifbeEWWugLlDe0s1999Krp5pA7JV XVZTiyY1 zOpdX+jtXbKsRnBNx/u3fnQlD1dUvhAz35jH/Ff9pIEW5pYqmRmAVGiULRqVcLhlI50e8kHVfgi4UgeUeUaHTqj+RJ0/tnPMyD+N3fat4kMfYclCdiLfULj/ByjFiXuiNPLDgjfZvtL19hUM5Ru8NUOlMdDlIozl8Tn7+B94gsNBPk3V6oYtcPbq6MIMLAjbBTrZb90F3v9AY6+3YgXCPvXMhYRMrx+oCwSM4zhZlzroVqkN1M/TWgRdjgzz5BTm9R9VGuTzeJvmUm1ShlE2TkROXVnDIdDy/v25fv+HdihTDQVswH7IDxrLW0tJ8DHPl8hYxqzzleXgx+M8hHNax2xkSkTPuA2KnWz+j8/RPjzfZGC2yckuvZrfARSFTXEd8s/sdW9BQrxLq5QE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 21, 2023 at 10:55:18PM +0900, Sergey Senozhatsky wrote: > On (23/06/21 13:41), Alexey Romanov wrote: > [..] > > > +static bool zspage_empty(struct zspage *zspage) > > > +{ > > > + return get_zspage_inuse(zspage) =3D=3D 0; > > > +} > > > + > > > /** > > > * zs_lookup_class_index() - Returns index of the zsmalloc &size_cla= ss > > > * that hold objects of the provided size. > > > @@ -1787,6 +1792,10 @@ static void migrate_zspage(struct zs_pool *poo= l, struct size_class *class, > > > obj_idx++; > > > record_obj(handle, free_obj); > > > obj_free(class->size, used_obj, NULL); > > > + > > > + /* Stop if there are no more objects to migrate */ > > > + if (zspage_empty(get_zspage(s_page))) > > > + break; > > > } > >=20 > > Yes it seems my version is not as good as I thought. Looks bad for an > > architecturally dependent PAGE_SIZE. [..] >=20 > Well, we are looking for a solution that is both reasonable (perf wise) > and is maintainable. >=20 > > I can implement this option. I'll test this and send patch this week. >=20 > Either that or, if Suggested-by: Alexey Romanov > is good enough for you, then I can send a series tonight or tomorrow (aft= er > some testing). I have two more patches on top of that one. Yeah, Suggested-by is OK. Let's send a patch. Thank you. --=20 Thank you, Alexey=