From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF2DEB64D7 for ; Wed, 21 Jun 2023 13:55:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265948D0007; Wed, 21 Jun 2023 09:55:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EEEB8D0003; Wed, 21 Jun 2023 09:55:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0E288D0007; Wed, 21 Jun 2023 09:55:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF12E8D0003 for ; Wed, 21 Jun 2023 09:55:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 802FFA08AB for ; Wed, 21 Jun 2023 13:55:27 +0000 (UTC) X-FDA: 80926902294.23.98E4155 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 0B7E51C001B for ; Wed, 21 Jun 2023 13:55:23 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Q/7FQuLc"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687355724; a=rsa-sha256; cv=none; b=h/YluVE0cJghGxQFOmOfTpoyZerDUhPdOt5r1UkSLy4wNtzikNtPbErCxD4zxFaYu+3nZU +f84ru+ijrUpaOI8jbiDJP0K/H8o6sjHdVeFCGEuWQgCU3or2aTtfOsxsLhluZ1kQNd+vG bPihXUNZvkWcnffGIuzVbEOXddiWcgY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Q/7FQuLc"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687355724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p4pHQjZOMqBN5NmKCmx+GJA0YbJi+vSazVFlD7bdpAk=; b=DvUtHLxhHig2gLepZXKQ5uQEZl0N+MfJ5+epw+IpoJ1TIexFS/MqNfer3S6ERzSzajto2C UEglXMyHUuwnvr8uso4dkNIw4/laLyRMwWsjx3pbmhCshewBB9OmYQ8CiqoVITEU2U3lp+ Dl9uu4cScuKHGaxoUDLhLYvzh/oSOZk= Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-38dec65ab50so4351524b6e.2 for ; Wed, 21 Jun 2023 06:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687355723; x=1689947723; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p4pHQjZOMqBN5NmKCmx+GJA0YbJi+vSazVFlD7bdpAk=; b=Q/7FQuLciu+yygCZvdriuhqDpOo04n9GD+hoY8dGXfWSHIZ6JOkYjl7Uv1RyT+nldf MMRVtI2vdWUyy7i+d5ulQvEheHoRH/AYXdV13q2P0gKy5ld5zvg7/a3JlkEFyzWCXAZe H4F7X7uTDAk5YuehaJk6iYEivkQOa6cjq/WmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687355723; x=1689947723; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p4pHQjZOMqBN5NmKCmx+GJA0YbJi+vSazVFlD7bdpAk=; b=QZovr93Z0g3u9Nsm5vDJZDRy2u2NMbVicTkUxPnvRhnCSedMJ90hWhsFcZTsVsAkjo xetRQOdEPGQWEitnkmM5/Yi27YaPTqZZyXd6LnytEY5dUbq6tIaLvbA6ITr17XXKBwT/ aiG53IIWsSA5yPLVJ5LlxLxVu/ilQ4CTdGyqN1uqXCGO6uILjUCciT3hL8/dK+PQu9gI QP25SETai5YfhHK9Zhk4g/L1MLpQdMpuOaPnIngN2hhYxgOUFwlSWSuZYyA8j73/LW1/ A2+iA5KFiyBIRINLF1yn4lErzSlssZmvD15CsptUdPy/rdMdfnaoAGqNaQlK3hQe8Mqq 8s5w== X-Gm-Message-State: AC+VfDykE4PEirNu86t5mLfKeP9hYV9sQGpXqvbQv42UzfgBcj/ENq5H tmK8RPRCtdm3nURIVU+U0wFoLA== X-Google-Smtp-Source: ACHHUZ42TWrozkAAl8dKheHX8FGuRKJk/RX5JCl2EV0zp5CjFa3l5t0IGddLDqpWq/voYddAFYYhCQ== X-Received: by 2002:a05:6808:614c:b0:3a0:3a17:a146 with SMTP id dl12-20020a056808614c00b003a03a17a146mr4511810oib.57.1687355722979; Wed, 21 Jun 2023 06:55:22 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id y17-20020a63e251000000b0050a0227a4bcsm3163906pgj.57.2023.06.21.06.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 06:55:22 -0700 (PDT) Date: Wed, 21 Jun 2023 22:55:18 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: Sergey Senozhatsky , Minchan Kim , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel Subject: Re: [PATCH v1 1/2] zsmalloc: add allocated objects counter for subpage Message-ID: <20230621135518.GD2934656@google.com> References: <20230619143506.45253-1-avromanov@sberdevices.ru> <20230619143506.45253-2-avromanov@sberdevices.ru> <20230620103629.GA42985@google.com> <20230620111635.gztldehfzvuzkdnj@cab-wsm-0029881> <20230621131716.GC2934656@google.com> <20230621134130.tm2oucg5eskelwzr@cab-wsm-0029881> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621134130.tm2oucg5eskelwzr@cab-wsm-0029881> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0B7E51C001B X-Stat-Signature: ybtfugoxoqtnirzao9zy9amo6uim85gb X-HE-Tag: 1687355723-917635 X-HE-Meta: U2FsdGVkX1+3V+y66hWsaHb0UV8QS+RcCUmR9VCdxG30OlW34qhB1Hyy6DPfl1izDG8roQZPs25lU3Nj7SRY/pPnsG4oYH5k5y3FIeUMpvq1BEpliVGZ9HTp64FZbF5/hOl1/WEt9esTqR/GTkyCiseOs48A489JzbXrNIEtRHu6ltHG4S4Q/6ab1gOf/WMh+0Gb2r4V5cS4sdCu4HehiUJnx+ONSUSMD79RKD8UUgln5L2AJkixybugX6rxKlHcvD5Pp3hR2evcJAVzvDFWkkSdB0i4G5OMj0cMODa3py8F/GsrRB3vAvG1/VpZXi3kFQTC9ZFVE5cOqFYcZMHpQE1Lm4+g20nTCnK0gYjDu+AtEDA/HaJoyLujK5e+77U09aALOsrIT7ihjg529H1XToBme/sRT3L5GeU+qQBvZwP33ai1H5uAYRuq9h2ejg3gsUKSMGdcsKjScUgp9ThdGDovCd8L41tGaCB3T6Oci0ctPTF7IRk7rfTPGejdZAZCzHn9+Iq+WT22OKhadtg7ttkxjVFb3IayxfiPDTcTtn8aAPCTOes/6RVuZCBK4+ITZvYGsQ3yvxoRz7VfWUKDoeRWour678aWvZ6PH4LN1IzuqKj/ZINEG8Fb8Bptqoxh3uc51mjPwzetcg3QnTCWFIU9HMxugqInlXBtMQ5HTOfs4pAyHxds9na97z6a3LtmC50OqsM4xDO1in0EIniahzSpvGRE0/Wi1NY89qXkgIHlu2RDJhSQGdZS6eq1TSRMwYcpnFMKyh/WLolYKgtGEnVzgbPvvIV58gP4R6dleKYAAQNAZTYC21crYXJPo8AEkHE92JZb8VRtNFV92EIl/BCuQbO8M4f6hsSE6c9Hn5qryN+KbEBL5EDeWt6B5f82f/G86R1uoWc8nl1uP8Qh5xEJYKkHNs6NvObmSosZyj7/SUeyZLUao80Zmf8r75NP2CGUfADxjYxtinSWZet dwHc2Ot8 TxSuaFXqatZLtahHUwYSfA029vFnzvnBa4YW61Y8SyIpu2nkzbIH6kP4KEBRedwxuVmy3E1yXtFLn7dt6370L3V1XKqTsY9fvq9sB5AbHTqA4AwVThSc8/WqjDLpYudgicuhtokcgjMjFC8TVTFznt7ti5JT3DREvdhqUu1Pjx/Nx+iQ+jKTV24vXSP2iMU6tUBq0ERb5eet58R++pyDkRS93zjJdjTpqyWg3S1RRDhSb5rTiL7nqZL7NBpNQCDf37I/Wu7FgGitrfeA8jvWneMXhXMDRD6S858Xv7Og3slSOaX1c0nns33YDez0NSoqr+p9IwUstw7zWuu4mjERTr4sF0TSaixvs99V0jeWXgs/4N+W2oNERPVHVTvluNakDsF/KwHa5oiYRi3roLe5QqGmaeEqpCsuUgbCr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/06/21 13:41), Alexey Romanov wrote: [..] > > +static bool zspage_empty(struct zspage *zspage) > > +{ > > + return get_zspage_inuse(zspage) == 0; > > +} > > + > > /** > > * zs_lookup_class_index() - Returns index of the zsmalloc &size_class > > * that hold objects of the provided size. > > @@ -1787,6 +1792,10 @@ static void migrate_zspage(struct zs_pool *pool, struct size_class *class, > > obj_idx++; > > record_obj(handle, free_obj); > > obj_free(class->size, used_obj, NULL); > > + > > + /* Stop if there are no more objects to migrate */ > > + if (zspage_empty(get_zspage(s_page))) > > + break; > > } > > Yes it seems my version is not as good as I thought. Looks bad for an > architecturally dependent PAGE_SIZE. [..] Well, we are looking for a solution that is both reasonable (perf wise) and is maintainable. > I can implement this option. I'll test this and send patch this week. Either that or, if Suggested-by: Alexey Romanov is good enough for you, then I can send a series tonight or tomorrow (after some testing). I have two more patches on top of that one.