From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62FEC0015E for ; Wed, 21 Jun 2023 13:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D8838D0006; Wed, 21 Jun 2023 09:16:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 188438D0003; Wed, 21 Jun 2023 09:16:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1CA08D0006; Wed, 21 Jun 2023 09:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E05DB8D0003 for ; Wed, 21 Jun 2023 09:16:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B00FF1206FB for ; Wed, 21 Jun 2023 13:16:00 +0000 (UTC) X-FDA: 80926802880.12.20B7943 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf17.hostedemail.com (Postfix) with ESMTP id 0B08340013; Wed, 21 Jun 2023 13:15:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=JNcJ5ITs; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf17.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687353357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NbLD2SuFhZddkTpTyuzHX5np9Ewwh7mfi7FsRT8ROaQ=; b=eHDDMHaMsChhV0cjH1E1nx2EX4J4Qc6r+OgKCaic7+LSXGOXv603BIEluNxmcvBwBy1oBw /Y3q8MmGD3towhF5ie5xXaPA21U37xawYfXRe3qKfJF3qEJKrwMRwoFvQUxxdbyvfn7YKr TjxF8P04hezchlJ/9qmpS42GT4p3Hxo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=JNcJ5ITs; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf17.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687353357; a=rsa-sha256; cv=none; b=r0cOR+GmkWNda9dEAZFC+gyUgiDwhgLvuLFc3cHIIpUrIS2ojmVOX9rbrgXdFa2DY6elNC QjF+oCYPocPkXXyj+iaeakHu2Cxqwp9TpdnaoubiE6pRFBeFRwJqd7EdKYvFknHsXrF3Qh X+P2Gh3GohkRQ4XleyZMdD8vbisdlDE= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230621131555euoutp01cbc0ed048af8c2bf28332479f20c2ce4~qru-OYmE12681126811euoutp01m; Wed, 21 Jun 2023 13:15:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230621131555euoutp01cbc0ed048af8c2bf28332479f20c2ce4~qru-OYmE12681126811euoutp01m DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687353355; bh=NbLD2SuFhZddkTpTyuzHX5np9Ewwh7mfi7FsRT8ROaQ=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=JNcJ5ITswF0IEJpYFOaxysTaMYVdrBOLr7EOczmyHgvwYgKoHvv+Z1wasrE5vJ9ze mG9m6hTMHD7eQZj6dy6futmrUSKu6ZtWcQPOiIGUJooV0+o97DkZ38AV+6ABgERAne ODsU39a5aZus6HUZguwhXM1F7n/MUL3RoWmKiS4c= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230621131555eucas1p20be9c897ff3f7c6cf943c864400829af~qru_4FVm-1334713347eucas1p2z; Wed, 21 Jun 2023 13:15:55 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id C1.C4.11320.A08F2946; Wed, 21 Jun 2023 14:15:54 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230621131554eucas1p135050d4ea931b8da593678132937163f~qru_TTVJM0660106601eucas1p1u; Wed, 21 Jun 2023 13:15:54 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230621131554eusmtrp1692d0318dd759904de572872ce9c6b36~qru_RdmKS1434014340eusmtrp1j; Wed, 21 Jun 2023 13:15:54 +0000 (GMT) X-AuditID: cbfec7f4-97dff70000022c38-5c-6492f80aeefc Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 94.9A.14344.A08F2946; Wed, 21 Jun 2023 14:15:54 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230621131553eusmtip164806c07aa1bfa8f2bab3ed09c2fc98c~qru95WHid1267712677eusmtip1g; Wed, 21 Jun 2023 13:15:53 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 14:15:53 +0100 Date: Wed, 21 Jun 2023 15:15:52 +0200 From: Joel Granados To: Greg Kroah-Hartman CC: , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , Theodore Ts'o , "Jason A. Donenfeld" , Jiri Slaby , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , , , , , , , , , , Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init Message-ID: <20230621131552.pqsordxcjmiopciq@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="kqwdriluwhsvqta5" Content-Disposition: inline In-Reply-To: <2023062150-outbound-quiet-2609@gregkh> X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA2VTa1BUZRjuO+fbc5ZVmCOYfCH+CEwNBAtT3zFpYrLxdDMtK6sxW+UMOAoo K6ZZCssmsmIgoOCCBu0IC7sBwrJBuOCsIHETJLkJeAMV5eINBNyRjfXg5Ez/nve5nO95fhwp 7Xxc6ibdErpTCA+Vb/NgZNh0frzRRzaWGPhG6YHFkJ5vYKApT49g1JpGQ1lfJ4bh8U4W1BNG DAZjFAWPCiYYeFRZzUD/uYcImntaGEi5E4Uh/U49C7bu2xRoMx/T0FcQgyC9UYVhSGnFcDOh mAabScVCtDafAUt1BQvHTrtCWko0BYnjCQiutbhBeocfDJ1wh/GsXBby8rUUKEt0FJgu/Yag MllDQ3f8UQz1h0KgrG6EguIuJQO3yw9TEDt6CkPyMSWCM+YaDP/8lc7AFYNNAvfjbjBQmd+A oe783xj0f0RK4FTbRQoMsTkSaE+4iSBp6BYCbfY8eFDxOTSfzaAgq/Q6hotRZxHok5+yMGa1 SqAzMQVD9eGzFNh6RiRQfvAaBc1j/RjKTv/OvPspP/rLr5i/OvAU84aTBsSnRV7EvDGng+K7 TpUi/kj0EMuXarpZXlV+meUzCiP41rKveVXloIQv0nnx2jN3KF7d3kzzhbmxzJoF38hWBArb tuwSwhe9870sWGfNpLZnOe5OKuihIlHzNDVykBLuLZKaU8SqkUzqzOkQUQ52UeIxjMhRm3bq eIRIaWwqeh4xadIkopCNSEz+CGsXnrmqzO+LQjEicXrLZFwqxdxrJEfD2T0Mt5A0DnTRdjyT W0ziGzTP3qa5W7NIU+sAYxdcuPeIObpXYseO3DIy0tpHi3gGqTnei+2Y5naTys5R2v59mptN siekdtphslzNeTMrFvUkbeVaRsQ/k1rj5WdrCNcynTzpvjUlrCT3rjbQInYhd6uNU2F3UpcU h8VAEiIVE/dZ8dAjkhU1Qomut4nqUu9UIoDolInI3ohwTqR9cIZY1IkkmlJokXYkBw84i+55 RH9lACcgT80L0zQvTNP8N02kF5KMsofM/2hvkpXZT4vYn+Tl3cMZiM1FrkKEIiRIUPiFCj/4 KuQhiojQIN/NYSGFaPKPrZuoHi5B2Xcf+FoQJUUWNHcyfKNA34TccGhYqOAx03FOYWKgs2Og fM+PQnjYxvCIbYLCgmZLsYero7d/zWZnLki+U9gqCNuF8OcqJXVwi6T2LW3rmNNjVi4q2fFB f6qkqnGTdx377R6f0ipFU4zvww9/ClkfkL0jQNd7Inbx/R6v5UMfGVXLmWk1y141y1YtbbNV yQ+o102fc+7k8V7vGTdNW61rM2P5ov2b8oIudH8XP+g9i50VlJQU7E5MSyzyAenGDJN7uWdx bfquk8HjLp8wDuWdPhlLZC1ORX+upoe9X1Je3d+6t6n7EFanqlaqX4+7azN/ORhp3LSh7zMX /3We0f4l5rEvrOqilU91HgvqufY1tdlO0c2Rgesthse1T172mx9zbEP8Ov9pK74yWMKc115o 8FvhdOS6/+oifDtOf6lqPvTUzB0IyGp1Qh1hr8Ts/XifB1YEy9/0osMV8n8BgipHCCwFAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA2VTe0xTdxT2d++v9xY2lksBuaAmS93YhrNSBD1MIGSL8e6RadyDsMW5Bq5C Bi1rgeiGk2cm3VCoKFkpivKSx3itMJSHiBXGAAUUxPGQlwIK+AAEVoFRmmUm++/L953zfeec 5AhJUTntKAySh/FKuSxYTFni5qXGvs2W85oAl+laC9AVF1LQVlSAYM6YRkLVWA+GmYUeGtRL egyF+mgCpkuWKJg2NFLw8OpTBB3DnRSkjkdj0I230LDcN0pA5rlnJIyV/IhAdyMOw1SMEcO9 pHISliviaIjNLKagvvEyDadL7SEtNZYAzUISgoFOR9DdcYWp9PWwkJNPQ1FxJgExlRcIqLh1 FoEhRUtC34lTGFp+CoGq5lkCyntjKBitTSQgYS4bQ8rpGATVNU0Ybl7SUdBfuCyAxz8PUWAo bsXQ3PAHhoJfowSQfbudgMKEPAF0J91DcHLqPoLMXCd4cvkT6KjLICDn4iCG9ug6BAUpizTM G40C6NGkYmhMrCNgeXhWALXHBgjomH+Ioar0POWzm5uLP465uxOLmCs8U4i4tKh2zOnz7hBc b/ZFxCXHTtHcRW0fzcXV/kVzGWXhXFeVHxdnmBRwv11w5jKrxwlO3d1BcmX5CdSeN7+QeCoV 4WH8q4EKVZiX+EspuEqkHiBxdfOQSLdu3/eOq7t4i7dnAB8cFMErt3h/LQmsqL5JhmZZHRqv yUdRqO0lNbIQsowbW6FNE6iRpVDEZCO29EwuNgvr2dKZToEZ27DPu9SUuegJYidGNZRJEDHl iP17wF6NhELMvM7maRkTTTFvszcmekkTtmW2sidatbSpl2SG1rIVI9dWBRvmPbYmdmQ1wIrZ zs52jZHmgEnEPq0uxmbBmm36ZWQVk0wEG2MYxqYwklnH5i4JTbTFygZNDTW0edCN7O3aTMqM j7DTi/dRErLRvuCkfcFJ+5+TmXZmu5fGif/Rm9iccw9JM/Zii4oe4QxE5yNbPlwVcjBE5SpR yUJU4fKDEn9FSBla+ZmKhgV9Jcp78ERSjwghqkevmXYvKWhDjliukPNiW6sNZZoAkVWA7PB3 vFKxXxkezKvqkfvKFZNJRzt/xcoDysP2S7e5uEvdtnm4uHts2yq2t3o/9JhMxByUhfHf8Hwo r/y3jxBaOEYRorY9DpK1fYtfXTsSad+t/9bu+nXRyztbSVtBQex8f2zA5gZfuxavU9LKjvTG hSjLxAfi4nGHzmjv9rp9Vz091cKlwQ3GxrHPPA43q3FV4p/+axJ+EEw+HfjoU53BCT/LuvuK /ujaSxHGHXhd5RXvmfhdh6Zys9d8Pu2isX70VlWCj1OTww2rW3U2BX7H3zgw23y0/zz5eIeP xicmJLm8Pt7t+W4PZ+s00QG3d4d2WguGRp3cRw2MaK/ueJDUl1fn7O2JSp/pNzj0dnUYB3lF /L5WjZY8KdfrPsj6+LBoUVYu8f/+lmfr2YzH7mHnr+2y84u0DDV4Rw5uEiPfD7dE/H4lPUKM VYEyqTOpVMn+Aa3aWqDIBAAA X-CMS-MailID: 20230621131554eucas1p135050d4ea931b8da593678132937163f X-Msg-Generator: CA X-RootMTR: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> <2023062150-outbound-quiet-2609@gregkh> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0B08340013 X-Stat-Signature: jhcz4gpbd4xpnxs1iwfatfupt6gt5gnc X-HE-Tag: 1687353356-119534 X-HE-Meta: U2FsdGVkX1+wdBChqGD//fHNm/WBOHRxyLr2QSjeDoVU1fMmevxhOViFWARn4QcFlkqM/HjLJPnLX09dKxMTuoxeIx06xKwdvr+Vw3pI5aZxJwJ7IoPaHKu1C9nzNQFcWFMC3updUfH/k2+0DfiYNlUorwAPzfjEs7ECF6iOcDiO6SSBJeGm5knn6Y46W5qN2yVtAvgyB2/Bt+cE84n7ZRhfaImEoQu6nGHXAhetAtgzocfG8ueyUyuHq0gOpoAJPKC36O5qwvcXphWFkOdtnyXJPlr/MWwEaVhHNM2PiPqKs0Bk2Drcz2Dn2NrAC0dlIQOQXImSJ0NfRkH30prCO8aNj63l2fQ66sW/Fo5AM7Hocl1xzc0onNf9pHT8dztBLd8r4HEQJ44ztYrkPTxAYHNBB2n3jdUt3F+O+cEHPqZEYWRWeM8IxAAaqCS9O9/mZiOPY4C04geC4LYFwVvU7Vg6eDp7btlWpZN/RntauS6sQk8g3/yiTwVwU53Gj4v0zOYy1g+cAIDUb1ctIV5qfjuW5MtoTCk3JtVg4nOcXrS2rXWbNx+mQQXop8wE/uNp+R2vRbgsmcnzHGComgddegQYKFEZbJri58lkmo2OuChq3hamhH+/zS4AD/ohrUfgj0bj5EfCX4rx60UNhxm/MzlpPIcLTz6cmwefmH1lLjXD4c4X0XlduCYxWmRjKPir8clNZVQ57JnY7suoJBC8TGlq4LXHwS3bdxsL8SQK+rFzhxIVQowaN4W1tgDTeVdepVnH14Tub6gLxhypkWfUi6zkzvtXNO4jcp3j9xYo7XiPcZFpsb6eKJgipOQwP10La4+XxGEfoUVXaVqT3032lqaqA0iEfvmEvKMO+pzaZc8VBFhSl5DFPq6ftYkjpD5XDm2PXX/WnpfBG/n5VVBMXB/9yrIl/YK+NEh66lKqUyvddigch5ksoQXyaFPPTxRDA6YBz48G++mkII0JHs5 OArRCFA7 ivCbqR1lVYG7PWm4vYrn0tjx8krIBvhqap61lvx9mct/mwVzGjhy6Ufy9AllThqH9NrLMCJDcEmxfO7XN/jTz+Wyhfy7SR+klx6nGPK9zFp1PPMVE0DvlLvfLc8lxbqXAQKxUGKWhjxe1Rq/2avnhnOatnzqtS2dgZQYMN1LZM0LV3W3X/UttsnLLA79Ogz6OAH9AzJXBYkSX/u1KBhBvXnh0wIkA97rzcu8IrvZsdmhcbiU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --kqwdriluwhsvqta5 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 21, 2023 at 12:47:58PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados wrote: > > static int __init random_sysctls_init(void) > > { > > - register_sysctl_init("kernel/random", random_table); > > + register_sysctl_init("kernel/random", random_table, > > + ARRAY_SIZE(random_table)); >=20 > As mentioned before, why not just do: >=20 > #define register_sysctl_init(string, table) \ > __register_sysctl_init(string, table, ARRAY_SIZE(table); Answered you in the original mail where you suggested it. Best >=20 > or something like that? >=20 > That way no callers need to change AND you prevent the size from ever > being incorrect? >=20 > thanks, >=20 > greg k-h --=20 Joel Granados --kqwdriluwhsvqta5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmSS+AgACgkQupfNUreW QU8jOQwAkoxloAVnIuEyaWUNUmcFoEEQMjNqdYL2wi038MemWOYfweOEMRyOEo3b iqRfJVW+fiwb+BFTXw9Z3i1KteXm7mdz4YY+VbjJiygOSu0zhM4LY4ViTh8pu5LV FSsRDdRaQZfbeb8bog0lWFauAs5AfpyFcUqvZM1O9TDiI+nMrMlzb4PzSBJeIq3r DCIxRhnWhl/QbfXYBx8rRHskljcS6NTXtILN4S3H88F5YOdof86uQwtXnz28VLdW C6DK8aafbLVrwB8/nYX6YxrT4nFquNKfodH7jKM7iHGCxZWc3ALSwvKBA6mjMSCh GqhXmroSN4hN0N1vA/oDK9ZwZ1GPwqmxtmXe1Rtp/Ah3CtzC2F3hbPxaHP5yEVJS pyPZRKBdEvIvWFhDf3JfEAhrvP08QKKyDN6cihST4dXQ7SHdgpwAVcK7hLnNU0mw Tg+iK0faxcu/tfkmixursSgigO7zwZJXKbBifv3mQ1RP5E5QnsSfgsgY50ogU7/I hN6IedMI =UHCo -----END PGP SIGNATURE----- --kqwdriluwhsvqta5--