From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B162BEB64D7 for ; Wed, 21 Jun 2023 08:54:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AA168D0002; Wed, 21 Jun 2023 04:54:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45A6F8D0001; Wed, 21 Jun 2023 04:54:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 321D78D0002; Wed, 21 Jun 2023 04:54:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 20D228D0001 for ; Wed, 21 Jun 2023 04:54:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ED2361607EC for ; Wed, 21 Jun 2023 08:54:52 +0000 (UTC) X-FDA: 80926144824.26.B06B030 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf19.hostedemail.com (Postfix) with ESMTP id D77E61A0004 for ; Wed, 21 Jun 2023 08:54:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=bXvV0+px; dkim=pass header.d=alien8.de header.s=alien8 header.b=NZyPtAM5; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687337691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PaijKeZv9hHzPlRW8nV/FYz8UIKd1karlQoSdFTK9HU=; b=aMVAMrgfpwhdTMHq2Fmei7YTRqO0xnLnQtu1oJKyUFNI9L0oDbWd7TPmimXlskAjjak/My 3uxmI7PB3UxAeLtiycg8U4wBL0mRC74KT1EfjHm/eZSyC5tmXrjr0kR2YDFEU2WRV8W8bW +o5hz/Tk0SvLyvrExr2M9htxPHQM/Qg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=bXvV0+px; dkim=pass header.d=alien8.de header.s=alien8 header.b=NZyPtAM5; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687337691; a=rsa-sha256; cv=none; b=vKIMzC+d+em2pXsiDTS8aMzD8ShPp+kmDjPkQt95tai31mglKKEHc78T+FEdQjARUMWd3f tnsHaeCu+ytRlEgm5FvNOomuYUO7s4hxXynCkPIvezPr1XDNcAfepc3EQss8Yl7ZNvOoLP yJvD7mrQGn0lgGwFjsfuW0hsM8YQoEs= Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A60A11EC0645; Wed, 21 Jun 2023 10:54:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1687337688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PaijKeZv9hHzPlRW8nV/FYz8UIKd1karlQoSdFTK9HU=; b=bXvV0+pxKiaymh6RMR5E7TymGBtOIKsJQRSEXl6ZgJlqDLoxmRN+EbYq53nMqpeSm8Fqcv juvqXqCN6U9D1PMExuQT2nUWstu0UHyTHq6SadvJ6vqMCjyKTvbQpFF+6xoNHNbK+zgcXd lMHc57oV4O1RNKyc122eH/G4HXSD12g= X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id J9iqJbrA_r02; Wed, 21 Jun 2023 08:54:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1687337685; bh=PaijKeZv9hHzPlRW8nV/FYz8UIKd1karlQoSdFTK9HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NZyPtAM5/IdcCmMCgT07D/cKwY5LISGmi08sReq8DvsGMAJg7TbmGflxm2e4+nhW1 iM8n4szOWC7EJktdC7OieNP3tV1U+8A8rGXnToElYLW9jG7PFYvhP/pxB/hG0gD0A5 NvgkTVHjWBzSaTC2PTYLrnb6dis6w/coleE3KJ7P5U4ueUijT+AY6Mw3eGKF/rpJOl 1+3U94yuoOb95xXewS808ymG8YphUWenlYBtwW1c59lKr3Bn5mSbiJLdjGiWnMxfIB W+IDhNs+64UGOO9sJmxs2+Qm445XqPoUuR7pqJpjx3DHGjK3Sb1pCewY4sVibZX3LX s0vVMDCE250TdXfAao/7fr9iTE2uU5U4fkvPZCZ/++dVp9/vBPEzvVJVSkfoDw/TWW ZGorHZa3NrTRAsNHRifAqR6/OV6uq7uqOwZBVdsra6/+Zymo6cXFgzqIHTwbQglT1Q hoZ6+C2USb20l9LItSwWGf+id6/NME+lQMm/ZGG7Pn5D7CdZT2epathV3G9ZpzgMUS BVC8P2MDBpL967kRs++EckTvrNYXIAi4Hml4Y9d6RNE+WHkqH5egbll7z0yZUR68ja XBymJ9aKqhJAMgYgsL9YnDigIu5FZeZfinbP/8kBa0FRKJS+OrU5iqj2Lar4z2aNqy 5dmKsESs5nfxY7bHbIvYwrqA= Received: from zn.tnic (p200300ea971Dc592329c23FffEA6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971d:c592:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id ED59740E019B; Wed, 21 Jun 2023 08:54:04 +0000 (UTC) Date: Wed, 21 Jun 2023 10:54:00 +0200 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, "Kirill A . Shutemov" Subject: Re: [PATCH RFC v9 05/51] x86/coco: move CONFIG_HAS_CC_PLATFORM check down into coco/Makefile Message-ID: <20230621085400.GDZJK6qMeOU2monJDv@fat_crate.local> References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-6-michael.roth@amd.com> <20230620120920.GAZJGW8B6XHrsoLGCJ@fat_crate.local> <20230620204315.xr7wtcrowc7oprka@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230620204315.xr7wtcrowc7oprka@amd.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D77E61A0004 X-Stat-Signature: dt33w1owrynwb53d7mowgpqu35671rzs X-HE-Tag: 1687337690-736107 X-HE-Meta: U2FsdGVkX19NbVeXsgN6XakBXF9U6sbXqLdig1CsNY87imKREIKZefeUWHlHeh3DuMok3wSPtyMOYxhVG/I6McYpwtQcwhGTYpwNobaTl1j2RetLyqvGHG6XVowt4t4EciHbUg7zCWxMd72exGLLfMt+kebiP2ub9YqS0UZPB6JgCfiaG7I5qSKuSJgN4tG9d8W49Um20zNCqYPH40u3M3lJ5ZmfB7tbsTA3u0WVYciG77OqH1aMFNhegYyYLQFdmHQVwcMD6HPauSL+0GuINosoT4cwIoNH0HJ9ip0fH4tDuH4YaDkhbzeT5pgtEDFNJ6HMENNbkvbmIIV14UTn/mQobpPQ9mIRG7e4Fm7Guud1Q3JardNUPSF2XRQjozMeerTCMdhxfEi0pp8m53hH90OHKEl+uRkLvPb7iQqMzJGuyQL8tW2tU9FQJPqswMgtHvGT2X9X/qWRVF/Q1gBsBLkgRv2/2ME+1wMNTC8th2SPomEnPpGlFo3AkT9+jXOAtZUBOkQAojSsMelbSrDZ7GtXcjvLYuOVHqLNBejhxkEF97E83BvxKV7+FJVsH+wwWbxvsDHK6OmJsZ9xHBg4UXb6OcvIW1etOYzg66ZbqWZ3NFNfmgm54JHRvyyJez6v5+OTThawqEL15xA6TvAzTGEmWNNg1uUnB4yRGOzViOthaW6DXgT/Ak6RzpAYDnQ949hmmtDeBklwoA2fTIOTrMU50IU9iqi9Mtt8N93zSy6qxy3HmXSCdfP+GD5h8eUYYmR81CoHX1GuqoYbrwKKVlfmCQ2HPC+ugZb5hdOeHUmAylLHXBlE9anaMGYr+2X8P1d7rgGDP8WAteztfJ3pEZKD4h0UZ9TyiZ39i3Jt0SxfotWhTlkPTNsmPaCozoj4aDwmT7xo0L4MpP+/bBVhPuvzUwqUn6tcTZ0YTIk8EJJo+JRk6LmCt7189zxdRHLiWD5zTfwoGhmKGzL5vAs lZn2e5Js LJKypxiFlKEb+fN9NFrFWrKSC08zqn5QQSiSMQPQ4nDE1wALjtqA/QbeL9V7Tl3qtN/5mK6gUruf8qZM6OCEO24mOkqxxf6lulRU7DTGHkTOygnFdshh322R2TOnFQMI9RXe3usg76EpOTXxuhEfl9q4fCTXzqKaAHKcOf9IWTr9RKFylxKUcmQ9eDQi7B2UL+jR4NnqFcY2rqZgCb8091xA+Opov8D+JJsdh0CVSDcZYhXqUGspLVcvwJPSgnNB1OkLhoHi8GDe4fIuH910HAALSODls3LdiWwxv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 03:43:15PM -0500, Michael Roth wrote: > Basically, arch/x86/coco/Makefile is never processed if arch/x86/Kbuild > indicates that CONFIG_HAS_CC_PLATFORM is not set. So if we want to have > stuff in arch/x86/coco/Makefile that build for !CONFIG_HAS_CC_PLATFORM, > like SNP host support, which does not rely on CONFIG_HAS_CC_PLATFORM > being set, that check needs to be moved down into arch/x86/coco/Makefile. Ok, so if you put SNP host support into arch/x86/virt/svm/sev.c, that should work too and won't have any relation to CONFIG_HAS_CC_PLATFORM, right? The CC_PLATFORM thing is a way to check for confidential computing guest features by abstracting the capabilities so that you don't have to check *each* and *every* conf guest type in the conditionals and thus go nuts. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette