From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F25E8EB64D7 for ; Wed, 21 Jun 2023 00:10:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 769E88D0003; Tue, 20 Jun 2023 20:10:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 718F88D0001; Tue, 20 Jun 2023 20:10:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E15D8D0003; Tue, 20 Jun 2023 20:10:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 500BA8D0001 for ; Tue, 20 Jun 2023 20:10:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 166D51C81BE for ; Wed, 21 Jun 2023 00:10:44 +0000 (UTC) X-FDA: 80924824008.02.71C5398 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf15.hostedemail.com (Postfix) with ESMTP id 405D5A0017 for ; Wed, 21 Jun 2023 00:10:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=MxRfzc1v; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687306242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sDoj5PizcTKiqq5oaVy5xtW8w+Dir/LUc1s8hK7cyjI=; b=xvTP+17IwXc+YTfGMhLQ9e9ELTxiPHWOKseTlgcKkEIJk9jUTtefvxVcUPhI7MdAWXFbSl 8sZnORvd2y7G69nKhHJftF/AeCTjGYUUuOejpu9B0ZLYv06s3jccK7iYIJNFFQ3zbOWg5M 090LXQ5vPvoRz+IsI3IwV8XcvSnu+RM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=MxRfzc1v; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687306242; a=rsa-sha256; cv=none; b=0oo7mOzahTa1ewt80mdME4dJhiHla8QTj6RzrxMglyApBGZmB6HJ51kEGoQHmUdJp8Zo/P AgcUXC2MZAqjQ2w1fDcnAnqkXgpIe8AnyRqmOrNKBqQ0f0D9HesAWAzaknsm99TNM9/FrO fl19J7LdoI/bbcgxlB7NpeB8bBEXJsM= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-666eba6f3d6so2267461b3a.3 for ; Tue, 20 Jun 2023 17:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687306241; x=1689898241; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sDoj5PizcTKiqq5oaVy5xtW8w+Dir/LUc1s8hK7cyjI=; b=MxRfzc1vGvZjmUSK3wSSYsPaxK/+eKVXg9yUx04aYXW4w1zjS5gJiN9BRJBjGbZJ1o 0jqovS3pviU2TkQAAUg0AvYmKyqWrE5FHICUk8VwCXpD93/jxE1QR1EcGRPgXHtOZXfI 1klvD0X02q/kN/H0f6kUoM6rx8UcoZSI2fhhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687306241; x=1689898241; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sDoj5PizcTKiqq5oaVy5xtW8w+Dir/LUc1s8hK7cyjI=; b=BPwXz2wQO8Hr5HpvxFdhK9PJW/Jys/uK8pp7F05zxmU3e7BAtmyj/gdGbdD4oc7Vw9 3OQB8Yge/vauKrhgRbvOvzNPFhotfyUJvSHBgqOshcJCxrC7ZN7Z0uQvnxBBV27PdMdN nvLxkJ/Tj7SMzTbTAwC1AAJeZv8QeJIEGpwOsl50i6YwKsTpQYM02W3odzoRlsFVIf4C TQZlP8QLMiunCtdiq4j6HNTDpEIcxPA+6tkaNbaWaJZsPfdgA8xiSgkGjH64GsxsJVJx HhDyQWswrv+uZeObZ0yrxXYBzlJoTTLq+i5+lCxb5usrwgeiC1+ya36FTVKoyT5XJ5UD lBKg== X-Gm-Message-State: AC+VfDzcEGVCD1z5ueDVfLjLe7jCRiZmTBeswzzzosJG7ExRtg2Qv8XJ FUrcOkTqRXA7sUQabpOMtjlvMw== X-Google-Smtp-Source: ACHHUZ7M1TXH01T8EJ1f7D/M/gWLBY5GZ2T6Wi2foAXBCD0fUUGWx06I4CB55Jn+ZXYErmZ+fgb2sw== X-Received: by 2002:a05:6a00:24cb:b0:668:74e9:8f06 with SMTP id d11-20020a056a0024cb00b0066874e98f06mr5912743pfv.1.1687306241046; Tue, 20 Jun 2023 17:10:41 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id t2-20020a62ea02000000b0064d27a28451sm1789600pfh.100.2023.06.20.17.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 17:10:40 -0700 (PDT) Date: Wed, 21 Jun 2023 09:10:36 +0900 From: Sergey Senozhatsky To: "Liam R. Howlett" , Sergey Senozhatsky , Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peng Zhang Subject: Re: [PATCH v2 04/16] mm: Change do_vmi_align_munmap() side tree index Message-ID: <20230621001036.GB2934656@google.com> References: <20230612203953.2093911-1-Liam.Howlett@oracle.com> <20230612203953.2093911-5-Liam.Howlett@oracle.com> <20230620122619.GA2934656@google.com> <20230620130412.lxri53iekoq6lpfb@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620130412.lxri53iekoq6lpfb@revolver> X-Rspamd-Queue-Id: 405D5A0017 X-Rspam-User: X-Stat-Signature: y7hto5tiuwjqpihc7zj5gqnudis69b4u X-Rspamd-Server: rspam01 X-HE-Tag: 1687306242-210372 X-HE-Meta: U2FsdGVkX19wgLh/G0dGRKKaBEp61fce5rqoLoKhAnDIGfaPvA63qqGnXb0TIrd0RyEpQDsDZ9y+03TV7lkLa/2XsGDUttGBYdFC2kDi9fYCbAHI6Drs4bIjcgnKwpm5XAy3YN2G8d+NiJHs+u3/pFtjyMvnS+r7olK9DmedKN0W3XsITDqVMSvTy0YcYCiZn6Bvo9p4kMzXE4bCj4SIqL70JTZif8XzCCEOscQJbpRAixM5F8MrQQ2DPLip03gjvgR/SuvAD/N2HQLnzenfEJKUknRWhF0HNVIEjiDwwCsbsIDrQrirLTSbpmcorjzETthQqnCBWGW7wekGmFIawMJblN1V5Pv0N+Uc5WBysfe/4Tu+LGNCfHqOyjRbpaH5ucIrnNyomkOndxpTquLP8/TgM6S+fmVzWz/5sSNeaJeCwY4KrXz+XS28NK8ZznhDgEUgxjxfr4c0vQWvk4D/G/ZWIUWsQ/2X2MWvpDBCDhS0x8myp5PWAWIc3FgypmxM2gvLlYg3ZSdjAJ542Lkw06a04Jpz7Ce4l6kK7Qt/LaTWlIud53bUPHjcWA1IeUyZyxVjCyBL+9m8+0DxFZ/nH9TNG2P74/PoemaVuQrVr1g9nFBwp/F1t8cBlrukRcvqoyZu6RV288lgHHUQtbCu1AwpGwsqZdNQflZeMUn3ap8kUBFFAfd2M60uQoW0YYLVP5bFSauSxRJ9m5LLqLhHGjNeFx7F56H9fzD00IRj4VQh4jCVH9TaCWJLOlt0KJ8V/Cup+W4QAOB7JYeys159ZQYIx8M9Z03bzCOczy2GewAYTG06MoTMYwbuCURPxpXbV00D0fuGHEYkq7SqZCYxXSQCd/VvYzNm7MniifDA4EGnI9UGRsLfai9W8iGKl2M/7n4U7n97eReg6BWTviSKYyKM9uOAxuqxoli9mrJOuHAAzVRYnAMvMyzhHijJTFu9XTzhpeh5RCjN9duFpmw 8gmhBbou JV3L61MpmO9//ataI5USsv0YrYo0va5Mcw+4ygf/cfjd6SNwKvRf38Mt9tpJIHvT3Z7lgbLOjchRNgfJ7+RJFPA5lul7aoB6QVA14jM/2kQGmXBAYuJ0FTdx/9q6iBSlZmu7/yExb4gVWEW21Z+Z0sTjRdHwTjuKLQc4UlDEQyT5vNV5rf88eIh9udJbKchcbJjad8k2Q5FTs2KAOTGWASoR1zzxXCzuX0oDkwS5kw98O9mRNj9OjW8SaKnwLgIaX4sBWmqsJwTUXh3cGw/lF989rZLk61YtRKP8R2V1MPRsx9X5OTdH+NQRZvCLcfwwyG3F975hsOD9/CYDsSi1dylLwsXV6sHm0V5wHAShexS22DFg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/06/20 09:04), Liam R. Howlett wrote: > > On (23/06/12 16:39), Liam R. Howlett wrote: > > [..] > > > @@ -2450,17 +2452,17 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma, > > > #if defined(CONFIG_DEBUG_VM_MAPLE_TREE) > > > /* Make sure no VMAs are about to be lost. */ > > > { > > > - MA_STATE(test, &mt_detach, start, end - 1); > > > + MA_STATE(test, &mt_detach, 0, 0); > > > struct vm_area_struct *vma_mas, *vma_test; > > > int test_count = 0; > > > > > > vma_iter_set(vmi, start); > > > rcu_read_lock(); > > > - vma_test = mas_find(&test, end - 1); > > > + vma_test = mas_find(&test, count - 1); > > > for_each_vma_range(*vmi, vma_mas, end) { > > > BUG_ON(vma_mas != vma_test); > > > test_count++; > > > - vma_test = mas_next(&test, end - 1); > > > + vma_test = mas_next(&test, count - 1); > > > } > > > rcu_read_unlock(); > > > BUG_ON(count != test_count); > > > > Something isn't quite working, I'm hitting BUG_ON(vma_mas != vma_test) > > Is this with next by any chance? Oh yes, linux-next