Re: [PATCH v3 0/3] shmemfs stable directory offsets

[Christian Brauner <brauner@kernel.org>]

On Wed, Jun 21, 2023 at 01:12:46PM +0000, Chuck Lever III wrote:
> 
> 
> > On Jun 6, 2023, at 9:10 AM, Chuck Lever <cel@kernel.org> wrote:
> > 
> > The following series is for continued discussion of the need for
> > and implementation of stable directory offsets for shmemfs/tmpfs.
> > 
> > As discussed in Vancouver, I've re-implemented this change in libfs
> > so that other "simple" filesystems can use it. There were a few
> > other suggestions made during that event that I haven't tried yet.
> > 
> > Changes since v2:
> > - Move bulk of stable offset support into fs/libfs.c
> > - Replace xa_find_after with xas_find_next for efficiency
> > 
> > Changes since v1:
> > - Break the single patch up into a series
> > 
> > Changes since RFC:
> > - Destroy xarray in shmem_destroy_inode() instead of free_in_core_inode()
> > - A few cosmetic updates
> > 
> > ---
> > 
> > Chuck Lever (3):
> >      libfs: Add directory operations for stable offsets
> >      shmem: Refactor shmem_symlink()
> >      shmem: stable directory offsets
> > 
> > 
> > fs/dcache.c            |   1 +
> > fs/libfs.c             | 185 +++++++++++++++++++++++++++++++++++++++++
> > include/linux/dcache.h |   1 +
> > include/linux/fs.h     |   9 ++
> > mm/shmem.c             |  58 +++++++++----
> > 5 files changed, 240 insertions(+), 14 deletions(-)
> 
> The good news is that so far I have received no complaints from bots
> on this series.
> 
> The bad news is I have received no human comments. Ping?

I haven't gotten around to reviewing this yet but it is still on my
radar. We should plan to get this done for v6.6. I'll aim to review
during the merge window. Sorry for the delay.