From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A65AEB64D8 for ; Tue, 20 Jun 2023 20:43:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FBAF8D0005; Tue, 20 Jun 2023 16:43:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ABDC8D0001; Tue, 20 Jun 2023 16:43:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14CE08D0005; Tue, 20 Jun 2023 16:43:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 05D158D0001 for ; Tue, 20 Jun 2023 16:43:37 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CD71EA04C3 for ; Tue, 20 Jun 2023 20:43:36 +0000 (UTC) X-FDA: 80924302032.11.5F42D16 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by imf30.hostedemail.com (Postfix) with ESMTP id E71CB80009 for ; Tue, 20 Jun 2023 20:43:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=jOrhUkER; spf=pass (imf30.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.243.65 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687293814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CwfQ/e8+tBEbHK2zEBAEbADi5TLtFWo+s3gGjkRKKUY=; b=JG/okhXkxO5g4xm+YjERro3y1LTWeXNgPlKtVUvSOjPD1joUvn8C+h4f422es8aNF0AYAW zPbITDIrvUBQ2ykE5a4DquWrc/1LTiUJ59BCx3qrk1pYj/wwMFR5nWNcNh6c+My5kPyzI/ 1ijK9lcQfPaRRZBfdbD/XgcnB0477NQ= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=jOrhUkER; spf=pass (imf30.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.243.65 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1687293814; a=rsa-sha256; cv=pass; b=zCfmNp7H1E8CEBCr6lmkGbgCBo6AOed8ym8SKK5R7QZouyQWy4FtSzgTO75CbNr5RMBet9 gCosrINbp5+yaalUFphTJ1PbeyeKu/iDa7yHpDRDhTovfXDQyxt7p+QbEYHVh64EwY+hUZ HF1TSHIitSMGBrkxFB3eX1dCC++iJ+M= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9JADzDuirTzkC7AgMIjHRP6cy7Z5w3Hx1DTHJCWQV/VAGpTUQQZt5clWExcyzOGq2r0BAYMv/WBJflVnFoKgIArqocrrqC+sljNgnhrTQl1Kxx0SbF0o5dQT1fEBG5nrFYUlF729fCOyM+9Y4j67GL8JpCi2VTuSd/U76qswMOqpACPt3m22Y+WjfbSh/vhs0Nt3J2zPr2RQBm/5XuzD9wd+F9qntnu5dT2xY5LJ+YkAg70IKihcTmLrTGTyaMIMSqzMOFxoLuEWAl4cUOKVQRYw1I2a9JcIogUZWldw8fJt5DgWcxF+lCcby0Mwu4BxVYbuUy1R4eVljG7nC6a9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CwfQ/e8+tBEbHK2zEBAEbADi5TLtFWo+s3gGjkRKKUY=; b=CZ19TV+vtkmPAYGyLERQU3ZerlBV5v642q4T5pDd2BadMyqK7nmwez59uB88UFe4nrODlPf2k9oKnnEOcOoxBMR8G8h63OarVQdMSAAqzPmXcYa7uXv+DKwXOaqOmbE8IMsGAQbQZvu6KkbXcZwNO+CINh6TLBKzgqF81F1peDaPVQ/Q1esgsjSEgt685k4OvMObLTUwb2JlwqaOwizP1cid/tsBLr76TeMP3+04gsMx2o8Go9Ibb7EOahP3Rez95a5oiJDaSLi5cE+BoScyb3pFnn/4OYCLVJ6uQGEawZIVt+0PieQY99RLMcaR4wt5RsoyAjJzR7+6uVE+rDuEvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CwfQ/e8+tBEbHK2zEBAEbADi5TLtFWo+s3gGjkRKKUY=; b=jOrhUkERAcvHTz2Moeq6j7MsBildnvfoh/4jkvYd414kZQqni5OVCBmfnZ9LUVL39ABaifGDt2VYnrcBu4QuVWv5In4+gSynzByjztLUJy7btXeDyx9TUbJt/6fVPdJn5q5wrBk+1jSudmrtVvcyWL2YOqBgfTKkoYNU4qbEemo= Received: from SA1P222CA0179.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c4::9) by BY5PR12MB4999.namprd12.prod.outlook.com (2603:10b6:a03:1da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 20:43:30 +0000 Received: from SN1PEPF0002636B.namprd02.prod.outlook.com (2603:10b6:806:3c4:cafe::f1) by SA1P222CA0179.outlook.office365.com (2603:10b6:806:3c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.45 via Frontend Transport; Tue, 20 Jun 2023 20:43:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002636B.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6521.17 via Frontend Transport; Tue, 20 Jun 2023 20:43:30 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 15:43:29 -0500 Date: Tue, 20 Jun 2023 15:43:15 -0500 From: Michael Roth To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , "Kirill A . Shutemov" Subject: Re: [PATCH RFC v9 05/51] x86/coco: move CONFIG_HAS_CC_PLATFORM check down into coco/Makefile Message-ID: <20230620204315.xr7wtcrowc7oprka@amd.com> References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-6-michael.roth@amd.com> <20230620120920.GAZJGW8B6XHrsoLGCJ@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230620120920.GAZJGW8B6XHrsoLGCJ@fat_crate.local> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636B:EE_|BY5PR12MB4999:EE_ X-MS-Office365-Filtering-Correlation-Id: ba0eb223-25c3-4014-2738-08db71cf0182 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QFJwbo8fmV8FuP8nhC59bSKnyQVLXUBBKPXdnrooa+wPHLQOm4bb0v4M8gJZT0DlwjyrqgtsLJLpk6U8aM5X1gGG9Sa4QvX52bwCXgFnyOHZxHAVCOIgzAFOL4gZJVqRxSVJnDSKsQIEByZDihILWfyR/zgJiyfTbxd+Yn1Mcb+M67vPWQLDJgOTWskdY4+r9TLGqP5P8wlUe0pKWyIRKZ6hxR6u8ySn8UHPHcg1WPiiWd9Lkp/4pTikrtfcjZ8nzkBMrskYeoNEKAyHvSE1W3/nbYxoHFjAEYsU+jngGVZvZ9a8d/cA9BEN7+wygiAGeLj3sLZfiKWCW2npqZuTiZCLePis/84qi1ALSi7i7DhZn964ciXbFwwIVXIRdZpAnOeeGx61gAiZhbb2Bqv7jvHRu9NXv+zrASFsBB1ahdVjrP6BFalbzYro56r/RzBCMA6oMqqD4J7VXAq6YOWM6nfXSfJQN9MIDuNtwD/+X66orc6LFzuRzOSvgThor5SrMnLJHxI+Pd1D6OpbsE5HJF5AroMJi+bKbmtpu5qTc7ReYue8AkFOto1kjFWAeKz9RtJn04Hgb+ZhjOTMdlxKy79iP70JkBFO7XcyQkJKnrr9cjqm+eOjh2vV8ttdvi1oroFXh8mXU6dmDRaiwNGW8KAAgpof8NKpkU142AhbWCe4oK97MQx6WYzPnIvBnQCxHwlqnyrZw07Eiog0rz33tT8931VmsOsftTS6TcWQQbksVJDGpMu2y+ejDVkp3wzcpu7eW/LNMwTpq+vUvDvcE0kz1PqtUNWfruJLEh2GJBk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(478600001)(186003)(16526019)(966005)(6666004)(47076005)(86362001)(26005)(1076003)(54906003)(2616005)(316002)(336012)(426003)(82740400003)(70206006)(81166007)(6916009)(70586007)(4326008)(356005)(36860700001)(8936002)(5660300002)(7416002)(44832011)(7406005)(2906002)(40460700003)(8676002)(41300700001)(36756003)(40480700001)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 20:43:30.0064 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba0eb223-25c3-4014-2738-08db71cf0182 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4999 X-Rspamd-Queue-Id: E71CB80009 X-Rspam-User: X-Stat-Signature: z5bfwp8j3y799yirg51mzqbcsbhysx8c X-Rspamd-Server: rspam01 X-HE-Tag: 1687293813-605576 X-HE-Meta: U2FsdGVkX1+MKBCrMx24BDoI6RKG4otWVTiq8eGla75/uoQkVjoh2/HFemFKgnPs3qJ7JfpujkmfbVwnebt2PHzlVbylaihVaaluvmBbOkTnvtnme1P3hkFkt4W8n+Dv6P9XBZ2FesAYSRkgU81c1oCD0bsgC+QKmRue2mCXtYySjHX8EPTf2bDz0emgOD5hBhB29WVpoPVg6hx8faiqCXzbUBczDNLPRo1OcXDGaV0Q15IlF1t2UArSHdDCmiWp5LLekS6xiMtl0hIODkQZOGBpGVdSc+bgUQYL+0zgJGM6pT7wBvL19PDd7V7P1/F2LchqycPqjm/9j7TmhJKvbpo+JIR9KotUpfNmEuOOY7lvukGDjOSfbxXieMowvb40fdk3T0t4zxMqpvfStOMGCp88VJpwwiNgp4Ch84Pk3utVbC9BiKi9AYYTczR9xy2rLxgY/SuxSSfVKVpwpXNpOByrwv/yuuJPLYeM8/gEUaWEqfUNg8A6/1JGHuRY8k/BZl7Jtcw4BTZFMQ60YXt7dWK84q+ZMg0kwfY92fCYZTrJZq1JGrR2WRJKNgzAR8phMOvP1o8p1j89UVZgUM3skVCSThI6E32aJGjGFyB5lW+eTuUz4pHKQbCkc5xmLJI0UNe0GbJIXkyhaCPlvgpjUYv8qSzevO4ff0GLR0jwbJngZO0PvhNwIC0Ao0YaP8Yl/CrpOT+BhB2a7AO07zGH3QB0f960zOay+7FJ9Z/VB8sJQkxYy/UESnNX+h8R17TFJZc8mWfzx8GdbQaAY95DDpul9NzYAETr4aDtYZzLLN7/qjcdjP277WMm/4ialMXXm1z1058KjSlqpFHv+d9hqSX7Cf20qAQclKggw3p3YX9fLMDrOnSitEvewSpiLmxY5pUWUpdLyFOUrF7Td2/gwYtyNTeOhxIILttbiBUxATig9jsXcF0p0mwRmhfN4Lh/CJN/2odYPj2c9tZsO5G q7zXAXsq X1X/KvhAott3TL7rjlaBHz8otLnkxMkN05CjqN3QzSgbaRrPVo0fuvZj/YXarU6Csn8V4Ttdrd2WmWYbiH5hjLmxBha6LU8k+r2zuYtY9A3X/4llgygue7a1LaRb4S3G5DkYMCPAiq+H4xvKUNu0Ls6XxR4D5Iy9Jo/4quKmUYB1yhSp/F78fKL4zaie/9G4TNRPAVCbXYUqZM0U9dCA5rvhpqJpEZVo+dl4w2D2rut3NtfNSyU9bzgXIsMeX+NZfunuWuEw5koMOXcF3W2+hCnt35okymL5wI+tG5sjI5EFE8gQFB8d1R8/3h9hL6pnbOLgVo+6g+LIRMpEXpoWjAg6cKWUgE0S3vgKlJtyACFHCm+X5fa8PaEUi3/wxK9mRNRyE8+BlKN1lwRqDKHTS1VAorA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 02:09:20PM +0200, Borislav Petkov wrote: > On Sun, Jun 11, 2023 at 11:25:13PM -0500, Michael Roth wrote: > > Currently CONFIG_HAS_CC_PLATFORM is a prereq for building anything in > ^^^^^^ > > Use proper english words pls. > > > arch/x86/coco, but that is generally only applicable for guest support. > > > > For SEV-SNP, helpers related purely to host support will also live in > > arch/x86/coco. To allow for CoCo-related host support code in > > arch/x86/coco, move that check down into the Makefile and check for it > > specifically when needed. > > I have no clue what that means. Example? Basically, arch/x86/coco/Makefile is never processed if arch/x86/Kbuild indicates that CONFIG_HAS_CC_PLATFORM is not set. So if we want to have stuff in arch/x86/coco/Makefile that build for !CONFIG_HAS_CC_PLATFORM, like SNP host support, which does not rely on CONFIG_HAS_CC_PLATFORM being set, that check needs to be moved down into arch/x86/coco/Makefile. > > The last time we talked about paths, we ended up agreeing on: > > https://lore.kernel.org/all/Yg5nh1RknPRwIrb8@zn.tnic/ > > So your "helpers related purely to host support" should go to > > arch/x86/virt/svm/sev*.c > > And just to keep it simple, that should be > > arch/x86/virt/svm/sev.c > > and if there's real need to split that, we can do that later. Ok, makes sense. Thanks, Mike > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette