From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0C4EB64D7 for ; Tue, 20 Jun 2023 20:19:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48A8E8D0002; Tue, 20 Jun 2023 16:19:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 413B38D0001; Tue, 20 Jun 2023 16:19:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B40E8D0002; Tue, 20 Jun 2023 16:19:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 18EC68D0001 for ; Tue, 20 Jun 2023 16:19:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9F85780332 for ; Tue, 20 Jun 2023 20:19:01 +0000 (UTC) X-FDA: 80924240082.18.CD6630A Received: from out-43.mta0.migadu.com (out-43.mta0.migadu.com [91.218.175.43]) by imf12.hostedemail.com (Postfix) with ESMTP id 9897840006 for ; Tue, 20 Jun 2023 20:18:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XuzztPfV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.43 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687292339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AknCkCooyVujKThdxC1FM7ZvENiuN9/CmEk5IHQ7iJc=; b=mcDz6GT3bXa4/KxHyOwAFbqE6xh3/b9UFDh3VSJbJzMNuGD9+j8ybXoK5oISdTU1uUvsf+ hUmnfyIcklA5HYXf/qfQLzTDbYDLeha+N5oiGN1965eDn0Tn7F0C45XPZ/m0zDCBkRn/I2 4rHWMh/beFrikYg5FTz/OtHORtYdG14= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XuzztPfV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.43 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687292339; a=rsa-sha256; cv=none; b=mm0lFWIVUwdruWvcS/WHNZlxDU2CKlQKBgdl0Hc+8R+2rhASWNAig29NmWLTAhX1IXOiIm 7KI6lgVht/rjTnCoPb63noUu0weDEW0DhUDBjiiIYSRloG4D9ob0rQavwHRHHm1HtfION2 QCMa1tFUVEjtVDQNHCYOz9ZGr+ZQRjk= Date: Tue, 20 Jun 2023 16:18:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687292337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AknCkCooyVujKThdxC1FM7ZvENiuN9/CmEk5IHQ7iJc=; b=XuzztPfVVe+3n5nJEOjm27aqlllgXuZQ6rVKnaNP1qE0QAgMdGx6B41jDrtlCUaSZVvcwB aFXG7iOPoRS+k3iuIDq6aCVJVdfwEIwxm8O1jeyxNx8BlQuDXJKsTMlQrOrb4Uy0Osm8So ZIKImGyM50seypVLOxcay429rYAWiDE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Dave Hansen Cc: Andy Lutomirski , Mark Rutland , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, "linux-bcachefs@vger.kernel.org" , Kent Overstreet , Andrew Morton , Uladzislau Rezki , "hch@infradead.org" , linux-mm@kvack.org, Kees Cook , the arch/x86 maintainers Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: <20230620201851.qrcabl327mrofygb@moria.home.lan> References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230619104717.3jvy77y3quou46u3@moria.home.lan> <20230619191740.2qmlza3inwycljih@moria.home.lan> <5ef2246b-9fe5-4206-acf0-0ce1f4469e6c@app.fastmail.com> <20230620180839.oodfav5cz234pph7@moria.home.lan> <37d2378e-72de-e474-5e25-656b691384ba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37d2378e-72de-e474-5e25-656b691384ba@intel.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9897840006 X-Stat-Signature: q9nczhiwrxpuefy7u44u8ta4sodmu6a4 X-HE-Tag: 1687292339-35419 X-HE-Meta: U2FsdGVkX1+ndMtI1l5nsCwfYdX9ooyRXOEagt3XTuTBjEsfaWK2cS41V2qmJRHFSbWGulxn3at2glIX4tVJpCEhFkNZnj33BqNraaWZhp8CNDi4JakB278ekA4hfYCBwvZndoCxQe9eIW6QkjEd7FSw67flITSRGflSnvSrPKl+6COOTMAAPleKmSyzQdZEBQscPntnrVG6oBT34DAfNwx9m6noaCpW6vfqnVT+ufEkOiZRRGxlK7qwe+/lzaor+x1lNZbkE99F0EkxuMpWEeVGA/JLIUzl6X3ZWb2e6KLNvJmJXZHIHi8mmK6skr0LCL9+R3Sz8M+JysvUDtcW4PVQ7pxNnu4Ok0IwzP4tFpOGpV5KrvAtiF3G1ZnEqtr4OlQYhIkQePw0+4sPzzVqcty7qrtzbdZS26FQwPsu5BSFTh4iPAqZnNkYqQrsEoVMqZ2aiSlirv5hX4Gu4cnY+47QfXbIcTw7hyHTEYPn9WMTl5G5VhbTfJcWg2HkkuE97/Wqt0peTV/NACpG3PXggI8iFxWVMLUFcuTwiNRzq5mY8gbz5KAxd8jMOV/1ECiulf4NWDdZBohZnGj0lcastGi9niLer/YxepUB6OM7mniBrFZLieaB6xt4YOEgWr2O+3qqA6HifG4uWMGA3nqw4Qv+bgJ7BhNwZSGp13q3+FuYMFtNLXklhOQRa50Ov7AFsFIQI8FQ72mcUFpibWmO7Ye2xrT9q5Xi4NczZPTsU7Z+/7xyeLLMvsKEfSjjSZvWSJgRxH5Eg5hCyte2BrCLZ0/Zs6aSQBZU7LqlRh3uiAV0gXd5MTUh+WEKGAMUgYx+MMvCqgpIM54aZ2l5vPa9SpEdzTbPCpN0EsHLDUexirgs3ejM219oagSi/10EgJwbpyip6LjgL94aTOhyn3e7c+swY2tnGvvv6xFX29t+y2oVZ7QFXqFDjpxBq4p2Vn3btCTUXtJjTtbWV6HzAIg gOwOeiJD RP3I9bKbcUM7jVVWDPnsDtViB3M8P3zUKNUcIqpI1KoQII63cARipcKIsAN41KNApLPogzN2OdrCtS/P8wVrPvCM2Aum+6H0DVDiNrA02Da9JtB6KW0VlVXlazPwEioSBkbjTHqOAVnUmMcnfIFs+fjjJiZXZmpPtpaLQ+EkDOItoFBfV0lJMW5akeRIcS2XHNgD92udpCNF5BgpsovNeeT43xTMSe37cB+NAz3Rc702Ju8fwNRVhfvl9koLCFoQyCzbMIC2I1D707H0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 11:48:26AM -0700, Dave Hansen wrote: > >> No, I'm saying your concerns are baseless and too vague to > >> address. > > If you don't address them, the NAK will stand forever, or at least > > until a different group of people take over x86 maintainership. > > That's fine with me. > > I've got a specific concern: I don't see vmalloc_exec() used in this > series anywhere. I also don't see any of the actual assembly that's > being generated, or the glue code that's calling into the generated > assembly. > > I grepped around a bit in your git trees, but I also couldn't find it in > there. Any chance you could help a guy out and point us to some of the > specifics of this new, tiny JIT? vmalloc_exec() has already been dropped from the patchset - I'll switch to the new jit allocator when that's available and doing sub-page allocations. I can however point you at the code that generates the unpack functions: https://evilpiepirate.org/git/bcachefs.git/tree/fs/bcachefs/bkey.c#n727 > >> Andy, I replied explaining the difference between text_poke() and > >> text_poke_sync(). It's clear you have no idea what you're talking about, > >> so I'm not going to be wasting my time on further communications with > >> you. > > One more specific concern: This comment made me very uncomfortable and > it read to me very much like a personal attack, something which is > contrary to our code of conduct. It's not; I prefer to be direct than passive aggressive, and if I have to bow out of a discussion that isn't going anywhere I feel I owe an explanation of _why_. Too much conflict avoidance means things don't get resolved. And Andy and I are talking on IRC now, so things are proceeding in a better direction.